Rework NormalizedNode type hierarchy

[yangtools.git] / yang / yang-data-impl / src / main / java / org / opendaylight / yangtools / yang / data / impl / schema / builder / impl / valid / DataNodeContainerValidator.java

diff --git a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/valid/DataNodeContainerValidator.java b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/valid/DataNodeContainerValidator.java
index 6deb106a79d0650c3573400679217fee8137e2bd..abdfaabd92722cbc7641acf19ebf0e8fb19d6c87 100644 (file)
--- a/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/valid/DataNodeContainerValidator.java
+++ b/yang/yang-data-impl/src/main/java/org/opendaylight/yangtools/yang/data/impl/schema/builder/impl/valid/DataNodeContainerValidator.java
@@ -7,74 +7,72 @@
  */
 package org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.valid;
 
-import java.util.Set;
+import static java.util.Objects.requireNonNull;
 
-import com.google.common.collect.Sets;
+import java.util.HashSet;
+import java.util.Set;
 import org.opendaylight.yangtools.yang.common.QName;
-import org.opendaylight.yangtools.yang.data.api.InstanceIdentifier;
+import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.AugmentationIdentifier;
+import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument;
 import org.opendaylight.yangtools.yang.data.api.schema.DataContainerChild;
-import org.opendaylight.yangtools.yang.data.impl.schema.SchemaUtils;
-import org.opendaylight.yangtools.yang.model.api.AugmentationSchema;
+import org.opendaylight.yangtools.yang.data.util.DataSchemaContextNode;
+import org.opendaylight.yangtools.yang.model.api.AugmentationSchemaNode;
 import org.opendaylight.yangtools.yang.model.api.AugmentationTarget;
-import org.opendaylight.yangtools.yang.model.api.ChoiceCaseNode;
+import org.opendaylight.yangtools.yang.model.api.CaseSchemaNode;
 import org.opendaylight.yangtools.yang.model.api.DataNodeContainer;
 import org.opendaylight.yangtools.yang.model.api.DataSchemaNode;
 
-import com.google.common.base.Preconditions;
-
 /**
  * General validator for container like statements, e.g. container, list-entry, choice, augment
  */
 public class DataNodeContainerValidator {
-
+    private final Set<AugmentationIdentifier> augments = new HashSet<>();
     private final DataNodeContainer schema;
     private final Set<QName> childNodes;
-    private final Set<InstanceIdentifier.AugmentationIdentifier> augments = Sets.newHashSet();
-
-    public DataNodeContainerValidator(DataNodeContainer schema) {
-        this.schema = Preconditions.checkNotNull(schema, "Schema was null");
 
+    public DataNodeContainerValidator(final DataNodeContainer schema) {
+        this.schema = requireNonNull(schema, "Schema was null");
         this.childNodes = getChildNodes(schema);
 
-        if(schema instanceof AugmentationTarget) {
-            for (AugmentationSchema augmentationSchema : ((AugmentationTarget) schema).getAvailableAugmentations()) {
-                augments.add(SchemaUtils.getNodeIdentifierForAugmentation(augmentationSchema));
+        if (schema instanceof AugmentationTarget) {
+            for (AugmentationSchemaNode augmentation : ((AugmentationTarget) schema).getAvailableAugmentations()) {
+                augments.add(DataSchemaContextNode.augmentationIdentifierFrom(augmentation));
             }
         }
     }
 
-    private boolean isKnownChild(InstanceIdentifier.PathArgument child) {
-        if(child instanceof InstanceIdentifier.AugmentationIdentifier) {
+    private boolean isKnownChild(final PathArgument child) {
+        if (child instanceof AugmentationIdentifier) {
             return augments.contains(child);
         }
 
         return childNodes.contains(child.getNodeType());
     }
 
-    public void validateChild(InstanceIdentifier.PathArgument child) {
+    public void validateChild(final PathArgument child) {
         DataValidationException.checkLegalChild(isKnownChild(child), child, schema, childNodes, augments);
     }
 
-    public DataContainerChild<?, ?> validateChild(DataContainerChild<?, ?> child) {
+    public DataContainerChild validateChild(final DataContainerChild child) {
         validateChild(child.getIdentifier());
         return child;
     }
 
     /**
-     * Map all direct child nodes. Skip augments since they have no qname. List cases since cases do not exist in NormalizedNode API.
+     * Map all direct child nodes. Skip augments since they have no qname. List cases since cases do not exist in
+     * NormalizedNode API.
      */
-    private static Set<QName> getChildNodes(DataNodeContainer nodeContainer) {
-        Set<QName> allChildNodes = Sets.newHashSet();
+    private static Set<QName> getChildNodes(final DataNodeContainer nodeContainer) {
+        Set<QName> allChildNodes = new HashSet<>();
 
         for (DataSchemaNode childSchema : nodeContainer.getChildNodes()) {
-            if(childSchema instanceof ChoiceCaseNode) {
+            if (childSchema instanceof CaseSchemaNode) {
                 allChildNodes.addAll(getChildNodes((DataNodeContainer) childSchema));
-            } else if (childSchema instanceof AugmentationSchema == false) {
+            } else if (!(childSchema instanceof AugmentationSchemaNode)) {
                 allChildNodes.add(childSchema.getQName());
             }
         }
 
         return allChildNodes;
     }
-
 }