*/
package org.opendaylight.yangtools.yang.data.impl.schema.tree;
-import com.google.common.base.Preconditions;
-import com.google.common.base.Verify;
+import static com.google.common.base.Preconditions.checkArgument;
+import static java.util.Objects.requireNonNull;
+
+import com.google.common.base.MoreObjects.ToStringHelper;
import java.util.Optional;
-import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier.PathArgument;
import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNodeContainer;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-final class MinMaxElementsValidation extends SchemaAwareApplyOperation {
+final class MinMaxElementsValidation<T extends DataSchemaNode & ElementCountConstraintAware>
+ extends ModificationApplyOperation {
private static final Logger LOG = LoggerFactory.getLogger(MinMaxElementsValidation.class);
- private final SchemaAwareApplyOperation delegate;
+ private final SchemaAwareApplyOperation<T> delegate;
private final int minElements;
private final int maxElements;
- private MinMaxElementsValidation(final SchemaAwareApplyOperation delegate, final Integer minElements,
+ private MinMaxElementsValidation(final SchemaAwareApplyOperation<T> delegate, final Integer minElements,
final Integer maxElements) {
- this.delegate = Preconditions.checkNotNull(delegate);
+ this.delegate = requireNonNull(delegate);
this.minElements = minElements != null ? minElements : 0;
this.maxElements = maxElements != null ? maxElements : Integer.MAX_VALUE;
}
- static SchemaAwareApplyOperation from(final SchemaAwareApplyOperation delegate, final DataSchemaNode schema) {
- if (!(schema instanceof ElementCountConstraintAware)) {
- return delegate;
- }
- final Optional<ElementCountConstraint> optConstraint = ((ElementCountConstraintAware) schema)
- .getElementCountConstraint();
+ static <T extends DataSchemaNode & ElementCountConstraintAware> ModificationApplyOperation from(
+ final SchemaAwareApplyOperation<T> delegate) {
+ final Optional<ElementCountConstraint> optConstraint = delegate.getSchema().getElementCountConstraint();
if (!optConstraint.isPresent()) {
return delegate;
}
final ElementCountConstraint constraint = optConstraint.get();
- return new MinMaxElementsValidation(delegate, constraint.getMinElements(), constraint.getMaxElements());
+ return new MinMaxElementsValidation<>(delegate, constraint.getMinElements(), constraint.getMaxElements());
}
- private void validateMinMaxElements(final YangInstanceIdentifier path, final PathArgument id,
- final NormalizedNode<?, ?> data) throws DataValidationFailedException {
- final int children = numOfChildrenFromValue(data);
- if (minElements > children) {
- throw new RequiredElementCountException(path, minElements, maxElements,
- children, "%s does not have enough elements (%s), needs at least %s", id, children, minElements);
- }
- if (maxElements < children) {
- throw new RequiredElementCountException(path, minElements, maxElements,
- children, "%s has too many elements (%s), can have at most %s", id, children, maxElements);
+ @Override
+ Optional<? extends TreeNode> apply(final ModifiedNode modification, final Optional<? extends TreeNode> storeMeta,
+ final Version version) {
+ Optional<? extends TreeNode> ret = modification.getValidatedNode(this, storeMeta);
+ if (ret == null) {
+ // Deal with the result moving on us
+ ret = delegate.apply(modification, storeMeta, version);
+ if (ret.isPresent()) {
+ checkChildren(ret.get().getData());
+ }
}
+
+ return ret;
}
- private void checkMinMaxElements(final YangInstanceIdentifier path, final NodeModification nodeMod,
- final Optional<TreeNode> current, final Version version) throws DataValidationFailedException {
- if (!(nodeMod instanceof ModifiedNode)) {
- LOG.debug("Could not validate {}, does not implement expected class {}", nodeMod, ModifiedNode.class);
+ @Override
+ void checkApplicable(final ModificationPath path, final NodeModification modification,
+ final Optional<? extends TreeNode> current, final Version version) throws DataValidationFailedException {
+ delegate.checkApplicable(path, modification, current, version);
+
+ if (!(modification instanceof ModifiedNode)) {
+ LOG.debug("Could not validate {}, does not implement expected class {}", modification, ModifiedNode.class);
return;
}
-
- final ModifiedNode modification = (ModifiedNode) nodeMod;
-
- // We need to actually perform the operation to get deal with merge in a sane manner. We know the modification
- // is immutable, so the result of validation will probably not change.
- final Optional<TreeNode> maybeApplied = delegate.apply(modification, current, version);
- Verify.verify(maybeApplied.isPresent());
-
- final TreeNode applied = maybeApplied.get();
- validateMinMaxElements(path, modification.getIdentifier(), applied.getData());
+ final ModifiedNode modified = (ModifiedNode) modification;
+
+ // We need to actually perform the operation to deal with merge in a sane manner. We know the modification
+ // is immutable, so the result of validation will probably not change. Note we should not be checking number
+ final Optional<? extends TreeNode> maybeApplied = delegate.apply(modified, current, version);
+ if (maybeApplied.isPresent()) {
+ // We only enforce min/max on present data and rely on MandatoryLeafEnforcer to take care of the empty case
+ validateMinMaxElements(path, maybeApplied.get().getData());
+ }
// Everything passed. We now have a snapshot of the result node, it would be too bad if we just threw it out.
// We know what the result of an apply operation is going to be *if* the following are kept unchanged:
// - the schemacontext (therefore, the fact this object is associated with the modification)
//
// So let's stash the result. We will pick it up during apply operation.
- modification.setValidatedNode(this, current, applied);
- }
-
- private static int numOfChildrenFromValue(final NormalizedNode<?, ?> value) {
- if (value instanceof NormalizedNodeContainer) {
- return ((NormalizedNodeContainer<?, ?, ?>) value).getValue().size();
- } else if (value instanceof UnkeyedListNode) {
- return ((UnkeyedListNode) value).getSize();
- }
-
- throw new IllegalArgumentException(String.format(
- "Unexpected type '%s', expected types are NormalizedNodeContainer and UnkeyedListNode",
- value.getClass()));
+ modified.setValidatedNode(this, current, maybeApplied);
}
@Override
- protected void checkTouchApplicable(final YangInstanceIdentifier path, final NodeModification modification,
- final Optional<TreeNode> current, final Version version) throws DataValidationFailedException {
- delegate.checkTouchApplicable(path, modification, current, version);
- checkMinMaxElements(path, modification, current, version);
+ void fullVerifyStructure(final NormalizedNode<?, ?> modification) {
+ delegate.fullVerifyStructure(modification);
+ checkChildren(modification);
}
@Override
- protected void checkMergeApplicable(final YangInstanceIdentifier path, final NodeModification modification,
- final Optional<TreeNode> current, final Version version) throws DataValidationFailedException {
- delegate.checkMergeApplicable(path, modification, current, version);
- checkMinMaxElements(path, modification, current, version);
+ public Optional<ModificationApplyOperation> getChild(final PathArgument child) {
+ return delegate.getChild(child);
}
@Override
- protected void checkWriteApplicable(final YangInstanceIdentifier path, final NodeModification modification,
- final Optional<TreeNode> current, final Version version) throws DataValidationFailedException {
- delegate.checkWriteApplicable(path, modification, current, version);
- checkMinMaxElements(path, modification, current, version);
+ ChildTrackingPolicy getChildPolicy() {
+ return delegate.getChildPolicy();
}
@Override
- public Optional<ModificationApplyOperation> getChild(final PathArgument child) {
- return delegate.getChild(child);
+ void mergeIntoModifiedNode(final ModifiedNode node, final NormalizedNode<?, ?> value, final Version version) {
+ delegate.mergeIntoModifiedNode(node, value, version);
}
@Override
- protected void verifyStructure(final NormalizedNode<?, ?> modification, final boolean verifyChildren) {
- delegate.verifyStructure(modification, verifyChildren);
- if (verifyChildren) {
- final int children = numOfChildrenFromValue(modification);
- Preconditions.checkArgument(minElements <= children,
- "Node %s does not have enough elements (%s), needs at least %s", modification.getIdentifier(),
- children, minElements);
- Preconditions.checkArgument(maxElements >= children,
- "Node %s has too many elements (%s), can have at most %s", modification.getIdentifier(), children,
- maxElements);
- }
+ void quickVerifyStructure(final NormalizedNode<?, ?> modification) {
+ delegate.quickVerifyStructure(modification);
}
@Override
- protected TreeNode applyMerge(final ModifiedNode modification, final TreeNode currentMeta, final Version version) {
- final TreeNode validated = modification.getValidatedNode(this, Optional.of(currentMeta));
- if (validated != null) {
- return validated;
- }
-
- // FIXME: the result moved, make sure we enforce again
- return delegate.applyMerge(modification, currentMeta, version);
+ void recursivelyVerifyStructure(final NormalizedNode<?, ?> value) {
+ delegate.recursivelyVerifyStructure(value);
}
@Override
- protected TreeNode applyTouch(final ModifiedNode modification, final TreeNode currentMeta, final Version version) {
- final TreeNode validated = modification.getValidatedNode(this, Optional.of(currentMeta));
- if (validated != null) {
- return validated;
- }
-
- // FIXME: the result moved, make sure we enforce again
- return delegate.applyTouch(modification, currentMeta, version);
+ ToStringHelper addToStringAttributes(final ToStringHelper helper) {
+ return helper.add("min", minElements).add("max", maxElements).add("delegate", delegate);
}
- @Override
- protected TreeNode applyWrite(final ModifiedNode modification, final Optional<TreeNode> currentMeta,
- final Version version) {
- final TreeNode validated = modification.getValidatedNode(this, currentMeta);
- if (validated != null) {
- return validated;
+ private void validateMinMaxElements(final ModificationPath path, final NormalizedNode<?, ?> value)
+ throws DataValidationFailedException {
+ final PathArgument id = value.getIdentifier();
+ final int children = numOfChildrenFromValue(value);
+ if (minElements > children) {
+ throw new RequiredElementCountException(path.toInstanceIdentifier(), minElements, maxElements, children,
+ "%s does not have enough elements (%s), needs at least %s", id, children, minElements);
+ }
+ if (maxElements < children) {
+ throw new RequiredElementCountException(path.toInstanceIdentifier(), minElements, maxElements, children,
+ "%s has too many elements (%s), can have at most %s", id, children, maxElements);
}
-
- // FIXME: the result moved, make sure we enforce again
- return delegate.applyWrite(modification, currentMeta, version);
}
- @Override
- protected ChildTrackingPolicy getChildPolicy() {
- return delegate.getChildPolicy();
+ private void checkChildren(final NormalizedNode<?, ?> value) {
+ final PathArgument id = value.getIdentifier();
+ final int children = numOfChildrenFromValue(value);
+ checkArgument(minElements <= children, "Node %s does not have enough elements (%s), needs at least %s", id,
+ children, minElements);
+ checkArgument(maxElements >= children, "Node %s has too many elements (%s), can have at most %s", id, children,
+ maxElements);
}
- @Override
- void mergeIntoModifiedNode(final ModifiedNode node, final NormalizedNode<?, ?> value, final Version version) {
- delegate.mergeIntoModifiedNode(node, value, version);
- }
+ private static int numOfChildrenFromValue(final NormalizedNode<?, ?> value) {
+ if (value instanceof NormalizedNodeContainer) {
+ return ((NormalizedNodeContainer<?, ?, ?>) value).size();
+ } else if (value instanceof UnkeyedListNode) {
+ return ((UnkeyedListNode) value).getSize();
+ }
- @Override
- void recursivelyVerifyStructure(final NormalizedNode<?, ?> value) {
- delegate.recursivelyVerifyStructure(value);
+ throw new IllegalArgumentException(String.format(
+ "Unexpected type '%s', expected types are NormalizedNodeContainer and UnkeyedListNode",
+ value.getClass()));
}
}
Code Review / yangtools.git / blobdiff