BUG-9265: Switch empty type mapping from Void to Empty
[yangtools.git] / yang / yang-data-impl / src / test / java / org / opendaylight / yangtools / yang / data / impl / schema / nodes / AbstractImmutableNormalizedValueAttrNodeTest.java
index 778bf25a26cfa16e2c9e47368052246ab3106861..effb1a5448710c8da11b62692cff7e5283d40f4e 100644 (file)
@@ -1,9 +1,14 @@
-/**
+/*
  * Copyright (c) 2013 Cisco Systems, Inc. and others.  All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
  */
 package org.opendaylight.yangtools.yang.data.impl.schema.nodes;
 
-import static org.junit.Assert.*;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 import org.junit.Test;
 import org.opendaylight.yangtools.yang.common.QName;
@@ -12,34 +17,20 @@ import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNodes;
 
 public class AbstractImmutableNormalizedValueAttrNodeTest {
 
-    private static QName ROOT_QNAME = QName.create("urn:test", "2014-03-13",
-            "root");
-    private static QName LEAF_QNAME = QName.create(ROOT_QNAME, "my-leaf");
-    private static QName SAME_LEAF_QNAME = QName.create(ROOT_QNAME, "my-leaf");
-    private static QName OTHER_LEAF_QNAME = QName.create(ROOT_QNAME,
-            "my-other-leaf");
+    private static final QName ROOT_QNAME = QName.create("urn:test", "2014-03-13", "root");
+    private static final QName LEAF_QNAME = QName.create(ROOT_QNAME, "my-leaf");
+    private static final QName SAME_LEAF_QNAME = QName.create(ROOT_QNAME, "my-leaf");
+    private static final QName OTHER_LEAF_QNAME = QName.create(ROOT_QNAME, "my-other-leaf");
 
     @Test
+    // This test is based on using different references; we're testing equals()
+    @SuppressWarnings({"RedundantStringConstructorCall", "EqualsWithItself"})
     public void equalsByteTest() {
-
-        byte[] valueNull = null;
-        byte[] equalValueNull = null;
-
-        LeafNode<byte[]> leafNodeNull = ImmutableNodes.leafNode(LEAF_QNAME,
-                valueNull);
-        LeafNode<byte[]> equalLeafNodeNull = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValueNull);
-
-        assertTrue(leafNodeNull.equals(leafNodeNull));
-        assertTrue(leafNodeNull.equals(equalLeafNodeNull));
-        assertTrue(equalLeafNodeNull.equals(leafNodeNull));
-
         byte[] value = "test".getBytes();
         byte[] equalValue = "test".getBytes();
 
         LeafNode<byte[]> leafNode = ImmutableNodes.leafNode(LEAF_QNAME, value);
-        LeafNode<byte[]> equalLeafNode = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue);
+        LeafNode<byte[]> equalLeafNode = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue);
 
         assertTrue(leafNode.equals(leafNode));
         assertTrue(leafNode.equals(equalLeafNode));
@@ -48,39 +39,35 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         Byte[] value2 = new Byte[] { new Byte("1"), new Byte("2") };
         Byte[] equalValue2 = new Byte[] { new Byte("1"), new Byte("2") };
 
-        LeafNode<Byte[]> leafNode2 = ImmutableNodes
-                .leafNode(LEAF_QNAME, value2);
-        LeafNode<Byte[]> equalLeafNode2 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue2);
+        LeafNode<Byte[]> leafNode2 = ImmutableNodes.leafNode(LEAF_QNAME, value2);
+        LeafNode<Byte[]> equalLeafNode2 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue2);
 
         assertTrue(leafNode2.equals(leafNode2));
         assertTrue(leafNode2.equals(equalLeafNode2));
         assertTrue(equalLeafNode2.equals(leafNode2));
 
         byte[][] value3 = new byte[][] { "test".getBytes(), "test2".getBytes() };
-        byte[][] equalValue3 = new byte[][] { "test".getBytes(),
-                "test2".getBytes() };
+        byte[][] equalValue3 = new byte[][] { "test".getBytes(), "test2".getBytes() };
 
         LeafNode<byte[][]> leafNode3 = ImmutableNodes.leafNode(LEAF_QNAME,
                 value3);
-        LeafNode<byte[][]> equalLeafNode3 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue3);
+        LeafNode<byte[][]> equalLeafNode3 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue3);
 
         assertTrue(leafNode3.equals(leafNode3));
         assertTrue(leafNode3.equals(equalLeafNode3));
         assertTrue(equalLeafNode3.equals(leafNode3));
 
         Byte[][] value4 = new Byte[][] {
-                new Byte[] { new Byte("1"), new Byte("2") },
-                new Byte[] { new Byte("3"), new Byte("4") } };
+            new Byte[] { new Byte("1"), new Byte("2") },
+            new Byte[] { new Byte("3"), new Byte("4") },
+        };
         Byte[][] equalValue4 = new Byte[][] {
-                new Byte[] { new Byte("1"), new Byte("2") },
-                new Byte[] { new Byte("3"), new Byte("4") } };
+            new Byte[] { new Byte("1"), new Byte("2") },
+            new Byte[] { new Byte("3"), new Byte("4") },
+        };
 
-        LeafNode<Byte[][]> leafNode4 = ImmutableNodes.leafNode(LEAF_QNAME,
-                value4);
-        LeafNode<Byte[][]> equalLeafNode4 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue4);
+        LeafNode<Byte[][]> leafNode4 = ImmutableNodes.leafNode(LEAF_QNAME,value4);
+        LeafNode<Byte[][]> equalLeafNode4 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue4);
 
         assertTrue(leafNode4.equals(leafNode4));
         assertTrue(leafNode4.equals(equalLeafNode4));
@@ -97,29 +84,27 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         assertTrue(leafNode6.equals(equalLeafNode6));
         assertTrue(equalLeafNode6.equals(leafNode6));
 
-        String value5 = new String("test");
+        String value5 = "test";
         String equalValue5 = new String("test");
 
-        LeafNode<String> leafNode5 = ImmutableNodes
-                .leafNode(LEAF_QNAME, value5);
-        LeafNode<String> equalLeafNode5 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue5);
+        LeafNode<String> leafNode5 = ImmutableNodes.leafNode(LEAF_QNAME, value5);
+        LeafNode<String> equalLeafNode5 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue5);
 
         assertTrue(leafNode5.equals(leafNode5));
         assertTrue(leafNode5.equals(equalLeafNode5));
         assertTrue(equalLeafNode5.equals(leafNode5));
-
     }
 
     @Test
+    // We're testing equals()
+    @SuppressWarnings({"ObjectEqualsNull", "EqualsBetweenInconvertibleTypes"})
     public void notEqualByteTest() {
 
         byte[] value = "test".getBytes();
         byte[] equalValue = "test".getBytes();
 
         LeafNode<byte[]> leafNode = ImmutableNodes.leafNode(LEAF_QNAME, value);
-        LeafNode<byte[]> otherLeafNode = ImmutableNodes.leafNode(
-                OTHER_LEAF_QNAME, equalValue);
+        LeafNode<byte[]> otherLeafNode = ImmutableNodes.leafNode(OTHER_LEAF_QNAME, equalValue);
 
         assertFalse(leafNode.equals(null));
         assertFalse(leafNode.equals(new Object()));
@@ -129,10 +114,8 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         byte[] value1 = "test".getBytes();
         byte[] otherValue1 = "test1".getBytes();
 
-        LeafNode<byte[]> leafNode1 = ImmutableNodes
-                .leafNode(LEAF_QNAME, value1);
-        LeafNode<byte[]> otherLeafNode1 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, otherValue1);
+        LeafNode<byte[]> leafNode1 = ImmutableNodes.leafNode(LEAF_QNAME, value1);
+        LeafNode<byte[]> otherLeafNode1 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, otherValue1);
 
         assertFalse(leafNode1.equals(otherLeafNode1));
         assertFalse(otherLeafNode1.equals(leafNode1));
@@ -140,37 +123,32 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         Byte[] value2 = new Byte[] { new Byte("1"), new Byte("1") };
         Byte[] otherValue2 = new Byte[] { new Byte("1"), new Byte("2") };
 
-        LeafNode<Byte[]> leafNode2 = ImmutableNodes
-                .leafNode(LEAF_QNAME, value2);
-        LeafNode<Byte[]> otherLeafNode2 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, otherValue2);
+        LeafNode<Byte[]> leafNode2 = ImmutableNodes.leafNode(LEAF_QNAME, value2);
+        LeafNode<Byte[]> otherLeafNode2 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, otherValue2);
 
         assertFalse(leafNode2.equals(otherLeafNode2));
         assertFalse(otherLeafNode2.equals(leafNode2));
 
         byte[][] value3 = new byte[][] { "test".getBytes(), "test2".getBytes() };
-        byte[][] otherValue3 = new byte[][] { "test".getBytes(),
-                "test3".getBytes() };
+        byte[][] otherValue3 = new byte[][] { "test".getBytes(), "test3".getBytes() };
 
-        LeafNode<byte[][]> leafNode3 = ImmutableNodes.leafNode(LEAF_QNAME,
-                value3);
-        LeafNode<byte[][]> otherLeafNode3 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, otherValue3);
+        LeafNode<byte[][]> leafNode3 = ImmutableNodes.leafNode(LEAF_QNAME, value3);
+        LeafNode<byte[][]> otherLeafNode3 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, otherValue3);
 
         assertFalse(leafNode3.equals(otherLeafNode3));
         assertFalse(otherLeafNode3.equals(leafNode3));
 
         Byte[][] value4 = new Byte[][] {
-                new Byte[] { new Byte("1"), new Byte("2") },
-                new Byte[] { new Byte("3"), new Byte("4") } };
+            new Byte[] { new Byte("1"), new Byte("2") },
+            new Byte[] { new Byte("3"), new Byte("4") },
+        };
         Byte[][] otherValue4 = new Byte[][] {
-                new Byte[] { new Byte("1"), new Byte("2") },
-                new Byte[] { new Byte("3"), new Byte("5") } };
+            new Byte[] { new Byte("1"), new Byte("2") },
+            new Byte[] { new Byte("3"), new Byte("5") },
+        };
 
-        LeafNode<Byte[][]> leafNode4 = ImmutableNodes.leafNode(LEAF_QNAME,
-                value4);
-        LeafNode<Byte[][]> otherLeafNode4 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, otherValue4);
+        LeafNode<Byte[][]> leafNode4 = ImmutableNodes.leafNode(LEAF_QNAME, value4);
+        LeafNode<Byte[][]> otherLeafNode4 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, otherValue4);
 
         assertFalse(leafNode4.equals(otherLeafNode4));
         assertFalse(otherLeafNode4.equals(leafNode4));
@@ -179,19 +157,16 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         Byte otherValue6 = new Byte("2");
 
         LeafNode<Byte> leafNode6 = ImmutableNodes.leafNode(LEAF_QNAME, value6);
-        LeafNode<Byte> otherLeafNode6 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, otherValue6);
+        LeafNode<Byte> otherLeafNode6 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, otherValue6);
 
         assertFalse(leafNode6.equals(otherLeafNode6));
         assertFalse(otherLeafNode6.equals(leafNode6));
 
-        String value5 = new String("test");
-        String otherValue5 = new String("test2");
+        String value5 = "test";
+        String otherValue5 = "test2";
 
-        LeafNode<String> leafNode5 = ImmutableNodes
-                .leafNode(LEAF_QNAME, value5);
-        LeafNode<String> otherLeafNode5 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, otherValue5);
+        LeafNode<String> leafNode5 = ImmutableNodes.leafNode(LEAF_QNAME, value5);
+        LeafNode<String> otherLeafNode5 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, otherValue5);
 
         assertFalse(leafNode5.equals(otherLeafNode5));
         assertFalse(otherLeafNode5.equals(leafNode5));
@@ -208,33 +183,23 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         assertFalse(leafNode4.equals(leafNode5));
         assertFalse(leafNode6.equals(leafNode5));
 
-        byte[] valueNull = null;
+        byte[] byteValue = new byte[] { 1, 1 };
 
-        LeafNode<byte[]> leafNodeNull = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, valueNull);
-        assertFalse(leafNodeNull.equals(leafNode));
-        assertFalse(leafNode.equals(leafNodeNull));
-
-        byte[] byteValue = new byte[] { new Byte("1").byteValue(),
-                new Byte("1").byteValue() };
-
-        LeafNode<byte[]> byteLeafNode = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, byteValue);
+        LeafNode<byte[]> byteLeafNode = ImmutableNodes.leafNode(SAME_LEAF_QNAME, byteValue);
         assertFalse(byteLeafNode.equals(leafNode2));
         assertFalse(leafNode2.equals(byteLeafNode));
-
     }
 
     @Test
+    // We're testing equals()
+    @SuppressWarnings({"EqualsWithItself", "EqualsBetweenInconvertibleTypes"})
     public void equalsOtherTypesTest() {
 
         char[] valueChar = "test".toCharArray();
         char[] equalValueChar = "test".toCharArray();
 
-        LeafNode<char[]> leafNodeChar = ImmutableNodes.leafNode(LEAF_QNAME,
-                valueChar);
-        LeafNode<char[]> equalLeafNodeChar = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValueChar);
+        LeafNode<char[]> leafNodeChar = ImmutableNodes.leafNode(LEAF_QNAME, valueChar);
+        LeafNode<char[]> equalLeafNodeChar = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValueChar);
 
         assertTrue(leafNodeChar.equals(leafNodeChar));
         assertTrue(leafNodeChar.equals(equalLeafNodeChar));
@@ -243,10 +208,8 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         boolean[] value = new boolean[] { true, false };
         boolean[] equalValue = new boolean[] { true, false };
 
-        LeafNode<boolean[]> leafNode = ImmutableNodes.leafNode(LEAF_QNAME,
-                value);
-        LeafNode<boolean[]> equalLeafNode = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue);
+        LeafNode<boolean[]> leafNode = ImmutableNodes.leafNode(LEAF_QNAME, value);
+        LeafNode<boolean[]> equalLeafNode = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue);
 
         assertTrue(leafNode.equals(leafNode));
         assertTrue(leafNode.equals(equalLeafNode));
@@ -256,8 +219,7 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         int[] equalValue2 = new int[] { 1, 2 };
 
         LeafNode<int[]> leafNode2 = ImmutableNodes.leafNode(LEAF_QNAME, value2);
-        LeafNode<int[]> equalLeafNode2 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue2);
+        LeafNode<int[]> equalLeafNode2 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue2);
 
         assertTrue(leafNode2.equals(leafNode2));
         assertTrue(leafNode2.equals(equalLeafNode2));
@@ -266,10 +228,8 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         short[] value3 = new short[] { 1, 2 };
         short[] equalValue3 = new short[] { 1, 2 };
 
-        LeafNode<short[]> leafNode3 = ImmutableNodes.leafNode(LEAF_QNAME,
-                value3);
-        LeafNode<short[]> equalLeafNode3 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue3);
+        LeafNode<short[]> leafNode3 = ImmutableNodes.leafNode(LEAF_QNAME, value3);
+        LeafNode<short[]> equalLeafNode3 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue3);
 
         assertTrue(leafNode3.equals(leafNode3));
         assertTrue(leafNode3.equals(equalLeafNode3));
@@ -278,10 +238,8 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         long[] value4 = new long[] { 1, 2 };
         long[] equalValue4 = new long[] { 1, 2 };
 
-        LeafNode<long[]> leafNode4 = ImmutableNodes
-                .leafNode(LEAF_QNAME, value4);
-        LeafNode<long[]> equalLeafNode4 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue4);
+        LeafNode<long[]> leafNode4 = ImmutableNodes.leafNode(LEAF_QNAME, value4);
+        LeafNode<long[]> equalLeafNode4 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue4);
 
         assertTrue(leafNode4.equals(leafNode4));
         assertTrue(leafNode4.equals(equalLeafNode4));
@@ -290,10 +248,8 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         double[] value6 = new double[] { 1, 2 };
         double[] equalValue6 = new double[] { 1, 2 };
 
-        LeafNode<double[]> leafNode6 = ImmutableNodes.leafNode(LEAF_QNAME,
-                value6);
-        LeafNode<double[]> equalLeafNode6 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue6);
+        LeafNode<double[]> leafNode6 = ImmutableNodes.leafNode(LEAF_QNAME, value6);
+        LeafNode<double[]> equalLeafNode6 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue6);
 
         assertTrue(leafNode6.equals(leafNode6));
         assertTrue(leafNode6.equals(equalLeafNode6));
@@ -302,10 +258,8 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         float[] value5 = new float[] { 1, 2 };
         float[] equalValue5 = new float[] { 1, 2 };
 
-        LeafNode<float[]> leafNode5 = ImmutableNodes.leafNode(LEAF_QNAME,
-                value5);
-        LeafNode<float[]> equalLeafNode5 = ImmutableNodes.leafNode(
-                SAME_LEAF_QNAME, equalValue5);
+        LeafNode<float[]> leafNode5 = ImmutableNodes.leafNode(LEAF_QNAME, value5);
+        LeafNode<float[]> equalLeafNode5 = ImmutableNodes.leafNode(SAME_LEAF_QNAME, equalValue5);
 
         assertTrue(leafNode5.equals(leafNode5));
         assertTrue(leafNode5.equals(equalLeafNode5));
@@ -325,5 +279,4 @@ public class AbstractImmutableNormalizedValueAttrNodeTest {
         assertFalse(leafNode5.equals(leafNodeChar));
         assertFalse(leafNode5.equals(leafNode6));
     }
-
 }