import static com.google.common.base.Verify.verifyNotNull;
import static java.util.Objects.requireNonNull;
+import com.google.common.annotations.Beta;
import java.util.ArrayList;
import java.util.List;
-import javax.annotation.concurrent.ThreadSafe;
+import org.eclipse.jdt.annotation.NonNull;
import org.opendaylight.yangtools.yang.common.QNameModule;
-import org.opendaylight.yangtools.yang.model.api.SchemaContext;
+import org.opendaylight.yangtools.yang.model.api.EffectiveModelContext;
+import org.opendaylight.yangtools.yang.model.api.SchemaNode;
+import org.opendaylight.yangtools.yang.model.api.TypeAware;
import org.opendaylight.yangtools.yang.model.api.TypeDefinition;
-import org.opendaylight.yangtools.yang.model.api.TypedDataSchemaNode;
import org.opendaylight.yangtools.yang.model.api.type.BinaryTypeDefinition;
import org.opendaylight.yangtools.yang.model.api.type.BitsTypeDefinition;
import org.opendaylight.yangtools.yang.model.api.type.BooleanTypeDefinition;
import org.opendaylight.yangtools.yang.model.api.type.Uint8TypeDefinition;
import org.opendaylight.yangtools.yang.model.api.type.UnionTypeDefinition;
import org.opendaylight.yangtools.yang.model.api.type.UnknownTypeDefinition;
-import org.opendaylight.yangtools.yang.model.util.SchemaContextUtil;
+import org.opendaylight.yangtools.yang.model.spi.AbstractEffectiveModelContextProvider;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
* A type-to-codec factory base class with logic to efficiently lookup and cache codec instances,
- * also dealing with union type composition.
- *
- * @author Robert Varga
+ * also dealing with union type composition. This class is thread-safe as long as its underlying {@link CodecCache}
+ * is thread-safe
*
* @param <T> Codec type
+ * @author Robert Varga
*/
-@ThreadSafe
-public abstract class AbstractCodecFactory<T extends TypeAwareCodec<?, ?, ?>> {
- private static final Logger LOG = LoggerFactory.getLogger(AbstractCodecFactory.class);
+public abstract class AbstractCodecFactory<T extends TypeAwareCodec<?, ?, ?>>
+ extends AbstractEffectiveModelContextProvider {
+ /**
+ * Helper interface aiding resolution of leafref chains.
+ */
+ @Beta
+ @FunctionalInterface
+ public interface LeafrefResolver {
+ /**
+ * Resolve specified {@link LeafrefTypeDefinition}.
+ *
+ * @param type leafref definition
+ * @return Resolved type
+ */
+ @NonNull TypeDefinition<?> resolveLeafref(@NonNull LeafrefTypeDefinition type);
+ }
- private final CodecCache<T> cache;
+ private static final Logger LOG = LoggerFactory.getLogger(AbstractCodecFactory.class);
- private final SchemaContext schemaContext;
+ private final @NonNull CodecCache<T> cache;
- protected AbstractCodecFactory(final SchemaContext schemaContext, final CodecCache<T> cache) {
- this.schemaContext = requireNonNull(schemaContext);
+ protected AbstractCodecFactory(final @NonNull EffectiveModelContext schemaContext,
+ final @NonNull CodecCache<T> cache) {
+ super(schemaContext);
this.cache = requireNonNull(cache);
}
- public final SchemaContext getSchemaContext() {
- return schemaContext;
- }
-
- public final T codecFor(final TypedDataSchemaNode schema) {
+ public final <S extends TypeAware & SchemaNode> @NonNull T codecFor(final S schema,
+ final LeafrefResolver resolver) {
/*
* There are many trade-offs to be made here. We need the common case being as fast as possible while reusing
* codecs as much as possible.
* - null codec, which does not depend on anything
* - instance identifier codec, which is based on namespace mapping
*
- * We assume prevalence is in above order and that caching is effective. We therefore
+ * We assume prevalence is in above order and that caching is effective.
*/
final TypeDefinition<?> type = schema.getType();
T ret = cache.lookupSimple(type);
}
// ... and complex types afterwards
- ret = createComplexCodecFor(schema, type);
+ ret = createComplexCodecFor(schema, type, resolver);
LOG.trace("Type {} miss complex {}", type, ret);
return cache.getComplex(schema, ret);
}
protected abstract T identityRefCodec(IdentityrefTypeDefinition type, QNameModule module);
+ // FIXME: there really are two favors, as 'require-instance true' needs to be validated. In order to deal
+ // with that, though, we need access to the current data store.
protected abstract T instanceIdentifierCodec(InstanceIdentifierTypeDefinition type);
protected abstract T int8Codec(Int8TypeDefinition type);
return true;
}
- private T createComplexCodecFor(final TypedDataSchemaNode schema, final TypeDefinition<?> type) {
+ private T createComplexCodecFor(final SchemaNode schema, final TypeDefinition<?> type,
+ final LeafrefResolver resolver) {
if (type instanceof UnionTypeDefinition) {
- return createComplexUnion(schema, (UnionTypeDefinition) type);
+ return createComplexUnion(schema, (UnionTypeDefinition) type, resolver);
} else if (type instanceof LeafrefTypeDefinition) {
- final TypeDefinition<?> target = SchemaContextUtil.getBaseTypeForLeafRef((LeafrefTypeDefinition) type,
- schemaContext, schema);
- verifyNotNull(target, "Unable to find base type for leafref node %s type %s.", schema.getPath(),
- target);
-
+ final TypeDefinition<?> target = resolver.resolveLeafref((LeafrefTypeDefinition) type);
final T ret = getSimpleCodecFor(target);
- return ret != null ? ret : createComplexCodecFor(schema, target);
+ return ret != null ? ret : createComplexCodecFor(schema, target, resolver);
} else if (type instanceof IdentityrefTypeDefinition) {
return identityRefCodec((IdentityrefTypeDefinition) type, schema.getQName().getModule());
} else {
return unionCodec(union, codecs);
}
- private T createComplexUnion(final TypedDataSchemaNode schema, final UnionTypeDefinition union) {
+ private T createComplexUnion(final SchemaNode schema, final UnionTypeDefinition union,
+ final LeafrefResolver resolver) {
final List<TypeDefinition<?>> types = union.getTypes();
final List<T> codecs = new ArrayList<>(types.size());
if (codec == null) {
codec = getSimpleCodecFor(type);
if (codec == null) {
- codec = createComplexCodecFor(schema, type);
+ codec = createComplexCodecFor(schema, type, resolver);
}
}
- codecs.add(verifyNotNull(codec, "Schema %s subtype %s has no codec", schema, type));
+ codecs.add(verifyNotNull(codec, "Type %s has no codec", schema, type));
}
return unionCodec(union, codecs);
Code Review / yangtools.git / blobdiff