BUG-4688: switch revisions from Date to Revision

[yangtools.git] / yang / yang-model-api / src / main / java / org / opendaylight / yangtools / yang / model / api / ModuleIdentifier.java

diff --git a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/ModuleIdentifier.java b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/ModuleIdentifier.java
index 67eed3ad303712eadb276cf7270ab9fb77988a6b..e31e1dfadbfd90289f1628aa15f0e2c2bab494f5 100644 (file)
--- a/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/ModuleIdentifier.java
+++ b/yang/yang-model-api/src/main/java/org/opendaylight/yangtools/yang/model/api/ModuleIdentifier.java
@@ -7,8 +7,8 @@
  */
 package org.opendaylight.yangtools.yang.model.api;
 
-import java.util.Date;
 import java.util.Optional;
+import org.opendaylight.yangtools.yang.common.Revision;
 import org.opendaylight.yangtools.yang.model.repo.api.SourceIdentifier;
 
 /**
@@ -34,13 +34,5 @@ public interface ModuleIdentifier {
      *         YANG {@link Module <b><font color="#339900">revison</font></b>}
      *         keyword
      */
-    // FIXME: BUG-4688: should return Optional<Revision>
-    Optional<Date> getRevision();
-
-    static int compareRevisions(final Optional<Date> first, final Optional<Date> second) {
-        if (!first.isPresent()) {
-            return second.isPresent() ? -1 : 0;
-        }
-        return second.isPresent() ? first.get().compareTo(second.get()) : 1;
-    }
+    Optional<Revision> getRevision();
 }