Do not use "".equals(String)

[yangtools.git] / yang / yang-parser-impl / src / main / java / org / opendaylight / yangtools / yang / parser / builder / impl / RefineUtils.java

diff --git a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/RefineUtils.java b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/RefineUtils.java
index c5071762f15dd81b9acc048c8825f83e224a7295..b9fbf520da9fa9c3bc356e6dad37d96d0b6ed590 100644 (file)
--- a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/RefineUtils.java
+++ b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/builder/impl/RefineUtils.java
@@ -30,13 +30,13 @@ public final class RefineUtils {
     private RefineUtils() {
     }
 
-    public static void refineLeaf(final LeafSchemaNodeBuilder leaf, final RefineBuilder refine) {
+    private static void refineLeaf(final LeafSchemaNodeBuilder leaf, final RefineBuilder refine) {
         String defaultStr = refine.getDefaultStr();
         Boolean mandatory = refine.isMandatory();
         MustDefinition must = refine.getMust();
         List<UnknownSchemaNodeBuilder> unknownNodes = refine.getUnknownNodes();
 
-        if (defaultStr != null && !("".equals(defaultStr))) {
+        if (defaultStr != null && !defaultStr.isEmpty()) {
             leaf.setDefaultStr(defaultStr);
         }
         if (mandatory != null) {
@@ -53,7 +53,7 @@ public final class RefineUtils {
         }
     }
 
-    public static void refineContainer(final ContainerSchemaNodeBuilder container, final RefineBuilder refine) {
+    private static void refineContainer(final ContainerSchemaNodeBuilder container, final RefineBuilder refine) {
         Boolean presence = refine.isPresence();
         MustDefinition must = refine.getMust();
         List<UnknownSchemaNodeBuilder> unknownNodes = refine.getUnknownNodes();
@@ -72,7 +72,7 @@ public final class RefineUtils {
         }
     }
 
-    public static void refineList(final ListSchemaNodeBuilder list, final RefineBuilder refine) {
+    private static void refineList(final ListSchemaNodeBuilder list, final RefineBuilder refine) {
         MustDefinition must = refine.getMust();
         Integer min = refine.getMinElements();
         Integer max = refine.getMaxElements();
@@ -259,7 +259,6 @@ public final class RefineUtils {
     private static void refineDefault(final Builder node, final RefineBuilder refine) {
         final String moduleName = refine.getModuleName();
         final int line = refine.getLine();
-        Class<? extends Builder> cls = node.getClass();
 
 
         final DocumentedNodeBuilder documentedNode;