Fix sonar warnings

[yangtools.git] / yang / yang-parser-impl / src / main / java / org / opendaylight / yangtools / yang / parser / spi / meta / StmtContextUtils.java

diff --git a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/spi/meta/StmtContextUtils.java b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/spi/meta/StmtContextUtils.java
index fa2e78bddb21689f1b33376e572be8ceea10b0d0..a410c197d9fae6d06bf63124117e2fd9a2ad8e3a 100644 (file)
--- a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/spi/meta/StmtContextUtils.java
+++ b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/spi/meta/StmtContextUtils.java
@@ -7,8 +7,8 @@
  */
 package org.opendaylight.yangtools.yang.parser.spi.meta;
 
-import java.util.Collection;
 import com.google.common.base.Function;
+import java.util.Collection;
 import org.opendaylight.yangtools.yang.model.api.meta.DeclaredStatement;
 import org.opendaylight.yangtools.yang.model.api.meta.EffectiveStatement;
 
@@ -16,14 +16,14 @@ public final class StmtContextUtils {
 
     private static final Function<StmtContext<?, ?,?>, DeclaredStatement<?>> BUILD_DECLARED = new Function<StmtContext<?,?,?>, DeclaredStatement<?>>() {
         @Override
-        public DeclaredStatement<?> apply(StmtContext<?, ?, ?> input) {
+        public DeclaredStatement<?> apply(final StmtContext<?, ?, ?> input) {
             return input.buildDeclared();
         }
     };
 
     private static final Function<StmtContext<?, ?,?>, EffectiveStatement<?,?>> BUILD_EFFECTIVE = new Function<StmtContext<?,?,?>, EffectiveStatement<?,?>>() {
         @Override
-        public EffectiveStatement<?, ?> apply(StmtContext<?, ?, ?> input) {
+        public EffectiveStatement<?, ?> apply(final StmtContext<?, ?, ?> input) {
             return input.buildEffective();
         }
     };
@@ -38,15 +38,14 @@ public final class StmtContextUtils {
     }
 
     @SuppressWarnings("unchecked")
-
-    public static final <E extends EffectiveStatement<?, ?>> Function<StmtContext<?, ?, ? extends E>, E> buildEffective() {
+    public static <E extends EffectiveStatement<?, ?>> Function<StmtContext<?, ?, ? extends E>, E> buildEffective() {
         return Function.class.cast(BUILD_EFFECTIVE);
     }
 
     @SuppressWarnings("unchecked")
-    public static final <AT, DT extends DeclaredStatement<AT>> AT firstAttributeOf(
-            Iterable<? extends StmtContext<?, ?, ?>> contexts,
-            Class<DT> declaredType) {
+    public static <AT, DT extends DeclaredStatement<AT>> AT firstAttributeOf(
+            final Iterable<? extends StmtContext<?, ?, ?>> contexts,
+            final Class<DT> declaredType) {
         for (StmtContext<?, ?, ?> ctx : contexts) {
             if (producesDeclared(ctx, declaredType)) {
                 return (AT) ctx.getStatementArgument();
@@ -56,8 +55,8 @@ public final class StmtContextUtils {
     }
 
     @SuppressWarnings("unchecked")
-    public static final <AT, DT extends DeclaredStatement<AT>> AT firstAttributeOf(
-            StmtContext<?, ?, ?> ctx, Class<DT> declaredType) {
+    public static <AT, DT extends DeclaredStatement<AT>> AT firstAttributeOf(
+            final StmtContext<?, ?, ?> ctx, final Class<DT> declaredType) {
 
         if (producesDeclared(ctx, declaredType)) {
             return (AT) ctx.getStatementArgument();
@@ -66,8 +65,8 @@ public final class StmtContextUtils {
         return null;
     }
 
-    public static final <DT extends DeclaredStatement<?>> StmtContext<?, ?, ?> findFirstDeclaredSubstatement(
-            StmtContext<?, ?, ?> stmtContext, Class<DT> declaredType) {
+    public static <DT extends DeclaredStatement<?>> StmtContext<?, ?, ?> findFirstDeclaredSubstatement(
+            final StmtContext<?, ?, ?> stmtContext, final Class<DT> declaredType) {
         Collection<? extends StmtContext<?, ?, ?>> declaredSubstatements = stmtContext
                 .declaredSubstatements();
         for (StmtContext<?, ?, ?> subStmtContext : declaredSubstatements) {
@@ -78,28 +77,30 @@ public final class StmtContextUtils {
         return null;
     }
 
-    public static final StmtContext<?, ?, ?> findFirstDeclaredSubstatement(
-            StmtContext<?, ?, ?> stmtContext, int startIndex, Class<? extends DeclaredStatement<?>>... types) {
+    public static StmtContext<?, ?, ?> findFirstDeclaredSubstatement(
+            final StmtContext<?, ?, ?> stmtContext, int startIndex, final Class<? extends DeclaredStatement<?>>... types) {
 
-        if (startIndex >= types.length)
+        if (startIndex >= types.length) {
             return null;
+        }
 
         Collection<? extends StmtContext<?, ?, ?>> declaredSubstatements = stmtContext
                 .declaredSubstatements();
         for (StmtContext<?, ?, ?> subStmtContext : declaredSubstatements) {
             if (producesDeclared(subStmtContext,types[startIndex])) {
-                if (startIndex + 1 == types.length)
+                if (startIndex + 1 == types.length) {
                     return subStmtContext;
-                else
+                } else {
                     return findFirstDeclaredSubstatement(subStmtContext,
                             ++startIndex, types);
+                }
             }
         }
         return null;
     }
 
-    public static final <DT extends DeclaredStatement<?>> StmtContext<?, ?, ?> findFirstDeclaredSubstatementOnSublevel(
-            StmtContext<?, ?, ?> stmtContext, Class<DT> declaredType,
+    public static <DT extends DeclaredStatement<?>> StmtContext<?, ?, ?> findFirstDeclaredSubstatementOnSublevel(
+            final StmtContext<?, ?, ?> stmtContext, final Class<DT> declaredType,
             int sublevel) {
         Collection<? extends StmtContext<?, ?, ?>> declaredSubstatements = stmtContext
                 .declaredSubstatements();
@@ -110,16 +111,17 @@ public final class StmtContextUtils {
                 if (sublevel > 1) {
                     StmtContext<?, ?, ?> result = findFirstDeclaredSubstatementOnSublevel(
                             subStmtContext, declaredType, --sublevel);
-                    if (result != null)
+                    if (result != null) {
                         return result;
+                    }
                 }
             }
         }
         return null;
     }
 
-    public static final <DT extends DeclaredStatement<?>> StmtContext<?, ?, ?> findDeepFirstDeclaredSubstatement(
-            StmtContext<?, ?, ?> stmtContext, Class<DT> declaredType) {
+    public static <DT extends DeclaredStatement<?>> StmtContext<?, ?, ?> findDeepFirstDeclaredSubstatement(
+            final StmtContext<?, ?, ?> stmtContext, final Class<DT> declaredType) {
 
         Collection<? extends StmtContext<?, ?, ?>> declaredSubstatements = stmtContext
                 .declaredSubstatements();
@@ -130,16 +132,17 @@ public final class StmtContextUtils {
             } else {
                 StmtContext<?, ?, ?> result = findDeepFirstDeclaredSubstatement(
                         subStmtContext, declaredType);
-                if (result != null)
+                if (result != null) {
                     return result;
+                }
 
             }
         }
         return null;
     }
 
-    public static final boolean producesDeclared(StmtContext<?, ?, ?> ctx,
-            Class<? extends DeclaredStatement<?>> type) {
+    public static boolean producesDeclared(final StmtContext<?, ?, ?> ctx,
+            final Class<? extends DeclaredStatement<?>> type) {
         return type.isAssignableFrom(ctx.getPublicDefinition()
                 .getDeclaredRepresentationClass());
     }