Bug 8831 - Yang 1.1 default values are not checked correctly

[yangtools.git] / yang / yang-parser-impl / src / main / java / org / opendaylight / yangtools / yang / parser / stmt / rfc6020 / effective / IdentityEffectiveStatementImpl.java

diff --git a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/effective/IdentityEffectiveStatementImpl.java b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/effective/IdentityEffectiveStatementImpl.java
index d6ae604622fce7146563168b774f349bfdc2cf7b..eac4e8f9c7423ddb18a0141be42eebaabbe19335 100644 (file)
--- a/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/effective/IdentityEffectiveStatementImpl.java
+++ b/yang/yang-parser-impl/src/main/java/org/opendaylight/yangtools/yang/parser/stmt/rfc6020/effective/IdentityEffectiveStatementImpl.java
@@ -7,54 +7,75 @@
  */
 package org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective;
 
+import com.google.common.base.MoreObjects;
+import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableSet;
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
 import java.util.Objects;
 import java.util.Set;
+import javax.annotation.Nonnull;
 import org.opendaylight.yangtools.yang.common.QName;
 import org.opendaylight.yangtools.yang.model.api.IdentitySchemaNode;
 import org.opendaylight.yangtools.yang.model.api.meta.EffectiveStatement;
 import org.opendaylight.yangtools.yang.model.api.stmt.IdentityStatement;
 import org.opendaylight.yangtools.yang.parser.spi.meta.DerivedIdentitiesNamespace;
+import org.opendaylight.yangtools.yang.parser.spi.meta.MutableStatement;
 import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContext;
 
-public final class IdentityEffectiveStatementImpl extends AbstractEffectiveSchemaNode<IdentityStatement>
-        implements IdentitySchemaNode {
-    private IdentitySchemaNode baseIdentity;
+public final class IdentityEffectiveStatementImpl extends AbstractEffectiveSchemaNode<IdentityStatement> implements
+        IdentitySchemaNode, MutableStatement {
     private final Set<IdentitySchemaNode> derivedIdentities;
+    private IdentitySchemaNode baseIdentity;
+    private Set<IdentitySchemaNode> baseIdentities;
+    private boolean sealed;
 
     public IdentityEffectiveStatementImpl(
             final StmtContext<QName, IdentityStatement, EffectiveStatement<QName, IdentityStatement>> ctx) {
         super(ctx);
 
+        this.baseIdentities = new HashSet<>();
+        ((StmtContext.Mutable<?, ?, ?>) ctx).addMutableStmtToSeal(this);
+
         // initDerivedIdentities
-        Set<IdentitySchemaNode> derivedIdentitiesInit = new HashSet<IdentitySchemaNode>();
-        List<StmtContext<?, ?, ?>> derivedIdentitiesCtxList = ctx.getFromNamespace(
+        final Set<IdentitySchemaNode> derivedIdentitiesInit = new HashSet<>();
+        final List<StmtContext<?, ?, ?>> derivedIdentitiesCtxList = ctx.getFromNamespace(
                 DerivedIdentitiesNamespace.class, ctx.getStatementArgument());
         if (derivedIdentitiesCtxList == null) {
             this.derivedIdentities = ImmutableSet.of();
             return;
         }
-        for (StmtContext<?, ?, ?> derivedIdentityCtx : derivedIdentitiesCtxList) {
-            IdentityEffectiveStatementImpl derivedIdentity = (IdentityEffectiveStatementImpl) derivedIdentityCtx
+        for (final StmtContext<?, ?, ?> derivedIdentityCtx : derivedIdentitiesCtxList) {
+            final IdentityEffectiveStatementImpl derivedIdentity = (IdentityEffectiveStatementImpl) derivedIdentityCtx
                     .buildEffective();
-            derivedIdentity.initBaseIdentity(this);
+            derivedIdentity.addBaseIdentity(this);
             derivedIdentitiesInit.add(derivedIdentity);
         }
         this.derivedIdentities = ImmutableSet.copyOf(derivedIdentitiesInit);
     }
 
-    private void initBaseIdentity(final IdentityEffectiveStatementImpl baseIdentity) {
+    private void addBaseIdentity(final IdentityEffectiveStatementImpl baseIdentity) {
+        Preconditions.checkState(!sealed, "Attempt to modify sealed identity effective statement %s", getQName());
         this.baseIdentity = baseIdentity;
+        this.baseIdentities.add(baseIdentity);
     }
 
     @Override
     public IdentitySchemaNode getBaseIdentity() {
+        Preconditions.checkState(sealed, "Attempt to get base identity from unsealed identity effective statement %s",
+                getQName());
         return baseIdentity;
     }
 
+    @Nonnull
+    @Override
+    public Set<IdentitySchemaNode> getBaseIdentities() {
+        Preconditions.checkState(sealed,
+                "Attempt to get base identities from unsealed identity effective statement %s", getQName());
+        return baseIdentities;
+    }
+
     @Override
     public Set<IdentitySchemaNode> getDerivedIdentities() {
         return Collections.unmodifiableSet(derivedIdentities);
@@ -80,15 +101,20 @@ public final class IdentityEffectiveStatementImpl extends AbstractEffectiveSchem
         if (getClass() != obj.getClass()) {
             return false;
         }
-        IdentityEffectiveStatementImpl other = (IdentityEffectiveStatementImpl) obj;
+        final IdentityEffectiveStatementImpl other = (IdentityEffectiveStatementImpl) obj;
         return Objects.equals(getQName(), other.getQName()) && Objects.equals(getPath(), other.getPath());
     }
 
     @Override
     public String toString() {
-        return IdentityEffectiveStatementImpl.class.getSimpleName() + "[" +
-                "base=" + baseIdentity +
-                ", qname=" + getQName() +
-                "]";
+        return MoreObjects.toStringHelper(this).add("qname", getQName()).add("path", getPath()).toString();
+    }
+
+    @Override
+    public void seal() {
+        if (!sealed) {
+            baseIdentities = ImmutableSet.copyOf(baseIdentities);
+            sealed = true;
+        }
     }
 }