Fixed bug in resolving groupings.
[yangtools.git] / yang / yang-parser-impl / src / main / java / org / opendaylight / yangtools / yang / parser / util / GroupingUtils.java
index 4626ce09571e3346419089c4a767e51a8b9cd807..80fb2c4479176af7e49a88303dfb08b8473f1f56 100644 (file)
@@ -81,7 +81,7 @@ public final class GroupingUtils {
             groupingName = groupingString;
         }
 
-        ModuleBuilder dependentModule = null;
+        ModuleBuilder dependentModule;
         if (groupingPrefix.equals(module.getPrefix())) {
             dependentModule = module;
         } else {
@@ -92,7 +92,7 @@ public final class GroupingUtils {
             return null;
         }
 
-        GroupingBuilder result = null;
+        GroupingBuilder result;
         Set<GroupingBuilder> groupings = dependentModule.getGroupingBuilders();
         result = findGroupingBuilder(groupings, groupingName);
         if (result != null) {
@@ -196,6 +196,7 @@ public final class GroupingUtils {
      * Add nodes defined in uses target grouping to uses parent.
      *
      * @param usesNode
+     *            yang uses node which will be instantiated in current location
      */
     public static void updateUsesParent(UsesNodeBuilder usesNode) {
         DataNodeContainerBuilder parent = usesNode.getParent();
@@ -205,30 +206,35 @@ public final class GroupingUtils {
         String prefix = module.getPrefix();
 
         SchemaPath parentPath = parent.getPath();
-        if(parent instanceof AugmentationSchemaBuilder) {
-            parentPath = ((AugmentationSchemaBuilder)parent).getTargetNodeSchemaPath();
+        if (parent instanceof AugmentationSchemaBuilder) {
+            parentPath = ((AugmentationSchemaBuilder) parent).getTargetNodeSchemaPath();
         }
 
         // child nodes
         for (DataSchemaNodeBuilder child : usesNode.getTargetChildren()) {
             if (child instanceof GroupingMember) {
-                ((GroupingMember) child).setAddedByUses(true);
+                setAddedByUsesToNode((GroupingMember)child);
             }
 
-            GroupingMember gm = (GroupingMember) child;
-            if (gm.isAddedByUses()) {
-                if(usesNode.isAugmenting()) {
-                    if(child.getQName().getLocalName().equals("paths")) {
-                        System.out.println();
+            if (child instanceof GroupingMember) {
+                GroupingMember gm = (GroupingMember) child;
+                if (gm.isAddedByUses()) {
+                    if (usesNode.isAugmenting()) {
+                        child.setAugmenting(true);
+                    }
+                    if (usesNode.isAugmenting()
+                            && !(usesNode.getParentAugment().getParent() instanceof UsesNodeBuilder)) {
+                        AugmentationSchemaBuilder parentAugment = usesNode.getParentAugment();
+                        ModuleBuilder m = ParserUtils.getParentModule(parentAugment);
+                        correctNodePathForUsesNodes(child, parentPath, m);
+                    } else {
+                        child.setQName(new QName(ns, rev, prefix, child.getQName().getLocalName()));
+                        correctNodePathForUsesNodes(child, parentPath, module);
                     }
-                    AugmentationSchemaBuilder parentAugment = usesNode.getParentAugment();
-                    ModuleBuilder m = ParserUtils.getParentModule(parentAugment);
-                    child.setAugmenting(true);
-                    correctNodePathForUsesNodes(child, parentPath, m);
-                } else {
-                    child.setQName(new QName(ns, rev, prefix, child.getQName().getLocalName()));
-                    correctNodePathForUsesNodes(child, parentPath, module);
                 }
+            } else {
+                throw new YangParseException(module.getName(), usesNode.getLine(),
+                        "Failed to process uses node: unresolved child node");
             }
 
             parent.addChildNode(child);
@@ -259,6 +265,17 @@ public final class GroupingUtils {
         }
     }
 
+    private static void setAddedByUsesToNode(GroupingMember node) {
+        node.setAddedByUses(true);
+        if (node instanceof DataNodeContainerBuilder) {
+            for (DataSchemaNodeBuilder child : ((DataNodeContainerBuilder)node).getChildNodeBuilders()) {
+                if (child instanceof GroupingMember) {
+                    setAddedByUsesToNode((GroupingMember)child);
+                }
+            }
+        }
+    }
+
     /**
      * Read data defined in target grouping builder, make a copy and add them to
      * uses node builder.
@@ -278,17 +295,17 @@ public final class GroupingUtils {
      * Read child nodes defined in target grouping and make a copy of them.
      *
      * @param usesNode
-     * @return copy of child nodes defined in uses target grouping
+     *            uses node for which data will be collected
      */
     private static void collectTargetChildNodes(UsesNodeBuilder usesNode) {
         final GroupingBuilder target = usesNode.getGroupingBuilder();
         final Set<DataSchemaNodeBuilder> collection = new HashSet<>();
-        addChildNodeToCollection(usesNode, collection, target.getChildNodeBuilders());
+        addChildNodeToCollection(usesNode, collection, target.getChildNodeBuilders(), usesNode.getParent());
 
         for (UsesNodeBuilder targetUses : target.getUsesNodes()) {
             Set<DataSchemaNodeBuilder> targetUsesChildNodes = collectTargetUsesChildNodes(targetUses,
                     usesNode.getParent());
-            addChildNodeToCollection(usesNode, collection, targetUsesChildNodes);
+            addChildNodeToCollection(usesNode, collection, targetUsesChildNodes, usesNode.getParent());
         }
         usesNode.getTargetChildren().addAll(collection);
     }
@@ -297,17 +314,17 @@ public final class GroupingUtils {
             DataNodeContainerBuilder parent) {
         final GroupingBuilder target = usesNode.getGroupingBuilder();
         final Set<DataSchemaNodeBuilder> collection = new HashSet<>(usesNode.getTargetChildren());
-        addChildNodeToCollection(usesNode, collection, target.getChildNodeBuilders());
+        addChildNodeToCollection(usesNode, collection, target.getChildNodeBuilders(), parent);
 
         for (UsesNodeBuilder targetUses : target.getUsesNodes()) {
             Set<DataSchemaNodeBuilder> targetUsesChildNodes = collectTargetUsesChildNodes(targetUses, parent);
-            addChildNodeToCollection(usesNode, collection, targetUsesChildNodes);
+            addChildNodeToCollection(usesNode, collection, targetUsesChildNodes, parent);
         }
         return collection;
     }
 
     private static void addChildNodeToCollection(UsesNodeBuilder usesNode, Set<DataSchemaNodeBuilder> collection,
-            Set<DataSchemaNodeBuilder> allNodes) {
+            Set<DataSchemaNodeBuilder> allNodes, Builder parent) {
         for (DataSchemaNodeBuilder childNode : allNodes) {
             boolean exists = false;
             for (DataSchemaNodeBuilder usesChildNode : usesNode.getTargetChildren()) {
@@ -317,7 +334,10 @@ public final class GroupingUtils {
                 }
             }
             if (!exists) {
-                DataSchemaNodeBuilder copy = CopyUtils.copy(childNode, usesNode.getParent(), true);
+                DataSchemaNodeBuilder copy = CopyUtils.copy(childNode, parent, true);
+                if (copy instanceof GroupingMember) {
+                    setAddedByUsesToNode((GroupingMember)copy);
+                }
                 collection.add(copy);
             }
         }
@@ -327,16 +347,16 @@ public final class GroupingUtils {
      * Read typedefs defined in target grouping and make a copy of them.
      *
      * @param usesNode
-     * @return copy of typedefs defined in uses target grouping
+     *            uses node for which data will be collected
      */
     private static void collectTargetTypedefs(UsesNodeBuilder usesNode) {
         final GroupingBuilder target = usesNode.getGroupingBuilder();
         Set<TypeDefinitionBuilder> collection = new HashSet<>();
-        addTypedefToCollection(usesNode, collection, target.getTypeDefinitionBuilders());
+        addTypedefToCollection(usesNode, collection, target.getTypeDefinitionBuilders(), usesNode.getParent());
 
         for (UsesNodeBuilder targetUses : target.getUsesNodes()) {
             Set<TypeDefinitionBuilder> targetUsesTypedefs = collectTargetUsesTypedefs(targetUses, usesNode.getParent());
-            addTypedefToCollection(usesNode, collection, targetUsesTypedefs);
+            addTypedefToCollection(usesNode, collection, targetUsesTypedefs, usesNode.getParent());
         }
         usesNode.getTargetTypedefs().addAll(collection);
     }
@@ -345,17 +365,17 @@ public final class GroupingUtils {
             DataNodeContainerBuilder parent) {
         final GroupingBuilder target = usesNode.getGroupingBuilder();
         Set<TypeDefinitionBuilder> collection = new HashSet<>(usesNode.getTargetTypedefs());
-        addTypedefToCollection(usesNode, collection, target.getTypeDefinitionBuilders());
+        addTypedefToCollection(usesNode, collection, target.getTypeDefinitionBuilders(), parent);
 
         for (UsesNodeBuilder targetUses : target.getUsesNodes()) {
             Set<TypeDefinitionBuilder> targetUsesTypedefs = collectTargetUsesTypedefs(targetUses, parent);
-            addTypedefToCollection(usesNode, collection, targetUsesTypedefs);
+            addTypedefToCollection(usesNode, collection, targetUsesTypedefs, parent);
         }
         return collection;
     }
 
     private static void addTypedefToCollection(UsesNodeBuilder usesNode, Set<TypeDefinitionBuilder> collection,
-            Set<TypeDefinitionBuilder> allTypedefs) {
+            Set<TypeDefinitionBuilder> allTypedefs, Builder parent) {
         for (TypeDefinitionBuilder childNode : allTypedefs) {
             boolean exists = false;
             for (TypeDefinitionBuilder usesTypedef : usesNode.getTargetTypedefs()) {
@@ -365,7 +385,7 @@ public final class GroupingUtils {
                 }
             }
             if (!exists) {
-                TypeDefinitionBuilder copy = CopyUtils.copy(childNode, usesNode.getParent(), true);
+                TypeDefinitionBuilder copy = CopyUtils.copy(childNode, parent, true);
                 collection.add(copy);
             }
         }
@@ -375,16 +395,16 @@ public final class GroupingUtils {
      * Read groupings defined in target grouping and make a copy of them.
      *
      * @param usesNode
-     * @return copy of groupings defined in uses target grouping
+     *            uses node for which data will be collected
      */
     private static void collectTargetGroupings(UsesNodeBuilder usesNode) {
         final GroupingBuilder target = usesNode.getGroupingBuilder();
         Set<GroupingBuilder> collection = new HashSet<>();
-        addGroupingToCollection(usesNode, collection, target.getGroupingBuilders());
+        addGroupingToCollection(usesNode, collection, target.getGroupingBuilders(), usesNode.getParent());
 
         for (UsesNodeBuilder targetUses : target.getUsesNodes()) {
             Set<GroupingBuilder> targetUsesGrouping = collectTargetGroupings(targetUses, usesNode.getParent());
-            addGroupingToCollection(usesNode, collection, targetUsesGrouping);
+            addGroupingToCollection(usesNode, collection, targetUsesGrouping, usesNode.getParent());
         }
         usesNode.getTargetGroupings().addAll(collection);
     }
@@ -392,17 +412,17 @@ public final class GroupingUtils {
     private static Set<GroupingBuilder> collectTargetGroupings(UsesNodeBuilder usesNode, DataNodeContainerBuilder parent) {
         final GroupingBuilder target = usesNode.getGroupingBuilder();
         Set<GroupingBuilder> collection = new HashSet<>(usesNode.getTargetGroupings());
-        addGroupingToCollection(usesNode, collection, target.getGroupingBuilders());
+        addGroupingToCollection(usesNode, collection, target.getGroupingBuilders(), parent);
 
         for (UsesNodeBuilder targetUses : target.getUsesNodes()) {
             Set<GroupingBuilder> targetUsesGroupings = collectTargetGroupings(targetUses, parent);
-            addGroupingToCollection(usesNode, collection, targetUsesGroupings);
+            addGroupingToCollection(usesNode, collection, targetUsesGroupings, parent);
         }
         return collection;
     }
 
     private static void addGroupingToCollection(UsesNodeBuilder usesNode, Set<GroupingBuilder> collection,
-            Set<GroupingBuilder> allGroupings) {
+            Set<GroupingBuilder> allGroupings, Builder parent) {
         for (GroupingBuilder childNode : allGroupings) {
             boolean exists = false;
             for (GroupingBuilder usesGrouping : usesNode.getTargetGroupings()) {
@@ -412,7 +432,7 @@ public final class GroupingUtils {
                 }
             }
             if (!exists) {
-                GroupingBuilder copy = CopyUtils.copy(childNode, usesNode.getParent(), true);
+                GroupingBuilder copy = CopyUtils.copy(childNode, parent, true);
                 collection.add(copy);
             }
         }
@@ -422,17 +442,17 @@ public final class GroupingUtils {
      * Read unknown nodes defined in target grouping and make a copy of them.
      *
      * @param usesNode
-     * @return copy of unknown nodes defined in uses target grouping
+     *            uses node for which data will be collected
      */
     private static void collectTargetUnknownNodes(UsesNodeBuilder usesNode) {
         final GroupingBuilder target = usesNode.getGroupingBuilder();
         final List<UnknownSchemaNodeBuilder> collection = new ArrayList<>();
-        addUnknownNodeToCollection(usesNode, collection, target.getUnknownNodeBuilders());
+        addUnknownNodeToCollection(usesNode, collection, target.getUnknownNodeBuilders(), usesNode.getParent());
 
         for (UsesNodeBuilder targetUses : target.getUsesNodes()) {
             List<UnknownSchemaNodeBuilder> targetUsesUnknownNodes = collectTargetUnknownNodes(targetUses,
                     usesNode.getParent());
-            addUnknownNodeToCollection(usesNode, collection, targetUsesUnknownNodes);
+            addUnknownNodeToCollection(usesNode, collection, targetUsesUnknownNodes, usesNode.getParent());
         }
         usesNode.getTargetUnknownNodes().addAll(collection);
     }
@@ -441,17 +461,17 @@ public final class GroupingUtils {
             DataNodeContainerBuilder parent) {
         final GroupingBuilder target = usesNode.getGroupingBuilder();
         List<UnknownSchemaNodeBuilder> collection = new ArrayList<>(usesNode.getTargetUnknownNodes());
-        addUnknownNodeToCollection(usesNode, collection, target.getUnknownNodeBuilders());
+        addUnknownNodeToCollection(usesNode, collection, target.getUnknownNodeBuilders(), parent);
 
         for (UsesNodeBuilder targetUses : target.getUsesNodes()) {
             List<UnknownSchemaNodeBuilder> targetUsesUnknownNodes = collectTargetUnknownNodes(targetUses, parent);
-            addUnknownNodeToCollection(usesNode, collection, targetUsesUnknownNodes);
+            addUnknownNodeToCollection(usesNode, collection, targetUsesUnknownNodes, parent);
         }
         return collection;
     }
 
     private static void addUnknownNodeToCollection(UsesNodeBuilder usesNode, List<UnknownSchemaNodeBuilder> collection,
-            List<UnknownSchemaNodeBuilder> allUnknownNodes) {
+            List<UnknownSchemaNodeBuilder> allUnknownNodes, Builder parent) {
         for (UnknownSchemaNodeBuilder childNode : allUnknownNodes) {
             boolean exists = false;
             for (UnknownSchemaNodeBuilder usesUnknownNode : usesNode.getTargetUnknownNodes()) {
@@ -461,7 +481,7 @@ public final class GroupingUtils {
                 }
             }
             if (!exists) {
-                UnknownSchemaNodeBuilder copy = CopyUtils.copy(childNode, usesNode.getParent(), true);
+                UnknownSchemaNodeBuilder copy = CopyUtils.copy(childNode, parent, true);
                 collection.add(copy);
             }
         }
@@ -561,10 +581,8 @@ public final class GroupingUtils {
                     throw new YangParseException(moduleName, lineNumber,
                             "Unknown member of target grouping while resolving uses node.");
                 }
-                if (newChild instanceof GroupingMember) {
-                    ((GroupingMember) newChild).setAddedByUses(true);
-                }
 
+                ((GroupingMember) newChild).setAddedByUses(true);
                 newChildren.add(newChild);
             }
         }
@@ -585,7 +603,7 @@ public final class GroupingUtils {
     private static void correctNodePathForUsesNodes(final SchemaNodeBuilder node, final SchemaPath parentSchemaPath,
             final ModuleBuilder parentModule) {
         // set correct path
-        List<QName> targetNodePath = new ArrayList<QName>(parentSchemaPath.getPath());
+        List<QName> targetNodePath = new ArrayList<>(parentSchemaPath.getPath());
         targetNodePath.add(new QName(parentModule.getNamespace(), parentModule.getRevision(), parentModule.getPrefix(),
                 node.getQName().getLocalName()));
         node.setPath(new SchemaPath(targetNodePath, true));
@@ -612,16 +630,23 @@ public final class GroupingUtils {
      * already performed.
      *
      * @param usesNode
+     *            uses node containing refine statements
      */
     public static void performRefine(UsesNodeBuilder usesNode) {
         for (RefineHolder refine : usesNode.getRefines()) {
-            DataSchemaNodeBuilder nodeToRefine = null;
-            for (DataSchemaNodeBuilder dataNode : usesNode.getParent().getChildNodeBuilders()) {
-                if (refine.getName().equals(dataNode.getQName().getLocalName())) {
-                    nodeToRefine = dataNode;
-                    break;
+            String refineTargetPath = refine.getName();
+
+            String[] splitted = refineTargetPath.split("/");
+            Builder currentNode = usesNode.getParent();
+            for (String pathElement : splitted) {
+                if (currentNode instanceof DataNodeContainerBuilder) {
+                    currentNode = ((DataNodeContainerBuilder) currentNode).getDataChildByName(pathElement);
+                } else if (currentNode instanceof ChoiceBuilder) {
+                    currentNode = ((ChoiceBuilder) currentNode).getCaseNodeByName(pathElement);
                 }
             }
+
+            DataSchemaNodeBuilder nodeToRefine = (DataSchemaNodeBuilder) currentNode;
             if (nodeToRefine == null) {
                 throw new YangParseException(refine.getModuleName(), refine.getLine(), "Refine target node '"
                         + refine.getName() + "' not found");