*/
package org.opendaylight.yangtools.yang.parser.rfc7950.stmt.list;
+import static com.google.common.base.Verify.verify;
+
import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableSet;
import java.util.ArrayList;
import java.util.HashSet;
import java.util.List;
import java.util.Optional;
import java.util.Set;
+import org.eclipse.jdt.annotation.NonNull;
import org.opendaylight.yangtools.yang.common.QName;
import org.opendaylight.yangtools.yang.model.api.ElementCountConstraint;
import org.opendaylight.yangtools.yang.model.api.LeafSchemaNode;
import org.opendaylight.yangtools.yang.model.api.YangStmtMapping;
import org.opendaylight.yangtools.yang.model.api.meta.DeclaredStatement;
import org.opendaylight.yangtools.yang.model.api.meta.EffectiveStatement;
+import org.opendaylight.yangtools.yang.model.api.meta.StatementDefinition;
import org.opendaylight.yangtools.yang.model.api.stmt.KeyEffectiveStatement;
import org.opendaylight.yangtools.yang.model.api.stmt.ListEffectiveStatement;
import org.opendaylight.yangtools.yang.model.api.stmt.ListStatement;
import org.opendaylight.yangtools.yang.model.api.stmt.OrderedByEffectiveStatement;
import org.opendaylight.yangtools.yang.model.api.stmt.OrderedByStatement.Ordering;
-import org.opendaylight.yangtools.yang.model.api.stmt.SchemaNodeIdentifier;
import org.opendaylight.yangtools.yang.model.api.stmt.StatusEffectiveStatement;
-import org.opendaylight.yangtools.yang.parser.rfc7950.namespace.ChildSchemaNodeNamespace;
-import org.opendaylight.yangtools.yang.parser.rfc7950.stmt.BaseQNameStatementSupport;
+import org.opendaylight.yangtools.yang.parser.rfc7950.stmt.BaseSchemaTreeStatementSupport;
import org.opendaylight.yangtools.yang.parser.rfc7950.stmt.EffectiveStatementMixins.EffectiveStatementWithFlags.FlagsBuilder;
import org.opendaylight.yangtools.yang.parser.rfc7950.stmt.EffectiveStmtUtils;
import org.opendaylight.yangtools.yang.parser.spi.meta.InferenceException;
import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContext;
import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContext.Mutable;
-import org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils;
-import org.opendaylight.yangtools.yang.parser.spi.source.StatementSourceReference;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-abstract class AbstractListStatementSupport extends BaseQNameStatementSupport<ListStatement, ListEffectiveStatement> {
+abstract class AbstractListStatementSupport extends
+ BaseSchemaTreeStatementSupport<ListStatement, ListEffectiveStatement> {
+
private static final Logger LOG = LoggerFactory.getLogger(AbstractListStatementSupport.class);
+ private static final ImmutableSet<YangStmtMapping> UNINSTANTIATED_DATATREE_STATEMENTS = ImmutableSet.of(
+ YangStmtMapping.GROUPING, YangStmtMapping.NOTIFICATION, YangStmtMapping.INPUT, YangStmtMapping.OUTPUT);
AbstractListStatementSupport() {
super(YangStmtMapping.LIST);
}
@Override
- public final QName parseArgumentValue(final StmtContext<?, ?, ?> ctx, final String value) {
- return StmtContextUtils.parseIdentifier(ctx, value);
- }
-
- @Override
- public final void onStatementAdded(final Mutable<QName, ListStatement, ListEffectiveStatement> stmt) {
- stmt.coerceParentContext().addToNs(ChildSchemaNodeNamespace.class, stmt.coerceStatementArgument(), stmt);
- }
-
- @Override
- protected ListStatement createDeclared(final StmtContext<QName, ListStatement, ?> ctx,
+ protected final ListStatement createDeclared(final StmtContext<QName, ListStatement, ?> ctx,
final ImmutableList<? extends DeclaredStatement<?>> substatements) {
return new RegularListStatement(ctx.coerceStatementArgument(), substatements);
}
@Override
- protected ListStatement createEmptyDeclared(final StmtContext<QName, ListStatement, ?> ctx) {
+ protected final ListStatement createEmptyDeclared(final StmtContext<QName, ListStatement, ?> ctx) {
return new EmptyListStatement(ctx.coerceStatementArgument());
}
protected final ListEffectiveStatement createEffective(
final StmtContext<QName, ListStatement, ListEffectiveStatement> ctx,
final ListStatement declared, final ImmutableList<? extends EffectiveStatement<?, ?>> substatements) {
- final StatementSourceReference ref = ctx.getStatementSourceReference();
final SchemaPath path = ctx.getSchemaPath().get();
final ListSchemaNode original = (ListSchemaNode) ctx.getOriginalCtx().map(StmtContext::buildEffective)
.orElse(null);
possibleLeafQNamesForKey.add(((LeafSchemaNode) effectiveStatement).getQName());
}
}
- for (final SchemaNodeIdentifier key : keyStmt.argument()) {
- final QName keyQName = key.getLastComponent();
-
+ for (final QName keyQName : keyStmt.argument()) {
if (!possibleLeafQNamesForKey.contains(keyQName)) {
- throw new InferenceException(ref, "Key '%s' misses node '%s' in list '%s'",
- keyStmt.getDeclared().rawArgument(), keyQName.getLocalName(), ctx.getStatementArgument());
+ throw new InferenceException(ctx.getStatementSourceReference(),
+ "Key '%s' misses node '%s' in list '%s'", keyStmt.getDeclared().rawArgument(),
+ keyQName.getLocalName(), ctx.getStatementArgument());
}
keyDefinitionInit.add(keyQName);
}
.setUserOrdered(findFirstArgument(substatements, OrderedByEffectiveStatement.class, Ordering.SYSTEM)
.equals(Ordering.USER))
.toFlags();
- if (configuration && keyDefinition.isEmpty() && !inGrouping(ctx)) {
- LOG.info("Configuration list {} does not define any keys in violation of RFC7950 section 7.8.2. While "
- + " this is fine with OpenDaylight, it can cause interoperability issues with other systems "
- + "[at {}]", ctx.getStatementArgument(), ref);
+ if (configuration && keyDefinition.isEmpty() && isInstantied(ctx)) {
+ warnConfigList(ctx);
}
final Optional<ElementCountConstraint> elementCountConstraint =
elementCountConstraint.orElse(null), original);
}
- private static boolean inGrouping(final StmtContext<?, ?, ?> ctx) {
+ private static void warnConfigList(final @NonNull StmtContext<QName, ListStatement, ListEffectiveStatement> ctx) {
+ final StmtContext<QName, ListStatement, ListEffectiveStatement> warnCtx = ctx.getOriginalCtx().orElse(ctx);
+ final Boolean warned = warnCtx.getFromNamespace(ConfigListWarningNamespace.class, Boolean.TRUE);
+ // Hacky check if we have issued a warning for the original statement
+ if (warned == null) {
+ verify(warnCtx instanceof Mutable, "Unexpected context %s", warnCtx);
+ ((Mutable<?, ?, ?>) warnCtx).addToNs(ConfigListWarningNamespace.class, Boolean.TRUE, Boolean.TRUE);
+ LOG.info("Configuration list {} does not define any keys in violation of RFC7950 section 7.8.2. While "
+ + "this is fine with OpenDaylight, it can cause interoperability issues with other systems "
+ + "[defined at {}]", ctx.getStatementArgument(), warnCtx.getStatementSourceReference());
+ }
+ }
+
+ private static boolean isInstantied(final StmtContext<?, ?, ?> ctx) {
StmtContext<?, ?, ?> parent = ctx.getParentContext();
while (parent != null) {
- if (parent.getPublicDefinition() == YangStmtMapping.GROUPING) {
- return true;
+ final StatementDefinition parentDef = parent.getPublicDefinition();
+ if (UNINSTANTIATED_DATATREE_STATEMENTS.contains(parentDef)) {
+ return false;
}
- parent = parent.getParentContext();
+
+ final StmtContext<?, ?, ?> grandParent = parent.getParentContext();
+ if (YangStmtMapping.AUGMENT == parentDef && grandParent != null) {
+ // If this is an augment statement and its parent is either a 'module' or 'submodule' statement, we are
+ // dealing with an uninstantiated context.
+ final StatementDefinition grandParentDef = grandParent.getPublicDefinition();
+ if (YangStmtMapping.MODULE == grandParentDef || YangStmtMapping.SUBMODULE == grandParentDef) {
+ return false;
+ }
+ }
+
+ parent = grandParent;
}
- return false;
+ return true;
}
@Override
Code Review / yangtools.git / blobdiff