X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=inline;f=opendaylight%2Fmd-sal%2Fsal-akka-raft-example%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fexample%2FExampleRoleChangeListener.java;h=d3bf544ef94d60365b1ae6cfb4046b5168110755;hb=12fcdfe39aa26dcba7fd3bb4d4c68e3d02e65c51;hp=29e8a477e87e643a0ef5435402c8b422aa806a39;hpb=22b54aa128163a52eb89743ce8d0d75615f6a04e;p=controller.git
diff --git a/opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java b/opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java
index 29e8a477e8..d3bf544ef9 100644
--- a/opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java
+++ b/opendaylight/md-sal/sal-akka-raft-example/src/main/java/org/opendaylight/controller/cluster/example/ExampleRoleChangeListener.java
@@ -23,31 +23,32 @@ import scala.concurrent.Await;
import scala.concurrent.duration.FiniteDuration;
/**
- * This is a sample implementation of a Role Change Listener which is an actor, which registers itself to the ClusterRoleChangeNotifier
- *
+ * This is a sample implementation of a Role Change Listener which is an actor, which registers itself
+ * to the ClusterRoleChangeNotifier.
+ *
+ *
* The Role Change listener receives a SetNotifiers message with the notifiers to register itself with.
- *
- * It kicks of a scheduler which sents registration messages to the notifiers, till it gets a RegisterRoleChangeListenerReply
- *
+ *
+ *
+ * It kicks of a scheduler which sends registration messages to the notifiers, till it gets a
+ * RegisterRoleChangeListenerReply.
+ *
+ *
* If all the notifiers have been regsitered with, then it cancels the scheduler.
* It starts the scheduler again when it receives a new registration
- *
*/
-public class ExampleRoleChangeListener extends AbstractUntypedActor implements AutoCloseable{
+public class ExampleRoleChangeListener extends AbstractUntypedActor implements AutoCloseable {
// the akka url should be set to the notifiers actor-system and domain.
- private static final String NOTIFIER_AKKA_URL = "akka.tcp://raft-test@127.0.0.1:2550/user/";
+ private static final String NOTIFIER_AKKA_URL = "akka://raft-test@127.0.0.1:2550/user/";
- private Map notifierRegistrationStatus = new HashMap<>();
+ private final Map notifierRegistrationStatus = new HashMap<>();
private Cancellable registrationSchedule = null;
- private static final FiniteDuration duration = new FiniteDuration(100, TimeUnit.MILLISECONDS);
- private static final FiniteDuration schedulerDuration = new FiniteDuration(1, TimeUnit.SECONDS);
- private final String memberName;
- private static final String[] shardsToMonitor = new String[] {"example"};
+ private static final FiniteDuration DURATION = new FiniteDuration(100, TimeUnit.MILLISECONDS);
+ private static final FiniteDuration SCHEDULER_DURATION = new FiniteDuration(1, TimeUnit.SECONDS);
+ private static final String[] SHARDS_TO_MONITOR = new String[] {"example"};
public ExampleRoleChangeListener(String memberName) {
- super();
- scheduleRegistrationListener(schedulerDuration);
- this.memberName = memberName;
+ scheduleRegistrationListener(SCHEDULER_DURATION);
populateRegistry(memberName);
}
@@ -56,7 +57,7 @@ public class ExampleRoleChangeListener extends AbstractUntypedActor implements A
}
@Override
- protected void handleReceive(Object message) throws Exception {
+ protected void handleReceive(Object message) {
if (message instanceof RegisterListener) {
// called by the scheduler at intervals to register any unregistered notifiers
sendRegistrationRequests();
@@ -87,28 +88,26 @@ public class ExampleRoleChangeListener extends AbstractUntypedActor implements A
}
private void populateRegistry(String memberName) {
-
- for (String shard: shardsToMonitor) {
- String notifier =(new StringBuilder()).append(NOTIFIER_AKKA_URL).append(memberName)
+ String notifier = new StringBuilder().append(NOTIFIER_AKKA_URL).append(memberName)
.append("/").append(memberName).append("-notifier").toString();
- if (!notifierRegistrationStatus.containsKey(notifier)) {
- notifierRegistrationStatus.put(notifier, false);
- }
+ if (!notifierRegistrationStatus.containsKey(notifier)) {
+ notifierRegistrationStatus.put(notifier, false);
}
if (!registrationSchedule.isCancelled()) {
- scheduleRegistrationListener(schedulerDuration);
+ scheduleRegistrationListener(SCHEDULER_DURATION);
}
}
+ @SuppressWarnings("checkstyle:IllegalCatch")
private void sendRegistrationRequests() {
for (Map.Entry entry : notifierRegistrationStatus.entrySet()) {
if (!entry.getValue()) {
try {
LOG.debug("{} registering with {}", getSelf().path().toString(), entry.getKey());
ActorRef notifier = Await.result(
- getContext().actorSelection(entry.getKey()).resolveOne(duration), duration);
+ getContext().actorSelection(entry.getKey()).resolveOne(DURATION), DURATION);
notifier.tell(new RegisterRoleChangeListener(), getSelf());
@@ -134,14 +133,15 @@ public class ExampleRoleChangeListener extends AbstractUntypedActor implements A
}
}
} else {
- LOG.info("Unexpected, RegisterRoleChangeListenerReply received from notifier which is not known to Listener:{}",
+ LOG.info(
+ "Unexpected, RegisterRoleChangeListenerReply received from notifier which is not known to Listener:{}",
senderId);
}
}
@Override
- public void close() throws Exception {
+ public void close() {
registrationSchedule.cancel();
}
}