X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=dom%2Fmdsal-dom-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fmdsal%2Fdom%2Fspi%2FDefaultDOMRpcResult.java;h=0f16df01fb5d8417c51c75be744fc934d6fa631e;hb=5efad8eb9dec08e7a0eb00e105385c81598863c2;hp=eb2c8ee8cb19088359a7f344dab333763ce2d376;hpb=1372ec96f3406ef72b8f5e09936ee35aa4cfa78e;p=mdsal.git diff --git a/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/DefaultDOMRpcResult.java b/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/DefaultDOMRpcResult.java index eb2c8ee8cb..0f16df01fb 100644 --- a/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/DefaultDOMRpcResult.java +++ b/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/DefaultDOMRpcResult.java @@ -10,12 +10,12 @@ package org.opendaylight.mdsal.dom.spi; import static java.util.Objects.requireNonNull; import com.google.common.annotations.Beta; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.io.Serializable; import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.Objects; -import javax.annotation.Nonnull; import org.eclipse.jdt.annotation.NonNullByDefault; import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.mdsal.dom.api.DOMRpcResult; @@ -30,10 +30,12 @@ import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; @NonNullByDefault public final class DefaultDOMRpcResult implements DOMRpcResult, Immutable, Serializable { private static final long serialVersionUID = 1L; - private final @Nullable NormalizedNode result; - private final Collection errors; - public DefaultDOMRpcResult(final NormalizedNode result, final RpcError... errors) { + @SuppressFBWarnings(value = "SE_BAD_FIELD", justification = "Interfaces do not specify Serializable") + private final @Nullable NormalizedNode result; + private final Collection errors; + + public DefaultDOMRpcResult(final NormalizedNode result, final RpcError... errors) { this(result, asCollection(errors)); } @@ -41,16 +43,17 @@ public final class DefaultDOMRpcResult implements DOMRpcResult, Immutable, Seria this(null, asCollection(errors)); } - public DefaultDOMRpcResult(final @Nullable NormalizedNode result) { + public DefaultDOMRpcResult(final @Nullable NormalizedNode result) { this(result, Collections.emptyList()); } - public DefaultDOMRpcResult(final @Nullable NormalizedNode result, final Collection errors) { + public DefaultDOMRpcResult(final @Nullable NormalizedNode result, + final Collection errors) { this.result = result; this.errors = requireNonNull(errors); } - public DefaultDOMRpcResult(@Nonnull final Collection errors) { + public DefaultDOMRpcResult(final Collection errors) { this(null, errors); } @@ -59,12 +62,12 @@ public final class DefaultDOMRpcResult implements DOMRpcResult, Immutable, Seria } @Override - public Collection getErrors() { + public Collection getErrors() { return errors; } @Override - public @Nullable NormalizedNode getResult() { + public @Nullable NormalizedNode getResult() { return result; }