X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=jjb%2Fpackaging%2Ftest-deb-deps.sh;h=720c1b31fc9cbc0466a4152e7ea64d43f184e89f;hb=ce618a81e648001a2ecf6b67f06407e76ea82786;hp=a2c927e9b3cb0d482cf43eb78deaa1121cccd042;hpb=63035eb4ad86763da323c5c9f43cd6a607709366;p=releng%2Fbuilder.git

diff --git a/jjb/packaging/test-deb-deps.sh b/jjb/packaging/test-deb-deps.sh
index a2c927e9b..720c1b31f 100644
--- a/jjb/packaging/test-deb-deps.sh
+++ b/jjb/packaging/test-deb-deps.sh
@@ -16,7 +16,7 @@
 set -ex -o pipefail
 
 # Verify exactly 1 deb is in the path we expect
-set -- $WORKSPACE/packaging/packages/deb/opendaylight/*.deb
+set -- "$WORKSPACE"/packaging/packages/deb/opendaylight/*.deb
 if [ $# -eq 1 ]; then
     echo "Found one deb in build out dir, as expected"
 else
@@ -25,10 +25,10 @@ else
 fi
 
 # If path is globbed (/path/to/*.deb), expand it
-path=$(sudo find / -wholename $WORKSPACE/packaging/packages/deb/opendaylight/*.deb)
+path=$(sudo find / -wholename "$WORKSPACE"/packaging/packages/deb/opendaylight/*.deb)
 
 # If no deb found, fail clearly
-if [ -z $path ]; then
+if [ -z "$path" ]; then
     echo "deb not found"
     exit 1
 fi
@@ -43,12 +43,12 @@ if [ -f /usr/bin/dpkg ]; then
 fi
 
 # shellcheck disable=SC2034
-mapfile -t actual_deps < <( dpkg -I $WORKSPACE/packaging/packages/deb/opendaylight/*.deb | grep Depends | sed 's/Depends: //g' | sed 's/,/\n/g' )
+mapfile -t actual_deps < <( dpkg -I "$WORKSPACE"/packaging/packages/deb/opendaylight/*.deb | grep Depends | sed 's/Depends: //g' | sed 's/,/\n/g' )
 # shellcheck disable=SC2154 disable=SC2145
 printf 'Dependency found: %s\n' "${actual_deps[@]}"
 
 # shellcheck disable=SC2154,SC2145,SC2034,SC2207
-diff_deps=(`echo "${expected_deps[@]}" "${actual_deps[@]}" | tr ' ' '\n' | sort | uniq -u`)
+diff_deps=($(echo "${expected_deps[@]}" "${actual_deps[@]}" | tr ' ' '\n' | sort | uniq -u))
 
 # shellcheck disable=SC2154 disable=SC2145 disable=SC2068 disable=SC2170 disable=SC1083
 if [ ${#diff_deps[*]} -eq 0 ]; then