X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=netconf%2Fsal-netconf-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fnetconf%2Fsal%2Fconnect%2Fnetconf%2FNetconfStateSchemas.java;fp=netconf%2Fsal-netconf-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fnetconf%2Fsal%2Fconnect%2Fnetconf%2FNetconfStateSchemas.java;h=55c23426ff41604885e2c8d3ff982ec54cb90e6a;hb=b8f5ebd2f817de1d613d84cf41f3516728767eba;hp=bec05994ef3e8beda133821dcfa7a6b2b22e133e;hpb=32198feec954f869a760c69bf5a4ccf6f116c7bd;p=netconf.git diff --git a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/NetconfStateSchemas.java b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/NetconfStateSchemas.java index bec05994ef..55c23426ff 100644 --- a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/NetconfStateSchemas.java +++ b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/NetconfStateSchemas.java @@ -9,6 +9,7 @@ package org.opendaylight.netconf.sal.connect.netconf; import static com.google.common.base.Preconditions.checkArgument; import static com.google.common.base.Preconditions.checkState; +import static com.google.common.base.Verify.verify; import static org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTransformUtil.NETCONF_DATA_NODEID; import static org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTransformUtil.NETCONF_GET_NODEID; import static org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTransformUtil.NETCONF_GET_PATH; @@ -17,11 +18,15 @@ import static org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTr import com.google.common.annotations.VisibleForTesting; import com.google.common.base.Strings; import com.google.common.collect.ImmutableSet; +import java.io.IOException; import java.net.URI; +import java.net.URISyntaxException; import java.util.HashSet; import java.util.Optional; import java.util.Set; import java.util.concurrent.ExecutionException; +import javax.xml.parsers.ParserConfigurationException; +import javax.xml.stream.XMLStreamException; import org.opendaylight.mdsal.dom.api.DOMRpcResult; import org.opendaylight.mdsal.dom.api.DOMRpcService; import org.opendaylight.netconf.sal.connect.api.NetconfDeviceSchemas; @@ -29,12 +34,14 @@ import org.opendaylight.netconf.sal.connect.netconf.listener.NetconfSessionPrefe import org.opendaylight.netconf.sal.connect.netconf.schema.mapping.BaseSchema; import org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTransformUtil; import org.opendaylight.netconf.sal.connect.util.RemoteDeviceId; +import org.opendaylight.netconf.util.NetconfUtil; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.monitoring.rev101004.NetconfState; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.monitoring.rev101004.Yang; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.monitoring.rev101004.netconf.state.Schemas; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.monitoring.rev101004.netconf.state.schemas.Schema; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; +import org.opendaylight.yangtools.yang.data.api.schema.AnyXmlNode; import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode; import org.opendaylight.yangtools.yang.data.api.schema.DataContainerChild; import org.opendaylight.yangtools.yang.data.api.schema.DataContainerNode; @@ -44,8 +51,10 @@ import org.opendaylight.yangtools.yang.data.api.schema.MapEntryNode; import org.opendaylight.yangtools.yang.data.api.schema.MapNode; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.data.impl.schema.Builders; +import org.opendaylight.yangtools.yang.model.api.SchemaContext; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import org.xml.sax.SAXException; /** * Holds QNames for all yang modules reported by ietf-netconf-monitoring/state/schemas. @@ -88,7 +97,8 @@ public final class NetconfStateSchemas implements NetconfDeviceSchemas { * Issue get request to remote device and parse response to find all schemas under netconf-state/schemas. */ static NetconfStateSchemas create(final DOMRpcService deviceRpc, - final NetconfSessionPreferences remoteSessionCapabilities, final RemoteDeviceId id) { + final NetconfSessionPreferences remoteSessionCapabilities, final RemoteDeviceId id, + final SchemaContext schemaContext) { if (!remoteSessionCapabilities.isMonitoringSupported()) { // TODO - need to search for get-schema support, not just ietf-netconf-monitoring support // issue might be a deviation to ietf-netconf-monitoring where get-schema is unsupported... @@ -114,7 +124,8 @@ public final class NetconfStateSchemas implements NetconfDeviceSchemas { return EMPTY; } - final Optional> optSchemasNode = findSchemasNode(schemasNodeResult.getResult()); + final Optional> optSchemasNode = findSchemasNode(schemasNodeResult.getResult(), + schemaContext); if (!optSchemasNode.isPresent()) { LOG.warn("{}: Unable to detect available schemas, get to {} was empty", id, STATE_SCHEMAS_IDENTIFIER); return EMPTY; @@ -152,18 +163,31 @@ public final class NetconfStateSchemas implements NetconfDeviceSchemas { return new NetconfStateSchemas(availableYangSchemas); } - private static Optional> findSchemasNode(final NormalizedNode result) { + private static Optional> findSchemasNode(final NormalizedNode result, + final SchemaContext schemaContext) { if (result == null) { return Optional.empty(); } - final Optional> dataNode = ((DataContainerNode) result) - .getChild(NETCONF_DATA_NODEID); - if (!dataNode.isPresent()) { + final Optional> rpcResultOpt = ((ContainerNode)result).getChild(NETCONF_DATA_NODEID); + if (!rpcResultOpt.isPresent()) { return Optional.empty(); } - final Optional> nStateNode = - ((DataContainerNode) dataNode.get()).getChild(toId(NetconfState.QNAME)); + final DataContainerChild rpcResult = rpcResultOpt.get(); + verify(rpcResult instanceof AnyXmlNode, "Unexpected result %s", rpcResult); + final NormalizedNode dataNode; + + try { + dataNode = NetconfUtil.transformDOMSourceToNormalizedNode(schemaContext, + ((AnyXmlNode) rpcResult).getValue()).getResult(); + } catch (XMLStreamException | URISyntaxException | IOException | SAXException + | ParserConfigurationException e) { + LOG.warn("Failed to transform {}", rpcResult, e); + return Optional.empty(); + } + + final Optional> nStateNode = ((DataContainerNode) dataNode).getChild( + toId(NetconfState.QNAME)); if (!nStateNode.isPresent()) { return Optional.empty(); }