X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=opendaylight%2Fforwardingrulesmanager%2Fapi%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fforwardingrulesmanager%2FfrmTest.java;h=a3e1ded14178ff8d00a3efe21d02ea798fa19af2;hb=74c92401812b8e77e8ceade6e8714d0fc1c35d3a;hp=fc22ee7dddaef5752bd03647e2e4830c0f77205d;hpb=b9a5497edea08e3b91846d9a371d7e9aeddf5055;p=controller.git diff --git a/opendaylight/forwardingrulesmanager/api/src/test/java/org/opendaylight/controller/forwardingrulesmanager/frmTest.java b/opendaylight/forwardingrulesmanager/api/src/test/java/org/opendaylight/controller/forwardingrulesmanager/frmTest.java index fc22ee7ddd..a3e1ded141 100644 --- a/opendaylight/forwardingrulesmanager/api/src/test/java/org/opendaylight/controller/forwardingrulesmanager/frmTest.java +++ b/opendaylight/forwardingrulesmanager/api/src/test/java/org/opendaylight/controller/forwardingrulesmanager/frmTest.java @@ -19,8 +19,6 @@ import java.util.concurrent.ConcurrentMap; import org.junit.Assert; import org.junit.Test; -import org.opendaylight.controller.forwardingrulesmanager.FlowConfig; -import org.opendaylight.controller.forwardingrulesmanager.FlowEntry; import org.opendaylight.controller.sal.action.Action; import org.opendaylight.controller.sal.action.ActionType; import org.opendaylight.controller.sal.action.Controller; @@ -523,6 +521,12 @@ public class frmTest { Assert.assertTrue(status.getDescription().contains("Node is null")); fc.setNode(Node.fromString(Node.NodeIDType.OPENFLOW, "1")); + Assert.assertFalse(fc.validate(null).isSuccess()); + List actions = new ArrayList(); + fc.setActions(actions); + Assert.assertFalse(fc.validate(null).isSuccess()); + actions.add("OUTPUT=2"); + fc.setActions(actions); Assert.assertTrue(fc.validate(null).isSuccess()); fc.setPriority("-1"); @@ -611,9 +615,15 @@ public class frmTest { Assert.assertFalse(status.isSuccess()); Assert.assertTrue(status.getDescription().contains("Transport source port")); + fc.setSrcPort("0"); + Assert.assertTrue(fc.validate(null).isSuccess()); + fc.setSrcPort("0x00ff"); Assert.assertTrue(fc.validate(null).isSuccess()); + fc.setSrcPort("0xffff"); + Assert.assertTrue(fc.validate(null).isSuccess()); + fc.setDstPort("-1"); status = fc.validate(null); Assert.assertFalse(status.isSuccess()); @@ -624,9 +634,15 @@ public class frmTest { Assert.assertFalse(status.isSuccess()); Assert.assertTrue(status.getDescription().contains("Transport destination port")); + fc.setDstPort("0"); + Assert.assertTrue(fc.validate(null).isSuccess()); + fc.setDstPort("0x00ff"); Assert.assertTrue(fc.validate(null).isSuccess()); + fc.setDstPort("0xffff"); + Assert.assertTrue(fc.validate(null).isSuccess()); + fc.setSrcMac("abc"); status = fc.validate(null); Assert.assertFalse(status.isSuccess());