*/
public class TestActorFactory implements AutoCloseable {
+ private static final Logger LOG = LoggerFactory.getLogger(TestActorFactory.class);
+
private final ActorSystem system;
List createdActors = new LinkedList<>();
- Logger LOG = LoggerFactory.getLogger(getClass());
private static int actorCount = 1;
- public TestActorFactory(ActorSystem system){
+ public TestActorFactory(ActorSystem system) {
this.system = system;
}
/**
- * Create a normal actor with an auto-generated name
+ * Create a normal actor with an auto-generated name.
*
- * @param props
- * @return
+ * @param props the actor Props
+ * @return the ActorRef
*/
- public ActorRef createActor(Props props){
+ public ActorRef createActor(Props props) {
ActorRef actorRef = system.actorOf(props);
- createdActors.add(actorRef);
- return actorRef;
+ return addActor(actorRef, true);
}
/**
- * Create a normal actor with the passed in name
- * @param props
+ * Create a normal actor with the passed in name.
+ *
+ * @param props the actor Props
* @param actorId name of actor
- * @return
+ * @return the ActorRef
*/
- public ActorRef createActor(Props props, String actorId){
+ public ActorRef createActor(Props props, String actorId) {
ActorRef actorRef = system.actorOf(props, actorId);
- createdActors.add(actorRef);
- return actorRef;
+ return addActor(actorRef, true);
}
/**
- * Create a test actor with the passed in name
- * @param props
- * @param actorId
- * @param
- * @return
+ * Create a normal actor with the passed in name w/o verifying that the actor is ready.
+ *
+ * @param props the actor Props
+ * @param actorId name of actor
+ * @return the ActorRef
*/
- public TestActorRef createTestActor(Props props, String actorId){
- TestActorRef actorRef = TestActorRef.create(system, props, actorId);
- createdActors.add(actorRef);
- return actorRef;
+ public ActorRef createActorNoVerify(Props props, String actorId) {
+ ActorRef actorRef = system.actorOf(props, actorId);
+ return addActor(actorRef, false);
}
/**
- * Create a test actor with an auto-generated name
- * @param props
- * @param
- * @return
+ * Create a test actor with the passed in name.
+ *
+ * @param props the actor Props
+ * @param actorId name of actor
+ * @param the actor type
+ * @return the ActorRef
*/
- public TestActorRef createTestActor(Props props){
+ @SuppressWarnings("unchecked")
+ public TestActorRef createTestActor(Props props, String actorId) {
+ InvalidActorNameException lastError = null;
+ for (int i = 0; i < 10; i++) {
+ try {
+ TestActorRef actorRef = TestActorRef.create(system, props, actorId);
+ return (TestActorRef) addActor(actorRef, true);
+ } catch (InvalidActorNameException e) {
+ lastError = e;
+ Uninterruptibles.sleepUninterruptibly(100, TimeUnit.MILLISECONDS);
+ }
+ }
+
+ throw lastError;
+ }
+
+ /**
+ * Create a test actor with an auto-generated name.
+ *
+ * @param props the actor Props
+ * @param the actor type
+ * @return the TestActorRef
+ */
+ @SuppressWarnings("unchecked")
+ public TestActorRef createTestActor(Props props) {
TestActorRef actorRef = TestActorRef.create(system, props);
+ return (TestActorRef) addActor(actorRef, true);
+ }
+
+ private ActorRef addActor(T actorRef, boolean verify) {
createdActors.add(actorRef);
+ if (verify) {
+ verifyActorReady(actorRef);
+ }
+
return actorRef;
}
+ @SuppressWarnings("checkstyle:IllegalCatch")
+ private void verifyActorReady(ActorRef actorRef) {
+ // Sometimes we see messages go to dead letters soon after creation - it seems the actor isn't quite
+ // in a state yet to receive messages or isn't actually created yet. This seems to happen with
+ // actorSelection so, to alleviate it, we use an actorSelection and send an Identify message with
+ // retries to ensure it's ready.
+
+ Timeout timeout = new Timeout(100, TimeUnit.MILLISECONDS);
+ Throwable lastError = null;
+ Stopwatch sw = Stopwatch.createStarted();
+ while (sw.elapsed(TimeUnit.SECONDS) <= 10) {
+ try {
+ ActorSelection actorSelection = system.actorSelection(actorRef.path().toString());
+ Future