X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FLocalTransactionContext.java;h=6b3006941817e05e4a7de6789e67871dda506846;hb=1d5ca4009be6c61d7b61989799037ad8f1ab7a75;hp=dd7c9194fde2cdd95b7f72be041c977ac7ad9739;hpb=95538aa1baf80a90f03e4ae6d8268c9db34b3bfa;p=controller.git

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java
index dd7c9194fd..6b30069418 100644
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/LocalTransactionContext.java
@@ -7,14 +7,22 @@
  */
 package org.opendaylight.controller.cluster.datastore;
 
+import static java.util.Objects.requireNonNull;
+
 import akka.actor.ActorSelection;
-import com.google.common.base.Optional;
-import com.google.common.base.Preconditions;
 import com.google.common.util.concurrent.FutureCallback;
 import com.google.common.util.concurrent.Futures;
+import com.google.common.util.concurrent.MoreExecutors;
 import com.google.common.util.concurrent.SettableFuture;
-import org.opendaylight.controller.cluster.datastore.identifiers.TransactionIdentifier;
-import org.opendaylight.controller.sal.core.spi.data.DOMStoreReadWriteTransaction;
+import java.util.Optional;
+import java.util.SortedSet;
+import java.util.function.Consumer;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+import org.opendaylight.controller.cluster.datastore.messages.AbstractRead;
+import org.opendaylight.mdsal.common.api.ReadFailedException;
+import org.opendaylight.mdsal.dom.spi.store.DOMStoreReadTransaction;
+import org.opendaylight.mdsal.dom.spi.store.DOMStoreTransaction;
+import org.opendaylight.mdsal.dom.spi.store.DOMStoreWriteTransaction;
 import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
 import scala.concurrent.Future;
@@ -25,92 +33,86 @@ import scala.concurrent.Future;
  *
  * @author Thomas Pantelis
  */
-final class LocalTransactionContext extends AbstractTransactionContext {
-    private final DOMStoreReadWriteTransaction delegate;
-    private final OperationCompleter completer;
+abstract class LocalTransactionContext extends TransactionContext {
+    private final DOMStoreTransaction txDelegate;
+    private final LocalTransactionReadySupport readySupport;
+    private Exception operationError;
 
-    LocalTransactionContext(TransactionIdentifier identifier, DOMStoreReadWriteTransaction delegate, OperationCompleter completer) {
+    LocalTransactionContext(final DOMStoreTransaction txDelegate, final TransactionIdentifier identifier,
+            final LocalTransactionReadySupport readySupport) {
         super(identifier);
-        this.delegate = Preconditions.checkNotNull(delegate);
-        this.completer = Preconditions.checkNotNull(completer);
+        this.txDelegate = requireNonNull(txDelegate);
+        this.readySupport = readySupport;
     }
 
-    @Override
-    public void writeData(final YangInstanceIdentifier path, final NormalizedNode<?, ?> data) {
-        delegate.write(path, data);
-        completer.onComplete(null, null);
+    abstract DOMStoreWriteTransaction getWriteDelegate();
+
+    abstract DOMStoreReadTransaction getReadDelegate();
+
+    @SuppressWarnings("checkstyle:IllegalCatch")
+    private void executeModification(final Consumer<DOMStoreWriteTransaction> consumer) {
+        incrementModificationCount();
+        if (operationError == null) {
+            try {
+                consumer.accept(getWriteDelegate());
+            } catch (Exception e) {
+                operationError = e;
+            }
+        }
     }
 
     @Override
-    public void mergeData(final YangInstanceIdentifier path, final NormalizedNode<?, ?> data) {
-        delegate.merge(path, data);
-        completer.onComplete(null, null);
+    void executeDelete(final YangInstanceIdentifier path, final Boolean havePermit) {
+        executeModification(transaction -> transaction.delete(path));
     }
 
     @Override
-    public void deleteData(final YangInstanceIdentifier path) {
-        delegate.delete(path);
-        completer.onComplete(null, null);
+    void executeMerge(final YangInstanceIdentifier path, final NormalizedNode data, final Boolean havePermit) {
+        executeModification(transaction -> transaction.merge(path, data));
     }
 
     @Override
-    public void readData(final YangInstanceIdentifier path, final SettableFuture<Optional<NormalizedNode<?, ?>>> proxyFuture) {
-
-        Futures.addCallback(delegate.read(path), new FutureCallback<Optional<NormalizedNode<?, ?>>>() {
-            @Override
-            public void onSuccess(Optional<NormalizedNode<?, ?>> result) {
-                proxyFuture.set(result);
-                completer.onComplete(null, null);
-            }
-
-            @Override
-            public void onFailure(Throwable t) {
-                proxyFuture.setException(t);
-                completer.onComplete(null, null);
-            }
-        });
+    void executeWrite(final YangInstanceIdentifier path, final NormalizedNode data, final Boolean havePermit) {
+        executeModification(transaction -> transaction.write(path, data));
     }
 
     @Override
-    public void dataExists(final YangInstanceIdentifier path, final SettableFuture<Boolean> proxyFuture) {
-        Futures.addCallback(delegate.exists(path), new FutureCallback<Boolean>() {
+    <T> void executeRead(final AbstractRead<T> readCmd, final SettableFuture<T> proxyFuture,
+            final Boolean havePermit) {
+        Futures.addCallback(readCmd.apply(getReadDelegate()), new FutureCallback<T>() {
             @Override
-            public void onSuccess(Boolean result) {
+            public void onSuccess(final T result) {
                 proxyFuture.set(result);
-                completer.onComplete(null, null);
             }
 
             @Override
-            public void onFailure(Throwable t) {
-                proxyFuture.setException(t);
-                completer.onComplete(null, null);
+            public void onFailure(final Throwable failure) {
+                proxyFuture.setException(failure instanceof Exception
+                        ? ReadFailedException.MAPPER.apply((Exception) failure) : failure);
             }
-        });
-    }
-
-    private LocalThreePhaseCommitCohort ready() {
-        LocalThreePhaseCommitCohort ready = (LocalThreePhaseCommitCohort) delegate.ready();
-        completer.onComplete(null, null);
-        return ready;
+        }, MoreExecutors.directExecutor());
     }
 
     @Override
-    public Future<ActorSelection> readyTransaction() {
-        return ready().initiateCoordinatedCommit();
+    Future<ActorSelection> readyTransaction(final Boolean havePermit,
+            final Optional<SortedSet<String>> participatingShardNames) {
+        final LocalThreePhaseCommitCohort cohort = ready();
+        return cohort.initiateCoordinatedCommit(participatingShardNames);
     }
 
     @Override
-    public Future<Object> directCommit() {
-        return ready().initiateDirectCommit();
+    Future<Object> directCommit(final Boolean havePermit) {
+        final LocalThreePhaseCommitCohort cohort = ready();
+        return cohort.initiateDirectCommit();
     }
 
     @Override
-    public boolean supportsDirectCommit() {
-        return true;
+    void closeTransaction() {
+        txDelegate.close();
     }
 
-    @Override
-    public void closeTransaction() {
-        delegate.close();
+    private LocalThreePhaseCommitCohort ready() {
+        logModificationCount();
+        return readySupport.onTransactionReady(getWriteDelegate(), operationError);
     }
 }