X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2Fshardstrategy%2FShardStrategyFactory.java;h=5891c4f7616af75ffc93556aa4f7e8cdf1d9d7d1;hb=abaef4a5ae37f27542155457fe7306a4662b1eeb;hp=fd786c903e87e4bc44136bf629977316250f79a3;hpb=4ed6793fcad89fcb4a3c0f7ec230753cb7ed31a9;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategyFactory.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategyFactory.java index fd786c903e..5891c4f761 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategyFactory.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/shardstrategy/ShardStrategyFactory.java @@ -5,54 +5,61 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.controller.cluster.datastore.shardstrategy; -import com.google.common.base.Optional; -import com.google.common.base.Preconditions; -import java.util.Map; -import java.util.concurrent.ConcurrentHashMap; -import org.opendaylight.controller.cluster.datastore.Configuration; +import static com.google.common.base.Preconditions.checkState; +import static java.util.Objects.requireNonNull; + +import org.opendaylight.controller.cluster.datastore.config.Configuration; +import org.opendaylight.mdsal.common.api.LogicalDatastoreType; +import org.opendaylight.mdsal.dom.api.DOMDataTreeIdentifier; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; public class ShardStrategyFactory { - private static Map moduleNameToStrategyMap = - new ConcurrentHashMap<>(); - private static final String UNKNOWN_MODULE_NAME = "unknown"; - private static Configuration configuration; + private final Configuration configuration; + private final LogicalDatastoreType logicalStoreType; - public static void setConfiguration(final Configuration configuration){ - ShardStrategyFactory.configuration = configuration; - moduleNameToStrategyMap = configuration.getModuleNameToShardStrategyMap(); + public ShardStrategyFactory(final Configuration configuration, final LogicalDatastoreType logicalStoreType) { + checkState(configuration != null, "configuration should not be missing"); + this.configuration = configuration; + this.logicalStoreType = requireNonNull(logicalStoreType); } - public static ShardStrategy getStrategy(final YangInstanceIdentifier path) { - Preconditions.checkState(configuration != null, "configuration should not be missing"); - Preconditions.checkNotNull(path, "path should not be null"); - - - String moduleName = getModuleName(path); - ShardStrategy shardStrategy = moduleNameToStrategyMap.get(moduleName); + public ShardStrategy getStrategy(final YangInstanceIdentifier path) { + // try with the legacy module based shard mapping + final String moduleName = getModuleName(requireNonNull(path, "path should not be null")); + final ShardStrategy shardStrategy = configuration.getStrategyForModule(moduleName); if (shardStrategy == null) { - return DefaultShardStrategy.getInstance(); + // retry with prefix based sharding + final ShardStrategy strategyForPrefix = + configuration.getStrategyForPrefix(new DOMDataTreeIdentifier(logicalStoreType, path)); + if (strategyForPrefix == null) { + return DefaultShardStrategy.getInstance(); + } + return strategyForPrefix; } return shardStrategy; } + public static ShardStrategy newShardStrategyInstance(final String moduleName, final String strategyName, + final Configuration configuration) { + if (ModuleShardStrategy.NAME.equals(strategyName)) { + return new ModuleShardStrategy(moduleName, configuration); + } - private static String getModuleName(final YangInstanceIdentifier path) { - String namespace = path.getPathArguments().iterator().next().getNodeType().getNamespace().toASCIIString(); - - Optional optional = - configuration.getModuleNameFromNameSpace(namespace); + return DefaultShardStrategy.getInstance(); + } - if(!optional.isPresent()){ + private String getModuleName(final YangInstanceIdentifier path) { + if (path.isEmpty()) { return UNKNOWN_MODULE_NAME; } - return optional.get(); + String namespace = path.getPathArguments().get(0).getNodeType().getNamespace().toString(); + String moduleName = configuration.getModuleNameFromNameSpace(namespace); + return moduleName != null ? moduleName : UNKNOWN_MODULE_NAME; } }