X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=opendaylight%2Fmd-sal%2Fsal-distributed-datastore%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fcluster%2Fdatastore%2FThreePhaseCommitCohortProxyTest.java;h=87231f08849ed02398472bb792a40a48753a96be;hb=9228eee6e438894b091f7bee8a4ba7b53286ef8f;hp=8ff785c8797eecb166c0381ab3e7a92980fa8396;hpb=44c747db358bf0d49434d5f818121286b5928d4a;p=controller.git diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxyTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxyTest.java index 8ff785c879..87231f0884 100644 --- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxyTest.java +++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/ThreePhaseCommitCohortProxyTest.java @@ -1,85 +1,245 @@ package org.opendaylight.controller.cluster.datastore; -import akka.actor.ActorRef; +import akka.actor.ActorPath; +import akka.actor.ActorSelection; import akka.actor.Props; +import akka.dispatch.Futures; + +import com.google.common.collect.Lists; import com.google.common.util.concurrent.ListenableFuture; -import junit.framework.Assert; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.mockito.Mockito.doReturn; +import static org.mockito.Mockito.any; +import static org.mockito.Mockito.isA; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.times; + import org.junit.Before; import org.junit.Test; +import org.mockito.Mock; +import org.mockito.MockitoAnnotations; +import org.mockito.stubbing.Stubber; +import org.opendaylight.controller.cluster.datastore.messages.AbortTransaction; import org.opendaylight.controller.cluster.datastore.messages.AbortTransactionReply; +import org.opendaylight.controller.cluster.datastore.messages.CanCommitTransaction; import org.opendaylight.controller.cluster.datastore.messages.CanCommitTransactionReply; +import org.opendaylight.controller.cluster.datastore.messages.CommitTransaction; import org.opendaylight.controller.cluster.datastore.messages.CommitTransactionReply; +import org.opendaylight.controller.cluster.datastore.messages.PreCommitTransaction; import org.opendaylight.controller.cluster.datastore.messages.PreCommitTransactionReply; +import org.opendaylight.controller.cluster.datastore.messages.SerializableMessage; +import org.opendaylight.controller.cluster.datastore.utils.ActorContext; import org.opendaylight.controller.cluster.datastore.utils.MessageCollectorActor; -import org.opendaylight.controller.cluster.datastore.utils.MockActorContext; +import scala.concurrent.duration.FiniteDuration; -import java.util.Arrays; -import java.util.concurrent.ExecutorService; -import java.util.concurrent.Executors; - -import static org.junit.Assert.assertNotNull; +import java.util.List; +import java.util.concurrent.ExecutionException; public class ThreePhaseCommitCohortProxyTest extends AbstractActorTest { - private ThreePhaseCommitCohortProxy proxy; - private Props props; - private ActorRef actorRef; - private MockActorContext actorContext; - private ExecutorService executor = Executors.newSingleThreadExecutor(); + @Mock + private ActorContext actorContext; @Before - public void setUp(){ - props = Props.create(MessageCollectorActor.class); - actorRef = getSystem().actorOf(props); - actorContext = new MockActorContext(this.getSystem()); + public void setUp() { + MockitoAnnotations.initMocks(this); + + doReturn(getSystem()).when(actorContext).getActorSystem(); + } + + private ThreePhaseCommitCohortProxy setupProxy(int nCohorts) { + List cohorts = Lists.newArrayList(); + for(int i = 1; i <= nCohorts; i++) { + ActorPath path = getSystem().actorOf(Props.create(MessageCollectorActor.class)).path(); + cohorts.add(path); + doReturn(mock(ActorSelection.class)).when(actorContext).actorSelection(path); + } + + return new ThreePhaseCommitCohortProxy(actorContext, cohorts, "txn-1"); + } + + private void setupMockActorContext(Class requestType, Object... responses) { + Stubber stubber = doReturn(responses[0] instanceof Throwable ? Futures + .failed((Throwable) responses[0]) : Futures + .successful(((SerializableMessage) responses[0]).toSerializable())); - proxy = - new ThreePhaseCommitCohortProxy(actorContext, - Arrays.asList(actorRef.path()), "txn-1", executor); + for(int i = 1; i < responses.length; i++) { + stubber = stubber.doReturn(responses[i] instanceof Throwable ? Futures + .failed((Throwable) responses[i]) : Futures + .successful(((SerializableMessage) responses[i]).toSerializable())); + } + stubber.when(actorContext).executeRemoteOperationAsync(any(ActorSelection.class), + isA(requestType), any(FiniteDuration.class)); + } + + private void verifyCohortInvocations(int nCohorts, Class requestType) { + verify(actorContext, times(nCohorts)).executeRemoteOperationAsync( + any(ActorSelection.class), isA(requestType), any(FiniteDuration.class)); } @Test - public void testCanCommit() throws Exception { - actorContext.setExecuteRemoteOperationResponse(new CanCommitTransactionReply(true)); + public void testCanCommitWithOneCohort() throws Exception { + + ThreePhaseCommitCohortProxy proxy = setupProxy(1); + + setupMockActorContext(CanCommitTransaction.SERIALIZABLE_CLASS, + new CanCommitTransactionReply(true)); + + ListenableFuture future = proxy.canCommit(); + + assertEquals("canCommit", true, future.get()); + + setupMockActorContext(CanCommitTransaction.SERIALIZABLE_CLASS, + new CanCommitTransactionReply(false)); + + future = proxy.canCommit(); + + assertEquals("canCommit", false, future.get()); + + verifyCohortInvocations(2, CanCommitTransaction.SERIALIZABLE_CLASS); + } + + @Test + public void testCanCommitWithMultipleCohorts() throws Exception { + + ThreePhaseCommitCohortProxy proxy = setupProxy(2); + + setupMockActorContext(CanCommitTransaction.SERIALIZABLE_CLASS, + new CanCommitTransactionReply(true), new CanCommitTransactionReply(true)); + + ListenableFuture future = proxy.canCommit(); + + assertEquals("canCommit", true, future.get()); + + verifyCohortInvocations(2, CanCommitTransaction.SERIALIZABLE_CLASS); + } + + @Test + public void testCanCommitWithMultipleCohortsAndOneFailure() throws Exception { + + ThreePhaseCommitCohortProxy proxy = setupProxy(3); + + setupMockActorContext(CanCommitTransaction.SERIALIZABLE_CLASS, + new CanCommitTransactionReply(true), new CanCommitTransactionReply(false), + new CanCommitTransactionReply(true)); ListenableFuture future = proxy.canCommit(); - Assert.assertTrue(future.get().booleanValue()); + assertEquals("canCommit", false, future.get()); + + verifyCohortInvocations(3, CanCommitTransaction.SERIALIZABLE_CLASS); + } + + @Test(expected = ExecutionException.class) + public void testCanCommitWithExceptionFailure() throws Exception { + + ThreePhaseCommitCohortProxy proxy = setupProxy(1); + + setupMockActorContext(CanCommitTransaction.SERIALIZABLE_CLASS, new RuntimeException("mock")); + + proxy.canCommit().get(); + } + + @Test(expected = ExecutionException.class) + public void testCanCommitWithInvalidResponseType() throws Exception { + ThreePhaseCommitCohortProxy proxy = setupProxy(1); + + setupMockActorContext(CanCommitTransaction.SERIALIZABLE_CLASS, + new PreCommitTransactionReply()); + + proxy.canCommit().get(); } @Test public void testPreCommit() throws Exception { - actorContext.setExecuteRemoteOperationResponse(new PreCommitTransactionReply()); + ThreePhaseCommitCohortProxy proxy = setupProxy(1); - ListenableFuture future = proxy.preCommit(); + setupMockActorContext(PreCommitTransaction.SERIALIZABLE_CLASS, + new PreCommitTransactionReply()); - future.get(); + proxy.preCommit().get(); + verifyCohortInvocations(1, PreCommitTransaction.SERIALIZABLE_CLASS); + } + + @Test(expected = ExecutionException.class) + public void testPreCommitWithFailure() throws Exception { + ThreePhaseCommitCohortProxy proxy = setupProxy(2); + + setupMockActorContext(PreCommitTransaction.SERIALIZABLE_CLASS, + new PreCommitTransactionReply(), new RuntimeException("mock")); + + proxy.preCommit().get(); } @Test public void testAbort() throws Exception { - actorContext.setExecuteRemoteOperationResponse(new AbortTransactionReply()); + ThreePhaseCommitCohortProxy proxy = setupProxy(1); - ListenableFuture future = proxy.abort(); + setupMockActorContext(AbortTransaction.SERIALIZABLE_CLASS, new AbortTransactionReply()); - future.get(); + proxy.abort().get(); + verifyCohortInvocations(1, AbortTransaction.SERIALIZABLE_CLASS); + } + + @Test + public void testAbortWithFailure() throws Exception { + ThreePhaseCommitCohortProxy proxy = setupProxy(1); + + setupMockActorContext(AbortTransaction.SERIALIZABLE_CLASS, new RuntimeException("mock")); + + // The exception should not get propagated. + proxy.abort().get(); + + verifyCohortInvocations(1, AbortTransaction.SERIALIZABLE_CLASS); } @Test public void testCommit() throws Exception { - actorContext.setExecuteRemoteOperationResponse(new CommitTransactionReply()); - ListenableFuture future = proxy.commit(); + ThreePhaseCommitCohortProxy proxy = setupProxy(2); + + setupMockActorContext(CommitTransaction.SERIALIZABLE_CLASS, new CommitTransactionReply(), + new CommitTransactionReply()); + + proxy.commit().get(); - future.get(); + verifyCohortInvocations(2, CommitTransaction.SERIALIZABLE_CLASS); + } + + @Test(expected = ExecutionException.class) + public void testCommitWithFailure() throws Exception { + + ThreePhaseCommitCohortProxy proxy = setupProxy(2); + + setupMockActorContext(CommitTransaction.SERIALIZABLE_CLASS, new CommitTransactionReply(), + new RuntimeException("mock")); + + proxy.commit().get(); + } + + @Test(expected = ExecutionException.class) + public void teseCommitWithInvalidResponseType() throws Exception { + + ThreePhaseCommitCohortProxy proxy = setupProxy(1); + + setupMockActorContext(CommitTransaction.SERIALIZABLE_CLASS, new PreCommitTransactionReply()); + + proxy.commit().get(); } @Test - public void testGetCohortPaths() throws Exception { - assertNotNull(proxy.getCohortPaths()); + public void testGetCohortPaths() { + + ThreePhaseCommitCohortProxy proxy = setupProxy(2); + + List paths = proxy.getCohortPaths(); + assertNotNull("getCohortPaths returned null", paths); + assertEquals("getCohortPaths size", 2, paths.size()); } }