X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=opendaylight%2Fmd-sal%2Fstatistics-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fstatistics%2Fmanager%2FAbstractStatsTracker.java;fp=opendaylight%2Fmd-sal%2Fstatistics-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fmd%2Fstatistics%2Fmanager%2FAbstractStatsTracker.java;h=7b756d8f48747fbdb89006c606ee91563b836340;hb=3a827de1a10cd2c88a09eefc0ec518fa00f8dc02;hp=81fa7c87917e98af33da999da7b17949592a8fcc;hpb=def3f90c150a98aa910ce5ba3e4692c461dd3250;p=controller.git diff --git a/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/AbstractStatsTracker.java b/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/AbstractStatsTracker.java index 81fa7c8791..7b756d8f48 100644 --- a/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/AbstractStatsTracker.java +++ b/opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/AbstractStatsTracker.java @@ -14,7 +14,6 @@ import java.util.Map; import java.util.Map.Entry; import java.util.concurrent.Future; -import org.opendaylight.controller.md.statistics.manager.MultipartMessageManager.StatsRequestType; import org.opendaylight.controller.sal.binding.api.data.DataModificationTransaction; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.transaction.rev131103.TransactionAware; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.transaction.rev131103.TransactionId; @@ -23,6 +22,8 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.N import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier.InstanceIdentifierBuilder; import org.opendaylight.yangtools.yang.common.RpcResult; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import com.google.common.base.Function; import com.google.common.base.Preconditions; @@ -30,10 +31,16 @@ import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.JdkFutureAdapters; abstract class AbstractStatsTracker { + private static final Logger logger = LoggerFactory.getLogger(AbstractStatsTracker.class); private static final Function, TransactionId> FUNCTION = new Function, TransactionId>() { @Override public TransactionId apply(RpcResult input) { + if (!input.isSuccessful()) { + logger.debug("Statistics request failed: {}", input.getErrors()); + throw new RPCFailedException("Failed to send statistics request", input.getErrors()); + } + return input.getResult().getTransactionId(); } }; @@ -59,8 +66,8 @@ abstract class AbstractStatsTracker { return context.getNodeIdentifier(); } - protected final void requestHelper(Future> future, StatsRequestType type) { - context.registerTransaction(Futures.transform(JdkFutureAdapters.listenInPoolThread(future), FUNCTION), type); + protected final void requestHelper(Future> future) { + context.registerTransaction(Futures.transform(JdkFutureAdapters.listenInPoolThread(future), FUNCTION)); } protected final DataModificationTransaction startTransaction() {