X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=openflowjava%2Fopenflow-protocol-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fopenflowjava%2Fprotocol%2Fimpl%2Fdeserialization%2Ffactories%2FHelloMessageFactory.java;fp=openflowjava%2Fopenflow-protocol-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fopenflowjava%2Fprotocol%2Fimpl%2Fdeserialization%2Ffactories%2FHelloMessageFactory.java;h=b60574b3eda9f77402551ac0847f17d4367cd53a;hb=73099b3ffa1362f9572399c75b521ebd0974de09;hp=9627cb9252fae1b59a58c51445621bc47521c825;hpb=f6bbc7b19d85cf7d216fe00f20a59840fc746a56;p=openflowplugin.git diff --git a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/HelloMessageFactory.java b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/HelloMessageFactory.java index 9627cb9252..b60574b3ed 100644 --- a/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/HelloMessageFactory.java +++ b/openflowjava/openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/deserialization/factories/HelloMessageFactory.java @@ -13,7 +13,6 @@ import static org.opendaylight.yangtools.yang.common.netty.ByteBufUtils.readUint import io.netty.buffer.ByteBuf; import java.util.ArrayList; import java.util.List; -import org.opendaylight.openflowjava.protocol.api.extensibility.OFDeserializer; import org.opendaylight.openflowjava.protocol.api.util.EncodeConstants; import org.opendaylight.openflowjava.protocol.impl.util.VersionAssignableFactory; import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.common.types.rev130731.HelloElementType; @@ -28,12 +27,11 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.openflow.protocol.rev130731 * @author michal.polkorab * @author timotej.kubas */ -public class HelloMessageFactory extends VersionAssignableFactory implements OFDeserializer { - +public class HelloMessageFactory extends VersionAssignableFactory { private static final byte HELLO_ELEMENT_HEADER_SIZE = 4; @Override - public HelloMessage deserialize(ByteBuf rawMessage) { + public HelloMessage deserialize(final ByteBuf rawMessage) { HelloMessageBuilder builder = new HelloMessageBuilder(); builder.setVersion(getVersion()); builder.setXid(readUint32(rawMessage)); @@ -43,7 +41,7 @@ public class HelloMessageFactory extends VersionAssignableFactory implements OFD return builder.build(); } - private static List readElement(ByteBuf input) { + private static List readElement(final ByteBuf input) { List elementsList = new ArrayList<>(); while (input.readableBytes() > 0) { ElementsBuilder elementsBuilder = new ElementsBuilder(); @@ -68,7 +66,7 @@ public class HelloMessageFactory extends VersionAssignableFactory implements OFD return elementsList; } - private static List readVersionBitmap(int[] input) { + private static List readVersionBitmap(final int[] input) { List versionBitmapList = new ArrayList<>(); for (int mask : input) { for (int j = 0; j < Integer.SIZE; j++) {