X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;ds=sidebyside;f=southbound%2Fsouthbound-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fovsdb%2Fsouthbound%2Fovsdb%2Ftransact%2FQueueRemovedCommand.java;h=7bf7f70ed22f24704625286ebab02c061f8f42e3;hb=48096e085b70127b9358d9ec33e772a6d94f569d;hp=4a7c85129588268200be5dd352980cf6887f28a2;hpb=fcfb5e64040407dbc2c1682ebe081c13d048811c;p=ovsdb.git diff --git a/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/QueueRemovedCommand.java b/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/QueueRemovedCommand.java index 4a7c85129..7bf7f70ed 100644 --- a/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/QueueRemovedCommand.java +++ b/southbound/southbound-impl/src/main/java/org/opendaylight/ovsdb/southbound/ovsdb/transact/QueueRemovedCommand.java @@ -5,7 +5,6 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.ovsdb.southbound.ovsdb.transact; import static org.opendaylight.ovsdb.lib.operations.Operations.op; @@ -13,19 +12,16 @@ import static org.opendaylight.ovsdb.lib.operations.Operations.op; import java.util.Collection; import java.util.List; import java.util.Map; - -import org.opendaylight.controller.md.sal.binding.api.DataTreeModification; -import org.opendaylight.controller.md.sal.common.api.data.AsyncDataChangeEvent; +import org.opendaylight.mdsal.binding.api.DataTreeModification; import org.opendaylight.ovsdb.lib.notation.UUID; import org.opendaylight.ovsdb.lib.operations.TransactionBuilder; -import org.opendaylight.ovsdb.lib.schema.typed.TyperUtils; import org.opendaylight.ovsdb.schema.openvswitch.Queue; -import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Uri; +import org.opendaylight.ovsdb.southbound.InstanceIdentifierCodec; +import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.OvsdbNodeAugmentation; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.ovsdb.node.attributes.Queues; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node; -import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -34,22 +30,23 @@ public class QueueRemovedCommand implements TransactCommand { private static final Logger LOG = LoggerFactory.getLogger(QueueRemovedCommand.class); @Override - public void execute(TransactionBuilder transaction, BridgeOperationalState state, - AsyncDataChangeEvent, DataObject> events) { + public void execute(final TransactionBuilder transaction, final BridgeOperationalState state, + final DataChangeEvent events, final InstanceIdentifierCodec instanceIdentifierCodec) { execute(transaction, state, TransactUtils.extractOriginal(events, OvsdbNodeAugmentation.class), TransactUtils.extractUpdated(events, OvsdbNodeAugmentation.class)); } @Override - public void execute(TransactionBuilder transaction, BridgeOperationalState state, - Collection> modifications) { + public void execute(final TransactionBuilder transaction, final BridgeOperationalState state, + final Collection> modifications, + final InstanceIdentifierCodec instanceIdentifierCodec) { execute(transaction, state, TransactUtils.extractOriginal(modifications, OvsdbNodeAugmentation.class), TransactUtils.extractUpdated(modifications, OvsdbNodeAugmentation.class)); } - private void execute(TransactionBuilder transaction, BridgeOperationalState state, - Map, OvsdbNodeAugmentation> originals, - Map, OvsdbNodeAugmentation> updated) { + private void execute(final TransactionBuilder transaction, final BridgeOperationalState state, + final Map, OvsdbNodeAugmentation> originals, + final Map, OvsdbNodeAugmentation> updated) { for (Map.Entry, OvsdbNodeAugmentation> originalEntry : originals .entrySet()) { InstanceIdentifier ovsdbNodeIid = originalEntry.getKey(); @@ -62,7 +59,7 @@ public class QueueRemovedCommand implements TransactCommand { if (origQueues != null && !origQueues.isEmpty()) { for (Queues origQueue : origQueues) { OvsdbNodeAugmentation operNode = - state.getBridgeNode(ovsdbNodeIid).get().getAugmentation( + state.getBridgeNode(ovsdbNodeIid).get().augmentation( OvsdbNodeAugmentation.class); List operQueues = operNode.getQueues(); @@ -79,13 +76,12 @@ public class QueueRemovedCommand implements TransactCommand { LOG.debug("Received request to delete Queue entry {}", origQueue.getQueueId()); Uuid queueUuid = getQueueUuid(operQueues, origQueue.getQueueId()); if (queueUuid != null) { - Queue queue = - TyperUtils.getTypedRowWrapper(transaction.getDatabaseSchema(), Queue.class, - null); + Queue queue = transaction.getTypedRowSchema(Queue.class); transaction.add(op.delete(queue.getSchema()) .where(queue.getUuidColumn().getSchema().opEqual( new UUID(queueUuid.getValue()))) .build()); + LOG.info("Deleted queue Uuid : {} for the Ovsdb Node : {}", queueUuid, operNode); } else { LOG.warn("Unable to delete Queue{} for node {} because it was not found in the " + "operational store, and thus we cannot retrieve its UUID", @@ -98,7 +94,7 @@ public class QueueRemovedCommand implements TransactCommand { } } - private Uuid getQueueUuid(List operQueues, Uri queueId) { + private Uuid getQueueUuid(final List operQueues, final Uri queueId) { if (operQueues != null && !operQueues.isEmpty()) { for (Queues queueEntry : operQueues) { if (queueEntry.getQueueId().equals(queueId)) {