X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=applications%2Fnotification-supplier%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fopenflowplugin%2Fapplications%2Fnotification%2Fsupplier%2Fimpl%2Fitem%2Fstat%2FQueueStatNotificationSupplierImplTest.java;h=d19d879174e2694ad315054070483a154d58ef6a;hb=refs%2Fchanges%2F37%2F45837%2F2;hp=e488b6484e17191f1a939b3f2f65775bb4af9fe2;hpb=82cd91207e0dfbea3bba59537e7ff9dcaf75d895;p=openflowplugin.git diff --git a/applications/notification-supplier/src/test/java/org/opendaylight/openflowplugin/applications/notification/supplier/impl/item/stat/QueueStatNotificationSupplierImplTest.java b/applications/notification-supplier/src/test/java/org/opendaylight/openflowplugin/applications/notification/supplier/impl/item/stat/QueueStatNotificationSupplierImplTest.java index e488b6484e..d19d879174 100644 --- a/applications/notification-supplier/src/test/java/org/opendaylight/openflowplugin/applications/notification/supplier/impl/item/stat/QueueStatNotificationSupplierImplTest.java +++ b/applications/notification-supplier/src/test/java/org/opendaylight/openflowplugin/applications/notification/supplier/impl/item/stat/QueueStatNotificationSupplierImplTest.java @@ -14,14 +14,17 @@ import static org.mockito.Mockito.mock; import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; -import java.util.HashMap; -import java.util.Map; +import java.util.ArrayList; +import java.util.Collection; import org.junit.Before; import org.junit.Test; import org.mockito.Matchers; import org.opendaylight.controller.md.sal.binding.api.DataBroker; +import org.opendaylight.controller.md.sal.binding.api.DataObjectModification; +import org.opendaylight.controller.md.sal.binding.api.DataTreeModification; import org.opendaylight.controller.sal.binding.api.NotificationProviderService; import org.opendaylight.openflowplugin.applications.notification.supplier.impl.helper.TestChangeEventBuildHelper; +import org.opendaylight.openflowplugin.applications.notification.supplier.impl.helper.TestData; import org.opendaylight.openflowplugin.applications.notification.supplier.impl.helper.TestSupplierVerifyHelper; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNodeConnector; import org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.port.rev130925.queues.Queue; @@ -36,7 +39,6 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.queue.statistics.rev131216. import org.opendaylight.yang.gen.v1.urn.opendaylight.queue.statistics.rev131216.FlowCapableNodeConnectorQueueStatisticsDataBuilder; import org.opendaylight.yang.gen.v1.urn.opendaylight.queue.statistics.rev131216.QueueStatisticsUpdate; import org.opendaylight.yang.gen.v1.urn.opendaylight.queue.statistics.rev131216.flow.capable.node.connector.queue.statistics.FlowCapableNodeConnectorQueueStatisticsBuilder; -import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; /** @@ -44,7 +46,7 @@ import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; */ public class QueueStatNotificationSupplierImplTest { - private static final String FLOW_NODE_ID = "test-111"; + private static final String FLOW_NODE_ID = "openflow:111"; private static final String FLOW_CODE_CONNECTOR_ID = "test-con-111"; private QueueStatNotificationSupplierImpl notifSupplierImpl; private NotificationProviderService notifProviderService; @@ -55,22 +57,22 @@ public class QueueStatNotificationSupplierImplTest { notifProviderService = mock(NotificationProviderService.class); dataBroker = mock(DataBroker.class); notifSupplierImpl = new QueueStatNotificationSupplierImpl(notifProviderService, dataBroker); - TestSupplierVerifyHelper.verifyDataChangeRegistration(dataBroker); + TestSupplierVerifyHelper.verifyDataTreeChangeListenerRegistration(dataBroker); } - @Test(expected = IllegalArgumentException.class) + @Test(expected = NullPointerException.class) public void testNullChangeEvent() { - notifSupplierImpl.onDataChanged(null); + notifSupplierImpl.onDataTreeChanged(null); } - @Test + @Test(expected = NullPointerException.class) public void testNullableChangeEvent() { - notifSupplierImpl.onDataChanged(TestChangeEventBuildHelper.createEmptyTestDataEvent()); + notifSupplierImpl.onDataTreeChanged(TestChangeEventBuildHelper.createNullTestDataTreeEvent()); } @Test public void testEmptyChangeEvent() { - notifSupplierImpl.onDataChanged(TestChangeEventBuildHelper.createEmptyTestDataEvent()); + notifSupplierImpl.onDataTreeChanged(TestChangeEventBuildHelper.createEmptyTestDataTreeEvent()); } @Test @@ -84,9 +86,11 @@ public class QueueStatNotificationSupplierImplTest { @Test public void testCreateChangeEvent() { - final Map, DataObject> createdData = new HashMap<>(); - createdData.put(createTestQueueStatPath(), createTestQueueStat()); - notifSupplierImpl.onDataChanged(TestChangeEventBuildHelper.createTestDataEvent(createdData, null, null)); + final TestData testData = new TestData(createTestQueueStatPath(),null,createTestQueueStat(), + DataObjectModification.ModificationType.WRITE); + Collection> collection = new ArrayList<>(); + collection.add(testData); + notifSupplierImpl.onDataTreeChanged(collection); verify(notifProviderService, times(1)).publish(Matchers.any(QueueStatisticsUpdate.class)); }