X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=bgp%2Fparser-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fprotocol%2Fbgp%2Fparser%2Fspi%2FAbstractBGPExtensionProviderActivator.java;h=1f1f0b74a4d8ec601bc27cebae605c15b29d8289;hb=2f3cf555f60c85d54af16d9d8d8f4e55523db2c3;hp=e51bc0d89f0adb3e480d767388c1147decda2b58;hpb=9ec280f26d682e115e206f3a51c1b84b9977087f;p=bgpcep.git diff --git a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AbstractBGPExtensionProviderActivator.java b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AbstractBGPExtensionProviderActivator.java index e51bc0d89f..1f1f0b74a4 100644 --- a/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AbstractBGPExtensionProviderActivator.java +++ b/bgp/parser-spi/src/main/java/org/opendaylight/protocol/bgp/parser/spi/AbstractBGPExtensionProviderActivator.java @@ -12,18 +12,14 @@ import static java.util.Objects.requireNonNull; import java.util.List; import javax.annotation.concurrent.GuardedBy; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; +import org.opendaylight.yangtools.concepts.Registration; public abstract class AbstractBGPExtensionProviderActivator implements AutoCloseable, BGPExtensionProviderActivator { - private static final Logger LOG = LoggerFactory.getLogger(AbstractBGPExtensionProviderActivator.class); - @GuardedBy("this") - private List registrations; + private List registrations; @GuardedBy("this") - // FIXME: use yangtools.concepts.Registration here - protected abstract List startImpl(BGPExtensionProviderContext context); + protected abstract List startImpl(BGPExtensionProviderContext context); @Override public final synchronized void start(final BGPExtensionProviderContext context) { @@ -32,20 +28,12 @@ public abstract class AbstractBGPExtensionProviderActivator implements AutoClose } @Override - @SuppressWarnings("checkstyle:illegalCatch") public final synchronized void stop() { if (this.registrations == null) { return; } - for (final AutoCloseable r : this.registrations) { - try { - r.close(); - } catch (final Exception e) { - LOG.warn("Failed to close registration", e); - } - } - + this.registrations.forEach(Registration::close); this.registrations = null; }