X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=bgp%2Frib-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fprotocol%2Fbgp%2Frib%2Fimpl%2FRIBImpl.java;h=cb8def72e9aa3dd6ab632ddd45837f8d3c704abb;hb=db8996e377c2e6eadf0d9b6117c11e66f5e5d043;hp=cc68033f6cf5f23b2ce84e24e433731c860fedd2;hpb=f865d41d600e3e7b10c9284b3d3546f527841975;p=bgpcep.git diff --git a/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/RIBImpl.java b/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/RIBImpl.java old mode 100644 new mode 100755 index cc68033f6c..cb8def72e9 --- a/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/RIBImpl.java +++ b/bgp/rib-impl/src/main/java/org/opendaylight/protocol/bgp/rib/impl/RIBImpl.java @@ -12,16 +12,21 @@ import com.google.common.base.MoreObjects.ToStringHelper; import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableSet; +import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.ListenableFuture; +import java.util.ArrayList; import java.util.HashSet; import java.util.List; +import java.util.Map; import java.util.Map.Entry; import java.util.Set; -import java.util.concurrent.ExecutionException; +import javax.annotation.Nonnull; +import javax.annotation.Nullable; import javax.annotation.concurrent.ThreadSafe; -import org.opendaylight.controller.md.sal.binding.api.DataBroker; +import org.opendaylight.controller.config.yang.bgp.rib.impl.RIBImplRuntimeRegistration; +import org.opendaylight.controller.config.yang.bgp.rib.impl.RIBImplRuntimeRegistrator; import org.opendaylight.controller.md.sal.common.api.data.AsyncTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; -import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; import org.opendaylight.controller.md.sal.common.api.data.TransactionChain; import org.opendaylight.controller.md.sal.common.api.data.TransactionChainListener; import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException; @@ -30,17 +35,28 @@ import org.opendaylight.controller.md.sal.dom.api.DOMDataBrokerExtension; import org.opendaylight.controller.md.sal.dom.api.DOMDataTreeChangeService; import org.opendaylight.controller.md.sal.dom.api.DOMDataWriteTransaction; import org.opendaylight.controller.md.sal.dom.api.DOMTransactionChain; +import org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTreeFactory; +import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonService; +import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceProvider; +import org.opendaylight.mdsal.singleton.common.api.ClusterSingletonServiceRegistration; +import org.opendaylight.mdsal.singleton.common.api.ServiceGroupIdentifier; +import org.opendaylight.protocol.bgp.mode.api.PathSelectionMode; +import org.opendaylight.protocol.bgp.mode.impl.base.BasePathSelectionModeFactory; +import org.opendaylight.protocol.bgp.openconfig.spi.BGPConfigModuleTracker; +import org.opendaylight.protocol.bgp.openconfig.spi.BGPOpenConfigProvider; import org.opendaylight.protocol.bgp.rib.DefaultRibReference; import org.opendaylight.protocol.bgp.rib.impl.spi.BGPDispatcher; +import org.opendaylight.protocol.bgp.rib.impl.spi.BgpDeployer; +import org.opendaylight.protocol.bgp.rib.impl.spi.CodecsRegistry; +import org.opendaylight.protocol.bgp.rib.impl.spi.ImportPolicyPeerTracker; import org.opendaylight.protocol.bgp.rib.impl.spi.RIB; import org.opendaylight.protocol.bgp.rib.impl.spi.RIBSupportContextRegistry; +import org.opendaylight.protocol.bgp.rib.impl.stats.rib.impl.BGPRenderStats; +import org.opendaylight.protocol.bgp.rib.impl.stats.rib.impl.RIBImplRuntimeMXBeanImpl; +import org.opendaylight.protocol.bgp.rib.spi.CacheDisconnectedPeers; import org.opendaylight.protocol.bgp.rib.spi.RIBExtensionConsumerContext; import org.opendaylight.protocol.bgp.rib.spi.RibSupportUtils; -import org.opendaylight.protocol.framework.ReconnectStrategyFactory; -import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.AsNumber; -import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Ipv4Address; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.inet.rev150305.bgp.rib.rib.loc.rib.tables.routes.Ipv4RoutesCase; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.inet.rev150305.bgp.rib.rib.loc.rib.tables.routes.Ipv6RoutesCase; +import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.AsNumber; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.multiprotocol.rev130919.BgpTableType; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.BgpRib; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.RibId; @@ -50,8 +66,8 @@ import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib. import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.bgp.rib.rib.Peer; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.rib.Tables; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.rib.TablesKey; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.BgpId; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.ClusterIdentifier; -import org.opendaylight.yangtools.binding.data.codec.api.BindingCodecTreeFactory; import org.opendaylight.yangtools.sal.binding.generator.impl.GeneratedClassLoadingStrategy; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.opendaylight.yangtools.yang.common.QName; @@ -71,87 +87,80 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; @ThreadSafe -public final class RIBImpl extends DefaultRibReference implements AutoCloseable, RIB, TransactionChainListener, SchemaContextListener { +public final class RIBImpl extends DefaultRibReference implements ClusterSingletonService, AutoCloseable, RIB, TransactionChainListener, SchemaContextListener { private static final Logger LOG = LoggerFactory.getLogger(RIBImpl.class); - private static final QName RIB_ID_QNAME = QName.cachedReference(QName.create(Rib.QNAME, "id")); + private static final QName RIB_ID_QNAME = QName.create(Rib.QNAME, "id").intern(); private static final ContainerNode EMPTY_TABLE_ATTRIBUTES = ImmutableNodes.containerNode(org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.rib.tables.Attributes.QNAME); - private final ReconnectStrategyFactory tcpStrategyFactory; - private final ReconnectStrategyFactory sessionStrategyFactory; - private final BGPDispatcher dispatcher; private final DOMTransactionChain domChain; private final AsNumber localAs; - private final Ipv4Address bgpIdentifier; - private final ClusterIdentifier clusterId; + private final BgpId bgpIdentifier; private final Set localTables; private final Set localTablesKeys; - private final DataBroker dataBroker; private final DOMDataBroker domDataBroker; private final RIBExtensionConsumerContext extensions; private final YangInstanceIdentifier yangRibId; private final RIBSupportContextRegistryImpl ribContextRegistry; - private final EffectiveRibInWriter efWriter; + private final CodecsRegistryImpl codecsRegistry; + private final ServiceGroupIdentifier serviceGroupIdentifier; + private final ClusterSingletonServiceProvider provider; + private final PolicyDatabase policyDatabase; + private final BgpDeployer.WriteConfiguration configurationWriter; + private ClusterSingletonServiceRegistration registration; private final DOMDataBrokerExtension service; + private final List locRibs = new ArrayList<>(); + private final BGPConfigModuleTracker configModuleTracker; + private final BGPOpenConfigProvider openConfigProvider; + private final CacheDisconnectedPeers cacheDisconnectedPeers; + private final Map bestPathSelectionStrategies; + private final ImportPolicyPeerTracker importPolicyPeerTracker; + private final RIBImplRuntimeMXBeanImpl renderStats; + private final RibId ribId; + + public RIBImpl(final ClusterSingletonServiceProvider provider, final RibId ribId, final AsNumber localAs, final BgpId localBgpId, + final ClusterIdentifier clusterId, final RIBExtensionConsumerContext extensions, final BGPDispatcher dispatcher, + final BindingCodecTreeFactory codecFactory, final DOMDataBroker domDataBroker, final List localTables, + @Nonnull final Map bestPathSelectionStrategies, final GeneratedClassLoadingStrategy classStrategy, + final BGPConfigModuleTracker moduleTracker, final BGPOpenConfigProvider openConfigProvider, final BgpDeployer.WriteConfiguration configurationWriter) { - public RIBImpl(final RibId ribId, final AsNumber localAs, final Ipv4Address localBgpId, final Ipv4Address clusterId, final RIBExtensionConsumerContext extensions, - final BGPDispatcher dispatcher, final ReconnectStrategyFactory tcpStrategyFactory, final BindingCodecTreeFactory codecFactory, - final ReconnectStrategyFactory sessionStrategyFactory, final DataBroker dps, final DOMDataBroker domDataBroker, final List localTables, final GeneratedClassLoadingStrategy classStrategy) { super(InstanceIdentifier.create(BgpRib.class).child(Rib.class, new RibKey(Preconditions.checkNotNull(ribId)))); this.domChain = domDataBroker.createTransactionChain(this); this.localAs = Preconditions.checkNotNull(localAs); this.bgpIdentifier = Preconditions.checkNotNull(localBgpId); - this.clusterId = (clusterId == null) ? new ClusterIdentifier(localBgpId) : new ClusterIdentifier(clusterId); this.dispatcher = Preconditions.checkNotNull(dispatcher); - this.sessionStrategyFactory = Preconditions.checkNotNull(sessionStrategyFactory); - this.tcpStrategyFactory = Preconditions.checkNotNull(tcpStrategyFactory); this.localTables = ImmutableSet.copyOf(localTables); - this.localTablesKeys = new HashSet(); - this.dataBroker = dps; + this.localTablesKeys = new HashSet<>(); this.domDataBroker = Preconditions.checkNotNull(domDataBroker); + this.service = this.domDataBroker.getSupportedExtensions().get(DOMDataTreeChangeService.class); this.extensions = Preconditions.checkNotNull(extensions); - this.ribContextRegistry = RIBSupportContextRegistryImpl.create(extensions, codecFactory, classStrategy); - this.yangRibId = YangInstanceIdentifier.builder().node(BgpRib.QNAME).node(Rib.QNAME).nodeWithKey(Rib.QNAME, RIB_ID_QNAME, ribId.getValue()).build(); - - LOG.debug("Instantiating RIB table {} at {}", ribId, this.yangRibId); - - final ContainerNode rib = Builders.containerBuilder() - .withNodeIdentifier(new NodeIdentifier(BgpRib.QNAME)) - .addChild(ImmutableNodes.mapNodeBuilder(Rib.QNAME) - .addChild(ImmutableNodes.mapEntryBuilder(Rib.QNAME, RIB_ID_QNAME, ribId.getValue()) - .addChild(ImmutableNodes.leafNode(RIB_ID_QNAME, ribId.getValue())) - .addChild(ImmutableNodes.mapNodeBuilder(Peer.QNAME).build()) - .addChild(Builders.containerBuilder().withNodeIdentifier(new NodeIdentifier(LocRib.QNAME)) - .addChild(ImmutableNodes.mapNodeBuilder(Tables.QNAME).build()) - .build()) - .build()) - .build()) - .build(); - - - final DOMDataWriteTransaction trans = this.domChain.newWriteOnlyTransaction(); - - // put empty BgpRib if not exists - trans.put(LogicalDatastoreType.OPERATIONAL, YangInstanceIdentifier.builder().node(BgpRib.QNAME).build(), rib); - - try { - trans.submit().checkedGet(); - } catch (final TransactionCommitFailedException e) { - LOG.error("Failed to initiate RIB {}", this.yangRibId); - } - - final PolicyDatabase pd = new PolicyDatabase(localAs.getValue(), localBgpId, this.clusterId); - - final DOMDataBrokerExtension service = this.domDataBroker.getSupportedExtensions().get(DOMDataTreeChangeService.class); - this.service = service; - this.efWriter = EffectiveRibInWriter.create(getService(), this.createPeerChain(this), getYangRibId(), pd, this.ribContextRegistry); - LOG.debug("Effective RIB created."); + this.codecsRegistry = CodecsRegistryImpl.create(codecFactory, classStrategy); + this.ribContextRegistry = RIBSupportContextRegistryImpl.create(extensions, this.codecsRegistry); + final InstanceIdentifierBuilder yangRibIdBuilder = YangInstanceIdentifier.builder().node(BgpRib.QNAME).node(Rib.QNAME); + this.yangRibId = yangRibIdBuilder.nodeWithKey(Rib.QNAME, RIB_ID_QNAME, ribId.getValue()).build(); + this.configModuleTracker = moduleTracker; + this.openConfigProvider = openConfigProvider; + this.cacheDisconnectedPeers = new CacheDisconnectedPeersImpl(); + this.bestPathSelectionStrategies = Preconditions.checkNotNull(bestPathSelectionStrategies); + final ClusterIdentifier cId = (clusterId == null) ? new ClusterIdentifier(localBgpId) : clusterId; + this.renderStats = new RIBImplRuntimeMXBeanImpl(localBgpId, ribId, localAs, cId); + this.ribId = ribId; + this.policyDatabase = new PolicyDatabase(this.localAs.getValue(), localBgpId, cId); + this.importPolicyPeerTracker = new ImportPolicyPeerTrackerImpl( this.policyDatabase); + this.serviceGroupIdentifier = ServiceGroupIdentifier.create(this.ribId + "-service-group"); + Preconditions.checkNotNull(provider, "ClusterSingletonServiceProvider is null"); + this.provider = provider; + LOG.info("RIB Singleton Service {} registered", this.getIdentifier()); + this.registration = registerClusterSingletonService(this); + this.configurationWriter = configurationWriter; + } - for (final BgpTableType t : this.localTables) { - final TablesKey key = new TablesKey(t.getAfi(), t.getSafi()); - this.localTablesKeys.add(key); - startLocRib(key, pd); - } + public RIBImpl(final ClusterSingletonServiceProvider provider, final RibId ribId, final AsNumber localAs, final BgpId localBgpId, @Nullable final ClusterIdentifier clusterId, + final RIBExtensionConsumerContext extensions, final BGPDispatcher dispatcher, final BindingCodecTreeFactory codecFactory, + final DOMDataBroker domDataBroker, final List localTables, final Map bestPathSelectionstrategies, + final GeneratedClassLoadingStrategy classStrategy, final BgpDeployer.WriteConfiguration configurationWriter) { + this(provider, ribId, localAs, localBgpId, clusterId, extensions, dispatcher, codecFactory, + domDataBroker, localTables, bestPathSelectionstrategies, classStrategy, null, null, configurationWriter); } private void startLocRib(final TablesKey key, final PolicyDatabase pd) { @@ -179,7 +188,14 @@ public final class RIBImpl extends DefaultRibReference implements AutoCloseable, } catch (final TransactionCommitFailedException e1) { LOG.error("Failed to initiate LocRIB for key {}", key, e1); } - LocRibWriter.create(this.ribContextRegistry, key, this.createPeerChain(this), getYangRibId(), this.localAs, getService(), pd); + + PathSelectionMode pathSelectionStrategy = this.bestPathSelectionStrategies.get(key); + if (pathSelectionStrategy == null) { + pathSelectionStrategy = BasePathSelectionModeFactory.createBestPathSelectionStrategy(); + } + + this.locRibs.add(LocRibWriter.create(this.ribContextRegistry, key, createPeerChain(this), getYangRibId(), this.localAs, getService(), pd, + this.cacheDisconnectedPeers, pathSelectionStrategy, this.renderStats.getLocRibRouteCounter().init(key))); } @Override @@ -192,12 +208,12 @@ public final class RIBImpl extends DefaultRibReference implements AutoCloseable, } @Override - public synchronized void close() throws InterruptedException, ExecutionException { - final DOMDataWriteTransaction t = this.domChain.newWriteOnlyTransaction(); - t.delete(LogicalDatastoreType.OPERATIONAL, getYangRibId()); - t.submit().get(); + public synchronized void close() throws Exception { this.domChain.close(); - this.efWriter.close(); + if (registration != null) { + registration.close(); + registration = null; + } } @Override @@ -206,7 +222,7 @@ public final class RIBImpl extends DefaultRibReference implements AutoCloseable, } @Override - public Ipv4Address getBgpIdentifier() { + public BgpId getBgpIdentifier() { return this.bgpIdentifier; } @@ -215,16 +231,6 @@ public final class RIBImpl extends DefaultRibReference implements AutoCloseable, return this.localTables; } - @Override - public ReconnectStrategyFactory getTcpStrategyFactory() { - return this.tcpStrategyFactory; - } - - @Override - public ReconnectStrategyFactory getSessionStrategyFactory() { - return this.sessionStrategyFactory; - } - @Override public BGPDispatcher getDispatcher() { return this.dispatcher; @@ -232,7 +238,7 @@ public final class RIBImpl extends DefaultRibReference implements AutoCloseable, @Override public void onTransactionChainFailed(final TransactionChain chain, final AsyncTransaction transaction, final Throwable cause) { - LOG.error("Broken chain in RIB {} transaction {}", getInstanceIdentifier(), transaction.getIdentifier(), cause); + LOG.error("Broken chain in RIB {} transaction {}", getInstanceIdentifier(), transaction != null ? transaction.getIdentifier() : null, cause); } @Override @@ -241,38 +247,20 @@ public final class RIBImpl extends DefaultRibReference implements AutoCloseable, } @Override - public long getRoutesCount(final TablesKey key) { - try { - final Optional tableMaybe = this.dataBroker.newReadOnlyTransaction().read(LogicalDatastoreType.OPERATIONAL, - getInstanceIdentifier().child(LocRib.class).child(Tables.class, key)).checkedGet(); - if (tableMaybe.isPresent()) { - final Tables table = tableMaybe.get(); - if (table.getRoutes() instanceof Ipv4RoutesCase) { - final Ipv4RoutesCase routesCase = (Ipv4RoutesCase) table.getRoutes(); - if (routesCase.getIpv4Routes() != null && routesCase.getIpv4Routes().getIpv4Route() != null) { - return routesCase.getIpv4Routes().getIpv4Route().size(); - } - } else if (table.getRoutes() instanceof Ipv6RoutesCase) { - final Ipv6RoutesCase routesCase = (Ipv6RoutesCase) table.getRoutes(); - if (routesCase.getIpv6Routes() != null && routesCase.getIpv6Routes().getIpv6Route() != null) { - return routesCase.getIpv6Routes().getIpv6Route().size(); - } - } - } - } catch (final ReadFailedException e) { - //no-op - } - return 0; - } - public Set getLocalTablesKeys() { return this.localTablesKeys; } + @Override public DOMDataTreeChangeService getService() { return (DOMDataTreeChangeService) this.service; } + @Override + public BGPRenderStats getRenderStats() { + return this.renderStats; + } + @Override public YangInstanceIdentifier getYangRibId() { return this.yangRibId; @@ -295,6 +283,111 @@ public final class RIBImpl extends DefaultRibReference implements AutoCloseable, @Override public void onGlobalContextUpdated(final SchemaContext context) { - this.ribContextRegistry.onSchemaContextUpdated(context); + this.codecsRegistry.onSchemaContextUpdated(context); + } + + @Override + public CodecsRegistry getCodecsRegistry() { + return this.codecsRegistry; + } + + @Override + public Optional getOpenConfigProvider() { + return Optional.fromNullable(this.openConfigProvider); + } + + @Override + public CacheDisconnectedPeers getCacheDisconnectedPeers() { + return this.cacheDisconnectedPeers; + } + + @Override + public ImportPolicyPeerTracker getImportPolicyPeerTracker() { + return this.importPolicyPeerTracker; + } + + @Override + public void instantiateServiceInstance() { + if(this.configurationWriter != null) { + this.configurationWriter.apply(); + } + LOG.info("RIB Singleton Service {} instantiated", this.getIdentifier()); + LOG.debug("Instantiating RIB table {} at {}", this.ribId , this.yangRibId); + + final ContainerNode bgpRib = Builders.containerBuilder().withNodeIdentifier(new NodeIdentifier(BgpRib.QNAME)) + .addChild(ImmutableNodes.mapNodeBuilder(Rib.QNAME).build()).build(); + + final MapEntryNode ribInstance = Builders.mapEntryBuilder().withNodeIdentifier( + new NodeIdentifierWithPredicates(Rib.QNAME, RIB_ID_QNAME, this.ribId .getValue())) + .addChild(ImmutableNodes.leafNode(RIB_ID_QNAME, this.ribId .getValue())) + .addChild(ImmutableNodes.mapNodeBuilder(Peer.QNAME).build()) + .addChild(Builders.containerBuilder().withNodeIdentifier(new NodeIdentifier(LocRib.QNAME)) + .addChild(ImmutableNodes.mapNodeBuilder(Tables.QNAME).build()) + .build()).build(); + + + final DOMDataWriteTransaction trans = this.domChain.newWriteOnlyTransaction(); + + // merge empty BgpRib + Rib, to make sure the top-level parent structure is present + trans.merge(LogicalDatastoreType.OPERATIONAL, YangInstanceIdentifier.builder().node(BgpRib.QNAME).build(), bgpRib); + trans.put(LogicalDatastoreType.OPERATIONAL, this.yangRibId, ribInstance); + + try { + trans.submit().checkedGet(); + } catch (final TransactionCommitFailedException e) { + LOG.error("Failed to initiate RIB {}", this.yangRibId, e); + } + + LOG.debug("Effective RIB created."); + + for (final BgpTableType t : this.localTables) { + final TablesKey key = new TablesKey(t.getAfi(), t.getSafi()); + this.localTablesKeys.add(key); + startLocRib(key, policyDatabase); + } + + if (this.configModuleTracker != null) { + this.configModuleTracker.onInstanceCreate(); + } + } + + @Override + public ListenableFuture closeServiceInstance() { + LOG.info("Close RIB Singleton Service {}", this.getIdentifier()); + for (final LocRibWriter locRib : this.locRibs) { + try { + locRib.close(); + } catch (final Exception e) { + LOG.warn("Could not close LocalRib reference: {}", locRib, e); + } + } + try { + final DOMDataWriteTransaction t = this.domChain.newWriteOnlyTransaction(); + t.delete(LogicalDatastoreType.OPERATIONAL, getYangRibId()); + t.submit().checkedGet(); + } catch (final TransactionCommitFailedException e) { + LOG.warn("Failed to remove RIB instance {} from DS.", getYangRibId(), e); + } + this.renderStats.getLocRibRouteCounter().resetAll(); + + if (this.configModuleTracker != null) { + this.configModuleTracker.onInstanceClose(); + } + return Futures.immediateFuture(null); + } + + @Override + public ServiceGroupIdentifier getIdentifier() { + return this.serviceGroupIdentifier; + } + + @Override + public ClusterSingletonServiceRegistration registerClusterSingletonService(final ClusterSingletonService clusterSingletonService) { + return this.provider.registerClusterSingletonService(clusterSingletonService); + } + + @Override + public ServiceGroupIdentifier getRibIServiceGroupIdentifier() { + return getIdentifier(); } }