X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=bgp%2Ftopology-provider%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fbgpcep%2Fbgp%2Ftopology%2Fprovider%2FAbstractReachabilityTopologyBuilder.java;h=2a6b1a6311a418445954c4fa602a137fa3896ddb;hb=804cd520199b1e0299952787027febef349d5980;hp=fd65369b90137f7bea9309dc45357d78eb0dcd5e;hpb=a0768a91898dae3d6311fb6600c2c0622214e854;p=bgpcep.git diff --git a/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/AbstractReachabilityTopologyBuilder.java b/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/AbstractReachabilityTopologyBuilder.java index fd65369b90..2a6b1a6311 100644 --- a/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/AbstractReachabilityTopologyBuilder.java +++ b/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/AbstractReachabilityTopologyBuilder.java @@ -18,7 +18,7 @@ import org.opendaylight.controller.md.sal.binding.api.ReadTransaction; import org.opendaylight.controller.md.sal.binding.api.ReadWriteTransaction; import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; import org.opendaylight.protocol.bgp.rib.RibReference; -import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.IpPrefix; +import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.IpPrefix; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev130919.path.attributes.Attributes; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.Route; import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.next.hop.CNextHop; @@ -68,7 +68,10 @@ abstract class AbstractReachabilityTopologyBuilder extends Abst private NodeId advertizingNode(final Attributes attrs) { final CNextHop nh = attrs.getCNextHop(); - if (nh instanceof Ipv4NextHopCase) { + if (nh == null) { + LOG.warn("Next hop value is null"); + return null; + } else if (nh instanceof Ipv4NextHopCase) { final Ipv4NextHop ipv4 = ((Ipv4NextHopCase) nh).getIpv4NextHop(); return new NodeId(ipv4.getGlobal().getValue()); @@ -122,6 +125,9 @@ abstract class AbstractReachabilityTopologyBuilder extends Abst @Override protected final void createObject(final ReadWriteTransaction trans, final InstanceIdentifier id, final T value) { final NodeId ni = advertizingNode(getAttributes(value)); + if (ni == null) { + return; + } final InstanceIdentifier nii = ensureNodePresent(trans, ni); final IpPrefix prefix = getPrefix(value); @@ -134,6 +140,9 @@ abstract class AbstractReachabilityTopologyBuilder extends Abst @Override protected final void removeObject(final ReadWriteTransaction trans, final InstanceIdentifier id, final T value) { final NodeId ni = advertizingNode(getAttributes(value)); + if (ni == null) { + return; + } final NodeUsage present = this.nodes.get(ni); Preconditions.checkState(present != null, "Removing prefix from non-existent node %s", present);