X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=bgp%2Ftopology-provider%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fbgpcep%2Fbgp%2Ftopology%2Fprovider%2FAbstractReachabilityTopologyBuilder.java;h=b11ea16f5085349725b08218f8b39af48be84d7a;hb=0fdeddbe3d072a88428599421191f0f60b2864e4;hp=69f1c641e51a359705b6231d9ef752a41d26ca0d;hpb=a4251513f5b90be5cfbea7267c1e39d946d454bc;p=bgpcep.git diff --git a/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/AbstractReachabilityTopologyBuilder.java b/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/AbstractReachabilityTopologyBuilder.java index 69f1c641e5..b11ea16f50 100644 --- a/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/AbstractReachabilityTopologyBuilder.java +++ b/bgp/topology-provider/src/main/java/org/opendaylight/bgpcep/bgp/topology/provider/AbstractReachabilityTopologyBuilder.java @@ -7,118 +7,185 @@ */ package org.opendaylight.bgpcep.bgp.topology.provider; -import java.util.ArrayList; - -import org.opendaylight.controller.md.sal.common.api.data.DataModification; -import org.opendaylight.controller.sal.binding.api.data.DataProviderService; -import org.opendaylight.protocol.bgp.rib.LocRibReference; -import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.IpPrefix; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.Route; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev130925.route.Attributes; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.next.hop.CNextHop; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.next.hop.c.next.hop.Ipv4NextHopCase; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.next.hop.c.next.hop.Ipv6NextHopCase; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.next.hop.c.next.hop.ipv4.next.hop._case.Ipv4NextHop; -import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev130919.next.hop.c.next.hop.ipv6.next.hop._case.Ipv6NextHop; +import static java.util.Objects.requireNonNull; + +import com.google.common.base.Preconditions; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.ExecutionException; +import org.opendaylight.mdsal.binding.api.DataBroker; +import org.opendaylight.mdsal.binding.api.ReadOperations; +import org.opendaylight.mdsal.binding.api.ReadWriteTransaction; +import org.opendaylight.mdsal.common.api.LogicalDatastoreType; +import org.opendaylight.protocol.bgp.rib.RibReference; +import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.IpPrefix; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.message.rev200120.path.attributes.Attributes; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.rib.rev180329.Route; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.AddressFamily; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.SubsequentAddressFamily; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.CNextHop; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.c.next.hop.Ipv4NextHopCase; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.c.next.hop.Ipv6NextHopCase; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.c.next.hop.ipv4.next.hop._case.Ipv4NextHop; +import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.types.rev200120.next.hop.c.next.hop.ipv6.next.hop._case.Ipv6NextHop; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.NodeId; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.TopologyId; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node; +import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.NodeBuilder; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.NodeKey; +import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.TopologyTypes; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.Node1; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.Node1Builder; +import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.igp.node.attributes.IgpNodeAttributes; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.igp.node.attributes.IgpNodeAttributesBuilder; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.igp.node.attributes.igp.node.attributes.Prefix; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.igp.node.attributes.igp.node.attributes.PrefixBuilder; import org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.igp.node.attributes.igp.node.attributes.PrefixKey; import org.opendaylight.yangtools.yang.binding.DataObject; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; +import org.opendaylight.yangtools.yang.binding.KeyedInstanceIdentifier; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -/** - * - */ abstract class AbstractReachabilityTopologyBuilder extends AbstractTopologyBuilder { - private static final Logger LOG = LoggerFactory.getLogger(AbstractReachabilityTopologyBuilder.class); - - protected AbstractReachabilityTopologyBuilder(final DataProviderService dataProvider, final LocRibReference locRibReference, final TopologyId topologyId, - final Class idClass) { - super(dataProvider, locRibReference, topologyId, idClass); - } - - private NodeId advertizingNode(final Attributes attrs) { - final CNextHop nh = attrs.getCNextHop(); - if (nh instanceof Ipv4NextHopCase) { - final Ipv4NextHop ipv4 = ((Ipv4NextHopCase) nh).getIpv4NextHop(); - - return new NodeId(ipv4.getGlobal().getValue()); - } else if (nh instanceof Ipv6NextHopCase) { - final Ipv6NextHop ipv6 = ((Ipv6NextHopCase) nh).getIpv6NextHop(); - - return new NodeId(ipv6.getGlobal().getValue()); - } else { - LOG.warn("Unhandled next hop class {}", nh.getImplementedInterface()); - return null; - } - } - - private InstanceIdentifier nodeInstanceId(final NodeId ni) { - return InstanceIdentifier.builder(getInstanceIdentifier()).child(Node.class, new NodeKey(ni)).augmentation(Node1.class).toInstance(); - } - - private InstanceIdentifier ensureNodePresent(final DataModification, DataObject> trans, final NodeId ni) { - final InstanceIdentifier nii = nodeInstanceId(ni); - - if (trans.readOperationalData(nii) == null) { - LOG.debug("Create a new node at {}", nii); - trans.putOperationalData( - nii, - new Node1Builder().setIgpNodeAttributes(new IgpNodeAttributesBuilder().setPrefix(new ArrayList()).build()).build()); - } - - return nii; - } - - private void removeEmptyNode(final DataModification, DataObject> trans, final InstanceIdentifier nii) { - final Node1 node = (Node1) trans.readOperationalData(nii); - if (node != null && node.getIgpNodeAttributes().getPrefix().isEmpty()) { - trans.removeOperationalData(nii); - } - } - - protected abstract Attributes getAttributes(final T value); - - protected abstract IpPrefix getPrefix(final T value); - - @Override - protected final void createObject(final DataModification, DataObject> trans, final InstanceIdentifier id, - final T value) { - final NodeId ni = advertizingNode(getAttributes(value)); - final InstanceIdentifier nii = ensureNodePresent(trans, ni); - - final IpPrefix prefix = getPrefix(value); - final PrefixKey pk = new PrefixKey(prefix); - - trans.putOperationalData( - InstanceIdentifier.builder(nii).child( - org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.igp.node.attributes.IgpNodeAttributes.class).child( - Prefix.class, pk).toInstance(), new PrefixBuilder().setKey(pk).setPrefix(prefix).build()); - } - - @Override - protected final void removeObject(final DataModification, DataObject> trans, final InstanceIdentifier id, - final T value) { - final NodeId ni = advertizingNode(getAttributes(value)); - final InstanceIdentifier nii = nodeInstanceId(ni); - - final IpPrefix prefix = getPrefix(value); - final PrefixKey pk = new PrefixKey(prefix); - - trans.removeOperationalData(InstanceIdentifier.builder(nii).child( - org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.igp.node.attributes.IgpNodeAttributes.class).child( - Prefix.class, pk).toInstance()); - - removeEmptyNode(trans, nii); - } - + private static final Logger LOG = LoggerFactory.getLogger(AbstractReachabilityTopologyBuilder.class); + private final Map nodes = new HashMap<>(); + + private static final class NodeUsage { + private final InstanceIdentifier attrId; + private int useCount = 1; + + NodeUsage(final InstanceIdentifier attrId) { + this.attrId = requireNonNull(attrId); + } + } + + protected AbstractReachabilityTopologyBuilder(final DataBroker dataProvider, final RibReference locRibReference, + final TopologyId topologyId, final TopologyTypes topologyTypes, final Class afi, + final Class safi) { + super(dataProvider, locRibReference, topologyId, topologyTypes, afi, safi); + } + + private static NodeId advertizingNode(final Attributes attrs) { + final CNextHop nh = attrs.getCNextHop(); + if (nh == null) { + LOG.warn("Next hop value is null"); + return null; + } else if (nh instanceof Ipv4NextHopCase) { + final Ipv4NextHop ipv4 = ((Ipv4NextHopCase) nh).getIpv4NextHop(); + + return new NodeId(ipv4.getGlobal().getValue()); + } else if (nh instanceof Ipv6NextHopCase) { + final Ipv6NextHop ipv6 = ((Ipv6NextHopCase) nh).getIpv6NextHop(); + + return new NodeId(ipv6.getGlobal().getValue()); + } else { + LOG.warn("Unhandled next hop class {}", nh.implementedInterface()); + return null; + } + } + + private KeyedInstanceIdentifier nodeInstanceId(final NodeId ni) { + return getInstanceIdentifier().child(Node.class, new NodeKey(ni)); + } + + private static T read(final ReadOperations rt, final InstanceIdentifier id) { + final Optional optional; + try { + optional = rt.read(LogicalDatastoreType.OPERATIONAL, id).get(); + } catch (InterruptedException | ExecutionException e) { + LOG.warn("Failed to read {}, assuming non-existent", id, e); + return null; + } + + return optional.orElse(null); + } + + private InstanceIdentifier ensureNodePresent(final ReadWriteTransaction trans, final NodeId ni) { + final NodeUsage present = this.nodes.get(ni); + if (present != null) { + return present.attrId; + } + + final KeyedInstanceIdentifier nii = nodeInstanceId(ni); + final InstanceIdentifier ret = nii.builder().augmentation(Node1.class) + .child(IgpNodeAttributes.class).build(); + + trans.merge(LogicalDatastoreType.OPERATIONAL, nii, new NodeBuilder().withKey(nii.getKey()).setNodeId(ni) + .addAugmentation(Node1.class, new Node1Builder().setIgpNodeAttributes( + new IgpNodeAttributesBuilder().setPrefix(Collections.emptyList()).build()).build()).build()); + + this.nodes.put(ni, new NodeUsage(ret)); + return ret; + } + + protected abstract Attributes getAttributes(T value); + + protected abstract IpPrefix getPrefix(T value); + + @Override + protected final void createObject(final ReadWriteTransaction trans, final InstanceIdentifier id, final T value) { + final NodeId ni = advertizingNode(getAttributes(value)); + if (ni == null) { + return; + } + final InstanceIdentifier nii = ensureNodePresent(trans, ni); + + final IpPrefix prefix = getPrefix(value); + final PrefixKey pk = new PrefixKey(prefix); + + trans.put(LogicalDatastoreType.OPERATIONAL, + nii.child(Prefix.class, pk), new PrefixBuilder().withKey(pk).setPrefix(prefix).build()); + } + + @Override + protected final void removeObject(final ReadWriteTransaction trans, final InstanceIdentifier id, final T value) { + if (value == null) { + LOG.error("Empty before-data received in delete data change notification for instance id {}", id); + return; + } + + final NodeId ni = advertizingNode(getAttributes(value)); + if (ni == null) { + return; + } + final NodeUsage present = this.nodes.get(ni); + Preconditions.checkState(present != null, "Removing prefix from non-existent node %s", present); + + final PrefixKey pk = new PrefixKey(getPrefix(value)); + trans.delete(LogicalDatastoreType.OPERATIONAL, present.attrId.child(Prefix.class, pk)); + + /* + * This is optimization magic: we are reading a list and we want to remove it once it + * hits zero. We may be in a transaction, so the read is costly, especially since we + * have just modified the list. + * + * Once we have performed the read, though, we can check the number of nodes, and reuse + * it for that number of removals. Note that since we do not track data and thus have + * no understanding about the difference between replace and add, we do not ever increase + * the life of this in createObject(). + */ + present.useCount--; + if (present.useCount == 0) { + final IgpNodeAttributes attrs = read(trans, present.attrId); + if (attrs != null) { + final List prefix = attrs.getPrefix(); + present.useCount = prefix == null ? 0 : prefix.size(); + } else { + present.useCount = 0; + } + if (present.useCount == 0) { + trans.delete(LogicalDatastoreType.OPERATIONAL, nodeInstanceId(ni)); + this.nodes.remove(ni); + } + } + } + + @Override + protected void clearTopology() { + this.nodes.clear(); + } }