X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=binding%2Fmdsal-binding-dom-adapter%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fmdsal%2Fbinding%2Fdom%2Fadapter%2FBindingToNormalizedNodeCodec.java;h=55fde2cd655b19b5e47517d3ca0ec7895f84cf50;hb=refs%2Fchanges%2F66%2F86466%2F1;hp=45ac5b28160b8fe1c15a55c4813939208f2cc4bb;hpb=2cd00f1a5d28cb5df491e07ac18848c50338a4c5;p=mdsal.git
diff --git a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingToNormalizedNodeCodec.java b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingToNormalizedNodeCodec.java
index 45ac5b2816..55fde2cd65 100644
--- a/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingToNormalizedNodeCodec.java
+++ b/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/BindingToNormalizedNodeCodec.java
@@ -11,8 +11,6 @@ import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkState;
import static java.util.Objects.requireNonNull;
-import com.google.common.base.Function;
-import com.google.common.base.Optional;
import com.google.common.cache.CacheBuilder;
import com.google.common.cache.CacheLoader;
import com.google.common.cache.LoadingCache;
@@ -20,33 +18,37 @@ import com.google.common.collect.ImmutableBiMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Iterators;
import java.lang.reflect.Method;
+import java.time.Instant;
import java.util.AbstractMap.SimpleEntry;
import java.util.Collection;
import java.util.HashSet;
import java.util.Map.Entry;
+import java.util.Optional;
import java.util.Set;
import java.util.concurrent.TimeUnit;
+import java.util.function.Function;
import java.util.stream.Collectors;
-import javassist.ClassPool;
-import javax.annotation.Nonnull;
+import javax.annotation.PreDestroy;
+import javax.inject.Inject;
+import javax.inject.Singleton;
+import org.eclipse.jdt.annotation.NonNull;
import org.opendaylight.mdsal.binding.api.DataTreeIdentifier;
import org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTree;
import org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTreeFactory;
import org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTreeNode;
+import org.opendaylight.mdsal.binding.dom.codec.api.BindingDataObjectCodecTreeNode;
import org.opendaylight.mdsal.binding.dom.codec.api.BindingLazyContainerNode;
import org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer;
-import org.opendaylight.mdsal.binding.dom.codec.gen.impl.StreamWriterGenerator;
import org.opendaylight.mdsal.binding.dom.codec.impl.BindingNormalizedNodeCodecRegistry;
import org.opendaylight.mdsal.binding.dom.codec.impl.MissingSchemaException;
import org.opendaylight.mdsal.binding.generator.api.ClassLoadingStrategy;
import org.opendaylight.mdsal.binding.generator.util.BindingRuntimeContext;
-import org.opendaylight.mdsal.binding.generator.util.JavassistUtils;
+import org.opendaylight.mdsal.binding.spec.naming.BindingMapping;
import org.opendaylight.mdsal.binding.spec.reflect.BindingReflections;
import org.opendaylight.mdsal.dom.api.DOMDataTreeIdentifier;
import org.opendaylight.mdsal.dom.api.DOMSchemaService;
import org.opendaylight.yangtools.concepts.ListenerRegistration;
import org.opendaylight.yangtools.yang.binding.Action;
-import org.opendaylight.yangtools.yang.binding.BindingMapping;
import org.opendaylight.yangtools.yang.binding.DataContainer;
import org.opendaylight.yangtools.yang.binding.DataObject;
import org.opendaylight.yangtools.yang.binding.InstanceIdentifier;
@@ -82,6 +84,7 @@ import org.slf4j.LoggerFactory;
*
* NOTE: this class is non-final to allow controller adapter migration without duplicated code.
*/
+@Singleton
public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
BindingNormalizedNodeSerializer, SchemaContextListener, AutoCloseable {
@@ -91,7 +94,7 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
private final LoadingCache, YangInstanceIdentifier> iiCache = CacheBuilder.newBuilder()
.softValues().build(new CacheLoader, YangInstanceIdentifier>() {
@Override
- public YangInstanceIdentifier load(@Nonnull final InstanceIdentifier> key) {
+ public YangInstanceIdentifier load(final InstanceIdentifier> key) {
return toYangInstanceIdentifierBlocking(key);
}
});
@@ -100,6 +103,7 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
private final FutureSchema futureSchema;
private ListenerRegistration> listenerRegistration;
+ @Inject
public BindingToNormalizedNodeCodec(final ClassLoadingStrategy classLoadingStrategy,
final BindingNormalizedNodeCodecRegistry codecRegistry) {
this(classLoadingStrategy, codecRegistry, false);
@@ -114,8 +118,7 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
public static BindingToNormalizedNodeCodec newInstance(final ClassLoadingStrategy classLoadingStrategy,
final DOMSchemaService schemaService) {
- final BindingNormalizedNodeCodecRegistry codecRegistry = new BindingNormalizedNodeCodecRegistry(
- StreamWriterGenerator.create(JavassistUtils.forClassPool(ClassPool.getDefault())));
+ final BindingNormalizedNodeCodecRegistry codecRegistry = new BindingNormalizedNodeCodecRegistry();
BindingToNormalizedNodeCodec instance = new BindingToNormalizedNodeCodec(
classLoadingStrategy, codecRegistry, true);
instance.listenerRegistration = schemaService.registerSchemaContextListener(instance);
@@ -147,7 +150,7 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
}
@Override
- public final YangInstanceIdentifier toYangInstanceIdentifier(@Nonnull final InstanceIdentifier> binding) {
+ public final YangInstanceIdentifier toYangInstanceIdentifier(final InstanceIdentifier> binding) {
return codecRegistry.toYangInstanceIdentifier(binding);
}
@@ -183,20 +186,24 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
}
@Override
- public final Entry, DataObject> fromNormalizedNode(@Nonnull final YangInstanceIdentifier path,
+ public final Entry, DataObject> fromNormalizedNode(final YangInstanceIdentifier path,
final NormalizedNode, ?> data) {
return codecRegistry.fromNormalizedNode(path, data);
}
@Override
- public final Notification fromNormalizedNodeNotification(@Nonnull final SchemaPath path,
- @Nonnull final ContainerNode data) {
+ public final Notification fromNormalizedNodeNotification(final SchemaPath path, final ContainerNode data) {
return codecRegistry.fromNormalizedNodeNotification(path, data);
}
@Override
- public final DataObject fromNormalizedNodeRpcData(@Nonnull final SchemaPath path,
- @Nonnull final ContainerNode data) {
+ public final Notification fromNormalizedNodeNotification(final SchemaPath path, final ContainerNode data,
+ final Instant eventInstant) {
+ return codecRegistry.fromNormalizedNodeNotification(path, data, eventInstant);
+ }
+
+ @Override
+ public final DataObject fromNormalizedNodeRpcData(final SchemaPath path, final ContainerNode data) {
return codecRegistry.fromNormalizedNodeRpcData(path, data);
}
@@ -213,17 +220,17 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
}
@Override
- public final InstanceIdentifier> fromYangInstanceIdentifier(@Nonnull final YangInstanceIdentifier dom) {
+ public final InstanceIdentifier> fromYangInstanceIdentifier(final YangInstanceIdentifier dom) {
return codecRegistry.fromYangInstanceIdentifier(dom);
}
@Override
- public final ContainerNode toNormalizedNodeNotification(@Nonnull final Notification data) {
+ public final ContainerNode toNormalizedNodeNotification(final Notification data) {
return codecRegistry.toNormalizedNodeNotification(data);
}
@Override
- public final ContainerNode toNormalizedNodeRpcData(@Nonnull final DataContainer data) {
+ public final ContainerNode toNormalizedNodeRpcData(final DataContainer data) {
return codecRegistry.toNormalizedNodeRpcData(data);
}
@@ -256,20 +263,20 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
* instance-identifier if it is possible to create representation.
*
*
- * Returns Optional.absent for cases where target is mixin node except
+ * Returns Optional.empty for cases where target is mixin node except
* augmentation.
*/
public final Optional> toBinding(final YangInstanceIdentifier normalized)
throws DeserializationException {
try {
- return Optional.fromNullable(codecRegistry.fromYangInstanceIdentifier(normalized));
+ return Optional.ofNullable(codecRegistry.fromYangInstanceIdentifier(normalized));
} catch (final IllegalArgumentException e) {
- return Optional.absent();
+ return Optional.empty();
}
}
public final Optional, DataObject>> toBinding(
- @Nonnull final Entry> normalized)
+ final @NonNull Entry> normalized)
throws DeserializationException {
try {
/*
@@ -289,9 +296,9 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
@SuppressWarnings("unchecked")
final Entry, DataObject> binding = Entry.class.cast(
codecRegistry.fromNormalizedNode(normalized.getKey(), normalized.getValue()));
- return Optional.fromNullable(binding);
+ return Optional.ofNullable(binding);
} catch (final IllegalArgumentException e) {
- return Optional.absent();
+ return Optional.empty();
}
}
@@ -310,8 +317,7 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
@Deprecated
public final Function>, Optional> deserializeFunction(
final InstanceIdentifier path) {
- return input -> Optional.fromJavaUtil(codecRegistry.deserializeFunction(path).apply(
- Optional.toJavaUtil(input)));
+ return codecRegistry.deserializeFunction(path)::apply;
}
public final BindingNormalizedNodeCodecRegistry getCodecRegistry() {
@@ -319,6 +325,7 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
}
@Override
+ @PreDestroy
public void close() {
if (listenerRegistration != null) {
listenerRegistration.close();
@@ -368,9 +375,14 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
checkState(localRuntimeContext != null, "BindingRuntimeContext is not available.");
module = localRuntimeContext.getSchemaContext().findModule(moduleName).orElse(null);
}
- checkState(module != null, "Schema for %s is not available; expected module name: %s.", modeledClass,
- moduleName);
- return module;
+ if (module != null) {
+ return module;
+ }
+
+ LOG.debug("Schema for {} is not available; expected module name: {}; BindingRuntimeContext: {}",
+ modeledClass, moduleName, localRuntimeContext);
+ throw new IllegalStateException(String.format("Schema for %s is not available; expected module name: %s; "
+ + "full BindingRuntimeContext available in debug log", modeledClass, moduleName));
}
private void waitForSchema(final Collection> binding, final MissingSchemaException exception) {
@@ -383,7 +395,7 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
private Method findRpcMethod(final Class extends RpcService> key, final RpcDefinition rpcDef)
throws NoSuchMethodException {
- final String methodName = BindingMapping.getMethodName(rpcDef.getQName());
+ final String methodName = BindingMapping.getRpcMethodName(rpcDef.getQName());
final Class> inputClz = runtimeContext().getClassForSchema(rpcDef.getInput());
return key.getMethod(methodName, inputClz);
}
@@ -398,8 +410,7 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
return codecRegistry.create(context, bindingClasses);
}
- @Nonnull
- protected Entry, BindingCodecTreeNode>> getSubtreeCodec(
+ protected @NonNull Entry, BindingDataObjectCodecTreeNode>> getSubtreeCodec(
final YangInstanceIdentifier domIdentifier) {
final BindingCodecTree currentCodecTree = codecRegistry.getCodecContext();
@@ -409,7 +420,7 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
* If we are able to deserialize YANG instance identifier, getSubtreeCodec must
* return non-null value.
*/
- final BindingCodecTreeNode> codecContext = currentCodecTree.getSubtreeCodec(bindingPath);
+ final BindingDataObjectCodecTreeNode> codecContext = currentCodecTree.getSubtreeCodec(bindingPath);
return new SimpleEntry<>(bindingPath, codecContext);
}
@@ -448,8 +459,16 @@ public class BindingToNormalizedNodeCodec implements BindingCodecTreeFactory,
return ImmutableNodes.fromInstanceId(runtimeContext().getSchemaContext(), parentPath);
}
+ /**
+ * This method creates an empty list container of a particular type.
+ *
+ * @deprecated This method is not generally useful, as empty lists do not convey information in YANG (they are
+ * equivalent to non-present lists). It also leaks implementation details to a broader scope and should
+ * never have been public in the first place.
+ */
+ @Deprecated
public NormalizedNode, ?> getDefaultNodeFor(final YangInstanceIdentifier parentMapPath) {
- final BindingCodecTreeNode> mapCodec = requireNonNull(
+ final BindingCodecTreeNode mapCodec = requireNonNull(
codecRegistry.getCodecContext().getSubtreeCodec(parentMapPath),
"Codec not found for yang instance identifier: " + parentMapPath);
final WithStatus schema = mapCodec.getSchema();