X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=bundles-test-lib%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fodlparent%2Fbundlestest%2Flib%2FBundleDiagInfosImpl.java;fp=bundles-test-lib%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fodlparent%2Fbundlestest%2Flib%2FBundleDiagInfosImpl.java;h=6e0d8800df9f2b7f13f034edbc4dfe1e6447d336;hb=29f9ec39d345639d7dfa2d6ca719efa7ddd16d59;hp=aa3d41980d169761d242e1533a8f7d3c8b47244e;hpb=8a6e629984616198cadd28fd72d534cfc146a344;p=odlparent.git diff --git a/bundles-test-lib/src/main/java/org/opendaylight/odlparent/bundlestest/lib/BundleDiagInfosImpl.java b/bundles-test-lib/src/main/java/org/opendaylight/odlparent/bundlestest/lib/BundleDiagInfosImpl.java index aa3d41980..6e0d8800d 100644 --- a/bundles-test-lib/src/main/java/org/opendaylight/odlparent/bundlestest/lib/BundleDiagInfosImpl.java +++ b/bundles-test-lib/src/main/java/org/opendaylight/odlparent/bundlestest/lib/BundleDiagInfosImpl.java @@ -30,15 +30,13 @@ import org.osgi.framework.BundleContext; */ // intentionally just package-local final class BundleDiagInfosImpl implements BundleDiagInfos { + @java.io.Serial private static final long serialVersionUID = 1L; - private static final Map WHITELISTED_BUNDLES; - - static { - WHITELISTED_BUNDLES = new HashMap<>(); - WHITELISTED_BUNDLES.put("slf4j.log4j12", Installed); - WHITELISTED_BUNDLES.put("org.apache.karaf.scr.management", Waiting); // ODLPARENT-144 - } + private static final Map WHITELISTED_BUNDLES = Map.of( + "slf4j.log4j12", Installed, + // ODLPARENT-144 + "org.apache.karaf.scr.management", Waiting); private final List okBundleStateInfoTexts; private final List nokBundleStateInfoTexts; @@ -90,12 +88,10 @@ final class BundleDiagInfosImpl implements BundleDiagInfos { + ", Karaf bundleState = " + karafBundleState + (diagText.isEmpty() ? "" : ", due to: " + diagText); - if (WHITELISTED_BUNDLES.get(bundleSymbolicName) != null) { - if (WHITELISTED_BUNDLES.get(bundleSymbolicName).equals(karafBundleState)) { - String msg = "WHITELISTED " + bundleSymbolicNameWithVersion + ": " + bundleStateDiagText; - whitelistedBundleStateInfoTexts.add(msg); - continue; - } + if (bundleSymbolicName != null && WHITELISTED_BUNDLES.get(bundleSymbolicName) == karafBundleState) { + whitelistedBundleStateInfoTexts.add( + "WHITELISTED " + bundleSymbolicNameWithVersion + ": " + bundleStateDiagText); + continue; } bundleStatesCounters.compute(karafBundleState, (key, counter) -> counter + 1);