X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Ftransportpce%2Fcommon%2Fmapping%2FPortMappingImpl.java;h=8652a78be946a50c430f6f5de631665e0268b3c8;hb=04b9194abd5955a6ce7334a25ee55aa18ed2e776;hp=da1fa9afca25043e2dd824a17984366c1e88a4a1;hpb=62924bb3518025fcdc8500128454054e7011559b;p=transportpce.git diff --git a/common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingImpl.java b/common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingImpl.java index da1fa9afc..8652a78be 100644 --- a/common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingImpl.java +++ b/common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingImpl.java @@ -14,16 +14,17 @@ import java.util.Optional; import java.util.concurrent.ExecutionException; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; - -import org.opendaylight.controller.md.sal.binding.api.DataBroker; -import org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction; -import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; -import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev170228.Network; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev170228.network.Nodes; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev170228.network.NodesKey; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev170228.network.nodes.Mapping; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev170228.network.nodes.MappingKey; +import org.opendaylight.mdsal.binding.api.DataBroker; +import org.opendaylight.mdsal.binding.api.ReadTransaction; +import org.opendaylight.mdsal.binding.api.WriteTransaction; +import org.opendaylight.mdsal.common.api.LogicalDatastoreType; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev200429.Network; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev200429.network.Nodes; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev200429.network.NodesKey; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev200429.network.nodes.Mapping; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev200429.network.nodes.MappingBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev200429.network.nodes.MappingKey; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev200429.network.nodes.NodeInfo.OpenroadmVersion; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -34,15 +35,13 @@ public class PortMappingImpl implements PortMapping { private static final Logger LOG = LoggerFactory.getLogger(PortMappingImpl.class); private final DataBroker dataBroker; - private final MappingUtils mappingUtils; private final PortMappingVersion221 portMappingVersion22; private final PortMappingVersion121 portMappingVersion121; - public PortMappingImpl(DataBroker dataBroker, PortMappingVersion221 portMappingVersion22, MappingUtils mappingUtils, - PortMappingVersion121 portMappingVersion121) { + public PortMappingImpl(DataBroker dataBroker, PortMappingVersion221 portMappingVersion22, + PortMappingVersion121 portMappingVersion121) { this.dataBroker = dataBroker; - this.mappingUtils = mappingUtils; this.portMappingVersion22 = portMappingVersion22; this.portMappingVersion121 = portMappingVersion121; } @@ -51,11 +50,10 @@ public class PortMappingImpl implements PortMapping { public boolean createMappingData(String nodeId, String nodeVersion) { if (nodeVersion.equals(OPENROADM_DEVICE_VERSION_1_2_1)) { return portMappingVersion121.createMappingData(nodeId); - } - else if (nodeVersion.equals(OPENROADM_DEVICE_VERSION_2_2_1)) { + } else if (nodeVersion.equals(OPENROADM_DEVICE_VERSION_2_2_1)) { return portMappingVersion22.createMappingData(nodeId); - } - else { + } else { + LOG.error("Unable to create mapping data for unmanaged openroadm device version"); return false; } } @@ -70,12 +68,11 @@ public class PortMappingImpl implements PortMapping { */ InstanceIdentifier portMappingIID = InstanceIdentifier.builder(Network.class).child(Nodes.class, new NodesKey(nodeId)).child(Mapping.class, new MappingKey(logicalConnPoint)).build(); - try (ReadOnlyTransaction readTx = this.dataBroker.newReadOnlyTransaction()) { - Optional mapObject = readTx.read(LogicalDatastoreType.CONFIGURATION, portMappingIID).get() - .toJavaUtil(); + try (ReadTransaction readTx = this.dataBroker.newReadOnlyTransaction()) { + Optional mapObject = readTx.read(LogicalDatastoreType.CONFIGURATION, portMappingIID).get(); if (mapObject.isPresent()) { Mapping mapping = mapObject.get(); - LOG.info("Found mapping for the logical port {}. Mapping: {}", logicalConnPoint, mapping.toString()); + LOG.info("Found mapping for {} - {}. Mapping: {}", nodeId, logicalConnPoint, mapping.toString()); return mapping; } else { LOG.warn("Could not find mapping for logical connection point {} for nodeId {}", logicalConnPoint, @@ -99,7 +96,7 @@ public class PortMappingImpl implements PortMapping { .child(Nodes.class, new NodesKey(nodeId)); rw.delete(LogicalDatastoreType.CONFIGURATION, nodesIID); try { - rw.submit().get(1, TimeUnit.SECONDS); + rw.commit().get(1, TimeUnit.SECONDS); LOG.info("Port mapping removal for node '{}'", nodeId); } catch (InterruptedException | ExecutionException | TimeoutException e) { LOG.error("Error for removing port mapping infos for node '{}'", nodeId); @@ -109,14 +106,36 @@ public class PortMappingImpl implements PortMapping { @Override public boolean updateMapping(String nodeId, Mapping oldMapping) { - - - String openROADMversion = mappingUtils.getOpenRoadmVersion(nodeId); - if (openROADMversion.equals(OPENROADM_DEVICE_VERSION_1_2_1)) { + OpenroadmVersion openROADMversion = this.getNode(nodeId).getNodeInfo().getOpenroadmVersion(); + if (openROADMversion.getIntValue() == 1) { return portMappingVersion121.updateMapping(nodeId,oldMapping); } - else if (openROADMversion.equals(OPENROADM_DEVICE_VERSION_2_2_1)) { - return portMappingVersion22.updateMapping(nodeId,oldMapping); + else if (openROADMversion.getIntValue() == 2) { + org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev200429.network.nodes + .MappingBuilder oldMapping2Bldr = new MappingBuilder().setLogicalConnectionPoint(oldMapping + .getLogicalConnectionPoint()).setPortDirection(oldMapping.getPortDirection()); + if (oldMapping.getConnectionMapLcp() != null) { + oldMapping2Bldr.setConnectionMapLcp(oldMapping.getConnectionMapLcp()); + } + if (oldMapping.getPartnerLcp() != null) { + oldMapping2Bldr.setPartnerLcp(oldMapping.getPartnerLcp()); + } + if (oldMapping.getPortQual() != null) { + oldMapping2Bldr.setPortQual(oldMapping.getPortQual()); + } + if (oldMapping.getSupportingCircuitPackName() != null) { + oldMapping2Bldr.setSupportingCircuitPackName(oldMapping.getSupportingCircuitPackName()); + } + if (oldMapping.getSupportingOms() != null) { + oldMapping2Bldr.setSupportingOms(oldMapping.getSupportingOms()); + } + if (oldMapping.getSupportingOts() != null) { + oldMapping2Bldr.setSupportingOts(oldMapping.getSupportingOts()); + } + if (oldMapping.getSupportingPort() != null) { + oldMapping2Bldr.setSupportingPort(oldMapping.getSupportingPort()); + } + return portMappingVersion22.updateMapping(nodeId, oldMapping2Bldr.build()); } else { @@ -128,9 +147,9 @@ public class PortMappingImpl implements PortMapping { public Nodes getNode(String nodeId) { InstanceIdentifier nodePortMappingIID = InstanceIdentifier.builder(Network.class).child(Nodes.class, new NodesKey(nodeId)).build(); - try (ReadOnlyTransaction readTx = this.dataBroker.newReadOnlyTransaction()) { - Optional nodePortMapObject = readTx.read(LogicalDatastoreType.CONFIGURATION, nodePortMappingIID) - .get().toJavaUtil(); + try (ReadTransaction readTx = this.dataBroker.newReadOnlyTransaction()) { + Optional nodePortMapObject = + readTx.read(LogicalDatastoreType.CONFIGURATION, nodePortMappingIID).get(); if (nodePortMapObject.isPresent()) { Nodes node = nodePortMapObject.get(); LOG.info("Found node {} in portmapping.", nodeId);