X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Ftransportpce%2Fcommon%2Fmapping%2FPortMappingVersion710.java;h=474fd72ff1d4e0d4acea293f6e09d60c541d5b7d;hb=refs%2Fchanges%2F46%2F100646%2F27;hp=0987dfe7f3b9b1b9110ba24385b1f301c1fb646f;hpb=e4254e34b1acd2c1e5218f09828a4654601407ae;p=transportpce.git diff --git a/common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingVersion710.java b/common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingVersion710.java index 0987dfe7f..474fd72ff 100644 --- a/common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingVersion710.java +++ b/common/src/main/java/org/opendaylight/transportpce/common/mapping/PortMappingVersion710.java @@ -9,54 +9,57 @@ package org.opendaylight.transportpce.common.mapping; import com.google.common.util.concurrent.FluentFuture; -import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.util.ArrayList; import java.util.Collection; import java.util.Collections; import java.util.Comparator; import java.util.HashMap; +import java.util.HashSet; import java.util.List; +import java.util.Locale; import java.util.Map; import java.util.Map.Entry; import java.util.Optional; +import java.util.Set; import java.util.concurrent.ExecutionException; import java.util.stream.Collectors; import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.mdsal.binding.api.DataBroker; +import org.opendaylight.mdsal.binding.api.ReadTransaction; import org.opendaylight.mdsal.binding.api.WriteTransaction; import org.opendaylight.mdsal.common.api.CommitInfo; import org.opendaylight.mdsal.common.api.LogicalDatastoreType; import org.opendaylight.transportpce.common.StringConstants; import org.opendaylight.transportpce.common.Timeouts; import org.opendaylight.transportpce.common.device.DeviceTransactionManager; -import org.opendaylight.transportpce.common.openroadminterfaces.OpenRoadmInterfaceException; -import org.opendaylight.transportpce.common.openroadminterfaces.OpenRoadmInterfaces; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.Network; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.NetworkBuilder; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.Nodes; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.NodesBuilder; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.NodesKey; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.CpToDegree; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.CpToDegreeBuilder; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.CpToDegreeKey; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.Mapping; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.MappingBuilder; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.MappingKey; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.McCapabilities; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.McCapabilitiesBuilder; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.McCapabilitiesKey; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.NodeInfo; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.NodeInfo.OpenroadmVersion; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.NodeInfoBuilder; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.SwitchingPoolLcp; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.SwitchingPoolLcpBuilder; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.SwitchingPoolLcpKey; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.switching.pool.lcp.NonBlockingList; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.switching.pool.lcp.NonBlockingListBuilder; -import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev201012.network.nodes.switching.pool.lcp.NonBlockingListKey; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.Network; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.NetworkBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.OpenroadmNodeVersion; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.cp.to.degree.CpToDegree; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.cp.to.degree.CpToDegreeBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.cp.to.degree.CpToDegreeKey; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mapping.Mapping; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mapping.MappingBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mapping.MappingKey; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mc.capabilities.McCapabilities; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mc.capabilities.McCapabilitiesBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mc.capabilities.McCapabilitiesKey; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.mpdr.restrictions.grp.MpdrRestrictionsBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network.Nodes; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network.NodesBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network.NodesKey; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network.nodes.NodeInfo; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.network.nodes.NodeInfoBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.switching.pool.lcp.SwitchingPoolLcp; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.switching.pool.lcp.SwitchingPoolLcpBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.switching.pool.lcp.SwitchingPoolLcpKey; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.switching.pool.lcp.switching.pool.lcp.NonBlockingList; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.switching.pool.lcp.switching.pool.lcp.NonBlockingListBuilder; +import org.opendaylight.yang.gen.v1.http.org.opendaylight.transportpce.portmapping.rev220316.switching.pool.lcp.switching.pool.lcp.NonBlockingListKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.common.alarm.pm.types.rev191129.Direction; import org.opendaylight.yang.gen.v1.http.org.openroadm.common.optical.channel.types.rev200529.FrequencyGHz; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.CircuitPack; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.OrgOpenroadmDeviceData; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.circuit.pack.Ports; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.circuit.pack.PortsKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.circuit.packs.CircuitPacks; @@ -71,6 +74,8 @@ import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.open import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org.openroadm.device.Info; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org.openroadm.device.McCapabilityProfile; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org.openroadm.device.McCapabilityProfileKey; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org.openroadm.device.MuxpProfile; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org.openroadm.device.MuxpProfileKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org.openroadm.device.OduSwitchingPools; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org.openroadm.device.Protocols; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org.openroadm.device.SharedRiskGroup; @@ -80,51 +85,65 @@ import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.open import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org.openroadm.device.odu.switching.pools.non.blocking.list.PortList; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.port.Interfaces; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.xponder.XpdrPort; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.types.rev191129.NodeTypes; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.types.rev191129.PortQual; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.types.rev191129.XpdrNodeTypes; import org.opendaylight.yang.gen.v1.http.org.openroadm.interfaces.rev191129.InterfaceType; import org.opendaylight.yang.gen.v1.http.org.openroadm.interfaces.rev191129.OpenROADMOpticalMultiplex; import org.opendaylight.yang.gen.v1.http.org.openroadm.interfaces.rev191129.OpticalTransport; import org.opendaylight.yang.gen.v1.http.org.openroadm.interfaces.rev191129.OtnOdu; +import org.opendaylight.yang.gen.v1.http.org.openroadm.interfaces.rev191129.OtnOtu; import org.opendaylight.yang.gen.v1.http.org.openroadm.lldp.rev200529.Protocols1; import org.opendaylight.yang.gen.v1.http.org.openroadm.lldp.rev200529.lldp.container.Lldp; import org.opendaylight.yang.gen.v1.http.org.openroadm.lldp.rev200529.lldp.container.lldp.PortConfig; +import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.common.types.rev200327.OpucnTribSlotDef; import org.opendaylight.yang.gen.v1.http.org.openroadm.port.capability.rev200529.Ports1; import org.opendaylight.yang.gen.v1.http.org.openroadm.port.capability.rev200529.port.capability.grp.port.capabilities.SupportedInterfaceCapability; -import org.opendaylight.yang.gen.v1.http.org.openroadm.port.capability.rev200529.port.capability.grp.port.capabilities.SupportedInterfaceCapabilityKey; -import org.opendaylight.yang.gen.v1.http.org.openroadm.port.types.rev200327.SupportedIfCapability; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; +import org.opendaylight.yangtools.yang.binding.KeyedInstanceIdentifier; import org.opendaylight.yangtools.yang.common.Uint16; import org.opendaylight.yangtools.yang.common.Uint32; import org.slf4j.Logger; import org.slf4j.LoggerFactory; + // FIXME: many common pieces of code between PortMapping Versions 121 and 221 and 710 // some mutualization would be helpful +@SuppressWarnings("CPD-START") public class PortMappingVersion710 { + private static final Logger LOG = LoggerFactory.getLogger(PortMappingVersion710.class); + private static final Map SUFFIX; + private static final Set TXRX_SET = Set.of(Direction.Tx.getIntValue(), Direction.Rx.getIntValue()); private final DataBroker dataBroker; private final DeviceTransactionManager deviceTransactionManager; - private final OpenRoadmInterfaces openRoadmInterfaces; - public PortMappingVersion710(DataBroker dataBroker, DeviceTransactionManager deviceTransactionManager, - OpenRoadmInterfaces openRoadmInterfaces) { + static { + SUFFIX = Map.of( + Direction.Tx, "TX", + Direction.Rx, "RX", + Direction.Bidirectional, "TXRX"); + } + + public PortMappingVersion710(DataBroker dataBroker, DeviceTransactionManager deviceTransactionManager) { this.dataBroker = dataBroker; this.deviceTransactionManager = deviceTransactionManager; - this.openRoadmInterfaces = openRoadmInterfaces; } public boolean createMappingData(String nodeId) { - LOG.info("Create Mapping Data for node 7.1.0 {}", nodeId); + LOG.info(PortMappingUtils.CREATE_MAPPING_DATA_LOGMSG, nodeId, "7.1"); List portMapList = new ArrayList<>(); - List mcCapabilitiesList = new ArrayList<>(); - InstanceIdentifier infoIID = InstanceIdentifier.create(OrgOpenroadmDevice.class).child(Info.class); + Map mcCapabilities = new HashMap<>(); + InstanceIdentifier infoIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(Info.class) + .build(); Optional deviceInfoOptional = this.deviceTransactionManager.getDataFromDevice( - nodeId, LogicalDatastoreType.OPERATIONAL, infoIID, - Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (!deviceInfoOptional.isPresent()) { - LOG.warn("Device info subtree is absent for {}", nodeId); + nodeId, LogicalDatastoreType.OPERATIONAL, infoIID, + Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (deviceInfoOptional.isEmpty()) { + LOG.warn(PortMappingUtils.DEVICE_HAS_LOGMSG, nodeId, "no info", "subtree"); return false; } Info deviceInfo = deviceInfoOptional.get(); @@ -140,57 +159,66 @@ public class PortMappingVersion710 { // Get TTP port mapping if (!createTtpPortMapping(nodeId, deviceInfo, portMapList)) { // return false if mapping creation for TTP's failed - LOG.warn("Unable to create mapping for TTP's on node {}", nodeId); + LOG.warn(PortMappingUtils.UNABLE_MAPPING_LOGMSG, nodeId, PortMappingUtils.CREATE, "TTP's"); return false; } // Get PP port mapping if (!createPpPortMapping(nodeId, deviceInfo, portMapList)) { // return false if mapping creation for PP's failed - LOG.warn("Unable to create mapping for PP's on node {}", nodeId); + LOG.warn(PortMappingUtils.UNABLE_MAPPING_LOGMSG, nodeId, PortMappingUtils.CREATE, "PP's"); return false; } // Get MC capabilities - if (!createMcCapabilitiesList(nodeId, deviceInfo, mcCapabilitiesList)) { + if (!createMcCapabilitiesList(nodeId, deviceInfo, mcCapabilities)) { // return false if MC capabilites failed - LOG.warn("Unable to create MC capabilities on node {}", nodeId); + LOG.warn(PortMappingUtils.UNABLE_MC_CAPA_LOGMSG, nodeId); return false; } break; case Xpdr: if (!createXpdrPortMapping(nodeId, portMapList)) { - LOG.warn("Unable to create mapping for Xponder on node {}", nodeId); + LOG.warn(PortMappingUtils.UNABLE_MAPPING_LOGMSG, nodeId, PortMappingUtils.CREATE, "Xponder"); + return false; + } + // In the case of 7.1 models, even XPDR advertizes mc-capabilities, + // hence we need to populate this information into the port-mapping data + // Get MC capabilities + if (!createMcCapabilitiesList(nodeId, deviceInfo, mcCapabilities)) { + // return false if MC capabilites failed + LOG.warn(PortMappingUtils.UNABLE_MC_CAPA_LOGMSG, nodeId); return false; } break; default: - LOG.error("Unable to create mapping for node {} : unknown nodetype ", nodeId); + LOG.error(PortMappingUtils.UNABLE_MAPPING_LOGMSG, + nodeId, PortMappingUtils.CREATE, deviceInfo.getNodeType() + " - unknown nodetype"); break; } - return postPortMapping(nodeId, nodeInfo, portMapList, null, null, mcCapabilitiesList); + return postPortMapping(nodeId, nodeInfo, portMapList, null, null, mcCapabilities); } public boolean updateMapping(String nodeId, Mapping oldMapping) { - InstanceIdentifier portIId = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(CircuitPacks.class, new CircuitPacksKey(oldMapping.getSupportingCircuitPackName())) - .child(Ports.class, new PortsKey(oldMapping.getSupportingPort())); - if ((oldMapping == null) || (nodeId == null)) { - LOG.error("Impossible to update mapping"); + if (nodeId == null) { + LOG.error(PortMappingUtils.UNABLE_MAPPING_LOGMSG, "node id null" , PortMappingUtils.UPDATE, "a null value"); return false; } + if (oldMapping == null) { + LOG.error(PortMappingUtils.UNABLE_MAPPING_LOGMSG, nodeId, PortMappingUtils.UPDATE, "a null value"); + return false; + } + InstanceIdentifier portId = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(CircuitPacks.class, new CircuitPacksKey(oldMapping.getSupportingCircuitPackName())) + .child(Ports.class, new PortsKey(oldMapping.getSupportingPort())) + .build(); try { - Optional portObject = deviceTransactionManager.getDataFromDevice(nodeId, - LogicalDatastoreType.OPERATIONAL, portIId, Timeouts.DEVICE_READ_TIMEOUT, - Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (!portObject.isPresent()) { - return false; - } - Ports port = portObject.get(); - Mapping newMapping = createMappingObject(nodeId, port, oldMapping.getSupportingCircuitPackName(), - oldMapping.getLogicalConnectionPoint()); - LOG.info("Updating old mapping Data {} for {} of {} by new mapping data {}", - oldMapping, oldMapping.getLogicalConnectionPoint(), nodeId, newMapping); + Ports port = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, + portId, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT).get(); + Mapping newMapping = updateMappingObject(nodeId, port, oldMapping); + LOG.debug(PortMappingUtils.UPDATE_MAPPING_LOGMSG, + nodeId, oldMapping, oldMapping.getLogicalConnectionPoint(), newMapping); final WriteTransaction writeTransaction = this.dataBroker.newWriteOnlyTransaction(); InstanceIdentifier mapIID = InstanceIdentifier.create(Network.class) .child(Nodes.class, new NodesKey(nodeId)) @@ -200,336 +228,279 @@ public class PortMappingVersion710 { commit.get(); return true; } catch (InterruptedException | ExecutionException e) { - LOG.error("Error updating Mapping {} for node {}", oldMapping.getLogicalConnectionPoint(), nodeId, e); + LOG.error(PortMappingUtils.UNABLE_MAPPING_LOGMSG, + nodeId, PortMappingUtils.UPDATE, oldMapping.getLogicalConnectionPoint(), e); + return false; + } + } + + public boolean updatePortMappingWithOduSwitchingPools(String nodeId, InstanceIdentifier ospIID, + Map>> nbliidMap) { + + KeyedInstanceIdentifier portMappingNodeIID = + InstanceIdentifier.create(Network.class).child(Nodes.class, new NodesKey(nodeId)); + Nodes portmappingNode = null; + try (ReadTransaction readTx = this.dataBroker.newReadOnlyTransaction()) { + portmappingNode = readTx.read(LogicalDatastoreType.CONFIGURATION, portMappingNodeIID).get().get(); + } catch (InterruptedException | ExecutionException ex) { + LOG.error("Unable to read the port-mapping for nodeId {}", nodeId, ex); + } + if (portmappingNode == null) { return false; } + + OduSwitchingPools osp = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, + ospIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT).get(); + Uint16 ospNumber = osp.getSwitchingPoolNumber(); + Map splMap = + new HashMap(portmappingNode.nonnullSwitchingPoolLcp()); + SwitchingPoolLcpBuilder splBldr = splMap.containsKey(new SwitchingPoolLcpKey(ospNumber)) + ? new SwitchingPoolLcpBuilder(splMap.get(new SwitchingPoolLcpKey(ospNumber))) + : new SwitchingPoolLcpBuilder().setSwitchingPoolNumber(ospNumber) + .setSwitchingPoolType(osp.getSwitchingPoolType()); + Map nblMap = new HashMap<>(); + for (Entry>> entry : nbliidMap.entrySet()) { + NonBlockingList nbl = createNonBlockingList( + splBldr, + osp.getNonBlockingList() + .get(new org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529 + .org.openroadm.device.container.org.openroadm.device.odu.switching.pools + .NonBlockingListKey(entry.getKey())) + .getInterconnectBandwidth(), + entry, + portmappingNode.nonnullMapping(), + nodeId); + if (nbl == null) { + return false; + } + nblMap.put(nbl.key(), nbl); + } + SwitchingPoolLcp switchingPoolLcp = splBldr.setNonBlockingList(nblMap).build(); + splMap.put(switchingPoolLcp.key(), switchingPoolLcp); + postPortMapping(nodeId, null, null, null, new ArrayList(splMap.values()), null); + return true; + } + + private NonBlockingList createNonBlockingList(SwitchingPoolLcpBuilder splBldr, Uint32 interconnectBw, + Entry>> entry, Map mappings, String nodeId) { + NonBlockingListBuilder nblBldr = splBldr.getNonBlockingList() == null + || !splBldr.getNonBlockingList().containsKey(new NonBlockingListKey(entry.getKey())) + ? new NonBlockingListBuilder().setNblNumber(entry.getKey()).setInterconnectBandwidth(interconnectBw) + : new NonBlockingListBuilder(splBldr.getNonBlockingList().get(new NonBlockingListKey(entry.getKey()))); + Set lcpList = nblBldr.getLcpList() != null ? nblBldr.getLcpList() : new HashSet<>(); + for (InstanceIdentifier id : entry.getValue()) { + PortList portList = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, + id, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT).get(); + String lcp = getLcpFromCpAndPort(mappings, portList.getCircuitPackName(), portList.getPortName()); + if (lcp == null || lcpList.contains(lcp)) { + return null; + } + lcpList.add(lcp); + } + return nblBldr.setLcpList(lcpList).build(); } private boolean createXpdrPortMapping(String nodeId, List portMapList) { // Creating for Xponder Line and Client Ports - InstanceIdentifier deviceIID = InstanceIdentifier.create(OrgOpenroadmDevice.class); + OrgOpenroadmDevice device = getXpdrDevice(nodeId); + if (device == null) { + return false; + } + Map lcpMap = new HashMap<>(); + Map mappingMap = new HashMap<>(); + getXpdrMaps(device, nodeId, lcpMap, mappingMap); + if (device.getConnectionMap() == null) { + LOG.warn(PortMappingUtils.NO_CONMAP_LOGMSG, nodeId); + } else { + for (ConnectionMap cm : device.nonnullConnectionMap().values()) { + String skey = cm.getSource().getCircuitPackName() + "+" + cm.getSource().getPortName(); + Destination destination0 = cm.nonnullDestination().values().iterator().next(); + String dkey = destination0.getCircuitPackName() + "+" + destination0.getPortName(); + if (!lcpMap.containsKey(skey)) { + LOG.error(PortMappingUtils.CONMAP_ISSUE_LOGMSG, nodeId, skey, dkey); + continue; + } + String slcp = lcpMap.get(skey); + Mapping mapping = mappingMap.get(slcp); + mappingMap.remove(slcp); + portMapList.add(createXpdrMappingObject(nodeId, null, null, null, null, mapping, + //dlcp + lcpMap.containsKey(dkey) ? lcpMap.get(dkey) : null, + null)); + } + } + if (device.getOduSwitchingPools() != null) { + postPortMapping(nodeId, null, null, null, getSwitchingPoolList(device, lcpMap, nodeId), null); + } + mappingMap.forEach((k,v) -> portMapList.add(v)); + return true; + } + + private OrgOpenroadmDevice getXpdrDevice(String nodeId) { + InstanceIdentifier deviceIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .build(); Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (!deviceObject.isPresent()) { - LOG.error("Impossible to get device configuration for node {}", nodeId); - return false; + if (deviceObject.isEmpty()) { + LOG.error(PortMappingUtils.CANNOT_GET_DEV_CONF_LOGMSG, nodeId); + return null; } OrgOpenroadmDevice device = deviceObject.get(); if (device.getCircuitPacks() == null) { - LOG.warn("Circuit Packs are not present for {}", nodeId); - return false; + LOG.warn(PortMappingUtils.MISSING_CP_LOGMSG, nodeId, PortMappingUtils.FOUND); + return null; } - // Variable to keep track of number of line ports - int line = 1; - // Variable to keep track of number of client ports - int client = 1; - Map lcpMap = new HashMap<>(); - Map mappingMap = new HashMap<>(); + return device; + } + + private void getXpdrMaps(OrgOpenroadmDevice device, String nodeId, + Map lcpMap, Map mappingMap) { List circuitPackList = new ArrayList<>(device.nonnullCircuitPacks().values()); circuitPackList.sort(Comparator.comparing(CircuitPack::getCircuitPackName)); - if (device.getXponder() == null) { - LOG.warn("{} configuration does not contain a list of xponders", nodeId); + LOG.warn(PortMappingUtils.XPDR_LIST_IN_CONF_LOGMSG, nodeId, "not found"); + // Variables to keep track of number of line ports and client ports + int line = 1; + int client = 1; + // TODO the treatment here inside the 2 nested for-loop is very similar to the one + // when device.getXponder() != null. Some code mutualization must be considered. for (CircuitPacks cp : circuitPackList) { String circuitPackName = cp.getCircuitPackName(); if (cp.getPorts() == null) { - LOG.warn("Ports were not found for circuit pack: {}", circuitPackName); + LOG.warn(PortMappingUtils.NO_PORT_ON_CP_LOGMSG, nodeId, PortMappingUtils.FOUND, circuitPackName); continue; } List portList = new ArrayList<>(cp.nonnullPorts().values()); portList.sort(Comparator.comparing(Ports::getPortName)); for (Ports port : portList) { - if (port.getPortQual() == null) { - LOG.warn("PortQual was not found for port {} on circuit pack: {}", port.getPortName(), - circuitPackName); - continue; - } - if (PortQual.XpdrNetwork.getIntValue() == port.getPortQual().getIntValue() - && port.getPortDirection().getIntValue() == Direction.Bidirectional.getIntValue()) { - String lcp = "XPDR1-" + StringConstants.NETWORK_TOKEN + line; - lcpMap.put(circuitPackName + '+' + port.getPortName(), lcp); - mappingMap.put(lcp, createXpdrMappingObject(nodeId, port, circuitPackName, lcp, null, null, - null, null)); - line++; - } else if (PortQual.XpdrNetwork.getIntValue() == port.getPortQual().getIntValue() - && port.getPortDirection().getIntValue() != Direction.Bidirectional.getIntValue() - && port.getPartnerPort() != null - && port.getPartnerPort().getCircuitPackName() != null - && port.getPartnerPort().getPortName() != null) { - if (lcpMap.containsKey(circuitPackName + '+' + port.getPortName())) { - continue; - } - String lcp1 = "XPDR1-" + StringConstants.NETWORK_TOKEN + line; - Optional cpOpt = circuitPackList.stream() - .filter(cP -> cP.getCircuitPackName().equals(port.getPartnerPort().getCircuitPackName())) - .findFirst(); - if (cpOpt.isPresent()) { - Optional poOpt = cpOpt.get().nonnullPorts().values().stream() - .filter(p -> p.getPortName().equals(port.getPartnerPort().getPortName().toString())) - .findFirst(); - if (poOpt.isPresent()) { - Ports port2 = poOpt.get(); - if (checkPartnerPort(circuitPackName, port, port2)) { - String lcp2 = new StringBuilder("XPDR1-").append(StringConstants.NETWORK_TOKEN) - .append(line + 1).toString(); - if (!lcpMap.containsKey(lcp1) && !lcpMap.containsKey(lcp2)) { - lcpMap.put(circuitPackName + '+' + port.getPortName(), lcp1); - lcpMap.put(cpOpt.get().getCircuitPackName() + '+' + port2.getPortName(), lcp2); - mappingMap.put(lcp1, createXpdrMappingObject(nodeId, port, circuitPackName, - lcp1, lcp2, null, null, null)); - mappingMap.put(lcp2, createXpdrMappingObject(nodeId, port2, cpOpt.get() - .getCircuitPackName(), lcp2, lcp1, null, null, null)); - } else { - LOG.warn("mapping already exists for {} or {}", lcp1, lcp2); - } - line += 2; - } else { - LOG.error("port {} on {} is not a correct partner port of {} on {}", - port2.getPortName(), cpOpt.get().getCircuitPackName(), port.getPortName(), - circuitPackName); - } - } else { - LOG.error("Error fetching port {} on {} for {}", port.getPartnerPort().getPortName(), - port.getPartnerPort().getCircuitPackName(), nodeId); - } - } else { - LOG.error("Error fetching circuit-pack {} for {}", port.getPartnerPort() - .getCircuitPackName(), nodeId); - } - } else if (PortQual.XpdrClient.getIntValue() == port.getPortQual().getIntValue()) { - String lcp = "XPDR1-" + StringConstants.CLIENT_TOKEN + client; - lcpMap.put(circuitPackName + '+' + port.getPortName(), lcp); - mappingMap.put(lcp, createXpdrMappingObject(nodeId, port, circuitPackName, lcp, null, null, - null, null)); - client++; - } else { - LOG.warn("Error in the configuration of port {} of {} for {}", port.getPortName(), - circuitPackName, - nodeId); - } + int[] counters = fillXpdrLcpsMaps(line, client, nodeId, + 1, XpdrNodeTypes.Tpdr, circuitPackName, port, + circuitPackList, lcpMap, mappingMap); + line = counters[0]; + client = counters[1]; } } } else { - LOG.info("{} configuration contains a list of xponders", nodeId); - for (Xponder xponder:deviceObject.get().nonnullXponder().values()) { - line = 1; - client = 1; + LOG.info(PortMappingUtils.XPDR_LIST_IN_CONF_LOGMSG, nodeId, PortMappingUtils.FOUND); + for (Xponder xponder : device.nonnullXponder().values()) { + // Variables to keep track of number of line ports and client ports + int line = 1; + int client = 1; Integer xponderNb = xponder.getXpdrNumber().toJava(); XpdrNodeTypes xponderType = xponder.getXpdrType(); - for (XpdrPort xpdrPort : xponder.nonnullXpdrPort().values()) { - String circuitPackName = xpdrPort.getCircuitPackName(); - String portName = xpdrPort.getPortName().toString(); - // If there xponder-subtree has missing circuit-packs or ports, - // This gives a null-pointer expection, - if (device.nonnullCircuitPacks().values().stream() - .filter(cp -> cp.getCircuitPackName().equals(circuitPackName)) - .findFirst().isEmpty()) { - LOG.warn("Circuit-pack {} is missing in the device", circuitPackName); - LOG.warn("Port-mapping will continue ignoring this circuit-pack {}", circuitPackName); + for (XpdrPort xpdrPort : xponder.nonnullXpdrPort().values().stream() + .sorted((xp1, xp2) -> xp1.getIndex().compareTo(xp2.getIndex())).collect(Collectors.toList())) { + Ports port = getXpdrPorts(device, xpdrPort, nodeId); + if (port == null) { continue; } - if (device.nonnullCircuitPacks().values().stream() - .filter(cp -> cp.getCircuitPackName().equals(circuitPackName)) - .findFirst().get().nonnullPorts().values().stream() - .filter(p -> p.getPortName().equals(portName)) - .findFirst().isEmpty()) { - LOG.warn("Port {} associated with CP {} is missing in the device", portName, circuitPackName); - LOG.warn("Port-mapping will continue ignoring this port {}", portName); - continue; - } - Ports port = device.nonnullCircuitPacks().values().stream() - .filter(cp -> cp.getCircuitPackName().equals(circuitPackName)) - .findFirst().get().nonnullPorts().values().stream() - .filter(p -> p.getPortName().equals(portName)) - .findFirst().get(); - if (port.getPortQual() == null) { - LOG.warn("PortQual was not found for port {} on circuit pack: {}", port.getPortName(), - circuitPackName); - continue; - } - if ((PortQual.XpdrNetwork.getIntValue() == port.getPortQual().getIntValue() - || PortQual.SwitchNetwork.getIntValue() == port.getPortQual().getIntValue()) - && port.getPortDirection().getIntValue() == Direction.Bidirectional.getIntValue()) { - String lcp = "XPDR" + xponderNb + "-" + StringConstants.NETWORK_TOKEN + line; - lcpMap.put(circuitPackName + '+' + port.getPortName(), lcp); - mappingMap.put(lcp, createXpdrMappingObject(nodeId, port, circuitPackName, lcp, - null, null, null, xponderType)); - line++; - } else if ((PortQual.XpdrNetwork.getIntValue() == port.getPortQual().getIntValue() - || PortQual.SwitchNetwork.getIntValue() == port.getPortQual().getIntValue()) - && port.getPortDirection().getIntValue() != Direction.Bidirectional.getIntValue() - && port.getPartnerPort() != null - && port.getPartnerPort().getCircuitPackName() != null - && port.getPartnerPort().getPortName() != null) { - if (lcpMap.containsKey(circuitPackName + '+' + port.getPortName())) { - continue; - } - String lcp1 = "XPDR" + xponderNb + "-" + StringConstants.NETWORK_TOKEN + line; - - Optional cpOpt = circuitPackList.stream() - .filter(cP -> cP.getCircuitPackName().equals(port.getPartnerPort().getCircuitPackName())) - .findFirst(); - if (cpOpt.isPresent()) { - Optional poOpt = cpOpt.get().nonnullPorts().values().stream() - .filter(p -> p.getPortName().equals(port.getPartnerPort().getPortName().toString())) - .findFirst(); - if (poOpt.isPresent()) { - Ports port2 = poOpt.get(); - if (checkPartnerPort(circuitPackName, port, port2)) { - String lcp2 = new StringBuilder("XPDR").append(xponderNb).append("-").append( - StringConstants.NETWORK_TOKEN).append(line + 1).toString(); - if (!lcpMap.containsKey(lcp1) && !lcpMap.containsKey(lcp2)) { - lcpMap.put(circuitPackName + '+' + port.getPortName(), lcp1); - lcpMap.put(cpOpt.get().getCircuitPackName() + '+' + port2.getPortName(), - lcp2); - mappingMap.put(lcp1, createXpdrMappingObject(nodeId, port, circuitPackName, - lcp1, lcp2, null, null, xponderType)); - mappingMap.put(lcp2, createXpdrMappingObject(nodeId, port2, cpOpt.get() - .getCircuitPackName(), lcp2, lcp1, null, null, - xponderType)); - } else { - LOG.warn("mapping already exists for {} or {}", lcp1, lcp2); - } - line += 2; - } else { - LOG.error("port {} on {} is not a correct partner port of {} on {}", port2 - .getPortName(), cpOpt.get().getCircuitPackName(), port.getPortName(), - circuitPackName); - } - } else { - LOG.error("Error fetching port {} on {} for {}", - port.getPartnerPort().getPortName(), - port.getPartnerPort().getCircuitPackName(), nodeId); - } - } else { - LOG.error("Error fetching circuit-pack {} for {}", port.getPartnerPort() - .getCircuitPackName(), nodeId); - } - } else if (PortQual.XpdrClient.getIntValue() == port.getPortQual().getIntValue() - || PortQual.SwitchClient.getIntValue() == port.getPortQual().getIntValue()) { - String lcp = "XPDR" + xponderNb + "-" + StringConstants.CLIENT_TOKEN + client; - lcpMap.put(circuitPackName + '+' + port.getPortName(), lcp); - mappingMap.put(lcp, createXpdrMappingObject(nodeId, port, circuitPackName, lcp, - null, null, null, null)); - client++; - } else { - LOG.warn("Error in the configuration of port {} of {} for {}", port.getPortName(), - circuitPackName, nodeId); - } + int[] counters = fillXpdrLcpsMaps(line, client, nodeId, + xponderNb, xponderType, xpdrPort.getCircuitPackName(), port, + circuitPackList, lcpMap, mappingMap); + line = counters[0]; + client = counters[1]; } } } + } - if (device.getConnectionMap() != null) { - Collection connectionMap = deviceObject.get().nonnullConnectionMap().values(); - String slcp = null; - String dlcp = null; - for (ConnectionMap cm : connectionMap) { - String skey = cm.getSource().getCircuitPackName() + "+" + cm.getSource().getPortName(); - if (lcpMap.containsKey(skey)) { - slcp = lcpMap.get(skey); - } - Destination destination0 = cm.nonnullDestination().values().iterator().next(); - String dkey = destination0.getCircuitPackName() + "+" + destination0.getPortName(); - if (lcpMap.containsKey(dkey)) { - dlcp = lcpMap.get(dkey); - } - if (slcp != null) { - Mapping mapping = mappingMap.get(slcp); - mappingMap.remove(slcp); - portMapList.add(createXpdrMappingObject(nodeId, null, null, null, null, mapping, dlcp, null)); - } else { - LOG.error("Error in connection-map analysis"); - } - } - } else { - LOG.warn("No connection-map inside device configuration"); + private Ports getXpdrPorts(OrgOpenroadmDevice device, XpdrPort xpdrPort, String nodeId) { + String circuitPackName = xpdrPort.getCircuitPackName(); + String portName = xpdrPort.getPortName(); + // If there xponder-subtree has missing circuit-packs or ports, + // This gives a null-pointer expection, + Optional cpList = device.nonnullCircuitPacks().values().stream() + .filter(cp -> cp.getCircuitPackName().equals(circuitPackName)).findFirst(); + if (cpList.isEmpty()) { + LOG.warn(PortMappingUtils.MISSING_CP_LOGMSG + PortMappingUtils.PORTMAPPING_IGNORE_LOGMSG, + nodeId, circuitPackName); + return null; } - if (device.getOduSwitchingPools() != null) { - Collection oduSwithcingPools = device.nonnullOduSwitchingPools().values(); - List switchingPoolList = new ArrayList<>(); - for (OduSwitchingPools odp : oduSwithcingPools) { - Map nbMap = new HashMap<>(); - for (org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org - .openroadm.device.odu.switching.pools.NonBlockingList nbl : odp.nonnullNonBlockingList().values()) { - List lcpList = new ArrayList<>(); - if (nbl.getPortList() != null) { - for (PortList item : nbl.nonnullPortList().values()) { - String key = item.getCircuitPackName() + "+" + item.getPortName(); - if (lcpMap.containsKey(key)) { - lcpList.add(lcpMap.get(key)); - } else { - LOG.error("error : port {} of {} is not associated to a logical connection point", - item.getPortName(), item.getCircuitPackName()); - } - } - NonBlockingList nonBlockingList = new NonBlockingListBuilder() - .setNblNumber(nbl.getNblNumber()) - .setInterconnectBandwidth(nbl.getInterconnectBandwidth()) - .setInterconnectBandwidthUnit(nbl.getInterconnectBandwidthUnit()) - .setLcpList(lcpList) - .build(); - nbMap.put(nonBlockingList.key(),nonBlockingList); + Optional portsList = cpList.get().nonnullPorts().values().stream() + .filter(p -> p.getPortName().equals(portName)).findFirst(); + if (portsList.isEmpty()) { + LOG.warn(PortMappingUtils.NO_ASSOC_FOUND_LOGMSG + PortMappingUtils.PORTMAPPING_IGNORE_LOGMSG, + nodeId, portName, circuitPackName, "in the device"); + return null; + } + return portsList.get(); + } + + private List getSwitchingPoolList(OrgOpenroadmDevice device, + Map lcpMap, String nodeId) { + List switchingPoolList = new ArrayList<>(); + for (OduSwitchingPools odp : device.nonnullOduSwitchingPools().values()) { + Map nbMap = new HashMap<>(); + for (org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.org.openroadm.device.container.org + .openroadm.device.odu.switching.pools.NonBlockingList nbl : odp.nonnullNonBlockingList().values()) { + if (nbl.getPortList() == null) { + continue; + } + Set lcpList = new HashSet<>(); + for (PortList item : nbl.nonnullPortList().values()) { + String key = item.getCircuitPackName() + "+" + item.getPortName(); + if (!lcpMap.containsKey(key)) { + LOG.error(PortMappingUtils.NO_ASSOC_FOUND_LOGMSG, + nodeId, item.getPortName(), item.getCircuitPackName(), "to a logical connection point"); + continue; } + lcpList.add(lcpMap.get(key)); } - SwitchingPoolLcp splBldr = new SwitchingPoolLcpBuilder() + NonBlockingList nonBlockingList = new NonBlockingListBuilder() + .setNblNumber(nbl.getNblNumber()) + .setInterconnectBandwidth(nbl.getInterconnectBandwidth()) + .setInterconnectBandwidthUnit(nbl.getInterconnectBandwidthUnit()) + .setLcpList(lcpList) + .build(); + nbMap.put(nonBlockingList.key(), nonBlockingList); + } + switchingPoolList.add( + new SwitchingPoolLcpBuilder() .setSwitchingPoolNumber(odp.getSwitchingPoolNumber()) .setSwitchingPoolType(odp.getSwitchingPoolType()) + //TODO differs from 2.2.1 SwitchingPoolTypes.forValue(odp.getSwitchingPoolType().getIntValue()) .setNonBlockingList(nbMap) - .build(); - switchingPoolList.add(splBldr); - } - postPortMapping(nodeId, null, null, null, switchingPoolList, null); + .build()); } + return switchingPoolList; + } - if (!mappingMap.isEmpty()) { - mappingMap.forEach((k,v) -> portMapList.add(v)); - } - return true; + private boolean checkPartnerPortNotNull(Ports port) { + return (port.getPartnerPort() != null + && port.getPartnerPort().getCircuitPackName() != null + && port.getPartnerPort().getPortName() != null); } - private boolean checkPartnerPort(String circuitPackName, Ports port1, Ports port2) { - if ((Direction.Rx.getIntValue() == port1.getPortDirection().getIntValue() - && Direction.Tx.getIntValue() == port2.getPortDirection().getIntValue() - && port2.getPartnerPort() != null - && port2.getPartnerPort().getCircuitPackName() != null - && port2.getPartnerPort().getPortName() != null + private boolean checkPartnerPortNoDir(String circuitPackName, Ports port1, Ports port2) { + return (checkPartnerPortNotNull(port2) && port2.getPartnerPort().getCircuitPackName().equals(circuitPackName) - && port2.getPartnerPort().getPortName().equals(port1.getPortName())) - || - (Direction.Tx.getIntValue() == port1.getPortDirection().getIntValue() - && Direction.Rx.getIntValue() == port2.getPortDirection().getIntValue() - && port2.getPartnerPort() != null - && port2.getPartnerPort().getCircuitPackName() != null - && port2.getPartnerPort().getPortName() != null - && port2.getPartnerPort().getCircuitPackName().equals(circuitPackName) - && port2.getPartnerPort().getPortName().equals(port1.getPortName()))) { - return true; - } else { - return false; - } + && port2.getPartnerPort().getPortName().equals(port1.getPortName())); + } + + private boolean checkPartnerPort(String circuitPackName, Ports port1, Ports port2) { + return checkPartnerPortNoDir(circuitPackName, port1, port2) + && Set.of(port1.getPortDirection().getIntValue(), port2.getPortDirection().getIntValue()) + .equals(TXRX_SET); } private HashMap> getSrgCps(String deviceId, Info ordmInfo) { + .CircuitPacks>> getSrgCps(String deviceId, Info ordmInfo) { HashMap> cpPerSrg = new HashMap<>(); - Integer maxSrg; // Get value for max Srg from info subtree, required for iteration // if not present assume to be 20 (temporary) - if (ordmInfo.getMaxSrgs() != null) { - maxSrg = ordmInfo.getMaxSrgs().toJava(); - } else { - maxSrg = 20; - } + Integer maxSrg = ordmInfo.getMaxSrgs() == null ? 20 : ordmInfo.getMaxSrgs().toJava(); for (int srgCounter = 1; srgCounter <= maxSrg; srgCounter++) { List srgCps = new ArrayList<>(); - LOG.info("Getting Circuitpacks for Srg Number {}", srgCounter); - InstanceIdentifier srgIID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(SharedRiskGroup.class, new SharedRiskGroupKey(Uint16.valueOf(srgCounter))); + LOG.debug(PortMappingUtils.GETTING_CP_LOGMSG, deviceId, srgCounter); + InstanceIdentifier srgIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(SharedRiskGroup.class, new SharedRiskGroupKey(Uint16.valueOf(srgCounter))) + .build(); Optional ordmSrgObject = this.deviceTransactionManager.getDataFromDevice(deviceId, LogicalDatastoreType.OPERATIONAL, srgIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); @@ -538,92 +509,62 @@ public class PortMappingVersion710 { cpPerSrg.put(ordmSrgObject.get().getSrgNumber().toJava(), srgCps); } } - LOG.info("Device {} has {} Srg", deviceId, cpPerSrg.size()); + LOG.info(PortMappingUtils.DEVICE_HAS_LOGMSG, deviceId, cpPerSrg.size(), "SRG"); return cpPerSrg; } - //last LOG info message in this method is too long - @SuppressWarnings("checkstyle:linelength") private boolean createPpPortMapping(String nodeId, Info deviceInfo, List portMapList) { // Creating mapping data for SRG's PP - HashMap> srgCps - = getSrgCps(nodeId, deviceInfo); - for (Entry> srgCpEntry : srgCps.entrySet()) { - List cpList = - srgCps.get(srgCpEntry.getKey()); + for (Entry> + srgCpEntry : getSrgCps(nodeId, deviceInfo).entrySet()) { List keys = new ArrayList<>(); - for (org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.srg.CircuitPacks cp : cpList) { + int portIndex = 1; + for (org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev200529.srg.CircuitPacks + cp : srgCpEntry.getValue()) { String circuitPackName = cp.getCircuitPackName(); - InstanceIdentifier cpIID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(CircuitPacks.class, new CircuitPacksKey(circuitPackName)); - Optional circuitPackObject = this.deviceTransactionManager.getDataFromDevice(nodeId, - LogicalDatastoreType.OPERATIONAL, cpIID, - Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - - if (!circuitPackObject.isPresent() || (circuitPackObject.get().getPorts() == null)) { - LOG.warn("{} : Circuit pack {} not found or without ports.", nodeId, circuitPackName); - continue; - } - List portList = new ArrayList<>(circuitPackObject.get().nonnullPorts().values()); + List portList = getPortList(circuitPackName, nodeId); Collections.sort(portList, new SortPort710ByName()); - int portIndex = 1; for (Ports port : portList) { + if (!checkPortQual(port, circuitPackName, nodeId)) { + continue; + } String currentKey = circuitPackName + "-" + port.getPortName(); - if (port.getPortQual() == null) { + if (keys.contains(currentKey)) { + LOG.debug(PortMappingUtils.PORT_ALREADY_HANDLED_LOGMSG + PortMappingUtils.CANNOT_AS_LCP_LOGMSG, + nodeId, port.getPortName(), circuitPackName); continue; - } else if (PortQual.RoadmExternal.getIntValue() == port.getPortQual().getIntValue() - && Direction.Bidirectional.getIntValue() == port.getPortDirection().getIntValue() - && !keys.contains(currentKey)) { - String logicalConnectionPoint = createLogicalConnectionPort(port, srgCpEntry.getKey(), portIndex); - LOG.info("{} : Logical Connection Point for {} {} is {}", nodeId, circuitPackName, - port.getPortName(), logicalConnectionPoint); - portMapList.add(createMappingObject(nodeId, port, circuitPackName, - logicalConnectionPoint)); - portIndex++; - keys.add(currentKey); - } else if (PortQual.RoadmExternal.getIntValue() == port.getPortQual().getIntValue() - && (Direction.Rx.getIntValue() == port.getPortDirection().getIntValue() - || Direction.Tx.getIntValue() == port.getPortDirection().getIntValue()) - && !keys.contains(currentKey) - && port.getPartnerPort() != null) { - String logicalConnectionPoint1 = createLogicalConnectionPort(port, srgCpEntry.getKey(), portIndex); - LOG.info("{} : Logical Connection Point for {} {} is {}", nodeId, circuitPackName, - port.getPortName(), logicalConnectionPoint1); - InstanceIdentifier port2ID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(CircuitPacks.class, new CircuitPacksKey(port.getPartnerPort().getCircuitPackName())) - .child(Ports.class, new PortsKey(port.getPartnerPort().getPortName().toString())); - Optional port2Object = this.deviceTransactionManager.getDataFromDevice(nodeId, - LogicalDatastoreType.OPERATIONAL, port2ID, - Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (port2Object.isPresent() - && port2Object.get().getPortQual().getIntValue() - == PortQual.RoadmExternal.getIntValue()) { - Ports port2 = port2Object.get(); - if (checkPartnerPort(circuitPackName, port, port2)) { - String logicalConnectionPoint2 = createLogicalConnectionPort(port2, srgCpEntry.getKey(), portIndex); - LOG.info("{} : Logical Connection Point for {} {} is {}", nodeId, circuitPackName, - port2.getPortName(), logicalConnectionPoint2); - portMapList.add(createMappingObject(nodeId, port, circuitPackName, - logicalConnectionPoint1)); - portMapList.add(createMappingObject(nodeId,port2, - port.getPartnerPort().getCircuitPackName(), logicalConnectionPoint2)); - portIndex++; - keys.add(currentKey); - keys.add(port.getPartnerPort().getCircuitPackName() + "-" + port2.getPortName()); - } else { - LOG.error("Error with partner port configuration for port {} of {} - {}", - port.getPortName(), circuitPackName, nodeId); - portIndex++; + } + switch (port.getPortDirection()) { + case Bidirectional: + String lcp = createLogicalConnectionPort(port, srgCpEntry.getKey(), portIndex); + LOG.info(PortMappingUtils.ASSOCIATED_LCP_LOGMSG, + nodeId, port.getPortName(), circuitPackName, lcp); + portMapList.add(createMappingObject(nodeId, port, circuitPackName, lcp)); + portIndex++; + keys.add(currentKey); + break; + case Rx: + case Tx: + Ports port2 = getPartnerPort(port, circuitPackName, nodeId); + if (port2 == null) { + continue; } - } else { - LOG.error("error getting partner port {} of {} - {}", - port.getPartnerPort().getPortName().toString(), - port.getPartnerPort().getCircuitPackName(), nodeId); - continue; - } - } else { - LOG.info("{} : port {} on {} is not roadm-external or has already been handled. No logicalConnectionPoint assignment for this port.", - nodeId, port.getPortName(), circuitPackName); + String lcp1 = createLogicalConnectionPort(port, srgCpEntry.getKey(), portIndex); + LOG.info(PortMappingUtils.ASSOCIATED_LCP_LOGMSG, + nodeId, port.getPortName(), circuitPackName, lcp1); + String lcp2 = createLogicalConnectionPort(port2, srgCpEntry.getKey(),portIndex); + LOG.info(PortMappingUtils.ASSOCIATED_LCP_LOGMSG, + nodeId, port2.getPortName(), circuitPackName, lcp2); + portMapList.add(createMappingObject(nodeId, port, circuitPackName, lcp1)); + portMapList.add( + createMappingObject(nodeId ,port2, port.getPartnerPort().getCircuitPackName(), lcp2)); + portIndex++; + keys.add(currentKey); + keys.add(port.getPartnerPort().getCircuitPackName() + "-" + port2.getPortName()); + break; + default: + LOG.error(PortMappingUtils.UNSUPPORTED_DIR_LOGMSG + PortMappingUtils.CANNOT_AS_LCP_LOGMSG, + nodeId, port.getPortName(), circuitPackName, port.getPortDirection()); } } } @@ -631,33 +572,79 @@ public class PortMappingVersion710 { return true; } + private Ports getPartnerPort(Ports port, String circuitPackName, String nodeId) { + if (!checkPartnerPortNotNull(port)) { + LOG.info(PortMappingUtils.NO_VALID_PARTNERPORT_LOGMSG + PortMappingUtils.CANNOT_AS_LCP_LOGMSG, + nodeId, port.getPortName(), circuitPackName); + return null; + } + InstanceIdentifier port2ID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(CircuitPacks.class, new CircuitPacksKey(port.getPartnerPort().getCircuitPackName())) + .child(Ports.class, new PortsKey(port.getPartnerPort().getPortName())) + .build(); + Optional port2Object = this.deviceTransactionManager + .getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, port2ID, + Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (port2Object.isEmpty() + || port2Object.get().getPortQual().getIntValue() != PortQual.RoadmExternal.getIntValue()) { + LOG.error(PortMappingUtils.NOT_CORRECT_PARTNERPORT_LOGMSG + PortMappingUtils.PARTNERPORT_GET_ERROR_LOGMSG, + nodeId, port.getPartnerPort().getPortName(), port.getPartnerPort().getCircuitPackName(), + port.getPortName(), circuitPackName); + return null; + } + Ports port2 = port2Object.get(); + if (!checkPartnerPort(circuitPackName, port, port2)) { + LOG.error(PortMappingUtils.NOT_CORRECT_PARTNERPORT_LOGMSG + PortMappingUtils.PARTNERPORT_CONF_ERROR_LOGMSG, + nodeId, port2.getPortName(), port.getPartnerPort().getCircuitPackName(), + port.getPortName(), circuitPackName); + //TODO check if we really needed to increment portIndex in this condition + // if yes this block should not be in getPartnerPort and must move back to createPpPortMapping + return null; + } + return port2; + } + + private List getPortList(String circuitPackName, String nodeId) { + InstanceIdentifier cpIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(CircuitPacks.class, new CircuitPacksKey(circuitPackName)) + .build(); + Optional circuitPackObject = this.deviceTransactionManager.getDataFromDevice(nodeId, + LogicalDatastoreType.OPERATIONAL, cpIID, + Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (circuitPackObject.isEmpty()) { + LOG.warn(PortMappingUtils.MISSING_CP_LOGMSG + PortMappingUtils.PORTMAPPING_IGNORE_LOGMSG, + nodeId, circuitPackName); + return new ArrayList<>(); + } + if (circuitPackObject.get().getPorts() == null) { + LOG.warn(PortMappingUtils.NO_PORT_ON_CP_LOGMSG, nodeId, PortMappingUtils.FOUND, circuitPackName); + return new ArrayList<>(); + } + return new ArrayList<>(circuitPackObject.get().nonnullPorts().values()); + } + private String createLogicalConnectionPort(Ports port, int index, int portIndex) { - String lcp = null; - switch (port.getPortDirection()) { - case Tx: - lcp = "SRG" + index + "-PP" + portIndex + "-TX"; - break; - case Rx: - lcp = "SRG" + index + "-PP" + portIndex + "-RX"; - break; - case Bidirectional: - lcp = "SRG" + index + "-PP" + portIndex + "-TXRX"; - break; - default: - LOG.error("Unsupported port direction for port {} : {}", port, port.getPortDirection()); + if (SUFFIX.containsKey(port.getPortDirection())) { + return String.join("-", "SRG" + index, "PP" + portIndex, SUFFIX.get(port.getPortDirection())); } - return lcp; + LOG.error(PortMappingUtils.UNSUPPORTED_DIR_LOGMSG, + "createLogicalConnectionPort", port, "SRG" + index + "-PP" + portIndex, port.getPortDirection()); + return null; } private Map getMcCapabilityProfiles(String deviceId, Info ordmInfo) { Map mcCapabilityProfiles = new HashMap<>(); - InstanceIdentifier deviceIID = InstanceIdentifier.create(OrgOpenroadmDevice.class); + InstanceIdentifier deviceIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .build(); Optional deviceObject = deviceTransactionManager.getDataFromDevice(deviceId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); OrgOpenroadmDevice device = null; - if (!deviceObject.isPresent()) { - LOG.error("Impossible to get device configuration for node {}", deviceId); + if (deviceObject.isEmpty()) { + LOG.error(PortMappingUtils.CANNOT_GET_DEV_CONF_LOGMSG, deviceId); LOG.warn("MC-capabilities profile will be empty for node {}", deviceId); return mcCapabilityProfiles; } @@ -666,47 +653,52 @@ public class PortMappingVersion710 { return mcCapabilityProfiles; } - private List getDegrees(String deviceId, Info ordmInfo) { - List degrees = new ArrayList<>(); - Integer maxDegree; + @edu.umd.cs.findbugs.annotations.SuppressFBWarnings( + value = "SLF4J_UNKNOWN_ARRAY", + justification = "False positive") + private Map getDegreesMap(String deviceId, Info ordmInfo) { + Map degrees = new HashMap<>(); // Get value for max degree from info subtree, required for iteration // if not present assume to be 20 (temporary) - if (ordmInfo.getMaxDegrees() != null) { - maxDegree = ordmInfo.getMaxDegrees().toJava(); - } else { - maxDegree = 20; - } + Integer maxDegree = ordmInfo.getMaxDegrees() == null ? 20 : ordmInfo.getMaxDegrees().toJava(); for (int degreeCounter = 1; degreeCounter <= maxDegree; degreeCounter++) { - LOG.info("Getting Connection ports for Degree Number {}", degreeCounter); - InstanceIdentifier deviceIID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(Degree.class, new DegreeKey(Uint16.valueOf(degreeCounter))); + LOG.debug(PortMappingUtils.GETTING_CONPORT_LOGMSG, deviceId, degreeCounter); + InstanceIdentifier deviceIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(Degree.class, new DegreeKey(Uint16.valueOf(degreeCounter))) + .build(); Optional ordmDegreeObject = this.deviceTransactionManager.getDataFromDevice(deviceId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); if (ordmDegreeObject.isPresent()) { - degrees.add(ordmDegreeObject.get()); + degrees.put(degreeCounter, ordmDegreeObject.get()); } } - LOG.info("Device {} has {} degree", deviceId, degrees.size()); + LOG.info(PortMappingUtils.DEVICE_HAS_LOGMSG, + deviceId, degrees.size(), degrees.size() <= 1 ? "degree" : "degrees"); return degrees; } + private Map> getPerDegreePorts(String deviceId, Info ordmInfo) { + Map> conPortMap = new HashMap<>(); + getDegreesMap(deviceId, ordmInfo).forEach( + (index, degree) -> conPortMap.put(index, new ArrayList<>(degree.nonnullConnectionPorts().values()))); + return conPortMap; + } + private List getSrgs(String deviceId, Info ordmInfo) { List srgs = new ArrayList<>(); - Integer maxSrg; // Get value for max Srg from info subtree, required for iteration // if not present assume to be 20 (temporary) - if (ordmInfo.getMaxSrgs() != null) { - maxSrg = ordmInfo.getMaxSrgs().toJava(); - } else { - maxSrg = 20; - } + Integer maxSrg = ordmInfo.getMaxSrgs() == null ? 20 : ordmInfo.getMaxSrgs().toJava(); for (int srgCounter = 1; srgCounter <= maxSrg; srgCounter++) { - InstanceIdentifier srgIID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(SharedRiskGroup.class, new SharedRiskGroupKey(Uint16.valueOf(srgCounter))); + InstanceIdentifier srgIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(SharedRiskGroup.class, new SharedRiskGroupKey(Uint16.valueOf(srgCounter))) + .build(); Optional ordmSrgObject = this.deviceTransactionManager.getDataFromDevice(deviceId, LogicalDatastoreType.OPERATIONAL, srgIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); @@ -718,137 +710,115 @@ public class PortMappingVersion710 { return srgs; } - private Map> getPerDegreePorts(String deviceId, Info ordmInfo) { - Map> conPortMap = new HashMap<>(); - Integer maxDegree; - - if (ordmInfo.getMaxDegrees() != null) { - maxDegree = ordmInfo.getMaxDegrees().toJava(); - } else { - maxDegree = 20; - } - for (int degreeCounter = 1; degreeCounter <= maxDegree; degreeCounter++) { - LOG.info("Getting Connection ports for Degree Number {}", degreeCounter); - InstanceIdentifier deviceIID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(Degree.class, new DegreeKey(Uint16.valueOf(degreeCounter))); - Optional ordmDegreeObject = this.deviceTransactionManager.getDataFromDevice(deviceId, - LogicalDatastoreType.OPERATIONAL, deviceIID, - Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (ordmDegreeObject.isPresent()) { - conPortMap.put(degreeCounter, new ArrayList<>(ordmDegreeObject.get() - .nonnullConnectionPorts().values())); - } - } - LOG.info("Device {} has {} degree", deviceId, conPortMap.size()); - return conPortMap; - } - private Map getEthInterfaceList(String nodeId) { - LOG.info("It is calling get ethernet interface"); - Map cpToInterfaceMap = new HashMap<>(); - InstanceIdentifier protocoliid = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(Protocols.class); + LOG.info(PortMappingUtils.GETTING_ETH_LIST_LOGMSG, nodeId); + InstanceIdentifier protocoliid = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(Protocols.class) + .build(); Optional protocolObject = this.deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, protocoliid, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (protocolObject.isPresent() && protocolObject.get().augmentation(Protocols1.class).getLldp() != null) { - Lldp lldp = protocolObject.get().augmentation(Protocols1.class).getLldp(); - for (PortConfig portConfig : lldp.nonnullPortConfig().values()) { - if (portConfig.getAdminStatus().equals(PortConfig.AdminStatus.Txandrx)) { - InstanceIdentifier interfaceIID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(Interface.class, new InterfaceKey(portConfig.getIfName())); - Optional interfaceObject = this.deviceTransactionManager.getDataFromDevice(nodeId, - LogicalDatastoreType.OPERATIONAL, interfaceIID, Timeouts.DEVICE_READ_TIMEOUT, - Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (interfaceObject.isPresent() && (interfaceObject.get().getSupportingCircuitPackName() != null)) { - String supportingCircuitPackName = interfaceObject.get().getSupportingCircuitPackName(); - cpToInterfaceMap.put(supportingCircuitPackName, portConfig.getIfName()); - InstanceIdentifier circuitPacksIID = InstanceIdentifier - .create(OrgOpenroadmDevice.class) - .child(CircuitPacks.class, new CircuitPacksKey(supportingCircuitPackName)); - Optional circuitPackObject = this.deviceTransactionManager.getDataFromDevice( - nodeId, LogicalDatastoreType.OPERATIONAL, circuitPacksIID, Timeouts.DEVICE_READ_TIMEOUT, - Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (circuitPackObject.isPresent() && (circuitPackObject.get().getParentCircuitPack() != null)) { - cpToInterfaceMap.put(circuitPackObject.get().getParentCircuitPack().getCircuitPackName(), - portConfig.getIfName()); - } - } - } + if (protocolObject.isEmpty() || protocolObject.get().augmentation(Protocols1.class).getLldp() == null) { + LOG.warn(PortMappingUtils.PROCESSING_DONE_LOGMSG, nodeId, PortMappingUtils.CANNOT_GET_LLDP_CONF_LOGMSG); + return new HashMap<>(); + } + Map cpToInterfaceMap = new HashMap<>(); + Lldp lldp = protocolObject.get().augmentation(Protocols1.class).getLldp(); + for (PortConfig portConfig : lldp.nonnullPortConfig().values()) { + if (!portConfig.getAdminStatus().equals(PortConfig.AdminStatus.Txandrx)) { + continue; } - } else { - LOG.warn("Couldnt find port config under LLDP for Node : {}", nodeId); + InstanceIdentifier interfaceIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(Interface.class, new InterfaceKey(portConfig.getIfName())) + .build(); + Optional interfaceObject = this.deviceTransactionManager.getDataFromDevice(nodeId, + LogicalDatastoreType.OPERATIONAL, interfaceIID, Timeouts.DEVICE_READ_TIMEOUT, + Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (interfaceObject.isEmpty() || interfaceObject.get().getSupportingCircuitPackName() == null) { + continue; + } + String supportingCircuitPackName = interfaceObject.get().getSupportingCircuitPackName(); + cpToInterfaceMap.put(supportingCircuitPackName, portConfig.getIfName()); + InstanceIdentifier circuitPacksIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(CircuitPacks.class, new CircuitPacksKey(supportingCircuitPackName)) + .build(); + Optional circuitPackObject = this.deviceTransactionManager.getDataFromDevice( + nodeId, LogicalDatastoreType.OPERATIONAL, circuitPacksIID, Timeouts.DEVICE_READ_TIMEOUT, + Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (circuitPackObject.isEmpty() || circuitPackObject.get().getParentCircuitPack() == null) { + continue; + } + cpToInterfaceMap.put(circuitPackObject.get().getParentCircuitPack().getCircuitPackName(), + portConfig.getIfName()); } - LOG.info("Processiong is done.. now returning.."); + LOG.info(PortMappingUtils.PROCESSING_DONE_LOGMSG, nodeId, " - success"); return cpToInterfaceMap; } - private List getCpToDegreeList(List degrees, String nodeId, - Map interfaceList) { + private List getCpToDegreeList(Map degrees, Map interfaceList) { List cpToDegreeList = new ArrayList<>(); - for (Degree degree : degrees) { - if (degree.getCircuitPacks() != null) { - LOG.info("Inside CP to degree list"); - cpToDegreeList.addAll(degree.nonnullCircuitPacks().values().stream() - .map(cp -> createCpToDegreeObject(cp.getCircuitPackName(), - degree.getDegreeNumber().toString(), nodeId, interfaceList)) - .collect(Collectors.toList())); - } + for (Degree degree : degrees.values()) { + cpToDegreeList.addAll(degree.nonnullCircuitPacks().values().stream() + .map(cp -> createCpToDegreeObject(cp.getCircuitPackName(), + degree.getDegreeNumber().toString(), interfaceList)) + .collect(Collectors.toList())); } return cpToDegreeList; } - private List getMcCapabilitiesList(List degrees, List srgs, - Info deviceInfo, String nodeId) { - LOG.info("Getting the MC capabilities for degrees of node {}", nodeId); + private Map getMcCapabilities(Map degrees, + List srgs, Info deviceInfo, String nodeId) { + //TODO some divergences with 2.2.1 here + LOG.info(PortMappingUtils.GETTING_MC_CAPA_LOGMSG , nodeId, "degrees"); //Get all the mc-capability profiles from the device - Map mcCapabilityProfiles = getMcCapabilityProfiles(nodeId, - deviceInfo); + Map mcCapabilityProfiles = + getMcCapabilityProfiles(nodeId, deviceInfo); // Add the DEG mc-capabilities - List mcCapabilitiesList = createMcCapDegreeObject(degrees, mcCapabilityProfiles, nodeId); + Map mcCapabilities = createMcCapDegreeObject(degrees, mcCapabilityProfiles, + nodeId); // Add the SRG mc-capabilities - LOG.info("Getting the MC capabilities for SRGs of node {}", nodeId); - mcCapabilitiesList.addAll(createMcCapSrgObject(srgs, mcCapabilityProfiles, nodeId)); - - return mcCapabilitiesList; + LOG.info(PortMappingUtils.GETTING_MC_CAPA_LOGMSG , nodeId, "SRGs"); + mcCapabilities.putAll(createMcCapSrgObject(srgs, mcCapabilityProfiles, nodeId)); + return mcCapabilities; } private boolean postPortMapping(String nodeId, NodeInfo nodeInfo, List portMapList, - List cp2DegreeList, List splList, List mcCapList) { + List cp2DegreeList, List splList, + Map mcCapMap) { NodesBuilder nodesBldr = new NodesBuilder().withKey(new NodesKey(nodeId)).setNodeId(nodeId); if (nodeInfo != null) { nodesBldr.setNodeInfo(nodeInfo); } if (portMapList != null) { Map mappingMap = new HashMap<>(); + // No element in the list below should be null at this stage for (Mapping mapping: portMapList) { - if (mapping != null) { - mappingMap.put(mapping.key(), mapping); - } + mappingMap.put(mapping.key(), mapping); } nodesBldr.setMapping(mappingMap); } if (cp2DegreeList != null) { Map cpToDegreeMap = new HashMap<>(); + // No element in the list below should be null at this stage for (CpToDegree cp2Degree: cp2DegreeList) { - if (cp2Degree != null) { - cpToDegreeMap.put(cp2Degree.key(), cp2Degree); - } + cpToDegreeMap.put(cp2Degree.key(), cp2Degree); } nodesBldr.setCpToDegree(cpToDegreeMap); } if (splList != null) { Map splMap = new HashMap<>(); + // No element in the list below should be null at this stage for (SwitchingPoolLcp spl: splList) { - if (spl != null) { - splMap.put(spl.key(), spl); - } + splMap.put(spl.key(), spl); } nodesBldr.setSwitchingPoolLcp(splMap); } - if (mcCapList != null) { - nodesBldr.setMcCapabilities(mcCapList); + if (mcCapMap != null) { + nodesBldr.setMcCapabilities(mcCapMap); } Map nodesList = new HashMap<>(); Nodes nodes = nodesBldr.build(); @@ -864,156 +834,214 @@ public class PortMappingVersion710 { commit.get(); return true; } catch (InterruptedException | ExecutionException e) { - LOG.warn("Failed to post {}", network, e); + LOG.warn(PortMappingUtils.PORTMAPPING_POST_FAIL_LOGMSG, nodeId, network, e); return false; } } - private CpToDegree createCpToDegreeObject(String circuitPackName, String degreeNumber, String nodeId, - Map interfaceList) { - String interfaceName = null; - if (interfaceList.get(circuitPackName) != null) { - interfaceName = interfaceList.get(circuitPackName); - } - return new CpToDegreeBuilder().withKey(new CpToDegreeKey(circuitPackName)).setCircuitPackName(circuitPackName) - .setDegreeNumber(Uint32.valueOf(degreeNumber)).setInterfaceName(interfaceName).build(); + private CpToDegree createCpToDegreeObject(String circuitPackName, String degreeNumber, + Map interfaceList) { + return new CpToDegreeBuilder() + .withKey(new CpToDegreeKey(circuitPackName)) + .setCircuitPackName(circuitPackName) + .setDegreeNumber(Uint32.valueOf(degreeNumber)) + .setInterfaceName(interfaceList.get(circuitPackName)).build(); } - private List createMcCapDegreeObject(List degrees, - Map mcCapabilityProfileMap, String nodeId) { - List mcCapabilitiesList = new ArrayList<>(); - for (Degree degree : degrees) { - if (!degree.getMcCapabilityProfileName().isEmpty()) { - for (String mcCapabilityProfileName : degree.getMcCapabilityProfileName()) { - McCapabilityProfileKey mcKey = new McCapabilityProfileKey(mcCapabilityProfileName); - McCapabilityProfile mcCapabilityProfile = mcCapabilityProfileMap.get(mcKey); - String mcNodeName = "DEG" + degree.getDegreeNumber().toString() + "-TTP-" + mcCapabilityProfile; - McCapabilitiesBuilder mcCapabilitiesBuilder = new McCapabilitiesBuilder() - .withKey(new McCapabilitiesKey(mcNodeName)) - .setMcNodeName(mcNodeName); - mcCapabilitiesBuilder - .setCenterFreqGranularity(mcCapabilityProfile.getCenterFreqGranularity()) - .setSlotWidthGranularity(mcCapabilityProfile.getSlotWidthGranularity()); - mcCapabilitiesList.add(mcCapabilitiesBuilder.build()); - } // end for - } - else { - LOG.warn("No MC profiles are found for node {} on degree {}", nodeId, degree.getDegreeNumber()); - LOG.warn("Assuming the fixed grid capabilities for degree {}", degree.getDegreeNumber()); - LOG.warn("Assuming a default MC profile-name for degree {}", degree.getDegreeNumber()); - String mcNodeName = "DEG" + degree.getDegreeNumber().toString() + "-TTP-" + "default-profile"; + private Map createMcCapDegreeObject(Map degrees, + Map mcCapabilityProfileMap, String nodeId) { + //TODO some divergences here with 2.2.1 + Map mcCapabilitiesMap = new HashMap<>(); + for (Degree degree : degrees.values()) { + + if ((degree.getMcCapabilityProfileName() == null) || (degree.getMcCapabilityProfileName().isEmpty())) { + String mcNodeName = + PortMappingUtils.degreeTtpNodeName(degree.getDegreeNumber().toString(), "default-profile"); + LOG.warn(PortMappingUtils.NO_MC_LOGMSG, nodeId, "degree", + degree.getDegreeNumber() + " - using " + mcNodeName + " as default MC profile name"); McCapabilitiesBuilder mcCapabilitiesBuilder = new McCapabilitiesBuilder() .withKey(new McCapabilitiesKey(mcNodeName)) .setMcNodeName(mcNodeName); mcCapabilitiesBuilder .setCenterFreqGranularity(FrequencyGHz.getDefaultInstance("50")) .setSlotWidthGranularity(FrequencyGHz.getDefaultInstance("50")); + mcCapabilitiesMap.put(mcCapabilitiesBuilder.key(), mcCapabilitiesBuilder.build()); + continue; } + + for (String mcCapabilityProfileName : degree.getMcCapabilityProfileName()) { + McCapabilityProfileKey mcKey = new McCapabilityProfileKey(mcCapabilityProfileName); + McCapabilityProfile mcCapabilityProfile = mcCapabilityProfileMap.get(mcKey); + String mcNodeName = PortMappingUtils.degreeTtpNodeName(degree.getDegreeNumber().toString(), + mcCapabilityProfile.toString()); + McCapabilitiesBuilder mcCapabilitiesBuilder = new McCapabilitiesBuilder() + .withKey(new McCapabilitiesKey(mcNodeName)) + .setMcNodeName(mcNodeName); + mcCapabilitiesBuilder + .setCenterFreqGranularity(mcCapabilityProfile.getCenterFreqGranularity()) + .setSlotWidthGranularity(mcCapabilityProfile.getSlotWidthGranularity()); + mcCapabilitiesMap.put(mcCapabilitiesBuilder.key(), mcCapabilitiesBuilder.build()); + } + } - return mcCapabilitiesList; + return mcCapabilitiesMap; } - private List createMcCapSrgObject(List srgs, - Map mcCapabilityProfileMap, String nodeId) { - List mcCapabilitiesList = new ArrayList<>(); + private Map createMcCapSrgObject(List srgs, + Map mcCapabilityProfileMap, String nodeId) { + + Map mcCapabilitiesMap = new HashMap<>(); for (SharedRiskGroup srg : srgs) { - if (!srg.getMcCapabilityProfileName().isEmpty()) { - for (String mcCapabilityProfileName : srg.getMcCapabilityProfileName()) { - McCapabilityProfileKey mcKey = new McCapabilityProfileKey(mcCapabilityProfileName); - McCapabilityProfile mcCapabilityProfile = mcCapabilityProfileMap.get(mcKey); - String mcNodeName = "SRG" + srg.getSrgNumber().toString() + "-PP-" + mcCapabilityProfile; - McCapabilitiesBuilder mcCapabilitiesBuilder = new McCapabilitiesBuilder() - .withKey(new McCapabilitiesKey(mcNodeName)) - .setMcNodeName(mcNodeName); - mcCapabilitiesBuilder - .setCenterFreqGranularity(mcCapabilityProfile.getCenterFreqGranularity()) - .setSlotWidthGranularity(mcCapabilityProfile.getSlotWidthGranularity()); - mcCapabilitiesList.add(mcCapabilitiesBuilder.build()); - } // end for - } - else { - LOG.warn("No MC profiles are found for node {} on SRG {}", nodeId, srg.getSrgNumber()); - LOG.warn("Assuming the fixed grid capabilities for SRG {}", srg.getSrgNumber()); - LOG.warn("Assuming a default MC profile-name for SRG {}", srg.getSrgNumber()); + + if ((srg.getMcCapabilityProfileName() == null) || (srg.getMcCapabilityProfileName().isEmpty())) { String mcNodeName = "SRG" + srg.getSrgNumber().toString() + "-PP-" + "default-profile"; + LOG.warn(PortMappingUtils.NO_MC_LOGMSG, nodeId, "SRG", + srg.getSrgNumber() + " - using " + mcNodeName + " as default MC profile name"); McCapabilitiesBuilder mcCapabilitiesBuilder = new McCapabilitiesBuilder() .withKey(new McCapabilitiesKey(mcNodeName)) .setMcNodeName(mcNodeName); mcCapabilitiesBuilder .setCenterFreqGranularity(FrequencyGHz.getDefaultInstance("50")) .setSlotWidthGranularity(FrequencyGHz.getDefaultInstance("50")); + mcCapabilitiesMap.put(mcCapabilitiesBuilder.key(), mcCapabilitiesBuilder.build()); + continue; + } + + for (String mcCapabilityProfileName : srg.getMcCapabilityProfileName()) { + McCapabilityProfileKey mcKey = new McCapabilityProfileKey(mcCapabilityProfileName); + McCapabilityProfile mcCapabilityProfile = mcCapabilityProfileMap.get(mcKey); + String mcNodeName = "SRG" + srg.getSrgNumber().toString() + "-PP-" + mcCapabilityProfile; + McCapabilitiesBuilder mcCapabilitiesBuilder = new McCapabilitiesBuilder() + .withKey(new McCapabilitiesKey(mcNodeName)) + .setMcNodeName(mcNodeName); + mcCapabilitiesBuilder + .setCenterFreqGranularity(mcCapabilityProfile.getCenterFreqGranularity()) + .setSlotWidthGranularity(mcCapabilityProfile.getSlotWidthGranularity()); + mcCapabilitiesMap.put(mcCapabilitiesBuilder.key(), mcCapabilitiesBuilder.build()); } } - return mcCapabilitiesList; + return mcCapabilitiesMap; } private Mapping createMappingObject(String nodeId, Ports port, String circuitPackName, String logicalConnectionPoint) { - MappingBuilder mpBldr = new MappingBuilder() .withKey(new MappingKey(logicalConnectionPoint)) .setLogicalConnectionPoint(logicalConnectionPoint) .setSupportingCircuitPackName(circuitPackName) .setSupportingPort(port.getPortName()) .setPortDirection(port.getPortDirection().getName()); + if (port.getAdministrativeState() != null) { + mpBldr.setPortAdminState(port.getAdministrativeState().name()); + } + if (port.getOperationalState() != null) { + mpBldr.setPortOperState(port.getOperationalState().name()); + } - // Get OMS and OTS interface provisioned on the TTP's - if ((logicalConnectionPoint.contains(StringConstants.TTP_TOKEN) - || logicalConnectionPoint.contains(StringConstants.NETWORK_TOKEN)) && (port.getInterfaces() != null)) { - for (Interfaces interfaces : port.getInterfaces()) { - try { - Optional openRoadmInterface = this.openRoadmInterfaces.getInterface(nodeId, - interfaces.getInterfaceName()); - if (openRoadmInterface.isPresent()) { - LOG.info("interface get from device is {} and of type {}", openRoadmInterface.get().getName(), - openRoadmInterface.get().getType()); - Class interfaceType - = (Class) openRoadmInterface.get().getType(); - // Check if interface type is OMS or OTS - if (interfaceType.equals(OpenROADMOpticalMultiplex.class)) { - mpBldr.setSupportingOms(interfaces.getInterfaceName()); - } - if (interfaceType.equals(OpticalTransport.class)) { - mpBldr.setSupportingOts(interfaces.getInterfaceName()); - } - if (interfaceType.equals(OtnOdu.class)) { - mpBldr.setSupportingOdu4(interfaces.getInterfaceName()); - } - } else { - LOG.warn("Interface {} from node {} was null!", interfaces.getInterfaceName(), nodeId); - } - } catch (OpenRoadmInterfaceException ex) { - LOG.warn("Error while getting interface {} from node {}!", interfaces.getInterfaceName(), nodeId, - ex); - } - } + if ((port.getInterfaces() == null) + || (!logicalConnectionPoint.contains(StringConstants.TTP_TOKEN) + && !logicalConnectionPoint.contains(StringConstants.NETWORK_TOKEN))) { + return mpBldr.build(); } + mpBldr = updateMappingInterfaces(nodeId, mpBldr, port); return mpBldr.build(); } - private Mapping createXpdrMappingObject(String nodeId, Ports ports, String circuitPackName, + private Mapping updateMappingObject(String nodeId, Ports port, Mapping oldmapping) { + MappingBuilder mpBldr = new MappingBuilder(oldmapping); + updateMappingStates(mpBldr, port, oldmapping); + if (port.getInterfaces() == null) { + return mpBldr.build(); + } + // Get interfaces provisioned on the port + mpBldr = updateMappingInterfaces(nodeId, mpBldr, port); + return mpBldr.build(); + } + + private MappingBuilder updateMappingStates(MappingBuilder mpBldr, Ports port, Mapping oldmapping) { + if (port.getAdministrativeState() != null + && !port.getAdministrativeState().getName().equals(oldmapping.getPortAdminState())) { + mpBldr.setPortAdminState(port.getAdministrativeState().name()); + } + if (port.getOperationalState() != null + && !port.getOperationalState().getName().equals(oldmapping.getPortOperState())) { + mpBldr.setPortOperState(port.getOperationalState().name()); + } + return mpBldr; + } + + private MappingBuilder updateMappingInterfaces(String nodeId, MappingBuilder mpBldr, Ports port) { + mpBldr.setSupportingOtu4(null) + .setSupportingOdu4(null) + .setSupportingOducn(null) + .setSupportingOtucn(null); + for (Interfaces interfaces : port.getInterfaces()) { + Optional openRoadmInterface = getInterfaceFromDevice(nodeId, + interfaces.getInterfaceName()); + if (openRoadmInterface.isEmpty()) { + LOG.warn(PortMappingUtils.INTF_ISSUE_LOGMSG, + nodeId, interfaces.getInterfaceName() + "- empty interface"); + continue; + } + LOG.debug(PortMappingUtils.GOT_INTF_LOGMSG, + nodeId, openRoadmInterface.get().getName(), openRoadmInterface.get().getType()); + Class interfaceType + = (Class) openRoadmInterface.get().getType(); + // Check if interface type is OMS or OTS + if (interfaceType.equals(OpenROADMOpticalMultiplex.class)) { + mpBldr.setSupportingOms(interfaces.getInterfaceName()); + } + if (interfaceType.equals(OpticalTransport.class)) { + mpBldr.setSupportingOts(interfaces.getInterfaceName()); + } + String interfaceName = interfaces.getInterfaceName(); + if (interfaceType.equals(OtnOtu.class) + && (interfaceName.substring(interfaceName.lastIndexOf("-") + 1) + .equals("OTU4"))) { + mpBldr.setSupportingOtu4(interfaces.getInterfaceName()); + } + if ((interfaceType.equals(OtnOtu.class)) + && (interfaceName.substring(interfaceName.lastIndexOf("-") + 1) + .contains("OTUC"))) { + mpBldr.setSupportingOtucn(interfaces.getInterfaceName()); + } + if (interfaceType.equals(OtnOdu.class) + && (interfaceName.substring(interfaceName.lastIndexOf("-") + 1) + .equals("ODU4"))) { + mpBldr.setSupportingOdu4(interfaces.getInterfaceName()); + } + if ((interfaceType.equals(OtnOdu.class)) + && (interfaceName.substring(interfaceName.lastIndexOf("-") + 1) + .contains("ODUC"))) { + mpBldr.setSupportingOducn(interfaces.getInterfaceName()); + } + } + return mpBldr; + } + + private Mapping createXpdrMappingObject(String nodeId, Ports port, String circuitPackName, String logicalConnectionPoint, String partnerLcp, Mapping mapping, String connectionMapLcp, XpdrNodeTypes xpdrNodeType) { + //TODO some divergens here with 2.2.1 if (mapping != null && connectionMapLcp != null) { // update existing mapping return new MappingBuilder(mapping).setConnectionMapLcp(connectionMapLcp).build(); } + return createNewXpdrMapping(nodeId, port, circuitPackName, logicalConnectionPoint, partnerLcp, xpdrNodeType); + } - // create a new mapping - String nodeIdLcp = nodeId + "-" + logicalConnectionPoint; + private Mapping createNewXpdrMapping(String nodeId, Ports port, String circuitPackName, + String logicalConnectionPoint, String partnerLcp, XpdrNodeTypes xpdrNodeType) { MappingBuilder mpBldr = new MappingBuilder() .withKey(new MappingKey(logicalConnectionPoint)) .setLogicalConnectionPoint(logicalConnectionPoint) .setSupportingCircuitPackName(circuitPackName) - .setSupportingPort(ports.getPortName()) - .setPortDirection(ports.getPortDirection().getName()) - .setLcpHashVal(FnvUtils.fnv1_64(nodeIdLcp)); - if (ports.getPortQual() != null) { - mpBldr.setPortQual(ports.getPortQual().getName()); - } - if (ports.augmentation(Ports1.class).getPortCapabilities().getSupportedInterfaceCapability() != null) { - mpBldr.setSupportedInterfaceCapability(getSupportedIfCapability(ports)); + .setSupportingPort(port.getPortName()) + .setPortDirection(port.getPortDirection().getName()) + .setLcpHashVal(PortMappingUtils.fnv1size64(nodeId + "-" + logicalConnectionPoint)); + if (port.getPortQual() != null) { + mpBldr.setPortQual(port.getPortQual().getName()); } if (xpdrNodeType != null) { mpBldr.setXponderType(xpdrNodeType); @@ -1021,177 +1049,387 @@ public class PortMappingVersion710 { if (partnerLcp != null) { mpBldr.setPartnerLcp(partnerLcp); } + Collection supIntfCapaList = getSupIntfCapaList(port); + if (supIntfCapaList != null) { + Set> supportedIntf = new HashSet<>(); + SupportedInterfaceCapability sic1 = null; + for (SupportedInterfaceCapability sic : supIntfCapaList) { + supportedIntf.add(MappingUtilsImpl.convertSupIfCapa(sic.getIfCapType().getSimpleName())); + sic1 = sic; + } + mpBldr.setSupportedInterfaceCapability(supportedIntf); + if (port.getPortQual() == PortQual.SwitchClient + && !sic1.getOtnCapability().getMpdrClientRestriction().isEmpty()) { + // Here we assume all the supported-interfaces has the support same rates, and the + // trib-slot numbers are assumed to be the same + String mxpProfileName = sic1.getOtnCapability().getMpdrClientRestriction().get(0).getMuxpProfileName() + .stream().findFirst().get(); + // From this muxponder-profile get the min-trib-slot and the max-trib-slot + LOG.info("{}: Muxp-profile used for trib information {}", nodeId, mxpProfileName); + // This provides the tribSlot information from muxProfile + List minMaxOpucnTribSlots = getOpucnTribSlots(nodeId, mxpProfileName); + mpBldr.setMpdrRestrictions( + new MpdrRestrictionsBuilder() + .setMinTribSlot(minMaxOpucnTribSlots.get(0)) + .setMaxTribSlot(minMaxOpucnTribSlots.get(1)) + .build()); + } + } + if (port.getAdministrativeState() != null) { + mpBldr.setPortAdminState(port.getAdministrativeState().name()); + } + if (port.getOperationalState() != null) { + mpBldr.setPortOperState(port.getOperationalState().name()); + } return mpBldr.build(); } + private Collection getSupIntfCapaList(Ports port) { + return + port.augmentation(Ports1.class) == null || port.augmentation(Ports1.class).getPortCapabilities() == null + ? null + : port.augmentation(Ports1.class).getPortCapabilities().nonnullSupportedInterfaceCapability().values(); + } + + private ArrayList getOpucnTribSlots(String deviceId, String mxpProfileName) { + ArrayList minMaxOpucnTribSlots = new ArrayList<>(2); - private List> getSupportedIfCapability(Ports ports) { - Map supportedInterfaceCapabilityMap = - ports.augmentation(Ports1.class).getPortCapabilities().getSupportedInterfaceCapability(); - List> supportedInterfaceCapabilityList = new ArrayList<>(); + LOG.info("{} : Getting Min/Max Trib-slots from {}", deviceId, mxpProfileName); + InstanceIdentifier deviceIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(MuxpProfile.class, new MuxpProfileKey(mxpProfileName)) + .build(); - supportedInterfaceCapabilityMap.forEach((k, v) -> supportedInterfaceCapabilityList.add(k.getIfCapType())); - return supportedInterfaceCapabilityList; + Optional muxpProfileObject = this.deviceTransactionManager.getDataFromDevice(deviceId, + LogicalDatastoreType.OPERATIONAL, deviceIID, + Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + + Set ntwHoOduOpucnTribSlots = muxpProfileObject.get().getNetworkHoOduOpucnTribSlots(); + // Sort the tib-slots in ascending order and pick min and max + List sortedNtwHoOduOpucnTribSlots = ntwHoOduOpucnTribSlots.stream().sorted( + Comparator.comparingDouble(x -> Double.parseDouble( + x.getValue().substring(x.getValue().lastIndexOf('.') + 1)))) + .collect(Collectors.toList()); + minMaxOpucnTribSlots.add(sortedNtwHoOduOpucnTribSlots.get(0)); + minMaxOpucnTribSlots.add(sortedNtwHoOduOpucnTribSlots.get(sortedNtwHoOduOpucnTribSlots.size() - 1)); + LOG.debug("Min, Max trib slot list {}", minMaxOpucnTribSlots); + return minMaxOpucnTribSlots; } - private boolean createMcCapabilitiesList(String nodeId, Info deviceInfo, List mcCapabilitiesList) { - List degrees = getDegrees(nodeId, deviceInfo); - List srgs = getSrgs(nodeId, deviceInfo); - mcCapabilitiesList.addAll(getMcCapabilitiesList(degrees, srgs, deviceInfo, nodeId)); + private Ports getPort2(Ports port, String nodeId, String circuitPackName, StringBuilder circuitPackName2, + //circuitPackName2 will be updated by reference contrary to circuitPackName + List circuitPackList, Map lcpMap) { + if (!checkPartnerPortNotNull(port)) { + LOG.warn(PortMappingUtils.NO_VALID_PARTNERPORT_LOGMSG, nodeId, port.getPortName(), circuitPackName); + return null; + } + if (lcpMap.containsKey(circuitPackName + '+' + port.getPortName())) { + return null; + } + Optional cpOpt = circuitPackList.stream() + .filter( + cP -> cP.getCircuitPackName().equals(port.getPartnerPort().getCircuitPackName())) + .findFirst(); + if (cpOpt.isEmpty()) { + LOG.error(PortMappingUtils.MISSING_CP_LOGMSG, nodeId, port.getPartnerPort().getCircuitPackName()); + return null; + } + Optional poOpt = cpOpt.get().nonnullPorts().values().stream() + .filter(p -> p.getPortName().equals(port.getPartnerPort().getPortName())) + .findFirst(); + if (poOpt.isEmpty()) { + LOG.error(PortMappingUtils.NO_PORT_ON_CP_LOGMSG, + nodeId, port.getPartnerPort().getPortName(), port.getPartnerPort().getCircuitPackName()); + return null; + } + Ports port2 = poOpt.get(); + circuitPackName2.append(cpOpt.get().getCircuitPackName()); + if (!checkPartnerPort(circuitPackName, port, port2)) { + LOG.error(PortMappingUtils.NOT_CORRECT_PARTNERPORT_LOGMSG, + nodeId, port2.getPortName(), circuitPackName2, port.getPortName(), circuitPackName); + return null; + } + return port2; + } + + private void putXpdrLcpsInMaps(int line, String nodeId, + Integer xponderNb, XpdrNodeTypes xponderType, + String circuitPackName, String circuitPackName2, Ports port, Ports port2, + Map lcpMap, Map mappingMap) { + String lcp1 = + PortMappingUtils.createXpdrLogicalConnectionPort(xponderNb, line, StringConstants.NETWORK_TOKEN); + if (lcpMap.containsKey(lcp1)) { + LOG.warn(PortMappingUtils.UNABLE_MAPPING_LOGMSG, nodeId, "add", lcp1 + " - already exist"); + return; + } + String lcp2 = + PortMappingUtils.createXpdrLogicalConnectionPort(xponderNb, line + 1, StringConstants.NETWORK_TOKEN); + if (lcpMap.containsKey(lcp2)) { + LOG.warn(PortMappingUtils.UNABLE_MAPPING_LOGMSG, nodeId, "add", lcp2 + " - already exist"); + return; + } + lcpMap.put(circuitPackName + '+' + port.getPortName(), lcp1); + lcpMap.put(circuitPackName2 + '+' + port2.getPortName(), lcp2); + mappingMap.put(lcp1, + createXpdrMappingObject(nodeId, port, circuitPackName, lcp1, lcp2, null, null, xponderType)); + mappingMap.put(lcp2, + createXpdrMappingObject(nodeId, port2, circuitPackName2, lcp2, lcp1, null, null, xponderType)); + return; + } + + private int[] fillXpdrLcpsMaps(int line, int client, String nodeId, + Integer xponderNb, XpdrNodeTypes xponderType, + String circuitPackName, Ports port, + List circuitPackList, Map lcpMap, Map mappingMap) { + + if (port.getPortQual() == null) { + LOG.warn(PortMappingUtils.PORTQUAL_LOGMSG, nodeId, port.getPortName(), circuitPackName, "not found"); + return new int[] {line, client}; + } + + switch (port.getPortQual()) { + + case XpdrClient: + case SwitchClient: + String lcp0 = + PortMappingUtils.createXpdrLogicalConnectionPort(xponderNb, client, StringConstants.CLIENT_TOKEN); + lcpMap.put(circuitPackName + '+' + port.getPortName(), lcp0); + mappingMap.put(lcp0, + createXpdrMappingObject(nodeId, port, circuitPackName, lcp0, null, null, null, xponderType)); + client++; + break; + + case XpdrNetwork: + case SwitchNetwork: + line = fillXpdrNetworkLcpsMaps(line, nodeId, + xponderNb, xponderType, + circuitPackName, port, + circuitPackList, lcpMap, mappingMap); + break; + + default: + LOG.error(PortMappingUtils.PORTQUAL_LOGMSG, + nodeId, port.getPortName(), circuitPackName, port.getPortQual() + " not supported"); + } + return new int[] {line, client}; + } + + private int fillXpdrNetworkLcpsMaps(int line, String nodeId, + Integer xponderNb, XpdrNodeTypes xponderType, + String circuitPackName, Ports port, + List circuitPackList, Map lcpMap, Map mappingMap) { + + switch (port.getPortDirection()) { + + case Bidirectional: + String lcp = + PortMappingUtils.createXpdrLogicalConnectionPort(xponderNb, line, StringConstants.NETWORK_TOKEN); + lcpMap.put(circuitPackName + '+' + port.getPortName(), lcp); + mappingMap.put(lcp, + createXpdrMappingObject(nodeId, port, circuitPackName, lcp, null, null, null, xponderType)); + line++; + break; + + case Rx: + case Tx: + StringBuilder circuitPackName2 = new StringBuilder(); + Ports port2 = getPort2(port, nodeId, circuitPackName, circuitPackName2, + circuitPackList, lcpMap); + + if (port2 == null) { + //key already present or an error occured and was logged + return line; + } + + putXpdrLcpsInMaps(line, nodeId, xponderNb, xponderType, + circuitPackName, circuitPackName2.toString(), port, port2, + lcpMap, mappingMap); + line += 2; + break; + + default: + LOG.error(PortMappingUtils.UNSUPPORTED_DIR_LOGMSG, + nodeId, port.getPortName(), circuitPackName, port.getPortDirection()); + } + + return line; + } + + private boolean createMcCapabilitiesList(String nodeId, Info deviceInfo, + Map mcCapabilitiesMap) { + if (deviceInfo.getNodeType() == NodeTypes.Rdm) { + Map degrees = getDegreesMap(nodeId, deviceInfo); + List srgs = getSrgs(nodeId, deviceInfo); + mcCapabilitiesMap.putAll(getMcCapabilities(degrees, srgs, deviceInfo, nodeId)); + } else if ((deviceInfo.getNodeType() == NodeTypes.Xpdr)) { + Map mcProfileXpdr = getMcCapabilityProfiles(nodeId, + deviceInfo); + if (mcProfileXpdr.size() > 1) { + LOG.warn("Re-check the mc-capability-profiles for XPDR port-mapping"); + } + // Typically for a XPDR there will be only one mc-capability-profile + for (Map.Entry mcCapProfile : mcProfileXpdr.entrySet()) { + String mcNodeName = "XPDR" + "-" + "mcprofile"; + McCapabilitiesBuilder mcCapabilitiesBuilder = new McCapabilitiesBuilder() + .withKey(new McCapabilitiesKey(mcNodeName)) + .setMcNodeName(mcNodeName); + mcCapabilitiesBuilder + .setCenterFreqGranularity(mcCapProfile.getValue().getCenterFreqGranularity()) + .setSlotWidthGranularity(mcCapProfile.getValue().getSlotWidthGranularity()); + // Build and add to the Map + mcCapabilitiesMap.put(mcCapabilitiesBuilder.key(), mcCapabilitiesBuilder.build()); + LOG.info("Finished building mc-capability profile for XPDR {}", nodeId); + // Since we only have one mc-profile for XPDR, we can break the for-loop + break; + } + + } return true; } - //some LOG messages are too long - @SuppressWarnings("checkstyle:linelength") - @SuppressFBWarnings("DM_CONVERT_CASE") private boolean createTtpPortMapping(String nodeId, Info deviceInfo, List portMapList) { // Creating mapping data for degree TTP's - List degrees = getDegrees(nodeId, deviceInfo); + Map degrees = getDegreesMap(nodeId, deviceInfo); Map interfaceList = getEthInterfaceList(nodeId); - List cpToDegreeList = getCpToDegreeList(degrees, nodeId, interfaceList); - LOG.info("Map looks like this {}", interfaceList); + List cpToDegreeList = getCpToDegreeList(degrees, interfaceList); + LOG.info(PortMappingUtils.MAP_LOOKS_LOGMSG, nodeId, interfaceList); postPortMapping(nodeId, null, null, cpToDegreeList, null, null); - Map> connectionPortMap = getPerDegreePorts(nodeId, deviceInfo); - for (Entry> cpMapEntry : connectionPortMap.entrySet()) { - switch (connectionPortMap.get(cpMapEntry.getKey()).size()) { + for (Entry> cpMapEntry : getPerDegreePorts(nodeId, deviceInfo).entrySet()) { + List cpMapValue = cpMapEntry.getValue(); + ConnectionPorts cp1 = cpMapValue.get(0); + String cp1Name = cp1.getCircuitPackName(); + switch (cpMapValue.size()) { case 1: // port is bidirectional - InstanceIdentifier portID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(CircuitPacks.class, new CircuitPacksKey(connectionPortMap.get(cpMapEntry.getKey()).get(0) - .getCircuitPackName())) - .child(Ports.class, new PortsKey(connectionPortMap.get(cpMapEntry.getKey()).get(0) - .getPortName().toString())); - LOG.info("Fetching connection-port {} at circuit pack {}", connectionPortMap.get(cpMapEntry.getKey()).get(0) - .getPortName().toString(), connectionPortMap.get(cpMapEntry.getKey()).get(0).getCircuitPackName()); - Optional portObject = this.deviceTransactionManager.getDataFromDevice(nodeId, - LogicalDatastoreType.OPERATIONAL, portID, Timeouts.DEVICE_READ_TIMEOUT, - Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (portObject.isPresent()) { - Ports port = portObject.get(); - if (port.getPortQual() == null) { - continue; - } else if (PortQual.RoadmExternal.getIntValue() == port.getPortQual().getIntValue() - && Direction.Bidirectional.getIntValue() == port.getPortDirection().getIntValue()) { - String logicalConnectionPoint = new StringBuilder("DEG").append(cpMapEntry.getKey()).append("-TTP-TXRX") - .toString(); - LOG.info("{} : Logical Connection Point for {} {} is {}", nodeId, - connectionPortMap.get(cpMapEntry.getKey()).get(0).getCircuitPackName(), port.getPortName(), - logicalConnectionPoint); - portMapList.add(createMappingObject(nodeId, port, - connectionPortMap.get(cpMapEntry.getKey()).get(0).getCircuitPackName(), - logicalConnectionPoint)); - } else { - LOG.error( - "Impossible to create logical connection point for port {} of {} on node {}" - + "- Error in configuration with port-qual or port-direction", - port.getPortName(), connectionPortMap.get(cpMapEntry.getKey()).get(0).getCircuitPackName(), nodeId); - } - } else { - LOG.error("No port {} on circuit pack {} for node {}", - connectionPortMap.get(cpMapEntry.getKey()).get(0).getPortName().toString(), - connectionPortMap.get(cpMapEntry.getKey()).get(0).getCircuitPackName(), nodeId); + Ports port = getTtpPort(cp1, cp1Name, nodeId); + if (port == null) { return false; } + if (!checkTtpPort(port, cp1Name, nodeId, true)) { + continue; + } + String logicalConnectionPoint = + PortMappingUtils.degreeTtpNodeName(cpMapEntry.getKey().toString(), "TXRX"); + LOG.info(PortMappingUtils.ASSOCIATED_LCP_LOGMSG, + nodeId, port.getPortName(), cp1Name, logicalConnectionPoint); + portMapList.add(createMappingObject(nodeId, port, cp1Name, logicalConnectionPoint)); break; case 2: // ports are unidirectionals - String cp1Name = connectionPortMap.get(cpMapEntry.getKey()).get(0).getCircuitPackName(); - String cp2Name = connectionPortMap.get(cpMapEntry.getKey()).get(1).getCircuitPackName(); - InstanceIdentifier port1ID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(CircuitPacks.class, new CircuitPacksKey(cp1Name)) - .child(Ports.class, new PortsKey(connectionPortMap.get(cpMapEntry.getKey()).get(0).getPortName().toString())); - LOG.info("Fetching connection-port {} at circuit pack {}", connectionPortMap.get(cpMapEntry.getKey()).get(0) - .getPortName().toString(), cp1Name); - Optional port1Object = this.deviceTransactionManager.getDataFromDevice(nodeId, - LogicalDatastoreType.OPERATIONAL, port1ID, Timeouts.DEVICE_READ_TIMEOUT, - Timeouts.DEVICE_READ_TIMEOUT_UNIT); - InstanceIdentifier port2ID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(CircuitPacks.class, new CircuitPacksKey(cp2Name)) - .child(Ports.class, new PortsKey(connectionPortMap.get(cpMapEntry.getKey()).get(1).getPortName().toString())); - LOG.info("Fetching connection-port {} at circuit pack {}", - connectionPortMap.get(cpMapEntry.getKey()).get(1).getPortName().toString(), cp2Name); - Optional port2Object = this.deviceTransactionManager.getDataFromDevice(nodeId, - LogicalDatastoreType.OPERATIONAL, port2ID, Timeouts.DEVICE_READ_TIMEOUT, - Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (port1Object.isPresent() && port2Object.isPresent()) { - Ports port1 = port1Object.get(); - Ports port2 = port2Object.get(); - if (port1.getPortQual() == null || port2.getPortQual() == null) { - continue; - } else if ((PortQual.RoadmExternal.getIntValue() == port1.getPortQual().getIntValue() - && PortQual.RoadmExternal.getIntValue() == port2.getPortQual().getIntValue() - && Direction.Rx.getIntValue() == port1.getPortDirection().getIntValue() - && Direction.Tx.getIntValue() == port2.getPortDirection().getIntValue() - && port1.getPartnerPort() != null && port2.getPartnerPort() != null - && port1.getPartnerPort().getCircuitPackName().equals(cp2Name) - && port1.getPartnerPort().getPortName().equals(port2.getPortName()) - && port2.getPartnerPort().getCircuitPackName().equals(cp1Name) - && port2.getPartnerPort().getPortName().equals(port1.getPortName())) - || - (PortQual.RoadmExternal.getIntValue() == port1.getPortQual().getIntValue() - && PortQual.RoadmExternal.getIntValue() == port2.getPortQual().getIntValue() - && Direction.Rx.getIntValue() == port2.getPortDirection().getIntValue() - && Direction.Tx.getIntValue() == port1.getPortDirection().getIntValue() - && port1.getPartnerPort() != null && port2.getPartnerPort() != null - && port1.getPartnerPort().getCircuitPackName().equals(cp2Name) - && port1.getPartnerPort().getPortName().equals(port2.getPortName()) - && port2.getPartnerPort().getCircuitPackName().equals(cp1Name) - && port2.getPartnerPort().getPortName().equals(port1.getPortName()))) { - String logicalConnectionPoint1 = new StringBuilder("DEG").append(cpMapEntry.getKey()).append("-TTP-") - .append(port1.getPortDirection().getName().toUpperCase()).toString(); - LOG.info("{} : Logical Connection Point for {} {} is {}", nodeId, - connectionPortMap.get(cpMapEntry.getKey()).get(0).getCircuitPackName(), port1.getPortName(), - logicalConnectionPoint1); - portMapList.add(createMappingObject(nodeId, port1, connectionPortMap.get(cpMapEntry.getKey()).get(0) - .getCircuitPackName(), logicalConnectionPoint1)); - String logicalConnectionPoint2 = new StringBuilder("DEG").append(cpMapEntry.getKey()).append("-TTP-") - .append(port2.getPortDirection().getName().toUpperCase()).toString(); - LOG.info("{} : Logical Connection Point for {} {} is {}", nodeId, - connectionPortMap.get(cpMapEntry.getKey()).get(1).getCircuitPackName(), port2.getPortName(), - logicalConnectionPoint2); - portMapList.add(createMappingObject(nodeId, port2, connectionPortMap.get(cpMapEntry.getKey()).get(1) - .getCircuitPackName(), logicalConnectionPoint2)); - } else { - LOG.error( - "impossible to create logical connection point for port {} or port {} on node {} - " - + "Error in configuration with port-qual, port-direction or partner-port configuration", - port1.getPortName(), port2.getPortName(), nodeId); - } - } else { - LOG.error("No port {} on circuit pack {} for node {}", - connectionPortMap.get(cpMapEntry.getKey()).get(0).getPortName().toString(), - connectionPortMap.get(cpMapEntry.getKey()).get(0).getCircuitPackName(), nodeId); + Ports port1 = getTtpPort(cp1, cp1Name, nodeId); + if (port1 == null) { return false; } - + ConnectionPorts cp2 = cpMapValue.get(1); + String cp2Name = cp2.getCircuitPackName(); + Ports port2 = getTtpPort(cp2, cp2Name, nodeId); + if (port2 == null) { + return false; + } + if (!checkTtpPortsUnidir(port1, port2, cp1Name, cp2Name, nodeId)) { + continue; + } + String logicalConnectionPoint1 = PortMappingUtils.degreeTtpNodeName(cpMapEntry.getKey().toString(), + port1.getPortDirection().getName().toUpperCase(Locale.getDefault())); + LOG.info(PortMappingUtils.ASSOCIATED_LCP_LOGMSG, + nodeId, port1.getPortName(), cp1Name, logicalConnectionPoint1); + portMapList.add(createMappingObject(nodeId, port1, cp1Name, logicalConnectionPoint1)); + String logicalConnectionPoint2 = PortMappingUtils.degreeTtpNodeName(cpMapEntry.getKey().toString(), + port2.getPortDirection().getName().toUpperCase(Locale.getDefault())); + LOG.info(PortMappingUtils.ASSOCIATED_LCP_LOGMSG, + nodeId, port2.getPortName(), cp2Name, logicalConnectionPoint2); + portMapList.add(createMappingObject(nodeId, port2, cp2Name, logicalConnectionPoint2)); break; default: - LOG.error("Number of connection port for DEG{} on {} is incorrect", cpMapEntry.getKey(), nodeId); + LOG.error(PortMappingUtils.NOT_CORRECT_CONPORT_LOGMSG, nodeId, cpMapEntry.getKey()); continue; + //TODO should it be continue or return false ? } } return true; } - private NodeInfo createNodeInfo(Info deviceInfo) { + private Ports getTtpPort(ConnectionPorts cp, String cpName, String nodeId) { + InstanceIdentifier portID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(CircuitPacks.class, new CircuitPacksKey(cpName)) + .child(Ports.class, new PortsKey(cp.getPortName())) + .build(); + LOG.debug(PortMappingUtils.FETCH_CONNECTIONPORT_LOGMSG, nodeId, cp.getPortName(), cpName); + Optional portObject = this.deviceTransactionManager.getDataFromDevice(nodeId, + LogicalDatastoreType.OPERATIONAL, portID, Timeouts.DEVICE_READ_TIMEOUT, + Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (portObject.isEmpty()) { + LOG.error(PortMappingUtils.NO_PORT_ON_CP_LOGMSG, nodeId, cp.getPortName(), cpName); + return null; + } + return portObject.get(); + } + private boolean checkPortQual(Ports port, String cpName, String nodeId) { + if (port.getPortQual() == null) { + return false; + } + if (PortQual.RoadmExternal.getIntValue() != port.getPortQual().getIntValue()) { + //used to be LOG.error when called from createTtpPortMapping + LOG.debug(PortMappingUtils.PORT_NOT_RDMEXT_LOGMSG + PortMappingUtils.CANNOT_AS_LCP_LOGMSG, + nodeId, port.getPortName(), cpName); + return false; + } + return true; + } + + private boolean checkTtpPort(Ports port, String cpName, String nodeId, boolean bidirectional) { + if (!checkPortQual(port, cpName, nodeId)) { + return false; + } + if (Direction.Bidirectional.getIntValue() == port.getPortDirection().getIntValue() ^ bidirectional) { + // (a ^ b) makes more sense than (!a && b) here since it can also work for unidirectional links + LOG.error(PortMappingUtils.PORTDIR_ERROR_LOGMSG + PortMappingUtils.CANNOT_AS_LCP_LOGMSG, + nodeId, port.getPortName(), cpName); + return false; + } + return true; + } + + private boolean checkTtpPortsUnidir(Ports port1, Ports port2, String cp1Name, String cp2Name, String nodeId) { + if (!checkTtpPort(port1, cp1Name, nodeId, false)) { + return false; + } + if (!checkTtpPort(port2, cp2Name, nodeId, false)) { + return false; + } + if (!checkPartnerPort(cp1Name, port1, port2)) { + LOG.error(PortMappingUtils.NOT_CORRECT_PARTNERPORT_LOGMSG, + nodeId, port2.getPortName(), cp2Name, port1.getPortName(), cp1Name); + return false; + } + // Directions checks are the same for cp1 and cp2, no need to check them twice. + if (!checkPartnerPortNoDir(cp2Name, port2, port1)) { + LOG.error(PortMappingUtils.NOT_CORRECT_PARTNERPORT_LOGMSG, + nodeId, port1.getPortName(), cp1Name, port2.getPortName(), cp2Name); + return false; + } + return true; + } + + private NodeInfo createNodeInfo(Info deviceInfo) { if (deviceInfo.getNodeType() == null) { // TODO make mandatory in yang - LOG.error("Node type field is missing"); + LOG.error(PortMappingUtils.NODE_TYPE_LOGMSG, deviceInfo.getNodeId(), "field missing"); return null; } - NodeInfoBuilder nodeInfoBldr = new NodeInfoBuilder() - .setOpenroadmVersion(OpenroadmVersion._710) + .setOpenroadmVersion(OpenroadmNodeVersion._71) + .setNodeClli( + deviceInfo.getClli() == null || deviceInfo.getClli().isEmpty() + ? "defaultCLLI" + : deviceInfo.getClli()) .setNodeType(deviceInfo.getNodeType()); // TODO: 221 versions expects an int value - need to check whether it is bug or an evolution here - if (deviceInfo.getClli() != null && !deviceInfo.getClli().isEmpty()) { - nodeInfoBldr.setNodeClli(deviceInfo.getClli()); - } else { - nodeInfoBldr.setNodeClli("defaultCLLI"); - } if (deviceInfo.getModel() != null) { nodeInfoBldr.setNodeModel(deviceInfo.getModel()); } @@ -1201,7 +1439,25 @@ public class PortMappingVersion710 { if (deviceInfo.getIpAddress() != null) { nodeInfoBldr.setNodeIpAddress(deviceInfo.getIpAddress()); } - return nodeInfoBldr.build(); } + + private String getLcpFromCpAndPort(Map mappings, String cpName, String portName) { + for (Mapping mapping : mappings.values()) { + if (cpName.equals(mapping.getSupportingCircuitPackName()) + && portName.equals(mapping.getSupportingPort())) { + return mapping.getLogicalConnectionPoint(); + } + } + return null; + } + + private Optional getInterfaceFromDevice(String nodeId, String interfaceName) { + InstanceIdentifier interfacesIID = InstanceIdentifier + .builderOfInherited(OrgOpenroadmDeviceData.class, OrgOpenroadmDevice.class) + .child(Interface.class, new InterfaceKey(interfaceName)) + .build(); + return deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, + interfacesIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + } }