X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=common%2Fyang-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fyangtools%2Fyang%2Fcommon%2FUnresolvedQName.java;fp=common%2Fyang-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fyangtools%2Fyang%2Fcommon%2FUnresolvedQName.java;h=0782626a7d5b5ecd725f678b18a2ca71cb5f2be7;hb=b0fa6a8ad00b48326aa1b9a746e01c079830c7ba;hp=73452c02233bda04d9c4846b71c40fd98db5b6b4;hpb=7e7320764df1c5d72330cdfdd4d3d62421e8c19a;p=yangtools.git diff --git a/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/UnresolvedQName.java b/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/UnresolvedQName.java index 73452c0223..0782626a7d 100644 --- a/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/UnresolvedQName.java +++ b/common/yang-common/src/main/java/org/opendaylight/yangtools/yang/common/UnresolvedQName.java @@ -12,7 +12,6 @@ import static java.util.Objects.requireNonNull; import com.google.common.base.MoreObjects; import com.google.common.collect.Interner; import com.google.common.collect.Interners; -import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.io.DataInput; import java.io.DataOutput; import java.io.IOException; @@ -82,12 +81,10 @@ public abstract sealed class UnresolvedQName extends AbstractQName { } @Override - @SuppressFBWarnings(value = "ES_COMPARING_STRINGS_WITH_EQ", justification = "Interning identity check") public Qualified intern() { // Make sure to intern the string and check whether it refers to the same name as we are - final String name = getLocalName(); - final String internedName = name.intern(); - final Qualified template = internedName == name ? this : new Qualified(prefix.intern(), internedName); + final String internedName = DoNotLeakSpotbugs.internedString(getLocalName()); + final Qualified template = internedName == null ? this : new Qualified(prefix.intern(), internedName); return INTERNER.intern(template); } @@ -172,12 +169,10 @@ public abstract sealed class UnresolvedQName extends AbstractQName { } @Override - @SuppressFBWarnings(value = "ES_COMPARING_STRINGS_WITH_EQ", justification = "Interning identity check") public Unqualified intern() { // Make sure to intern the string and check whether it refers to the same name as we are - final String name = getLocalName(); - final String internedName = name.intern(); - final Unqualified template = internedName == name ? this : new Unqualified(internedName); + final var internedName = DoNotLeakSpotbugs.internedString(getLocalName()); + final var template = internedName == null ? this : new Unqualified(internedName); return INTERNER.intern(template); }