X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=csit%2Flibraries%2FShardStability.robot;h=26ef6cdda4220e6a2cd8982443c03bf71a7473eb;hb=2e535decaa53790a60bb17860553e56cae8c06df;hp=44ab75f403f00660c536c515dc266d17fb259bbf;hpb=9289a0f0c7bfd8af0612fd0d9fab13be95d45579;p=integration%2Ftest.git

diff --git a/csit/libraries/ShardStability.robot b/csit/libraries/ShardStability.robot
index 44ab75f403..26ef6cdda4 100644
--- a/csit/libraries/ShardStability.robot
+++ b/csit/libraries/ShardStability.robot
@@ -1,83 +1,119 @@
 *** Settings ***
-Documentation     Robot library to monitor shard stability.
+Documentation       Robot library to monitor shard stability.
 ...
-...               Copyright (c) 2017 Cisco Systems, Inc. and others. All rights reserved.
+...                 Copyright (c) 2017 Cisco Systems, Inc. and others. All rights reserved.
 ...
-...               This program and the accompanying materials are made available under the
-...               terms of the Eclipse Public License v1.0 which accompanies this distribution,
-...               and is available at http://www.eclipse.org/legal/epl-v10.html
+...                 This program and the accompanying materials are made available under the
+...                 terms of the Eclipse Public License v1.0 which accompanies this distribution,
+...                 and is available at http://www.eclipse.org/legal/epl-v10.html
 ...
-...               This is a "stateful" library to monitor shard leaders and candidates. During the initial phase
-...               all leaders and followeres are stored and then checked with new value on verify.
-...               TODO: investigate whether pure stateless library would be easier or harder to use.
+...                 This is a "stateful" library to monitor shard leaders and candidates. During the initial phase
+...                 all leaders and followeres are stored and then checked with new value on verify.
+...                 TODO: investigate whether pure stateless library would be easier or harder to use.
 ...
-...               Requirements: ClusterManagement.ClusterManagement_Setup must be called before Shard_Stability_Init
+...                 Requirements: ClusterManagement.ClusterManagement_Setup must be called before Shard_Stability_Init
 ...
-...               It is possible to use it for stateless comparison.
-...               Variable @{DEFAULT_SHARD_LIST} contains default module shards.
-Library           Collections
-Library           String
-Resource          ${CURDIR}/ClusterManagement.robot
+...                 It is possible to use it for stateless comparison.
+...                 Variable @{DEFAULT_SHARD_LIST} contains default module shards.
+
+Library             Collections
+Library             String
+Resource            ${CURDIR}/ClusterManagement.robot
+
 
 *** Variables ***
 &{stored_details}
-@{DEFAULT_SHARD_LIST}    default:config    default:operational    topology:config    topology:operational    inventory:config    inventory:operational    entity-ownership:operational
+@{DEFAULT_SHARD_LIST}
+...                         default:config
+...                         default:operational
+...                         topology:config
+...                         topology:operational
+...                         inventory:config
+...                         inventory:operational
+...                         entity-ownership:operational
+
 
 *** Keywords ***
 Shards_Stability_Init_Details
-    [Arguments]    ${shard_list}    ${member_index_list}=${EMPTY}
     [Documentation]    Initialize data for given shards.
     ...    ${shard_list} should be initialized as @{list} shard_name1:shard_type1 shard_name2:shard..
+    [Arguments]    ${shard_list}    ${member_index_list}=${EMPTY}
     ${shards_details} =    Shards_Stability_Get_Details    ${shard_list}    member_index_list=${member_index_list}
     BuiltIn.Set_Suite_Variable    ${stored_details}    ${shards_details}
 
 Shards_Stability_Get_Details
-    [Arguments]    ${shard_list}    ${member_index_list}=${EMPTY}    ${verify_restconf}=False    ${http_timeout}=${EMPTY}
     [Documentation]    Return shard details stored in dictionary.
     ...    ${shard_list} should be initialized as @{list} shard_name1:shard_type1 shard_name2:shard..
-    &{shards_details}    BuiltIn.Create_Dictionary
-    CompareStream.Run_Keyword_If_At_Least_Phosphorus    Collections.Remove_Values_From_List    ${shard_list}    entity-ownership:operational
+    [Arguments]    ${shard_list}    ${member_index_list}=${EMPTY}    ${verify_restconf}=False    ${http_timeout}=${EMPTY}
+    &{shards_details} =    BuiltIn.Create_Dictionary
+    CompareStream.Run_Keyword_If_At_Least_Phosphorus
+    ...    Collections.Remove_Values_From_List
+    ...    ${shard_list}
+    ...    entity-ownership:operational
     FOR    ${shard_details}    IN    @{shard_list}
-        ${shard_name}    ${shard_type}    String.Split_String    ${shard_details}    separator=:
-        ${leader}    ${followers}    ClusterManagement.Get_Leader_And_Followers_For_Shard    shard_name=${shard_name}    shard_type=${shard_type}    member_index_list=${member_index_list}
-        ...    verify_restconf=${verify_restconf}    http_timeout=${http_timeout}
+        ${shard_name}    ${shard_type} =    String.Split_String    ${shard_details}    separator=:
+        ${leader}    ${followers} =    ClusterManagement.Get_Leader_And_Followers_For_Shard
+        ...    shard_name=${shard_name}
+        ...    shard_type=${shard_type}
+        ...    member_index_list=${member_index_list}
+        ...    verify_restconf=${verify_restconf}
+        ...    http_timeout=${http_timeout}
         Collections.Sort_List    ${followers}
         Collections.Set_To_Dictionary    ${shards_details}    ${shard_name}_${shard_type}_leader=${leader}
         Collections.Set_To_Dictionary    ${shards_details}    ${shard_name}_${shard_type}_followers=${followers}
     END
-    BuiltIn.Return_From_Keyword    ${shards_details}
+    RETURN    ${shards_details}
 
 Shards_Stability_Verify
-    [Arguments]    ${shard_list}    ${member_index_list}=${EMPTY}
     [Documentation]    Verify that present details as the same as the stored one from Shards_Stability_Init_Details
+    [Arguments]    ${shard_list}    ${member_index_list}=${EMPTY}
     ${present_details} =    Shards_Stability_Get_Details    ${shard_list}    member_index_list=${member_index_list}
     Shards_Stability_Compare_Same    ${present_details}
 
 Shards_Stability_Compare_Same
-    [Arguments]    ${details}    ${stateless_details}=${EMPTY}
     [Documentation]    Compare two distionaries created by Shards_Stability_Get_Details
-    ${exp_details} =    BuiltIn.Set_Variable_If    "${stateless_details}" == "${EMPTY}"    ${stored_details}    ${stateless_details}
+    [Arguments]    ${details}    ${stateless_details}=${EMPTY}
+    ${exp_details} =    BuiltIn.Set_Variable_If
+    ...    "${stateless_details}" == "${EMPTY}"
+    ...    ${stored_details}
+    ...    ${stateless_details}
     Collections.Log_Dictionary    ${exp_details}
     Collections.Log_Dictionary    ${details}
     Collections.Dictionaries_Should_Be_Equal    ${exp_details}    ${details}
 
 Set_Shard_Location
-    [Arguments]    ${requested_leader_idx}
     [Documentation]    Move default/topology config/operational shard location to local or remote node as requested
     ...    towards the given member.
+    [Arguments]    ${requested_leader_idx}
     ClusterAdmin.Make_Leader_Local    ${requested_leader_idx}    default    config
     ClusterAdmin.Make_Leader_Local    ${requested_leader_idx}    default    operational
     ClusterAdmin.Make_Leader_Local    ${requested_leader_idx}    topology    config
     ClusterAdmin.Make_Leader_Local    ${requested_leader_idx}    topology    operational
 
 Verify_Shard_Leader_Located_As_Expected
-    [Arguments]    ${expected_leader_idx}    ${http_timeout}=${EMPTY}
     [Documentation]    Verify default/topology config/operational shard leader location is as expected
-    ${leader}    ${follower_list} =    ClusterManagement.Get_Leader_And_Followers_For_Shard    shard_name=default    shard_type=config    verify_restconf=False    http_timeout=${http_timeout}
+    [Arguments]    ${expected_leader_idx}    ${http_timeout}=${EMPTY}
+    ${leader}    ${follower_list} =    ClusterManagement.Get_Leader_And_Followers_For_Shard
+    ...    shard_name=default
+    ...    shard_type=config
+    ...    verify_restconf=False
+    ...    http_timeout=${http_timeout}
     BuiltIn.Should_Be_Equal_As_Numbers    ${expected_leader_idx}    ${leader}
-    ${leader}    ${follower_list} =    ClusterManagement.Get_Leader_And_Followers_For_Shard    shard_name=default    shard_type=operational    verify_restconf=False    http_timeout=${http_timeout}
+    ${leader}    ${follower_list} =    ClusterManagement.Get_Leader_And_Followers_For_Shard
+    ...    shard_name=default
+    ...    shard_type=operational
+    ...    verify_restconf=False
+    ...    http_timeout=${http_timeout}
     BuiltIn.Should_Be_Equal_As_Numbers    ${expected_leader_idx}    ${leader}
-    ${leader}    ${follower_list} =    ClusterManagement.Get_Leader_And_Followers_For_Shard    shard_name=topology    shard_type=config    verify_restconf=False    http_timeout=${http_timeout}
+    ${leader}    ${follower_list} =    ClusterManagement.Get_Leader_And_Followers_For_Shard
+    ...    shard_name=topology
+    ...    shard_type=config
+    ...    verify_restconf=False
+    ...    http_timeout=${http_timeout}
     BuiltIn.Should_Be_Equal_As_Numbers    ${expected_leader_idx}    ${leader}
-    ${leader}    ${follower_list} =    ClusterManagement.Get_Leader_And_Followers_For_Shard    shard_name=topology    shard_type=operational    verify_restconf=False    http_timeout=${http_timeout}
+    ${leader}    ${follower_list} =    ClusterManagement.Get_Leader_And_Followers_For_Shard
+    ...    shard_name=topology
+    ...    shard_type=operational
+    ...    verify_restconf=False
+    ...    http_timeout=${http_timeout}
     BuiltIn.Should_Be_Equal_As_Numbers    ${expected_leader_idx}    ${leader}