X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=csit%2Flibraries%2Fcontroller%2FDrbCommons.robot;h=d835db8585c63735a4345724b051bfb24b8164e3;hb=39de3404b2681d425af82a66f7f665ecd4a2da3a;hp=16835d2440c1fdafdb9245747e0fc5cfed5cfd19;hpb=0242bbd450227b00d5d8c351b6e97b4810f3dfc2;p=integration%2Ftest.git diff --git a/csit/libraries/controller/DrbCommons.robot b/csit/libraries/controller/DrbCommons.robot index 16835d2440..d835db8585 100644 --- a/csit/libraries/controller/DrbCommons.robot +++ b/csit/libraries/controller/DrbCommons.robot @@ -1,12 +1,12 @@ *** Settings *** Documentation DOMRpcBroker testing: Common keywords -... +... ... Copyright (c) 2017 Cisco Systems, Inc. and others. All rights reserved. -... +... ... This program and the accompanying materials are made available under the ... terms of the Eclipse Public License v1.0 which accompanies this distribution, ... and is available at http://www.eclipse.org/legal/epl-v10.html -... +... ... The aim of this resource is to groups reusable blocks of commands into ... keywords. It should be initiated by DrbCommons_Init. It creates ... ${all_indices}, ${registered_indices}, ${nonregistered_indices} and @@ -20,11 +20,11 @@ Documentation DOMRpcBroker testing: Common keywords ... constant from isolated node with regirered rpc is ... invalid ... ${active_indices} - list of indexes of non-isolated, non-stopped/killed nodes -... +... ... Akka can create spurious UnreachableMember events, see ... https://bugs.opendaylight.org/show_bug.cgi?id=8430 ... so some keywords contain "tolerance" argument which applies BuiltIn.Wait_Until_Keyword_Succeeds. -... +... ... The delay before subsequent ReachableMember is significantly higher than ... RPC registration delay documented at ... http://docs.opendaylight.org/en/latest/developer-guide/controller.html#rpcs-and-cluster @@ -84,26 +84,30 @@ Unregister_Action_And_Update_Possible_Constants Register_Rpc_On_Nodes [Arguments] ${index_list} [Documentation] Register global rpc on given nodes of the cluster. - : FOR ${index} IN @{index_list} - \ Register_Rpc_And_Update_Possible_Constants ${index} + FOR ${index} IN @{index_list} + Register_Rpc_And_Update_Possible_Constants ${index} + END Unregister_Rpc_On_Nodes [Arguments] ${index_list} [Documentation] Unregister global rpc on given nodes of the cluster. - : FOR ${index} IN @{index_list} - \ Unregister_Rpc_And_Update_Possible_Constants ${index} + FOR ${index} IN @{index_list} + Unregister_Rpc_And_Update_Possible_Constants ${index} + END Register_Action_On_Nodes [Arguments] ${index_list} [Documentation] Register global rpc on given nodes of the cluster. - : FOR ${index} IN @{index_list} - \ Register_Action_And_Update_Possible_Constants ${index} + FOR ${index} IN @{index_list} + Register_Action_And_Update_Possible_Constants ${index} + END Unregister_Action_On_Nodes [Arguments] ${index_list} [Documentation] Unregister global rpc on given nodes of the cluster. - : FOR ${index} IN @{index_list} - \ Unregister_Action_And_Update_Possible_Constants ${index} + FOR ${index} IN @{index_list} + Unregister_Action_And_Update_Possible_Constants ${index} + END Verify_Constant_On_Registered_Node [Arguments] ${member_index} @@ -138,20 +142,23 @@ Verify_Contexted_Constant_On_Unregistered_Node Verify_Constant_On_Registered_Nodes [Arguments] ${index_list} [Documentation] Verify that the rpc response comes from the local node for every node in the list. - : FOR ${index} IN @{index_list} - \ Verify_Constant_On_Registered_Node ${index} + FOR ${index} IN @{index_list} + Verify_Constant_On_Registered_Node ${index} + END Verify_Contexted_Constant_On_Registered_Nodes [Arguments] ${index_list} [Documentation] Verify that the rpc response comes from the local node for every node in the list. - : FOR ${index} IN @{index_list} - \ Verify_Contexted_Constant_On_Registered_Node ${index} + FOR ${index} IN @{index_list} + Verify_Contexted_Constant_On_Registered_Node ${index} + END Verify_Constant_On_Unregistered_Nodes [Arguments] ${index_list} [Documentation] Verify that the rpc response comes from the remote node for every node in the list. - : FOR ${index} IN @{index_list} - \ Verify_Constant_On_Unregistered_Node ${index} + FOR ${index} IN @{index_list} + Verify_Constant_On_Unregistered_Node ${index} + END Verify_Constant_On_Active_Nodes [Arguments] ${tolerance}=${BUG_8430_TOLERANCE} @@ -159,9 +166,10 @@ Verify_Constant_On_Active_Nodes ... As a workaround for Bug 8430, \${tolerance} can be set as duration (number of seconds) for WUKS. # TODO: Rename most Verify_* keywords to Check_* and use the Verify prefix for the WUKS versions. BuiltIn.Run_Keyword_And_Return_If ${tolerance} BuiltIn.Wait_Until_Keyword_Succeeds ${tolerance} 1s Verify_Constant_On_Active_Nodes tolerance=0 - : FOR ${index} IN @{active_indices} - \ BuiltIn.Run_Keyword_If ${index} in ${registered_indices} Verify_Constant_On_Registered_Node ${index} - \ ... ELSE Verify_Constant_On_Unregistered_Node ${index} + FOR ${index} IN @{active_indices} + BuiltIn.Run_Keyword_If ${index} in ${registered_indices} Verify_Constant_On_Registered_Node ${index} + ... ELSE Verify_Constant_On_Unregistered_Node ${index} + END Verify_Contexted_Constant_On_Active_Nodes [Arguments] ${tolerance}=${BUG_8430_TOLERANCE} @@ -169,16 +177,18 @@ Verify_Contexted_Constant_On_Active_Nodes ... As a workaround for Bug 8430, \${tolerance} can be set as duration (number of seconds) for WUKS. # TODO: Rename most Verify_* keywords to Check_* and use the Verify prefix for the WUKS versions. BuiltIn.Run_Keyword_And_Return_If ${tolerance} BuiltIn.Wait_Until_Keyword_Succeeds ${tolerance} 1s Verify_Contexted_Constant_On_Active_Nodes tolerance=0 - : FOR ${index} IN @{active_indices} - \ BuiltIn.Run_Keyword_If ${index} in ${registered_indices} Verify_Contexted_Constant_On_Registered_Node ${index} - \ ... ELSE Verify_Contexted_Constant_On_Unregistered_Node ${index} + FOR ${index} IN @{active_indices} + BuiltIn.Run_Keyword_If ${index} in ${registered_indices} Verify_Contexted_Constant_On_Registered_Node ${index} + ... ELSE Verify_Contexted_Constant_On_Unregistered_Node ${index} + END Verify_Expected_Constant_On_Nodes [Arguments] ${index_list} ${exp_constant} [Documentation] Verify that the rpc response comes only from one node only for every node in the list. - : FOR ${index} IN @{index_list} - \ ${const_index} = Get_Constant_Index_From_Node ${index} - \ BuiltIn.Should_Be_Equal_As_Strings ${exp_constant} ${CONSTANT_PREFIX}${const_index} + FOR ${index} IN @{index_list} + ${const_index} = Get_Constant_Index_From_Node ${index} + BuiltIn.Should_Be_Equal_As_Strings ${exp_constant} ${CONSTANT_PREFIX}${const_index} + END Get_Constant_Index_From_Node [Arguments] ${member_index}