X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=dom%2Fmdsal-dom-inmemory-datastore%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fmdsal%2Fdom%2Fstore%2Finmemory%2FInMemoryDOMStoreThreePhaseCommitCohort.java;h=ef1a61859134db94e985f4e7f8e8907662f1b4e2;hb=5e09dedf6a5423744d9d56a464adf3664459db6d;hp=d7de64d02c33581adf89ce601485c065b4bd1cec;hpb=11408d627adca7eb71ac956c3ad01f75b6b91596;p=mdsal.git diff --git a/dom/mdsal-dom-inmemory-datastore/src/main/java/org/opendaylight/mdsal/dom/store/inmemory/InMemoryDOMStoreThreePhaseCommitCohort.java b/dom/mdsal-dom-inmemory-datastore/src/main/java/org/opendaylight/mdsal/dom/store/inmemory/InMemoryDOMStoreThreePhaseCommitCohort.java index d7de64d02c..ef1a618591 100644 --- a/dom/mdsal-dom-inmemory-datastore/src/main/java/org/opendaylight/mdsal/dom/store/inmemory/InMemoryDOMStoreThreePhaseCommitCohort.java +++ b/dom/mdsal-dom-inmemory-datastore/src/main/java/org/opendaylight/mdsal/dom/store/inmemory/InMemoryDOMStoreThreePhaseCommitCohort.java @@ -14,11 +14,13 @@ import static java.util.Objects.requireNonNull; import com.google.common.annotations.VisibleForTesting; import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; +import org.opendaylight.mdsal.common.api.CommitInfo; import org.opendaylight.mdsal.common.api.OptimisticLockFailedException; import org.opendaylight.mdsal.common.api.TransactionCommitFailedException; import org.opendaylight.mdsal.dom.spi.store.AbstractDOMStoreTransaction; import org.opendaylight.mdsal.dom.spi.store.DOMStoreThreePhaseCommitCohort; import org.opendaylight.mdsal.dom.spi.store.SnapshotBackedWriteTransaction; +import org.opendaylight.yangtools.yang.common.Empty; import org.opendaylight.yangtools.yang.data.tree.api.ConflictingModificationAppliedException; import org.opendaylight.yangtools.yang.data.tree.api.DataTreeCandidate; import org.opendaylight.yangtools.yang.data.tree.api.DataTreeModification; @@ -28,7 +30,7 @@ import org.slf4j.LoggerFactory; class InMemoryDOMStoreThreePhaseCommitCohort implements DOMStoreThreePhaseCommitCohort { private static final Logger LOG = LoggerFactory.getLogger(InMemoryDOMStoreThreePhaseCommitCohort.class); - private static final ListenableFuture SUCCESSFUL_FUTURE = Futures.immediateFuture(null); + private static final ListenableFuture SUCCESSFUL_FUTURE = Futures.immediateFuture(Empty.value()); private static final ListenableFuture CAN_COMMIT_FUTURE = Futures.immediateFuture(Boolean.TRUE); private final SnapshotBackedWriteTransaction transaction; @@ -91,7 +93,7 @@ class InMemoryDOMStoreThreePhaseCommitCohort implements DOMStoreThreePhaseCommit @SuppressWarnings("checkstyle:IllegalCatch") @Override - public final ListenableFuture preCommit() { + public final ListenableFuture preCommit() { try { candidate = store.prepare(modification); return SUCCESSFUL_FUTURE; @@ -102,7 +104,7 @@ class InMemoryDOMStoreThreePhaseCommitCohort implements DOMStoreThreePhaseCommit } @Override - public final ListenableFuture abort() { + public final ListenableFuture abort() { candidate = null; return SUCCESSFUL_FUTURE; } @@ -112,15 +114,12 @@ class InMemoryDOMStoreThreePhaseCommitCohort implements DOMStoreThreePhaseCommit } @Override - public ListenableFuture commit() { + public ListenableFuture commit() { checkState(candidate != null, "Proposed subtree must be computed"); - /* - * The commit has to occur atomically with regard to listener - * registrations. - */ + // The commit has to occur atomically with regard to listener registrations. store.commit(candidate); - return SUCCESSFUL_FUTURE; + return CommitInfo.emptyFluentFuture(); } }