X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=dom%2Fmdsal-dom-spi%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fmdsal%2Fdom%2Fspi%2Fstore%2FSnapshotBackedReadTransaction.java;h=cfac80726230acc3bfdd6ba41d730a058c7277e7;hb=465c7e6c9d5bcaa647cf2e86aa3e1c65fc0d591d;hp=16539ccc19e7c304e740b8c48874955a291ac928;hpb=6a8c4d89d24cb6a819949b3782965f2cde1d20fe;p=mdsal.git diff --git a/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/store/SnapshotBackedReadTransaction.java b/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/store/SnapshotBackedReadTransaction.java index 16539ccc19..cfac807262 100644 --- a/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/store/SnapshotBackedReadTransaction.java +++ b/dom/mdsal-dom-spi/src/main/java/org/opendaylight/mdsal/dom/spi/store/SnapshotBackedReadTransaction.java @@ -9,13 +9,12 @@ package org.opendaylight.mdsal.dom.spi.store; import static com.google.common.base.Preconditions.checkNotNull; -import org.opendaylight.mdsal.common.api.ReadFailedException; - import com.google.common.annotations.Beta; import com.google.common.base.Optional; import com.google.common.base.Preconditions; import com.google.common.util.concurrent.CheckedFuture; import com.google.common.util.concurrent.Futures; +import org.opendaylight.mdsal.common.api.ReadFailedException; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode; import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeSnapshot; @@ -23,16 +22,15 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** - * - * Implementation of read-only transaction backed by {@link DataTreeSnapshot} - * * Implementation of read-only transaction backed by {@link DataTreeSnapshot} which delegates most * of its calls to similar methods provided by underlying snapshot. * * @param identifier type */ @Beta -public final class SnapshotBackedReadTransaction extends AbstractDOMStoreTransaction implements DOMStoreReadTransaction { +public final class SnapshotBackedReadTransaction extends + AbstractDOMStoreTransaction implements DOMStoreReadTransaction { + private static final Logger LOG = LoggerFactory.getLogger(SnapshotBackedReadTransaction.class); private volatile DataTreeSnapshot stableSnapshot; @@ -55,6 +53,7 @@ public final class SnapshotBackedReadTransaction extends AbstractDOMStoreTran stableSnapshot = null; } + @SuppressWarnings("checkstyle:IllegalCatch") @Override public CheckedFuture>, ReadFailedException> read(final YangInstanceIdentifier path) { LOG.debug("Tx: {} Read: {}", getIdentifier(), path); @@ -67,9 +66,9 @@ public final class SnapshotBackedReadTransaction extends AbstractDOMStoreTran try { return Futures.immediateCheckedFuture(snapshot.readNode(path)); - } catch (final Exception e) { + } catch (Exception e) { LOG.error("Tx: {} Failed Read of {}", getIdentifier(), path, e); - return Futures.immediateFailedCheckedFuture(new ReadFailedException("Read failed",e)); + return Futures.immediateFailedCheckedFuture(new ReadFailedException("Read failed", e)); } } @@ -80,7 +79,7 @@ public final class SnapshotBackedReadTransaction extends AbstractDOMStoreTran try { return Futures.immediateCheckedFuture(read(path).checkedGet().isPresent()); - } catch (final ReadFailedException e) { + } catch (ReadFailedException e) { return Futures.immediateFailedCheckedFuture(e); } }