X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=inventory%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Ftransportpce%2Finventory%2FINode121.java;h=456342af217d637d25f0240b74a39fc5c025fd0a;hb=a13c342256ab5d40f20b28b2ba2bde1e9dcccc6c;hp=5ba9a938f3500a9b666433418fa5ac05b7deca6b;hpb=f5a8fe61d265bce36b2fca393d82685a22ac326a;p=transportpce.git diff --git a/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode121.java b/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode121.java index 5ba9a938f..456342af2 100644 --- a/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode121.java +++ b/inventory/src/main/java/org/opendaylight/transportpce/inventory/INode121.java @@ -8,58 +8,83 @@ package org.opendaylight.transportpce.inventory; +import static java.util.Objects.requireNonNull; import static org.opendaylight.transportpce.inventory.utils.StringUtils.getCurrentTimestamp; import static org.opendaylight.transportpce.inventory.utils.StringUtils.prepareDashString; import static org.opendaylight.transportpce.inventory.utils.StringUtils.prepareEmptyString; -import com.google.common.base.Preconditions; import java.sql.Connection; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; +import java.util.Map; import java.util.Optional; import java.util.concurrent.ExecutionException; import javax.sql.DataSource; +import org.eclipse.jdt.annotation.NonNull; import org.opendaylight.mdsal.common.api.LogicalDatastoreType; import org.opendaylight.transportpce.common.Timeouts; import org.opendaylight.transportpce.common.device.DeviceTransactionManager; import org.opendaylight.transportpce.inventory.query.Queries; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.circuit.pack.CpSlots; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.circuit.pack.CpSlotsKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.circuit.pack.Ports; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.circuit.pack.PortsKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.circuit.packs.CircuitPacks; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.circuit.packs.CircuitPacksKey; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.degree.ConnectionPorts; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.degree.ConnectionPortsKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.external.links.ExternalLink; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.external.links.ExternalLinkKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.interfaces.grp.Interface; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.interfaces.grp.InterfaceKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.internal.links.InternalLink; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.internal.links.InternalLinkKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.OrgOpenroadmDevice; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.ConnectionMap; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.ConnectionMapKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.Degree; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.DegreeKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.Info; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.Protocols; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.RoadmConnections; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.RoadmConnectionsKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.SharedRiskGroup; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.org.openroadm.device.container.org.openroadm.device.SharedRiskGroupKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.physical.links.PhysicalLink; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.physical.links.PhysicalLinkKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.shelf.Slots; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.shelf.SlotsKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.shelves.Shelves; +import org.opendaylight.yang.gen.v1.http.org.openroadm.device.rev170206.shelves.ShelvesKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.ethernet.interfaces.rev161014.Interface1; import org.opendaylight.yang.gen.v1.http.org.openroadm.ethernet.interfaces.rev161014.ethernet.container.EthernetBuilder; import org.opendaylight.yang.gen.v1.http.org.openroadm.lldp.rev161014.Protocols1; import org.opendaylight.yang.gen.v1.http.org.openroadm.lldp.rev161014.lldp.container.lldp.PortConfig; +import org.opendaylight.yang.gen.v1.http.org.openroadm.lldp.rev161014.lldp.container.lldp.PortConfigKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.lldp.rev161014.lldp.container.lldp.nbr.list.IfName; +import org.opendaylight.yang.gen.v1.http.org.openroadm.lldp.rev161014.lldp.container.lldp.nbr.list.IfNameKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.optical.channel.interfaces.rev161014.och.container.OchBuilder; import org.opendaylight.yang.gen.v1.http.org.openroadm.optical.transport.interfaces.rev161014.ots.container.OtsBuilder; import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.odu.interfaces.rev161014.odu.attributes.Tcm; +import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.odu.interfaces.rev161014.odu.attributes.TcmKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.odu.interfaces.rev161014.odu.container.OduBuilder; import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.odu.interfaces.rev161014.opu.opu.msi.ExpMsi; +import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.odu.interfaces.rev161014.opu.opu.msi.ExpMsiKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.odu.interfaces.rev161014.opu.opu.msi.RxMsi; +import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.odu.interfaces.rev161014.opu.opu.msi.RxMsiKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.odu.interfaces.rev161014.opu.opu.msi.TxMsi; +import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.odu.interfaces.rev161014.opu.opu.msi.TxMsiKey; import org.opendaylight.yang.gen.v1.http.org.openroadm.otn.otu.interfaces.rev161014.otu.container.OtuBuilder; -import org.opendaylight.yang.gen.v1.http.org.openroadm.rstp.rev161014.rstp.bridge.port.attr.RstpBridgePortTable; -import org.opendaylight.yang.gen.v1.http.org.openroadm.rstp.rev161014.rstp.container.rstp.RstpBridgeInstance; import org.opendaylight.yang.gen.v1.http.org.openroadm.wavelength.map.rev161014.wavelength.map.g.Wavelengths; +import org.opendaylight.yang.gen.v1.http.org.openroadm.wavelength.map.rev161014.wavelength.map.g.WavelengthsKey; import org.opendaylight.yangtools.yang.binding.InstanceIdentifier; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +@edu.umd.cs.findbugs.annotations.SuppressFBWarnings( + value = "SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING", + justification = "TODO review the SQL statement generation process") public class INode121 { private static final Logger LOG = LoggerFactory.getLogger(INode121.class); @@ -89,7 +114,7 @@ public class INode121 { String query = Queries.getQuery().deviceInfoInsert().get(); LOG.info("Running {} query ", query); try (Connection connection = dataSource.getConnection(); - PreparedStatement preparedStatement = connection.prepareStatement(query)) { + PreparedStatement preparedStatement = connection.prepareStatement(query)) { Object[] prepareParameters = prepareDeviceInfoParameters(deviceInfo); for (int i = 0; i < prepareParameters.length; i++) { LOG.debug("Parameter {} has value {}", i + 1, prepareParameters[i]); @@ -148,12 +173,8 @@ public class INode121 { persistDevConnectionMap(deviceId, connection); LOG.debug("iNode persist Connection Map call complete"); - } catch (SQLException e) { - LOG.error(e.getMessage(), e); - } catch (InterruptedException e) { - LOG.error(e.getMessage(), e); - } catch (ExecutionException e) { - LOG.error(e.getMessage(), e); + } catch (SQLException | InterruptedException | ExecutionException e) { + LOG.error("Something wrong when storing node into DB", e); } return sqlResult; } @@ -172,7 +193,7 @@ public class INode121 { } } } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when fetching node in DB", e); } return nodeExists == 0 ? false : true; } @@ -182,26 +203,26 @@ public class INode121 { Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (deviceObject.isPresent()) { + Map shelvesMap = deviceObject.get().nonnullShelves(); + LOG.info("Shelves size {}", shelvesMap.size()); + try (Connection connection = requireNonNull(dataSource.getConnection())) { + for (Map.Entry shelveEntry : shelvesMap.entrySet()) { + Shelves shelve = shelveEntry.getValue(); + String shelfName = shelve.getShelfName(); + LOG.info("Getting Shelve Details of {}", shelfName); + if (shelve.getSlots() != null) { + LOG.info("Slot Size {} ", shelve.getSlots().size()); + persistShelveSlots(nodeId, shelve, connection); + } else { + LOG.info("No Slots for shelf {}", shelfName); + } - LOG.info("Shelves size {}", deviceObject.get().getShelves().size()); - try (Connection connection = dataSource.getConnection()) { - Preconditions.checkNotNull(connection); - for (int i = 0; i < deviceObject.get().getShelves().size(); i++) { - Shelves shelve = deviceObject.get().getShelves().get(i); - String shelfName = shelve.getShelfName(); - - LOG.info("Getting Shelve Details of {}", shelfName); - if (shelve.getSlots() != null) { - LOG.info("Slot Size {} ", shelve.getSlots().size()); - persistShelveSlots(nodeId, shelve, connection); - } else { - LOG.info("No Slots for shelf {}", shelfName); + persistShelves(nodeId, connection, shelve); } - - persistShelves(nodeId, connection, shelve); + } catch (SQLException e1) { + LOG.error("Something wrong when fetching ROADM shelves in DB", e1); } - } catch (SQLException e1) { - LOG.error(e1.getMessage(), e1); } } @@ -214,12 +235,12 @@ public class INode121 { LOG.warn("Device object {} was not found", nodeId); return; } - LOG.info("Circuit pack size {}", deviceObject.get().getCircuitPacks().size()); + Map circuitPacksMap = deviceObject.get().nonnullCircuitPacks(); + LOG.info("Circuit pack size {}", circuitPacksMap.size()); - try (Connection connection = dataSource.getConnection()) { - Preconditions.checkNotNull(connection); - for (int i = 0; i < deviceObject.get().getCircuitPacks().size(); i++) { - CircuitPacks cp = deviceObject.get().getCircuitPacks().get(i); + try (Connection connection = requireNonNull(dataSource.getConnection())) { + for (Map.Entry circuitPackEntry : circuitPacksMap.entrySet()) { + CircuitPacks cp = circuitPackEntry.getValue(); if (cp.getCpSlots() != null) { persistCircuitPacksSlots(nodeId, cp, connection); @@ -234,7 +255,7 @@ public class INode121 { persistCircuitPacks(nodeId, connection, cp); } } catch (SQLException e1) { - LOG.error(e1.getMessage(), e1); + LOG.error("Something wrong when fetching Circuit Packs in DB", e1); } } @@ -249,7 +270,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing Circuit Packs in DB", e); } } @@ -264,14 +285,15 @@ public class INode121 { preparedStmt.execute(); preparedStmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing shelves in DB", e); } } private void persistShelveSlots(String nodeId, Shelves shelves, Connection connection) { String startTimetampStr = getCurrentTimestamp(); - for (int i = 0; i < shelves.getSlots().size(); i++) { - Slots slot = shelves.getSlots().get(i); + Map slotsMap = shelves.nonnullSlots(); + for (Map.Entry slotEntry : slotsMap.entrySet()) { + Slots slot = slotEntry.getValue(); LOG.info("Getting Slot Details of {}", slot.getSlotName()); Object[] parameters = new Object[]{nodeId, shelves.getShelfName(), @@ -290,7 +312,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing shelves slots in DB", e); } } } @@ -298,8 +320,9 @@ public class INode121 { private void persistCircuitPacksSlots(String nodeId, CircuitPacks circuitPacks, Connection connection) { String startTimetampStr = getCurrentTimestamp(); - for (int i = 0; i < circuitPacks.getCpSlots().size(); i++) { - CpSlots cpSlot = circuitPacks.getCpSlots().get(i); + Map cpSlotsMap = circuitPacks.nonnullCpSlots(); + for (Map.Entry cpSlotEntry: cpSlotsMap.entrySet()) { + CpSlots cpSlot = cpSlotEntry.getValue(); Object[] parameters = new Object[]{nodeId, circuitPacks.getCircuitPackName(), @@ -319,16 +342,11 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing Cirtcuits Packs slots in DB", e); } } } - private void persistPorts(CircuitPacks circuitPacks, Connection connection) { - LOG.warn("Ports are not persisted yet"); - } - - /** * Prepares parameters for device insert query. * @@ -517,7 +535,7 @@ public class INode121 { cpPort.getOtdrPort().getLaunchCableLength().toString())); String otdrPortPortDirection = (cpPort.getOtdrPort() == null ? "-1" : (cpPort.getOtdrPort().getPortDirection() == null ? "-1" : - Integer.valueOf(cpPort.getOtdrPort().getPortDirection().getIntValue()).toString())); + Integer.toString(cpPort.getOtdrPort().getPortDirection().getIntValue()))); //String ilaPortPortPowerCapabilityMixRx = ""; //String ilaPortPortPowerCapabilityMixTx = ""; //String ilaPortPortPowerCapabilityMaxRx = ""; @@ -606,9 +624,10 @@ public class INode121 { private void persistCPPorts(String nodeId, Connection connection, CircuitPacks circuitPacks) { - - for (int i = 0; i < circuitPacks.getPorts().size(); i++) { - Object[] cpPortsParameters = prepareCPPortsParameters(nodeId, circuitPacks, circuitPacks.getPorts().get(i)); + @NonNull + Map nonnullPorts = circuitPacks.nonnullPorts(); + for (Map.Entry entry : nonnullPorts.entrySet()) { + Object[] cpPortsParameters = prepareCPPortsParameters(nodeId, circuitPacks, entry.getValue()); String query = Queries.getQuery().deviceCPPortInsert().get(); LOG.info("Running {} query ", query); try (PreparedStatement preparedStmt = connection.prepareStatement(query)) { @@ -618,7 +637,7 @@ public class INode121 { preparedStmt.execute(); preparedStmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing Cirtcuits Packs Ports in DB", e); } } } @@ -632,7 +651,7 @@ public class INode121 { String maintTestsignalTypeEnu = ""; String otuFecEnu = ""; String otuMaintTypeEnu = ""; - String otsFiberTypeEnu = ""; + //String otsFiberTypeEnu = ""; String ethernetSpeed = "-1"; String ethernetFec = ""; String ethernetMtu = "-1"; @@ -718,7 +737,7 @@ public class INode121 { EthernetBuilder ethIfBuilder = new EthernetBuilder(deviceInterface.augmentation(Interface1.class) .getEthernet()); ethernetSpeed = (ethIfBuilder.getSpeed() == null ? "-1" : - Integer.valueOf(ethIfBuilder.getSpeed().intValue()).toString()); + Integer.toString(ethIfBuilder.getSpeed().intValue())); ethernetFec = ethIfBuilder.getFec().getName(); ethernetDuplexEnu = (ethIfBuilder.getDuplex() == null ? "" : ethIfBuilder.getDuplex().getName()); ethernetMtu = ethIfBuilder.getMtu().toString(); @@ -743,7 +762,7 @@ public class INode121 { org.opendaylight.yang.gen.v1 .http.org.openroadm.optical.transport.interfaces.rev161014.Interface1.class) .getOts()); - otsFiberTypeEnu = String.valueOf(otsIfBuilder.getFiberType().getIntValue()); + //otsFiberTypeEnu = String.valueOf(otsIfBuilder.getFiberType().getIntValue()); otsSpanLossReceive = otsIfBuilder.getSpanLossReceive().toString(); otsSpanLossTransmit = otsIfBuilder.getSpanLossTransmit().toString(); break; @@ -771,8 +790,8 @@ public class INode121 { maintTestsignalEnabled = oduIfBuilder.getMaintTestsignal().isEnabled().toString(); maintTestsignalTestpatternEnu = oduIfBuilder.getMaintTestsignal().getTestPattern().getName(); maintTestsignalTypeEnu = oduIfBuilder.getMaintTestsignal().getType().getName(); - maintTestsignalBiterrors = Integer.valueOf(oduIfBuilder.getMaintTestsignal().getBitErrors().intValue()) - .toString(); + maintTestsignalBiterrors = Integer.toString( + oduIfBuilder.getMaintTestsignal().getBitErrors().intValue()); maintTestsignalBiterrorsterminal = oduIfBuilder.getMaintTestsignal().getBitErrorsTerminal().toString(); maintTestsignalSyncseconds = oduIfBuilder.getMaintTestsignal().getSyncSeconds(); maintTestsignalSyncsecondsterminal = oduIfBuilder.getMaintTestsignal().getSyncSecondsTerminal(); @@ -1011,35 +1030,23 @@ public class INode121 { Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (deviceObject.isPresent()) { + Map interfaceMap = deviceObject.get().nonnullInterface(); + for (Map.Entry interfaceEntrySet : interfaceMap.entrySet()) { + Interface deviceInterface = interfaceEntrySet.getValue(); + Object[] parameters = prepareDevInterfaceParameters(nodeId, deviceInterface, connection); - /*InstanceIdentifier interfaceIID = InstanceIdentifier.create(OrgOpenroadmDevice.class) - .child(Interface.class); - Optional interfaceOpt = - deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, interfaceIID, - Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); */ - - for (int i = 0; i < deviceObject.get().getInterface().size(); i++) { - Interface deviceInterface; - - deviceInterface = deviceObject.get().getInterface().get(i); - /*if (interfaceOpt.isPresent()) { - deviceInterface = interfaceOpt.get(); - } else { - LOG.warn("Could not get interface info"); - return false; - }*/ - Object[] parameters = prepareDevInterfaceParameters(nodeId, deviceInterface, connection); - - String query = Queries.getQuery().deviceInterfacesInsert().get(); - LOG.info("Running {} query ", query); - try (PreparedStatement stmt = connection.prepareStatement(query)) { - for (int j = 0; j < parameters.length; j++) { - stmt.setObject(j + 1, parameters[j]); + String query = Queries.getQuery().deviceInterfacesInsert().get(); + LOG.info("Running {} query ", query); + try (PreparedStatement stmt = connection.prepareStatement(query)) { + for (int j = 0; j < parameters.length; j++) { + stmt.setObject(j + 1, parameters[j]); + } + stmt.execute(); + stmt.clearParameters(); + } catch (SQLException e) { + LOG.error("Something wrong when storing devices interfaces in DB", e); } - stmt.execute(); - stmt.clearParameters(); - } catch (SQLException e) { - LOG.error(e.getMessage(), e); } } } @@ -1082,7 +1089,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices protocols in DB", e); } } } @@ -1097,12 +1104,15 @@ public class INode121 { Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); if (!protocolObject.isPresent() || protocolObject.get().augmentation(Protocols1.class) == null) { LOG.error("LLDP subtree is missing"); + return; } String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < protocolObject.get().augmentation(Protocols1.class).getLldp().getPortConfig().size(); i++) { - PortConfig portConfig = - protocolObject.get().augmentation(Protocols1.class).getLldp().getPortConfig().get(i); + @NonNull + Map portConfigMap = protocolObject.get() + .augmentation(Protocols1.class).getLldp().nonnullPortConfig(); + for (Map.Entry entry : portConfigMap.entrySet()) { + PortConfig portConfig = entry.getValue(); String ifName = portConfig.getIfName(); String adminStatusEnu = portConfig.getAdminStatus().getName(); @@ -1122,7 +1132,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices protocols LLDP Port config in DB", e); } } @@ -1136,6 +1146,11 @@ public class INode121 { Optional protocolObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, protocolsIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (!protocolObject.isPresent()) { + LOG.error("Protocols is missing"); + return; + + } if (protocolObject.get().augmentation(Protocols1.class).getLldp().getNbrList() == null) { protocolObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, protocolsIID, @@ -1147,11 +1162,11 @@ public class INode121 { } else { String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < protocolObject.get() - .augmentation(Protocols1.class).getLldp().getNbrList().getIfName().size(); i++) { + Map ifNameMap = + protocolObject.get().augmentation(Protocols1.class).getLldp().getNbrList().nonnullIfName(); + for (Map.Entry ifNameEntry : ifNameMap.entrySet()) { - IfName ifNameObj = protocolObject.get().augmentation(Protocols1.class).getLldp().getNbrList() - .getIfName().get(i); + IfName ifNameObj = ifNameEntry.getValue(); String ifName = ifNameObj.getIfName(); String remotesysname = ifNameObj.getRemoteSysName(); String remotemgmtaddresssubtype = ifNameObj.getRemoteMgmtAddressSubType().getName(); @@ -1183,230 +1198,53 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices protocols LLDP list number in DB", e); } } } } - private void persistDevProtocolRstp(String nodeId, Connection connection) { - - InstanceIdentifier protocolsIID = - InstanceIdentifier.create(OrgOpenroadmDevice.class).child(Protocols.class); - Optional protocolObject = - deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, protocolsIID, - Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (!protocolObject.isPresent() || protocolObject.get().augmentation(Protocols1.class) == null) { - LOG.error("LLDP subtree is missing"); - - } - String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < protocolObject.get() - .augmentation(org.opendaylight.yang.gen.v1.http.org.openroadm.rstp.rev161014.Protocols1.class) - .getRstp().getRstpBridgeInstance().size(); i++) { - - RstpBridgeInstance rstpBridgeInstance = protocolObject.get() - .augmentation(org.opendaylight.yang.gen.v1.http.org.openroadm.rstp.rev161014.Protocols1.class) - .getRstp().getRstpBridgeInstance().get(i); - String bridgeName = rstpBridgeInstance.getBridgeName(); - String bridgePriority = rstpBridgeInstance.getRstpConfig().getBridgePriority().toString(); - String shutdown = rstpBridgeInstance.getRstpConfig().getShutdown().toString(); - String holdTime = rstpBridgeInstance.getRstpConfig().getHoldTime().toString(); - String helloTime = rstpBridgeInstance.getRstpConfig().getHelloTime().toString(); - String maxAge = rstpBridgeInstance.getRstpConfig().getMaxAge().toString(); - String forwardDelay = rstpBridgeInstance.getRstpConfig().getForwardDelay().toString(); - String transmitHoldCount = rstpBridgeInstance.getRstpConfig().getTransmitHoldCount().toString(); - String rootBridgePort = - rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getRootBridgePort().toString(); - String rootPathCost = rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getRootPathCost().toString(); - String rootBridgePriority = - rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getRootBridgePriority().toString(); - String rootBridgeId = rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getRootBridgeId().toString(); - String rootHoldTime = rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getRootHoldTime().toString(); - String rootHelloTime = rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getRootHelloTime().toString(); - String rootMaxAge = rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getRootMaxAge().toString(); - String rootForwardDelay = - rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getRootForwardDelay().toString(); - String bridgeId = rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getBridgeId().toString(); - String topoChangeCount = - rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getTopoChangeCount().toString(); - String timeSinceTopoChange = - rstpBridgeInstance.getRstpState().getRstpBridgeAttr().getTimeSinceTopoChange().toString(); - - persistDevProtocolRstpBridgePort(nodeId, bridgeName, rstpBridgeInstance, connection); - persistDevProtocolRstpBridgePortAttr(nodeId, bridgeName, rstpBridgeInstance, connection); - - Object[] parameters = {nodeId, - bridgeName, - bridgePriority, - shutdown, - holdTime, - helloTime, - maxAge, - forwardDelay, - transmitHoldCount, - rootBridgePort, - rootPathCost, - rootBridgePriority, - rootBridgeId, - rootHoldTime, - rootHelloTime, - rootMaxAge, - rootForwardDelay, - bridgeId, - topoChangeCount, - timeSinceTopoChange, - startTimestamp, - startTimestamp - }; - - String query = Queries.getQuery().deviceProtocolRstpInsert().get(); - LOG.info("Running {} query ", query); - try (PreparedStatement stmt = connection.prepareStatement(query)) { - for (int j = 0; j < parameters.length; j++) { - stmt.setObject(j + 1, parameters[j]); - } - stmt.execute(); - stmt.clearParameters(); - } catch (SQLException e) { - LOG.error(e.getMessage(), e); - } - - } - } - - private void persistDevProtocolRstpBridgePort(String nodeId, String bridgeName, - RstpBridgeInstance rstpBridgeInstance, Connection connection) { - - String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < rstpBridgeInstance.getRstpConfig().getRstpBridgePortTable().size(); i++) { - RstpBridgePortTable rstpBridgePortTable = - rstpBridgeInstance.getRstpConfig().getRstpBridgePortTable().get(i); - - String ifName = rstpBridgePortTable.getIfname(); - String cost = rstpBridgePortTable.getCost().toString(); - String priority = rstpBridgePortTable.getPriority().toString(); - - Object[] parameters = {nodeId, - bridgeName, - ifName, - cost, - priority, - startTimestamp, - startTimestamp - }; - - String query = Queries.getQuery().deviceProtocolRstpBridgePortInsert().get(); - LOG.info("Running {} query ", query); - try (PreparedStatement stmt = connection.prepareStatement(query)) { - for (int j = 0; j < parameters.length; j++) { - stmt.setObject(j + 1, parameters[j]); - } - stmt.execute(); - stmt.clearParameters(); - } catch (SQLException e) { - LOG.error(e.getMessage(), e); - } - - } - } - - private void persistDevProtocolRstpBridgePortAttr(String nodeId, String bridgeName, - RstpBridgeInstance rstpBridgeInstance, Connection connection) { - - String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < rstpBridgeInstance.getRstpState().getRstpBridgePortAttr().getRstpBridgePortTable().size(); - i++) { - - org.opendaylight.yang.gen.v1.http.org.openroadm.rstp.rev161014.rstp.bridge.port.state.attr - .RstpBridgePortTable rstpBridgePortTableAttr = - rstpBridgeInstance.getRstpState().getRstpBridgePortAttr().getRstpBridgePortTable().get(i); - - String ifName = rstpBridgePortTableAttr.getIfname(); - String bridgePortState = rstpBridgePortTableAttr.getBridgePortState().getName(); - String bridgePortRole = rstpBridgePortTableAttr.getBridgePortRole().getName(); - String bridgePortId = rstpBridgePortTableAttr.getBridgePortId().toString(); - String openEdgeBridgePort = rstpBridgePortTableAttr.getOperEdgeBridgePort().toString(); - String designatedBridgePort = rstpBridgePortTableAttr.getDesignatedBridgePort().toString(); - String designatedBridgeId = rstpBridgePortTableAttr.getDesignatedBridgeid().toString(); - - Object[] parameters = {nodeId, - bridgeName, - ifName, - bridgePortState, - bridgePortRole, - bridgePortId, - openEdgeBridgePort, - designatedBridgePort, - designatedBridgeId, - startTimestamp, - startTimestamp - }; - - String query = Queries.getQuery().deviceProtocolRstpBridgePortAttrInsert().get(); - LOG.info("Running {} query ", query); - try (PreparedStatement stmt = connection.prepareStatement(query)) { - for (int j = 0; j < parameters.length; j++) { - stmt.setObject(j + 1, parameters[j]); - } - stmt.execute(); - stmt.clearParameters(); - } catch (SQLException e) { - LOG.error(e.getMessage(), e); - } - - } - } - - private void persistDevInternalLinks(String nodeId, Connection connection) { InstanceIdentifier deviceIID = InstanceIdentifier.create(OrgOpenroadmDevice.class); Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - if (deviceObject.get().getInternalLink() == null) { - deviceObject = - deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, deviceIID, - Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - } - if (deviceObject.get().getInternalLink() == null) { - LOG.info("External links not found for {}", nodeId); - } else { - - - String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < deviceObject.get().getInternalLink().size(); i++) { - InternalLink internalLink = deviceObject.get().getInternalLink().get(i); - String internalLinkName = internalLink.getInternalLinkName(); - String sourceCircuitPackName = internalLink.getSource().getCircuitPackName(); - String sourcePortName = internalLink.getSource().getPortName().toString(); - String destinationCircuitPackName = internalLink.getDestination().getCircuitPackName(); - String destinationPortName = internalLink.getDestination().getPortName().toString(); - - Object[] parameters = {nodeId, - internalLinkName, - sourceCircuitPackName, - sourcePortName, - destinationCircuitPackName, - destinationPortName, - startTimestamp, - startTimestamp - }; - - String query = Queries.getQuery().deviceInternalLinkInsert().get(); - LOG.info("Running {} query ", query); - try (PreparedStatement stmt = connection.prepareStatement(query)) { - for (int j = 0; j < parameters.length; j++) { - stmt.setObject(j + 1, parameters[j]); + if (deviceObject.isPresent()) { + if (deviceObject.get().getInternalLink() == null) { + deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, + deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + } + if (deviceObject.get().getInternalLink() == null) { + LOG.info("External links not found for {}", nodeId); + } else { + @NonNull + Map internalLinkMap = deviceObject.get().nonnullInternalLink(); + String startTimestamp = getCurrentTimestamp(); + for (Map.Entry internalLinkEntry: internalLinkMap.entrySet()) { + InternalLink internalLink = internalLinkEntry.getValue(); + String internalLinkName = internalLink.getInternalLinkName(); + String sourceCircuitPackName = internalLink.getSource().getCircuitPackName(); + String sourcePortName = internalLink.getSource().getPortName().toString(); + String destinationCircuitPackName = internalLink.getDestination().getCircuitPackName(); + String destinationPortName = internalLink.getDestination().getPortName().toString(); + + Object[] parameters = { nodeId, internalLinkName, sourceCircuitPackName, sourcePortName, + destinationCircuitPackName, destinationPortName, startTimestamp, startTimestamp }; + String query = Queries.getQuery().deviceInternalLinkInsert().get(); + LOG.info("Running {} query ", query); + try (PreparedStatement stmt = connection.prepareStatement(query)) { + for (int j = 0; j < parameters.length; j++) { + stmt.setObject(j + 1, parameters[j]); + } + stmt.execute(); + stmt.clearParameters(); + } catch (SQLException e) { + LOG.error("Something wrong when storing devices internal links", e); } - stmt.execute(); - stmt.clearParameters(); - } catch (SQLException e) { - LOG.error(e.getMessage(), e); - } + } } } } @@ -1418,50 +1256,44 @@ public class INode121 { Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - - if (deviceObject.get().getExternalLink() == null) { - deviceObject = - deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, deviceIID, - Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - } - if (deviceObject.get().getExternalLink() == null) { - LOG.info("External links not found for {}", nodeId); - } else { - String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < deviceObject.get().getExternalLink().size(); i++) { - ExternalLink externalLink = deviceObject.get().getExternalLink().get(i); - String externalLinkName = externalLink.getExternalLinkName(); - String sourceNodeId = externalLink.getSource().getNodeId(); - String sourceCircuitPackName = externalLink.getSource().getCircuitPackName(); - String sourcePortName = externalLink.getSource().getPortName().toString(); - String destinationNodeId = externalLink.getDestination().getNodeId(); - String destinationCircuitPackName = externalLink.getDestination().getCircuitPackName(); - String destinationPortName = externalLink.getDestination().getPortName().toString(); - - Object[] parameters = {nodeId, - externalLinkName, - sourceNodeId, - sourceCircuitPackName, - sourcePortName, - destinationNodeId, - destinationCircuitPackName, - destinationPortName, - startTimestamp, - startTimestamp - }; - - String query = Queries.getQuery().deviceExternalLinkInsert().get(); - LOG.info("Running {} query ", query); - try (PreparedStatement stmt = connection.prepareStatement(query)) { - for (int j = 0; j < parameters.length; j++) { - stmt.setObject(j + 1, parameters[j]); + if (deviceObject.isPresent()) { + if (deviceObject.get().getExternalLink() == null) { + deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, + deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + } + if (deviceObject.get().getExternalLink() == null) { + LOG.info("External links not found for {}", nodeId); + } else { + String startTimestamp = getCurrentTimestamp(); + @NonNull + Map externalLinkMap = deviceObject.get().nonnullExternalLink(); + for (Map.Entry externalLinkEntry: externalLinkMap.entrySet()) { + ExternalLink externalLink = externalLinkEntry.getValue(); + String externalLinkName = externalLink.getExternalLinkName(); + String sourceNodeId = externalLink.getSource().getNodeId(); + String sourceCircuitPackName = externalLink.getSource().getCircuitPackName(); + String sourcePortName = externalLink.getSource().getPortName(); + String destinationNodeId = externalLink.getDestination().getNodeId(); + String destinationCircuitPackName = externalLink.getDestination().getCircuitPackName(); + String destinationPortName = externalLink.getDestination().getPortName(); + + Object[] parameters = { nodeId, externalLinkName, sourceNodeId, sourceCircuitPackName, + sourcePortName, destinationNodeId, destinationCircuitPackName, destinationPortName, + startTimestamp, startTimestamp }; + + String query = Queries.getQuery().deviceExternalLinkInsert().get(); + LOG.info("Running {} query ", query); + try (PreparedStatement stmt = connection.prepareStatement(query)) { + for (int j = 0; j < parameters.length; j++) { + stmt.setObject(j + 1, parameters[j]); + } + stmt.execute(); + stmt.clearParameters(); + } catch (SQLException e) { + LOG.error("Something wrong when storing devices external links", e); } - stmt.execute(); - stmt.clearParameters(); - } catch (SQLException e) { - LOG.error(e.getMessage(), e); - } + } } } } @@ -1472,18 +1304,28 @@ public class INode121 { Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (!deviceObject.isPresent()) { + LOG.error("No device with node Id {}", nodeId); + return; + } if (deviceObject.get().getPhysicalLink() == null) { deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); } + if (!deviceObject.isPresent()) { + LOG.error("No device with node Id {}", nodeId); + return; + } if (deviceObject.get().getPhysicalLink() == null) { LOG.info("Physical links not found for {}", nodeId); } else { String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < deviceObject.get().getPhysicalLink().size(); i++) { - PhysicalLink physicalLink = deviceObject.get().getPhysicalLink().get(i); + @NonNull + Map physicalLinkMap = deviceObject.get().nonnullPhysicalLink(); + for (Map.Entry physicalLinkEntry : physicalLinkMap.entrySet()) { + PhysicalLink physicalLink = physicalLinkEntry.getValue(); String physicalLinkName = physicalLink.getPhysicalLinkName(); String sourceCircuitPackName = physicalLink.getSource().getCircuitPackName(); String sourcePortName = physicalLink.getSource().getPortName().toString(); @@ -1509,7 +1351,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices physical links", e); } } @@ -1529,53 +1371,47 @@ public class INode121 { deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); } */ - if (deviceObject.get().getDegree() == null) { - LOG.warn("Degree info not found for {}", nodeId); - } else { - - String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < deviceObject.get().getDegree().size(); i++) { - Degree degree = deviceObject.get().getDegree().get(i); - String degreeNumber = degree.getDegreeNumber().toString(); - String maxWavelengths = degree.getMaxWavelengths().toString(); - String otdrPortCircuitPackName = + if (!deviceObject.isPresent()) { + LOG.error("Cannot get device for node {}", nodeId); + return; + } + String startTimestamp = getCurrentTimestamp(); + @NonNull + Map degreeMap = deviceObject.get().nonnullDegree(); + for (Map.Entry degreeEntry : degreeMap.entrySet()) { + Degree degree = degreeEntry.getValue(); + String degreeNumber = degree.getDegreeNumber().toString(); + String maxWavelengths = degree.getMaxWavelengths().toString(); + String otdrPortCircuitPackName = (degree.getOtdrPort() == null ? "" : degree.getOtdrPort().getCircuitPackName()); - String otdrPortPortName = + String otdrPortPortName = (degree.getOtdrPort() == null ? "" : degree.getOtdrPort().getPortName().toString()); - //String mcCapabilitiesSlotWidthGranularity = ""; - //String mcCapabilitiesCenterFreqGranularity = ""; - //String mcCapabilitiesMinSlots = "-1"; - //String mcCapabilitiesMaxSlots = "-1"; - persistDevDegreeCircuitPack(nodeId, degree, degreeNumber, connection); - persistDevDegreeConnectionPort(nodeId, degree, degreeNumber, connection); - - Object[] parameters = {nodeId, - degreeNumber, - maxWavelengths, - otdrPortCircuitPackName, - otdrPortPortName, - //mcCapabilitiesSlotWidthGranularity, - //mcCapabilitiesCenterFreqGranularity, - //mcCapabilitiesMinSlots, - //mcCapabilitiesMaxSlots, - "", "", "-1", "-1", - startTimestamp, - startTimestamp - }; - - String query = Queries.getQuery().deviceDegreeInsert().get(); - LOG.info("Running {} query ", query); - try (PreparedStatement stmt = connection.prepareStatement(query)) { - for (int j = 0; j < parameters.length; j++) { - stmt.setObject(j + 1, parameters[j]); - } - stmt.execute(); - stmt.clearParameters(); - } catch (SQLException e) { - LOG.error(e.getMessage(), e); + // String mcCapabilitiesSlotWidthGranularity = ""; + // String mcCapabilitiesCenterFreqGranularity = ""; + // String mcCapabilitiesMinSlots = "-1"; + // String mcCapabilitiesMaxSlots = "-1"; + persistDevDegreeCircuitPack(nodeId, degree, degreeNumber, connection); + persistDevDegreeConnectionPort(nodeId, degree, degreeNumber, connection); + + Object[] parameters = { nodeId, degreeNumber, maxWavelengths, otdrPortCircuitPackName, otdrPortPortName, + // mcCapabilitiesSlotWidthGranularity, + // mcCapabilitiesCenterFreqGranularity, + // mcCapabilitiesMinSlots, + // mcCapabilitiesMaxSlots, + "", "", "-1", "-1", startTimestamp, startTimestamp }; + + String query = Queries.getQuery().deviceDegreeInsert().get(); + LOG.info("Running {} query ", query); + try (PreparedStatement stmt = connection.prepareStatement(query)) { + for (int j = 0; j < parameters.length; j++) { + stmt.setObject(j + 1, parameters[j]); } - + stmt.execute(); + stmt.clearParameters(); + } catch (SQLException e) { + LOG.error("Something wrong when storing devices degrees", e); } + } } @@ -1583,10 +1419,16 @@ public class INode121 { private void persistDevDegreeCircuitPack(String nodeId, Degree degree, String degreeNumber, Connection connection) { String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < degree.getCircuitPacks().size(); i++) { + @NonNull + Map + circuitPacksMap = degree.nonnullCircuitPacks(); + for (Map.Entry circuitPackEntry : + circuitPacksMap.entrySet()) { - String circuitPackIndex = degree.getCircuitPacks().get(i).getIndex().toString(); - String circuitPackName = degree.getCircuitPacks().get(i).getCircuitPackName(); + String circuitPackIndex = circuitPackEntry.getValue().getIndex().toString(); + String circuitPackName = circuitPackEntry.getValue().getCircuitPackName(); Object[] parameters = {nodeId, degreeNumber, @@ -1605,7 +1447,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices degrees circuit packs", e); } } @@ -1615,11 +1457,12 @@ public class INode121 { Connection connection) { String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < degree.getConnectionPorts().size(); i++) { - - String connectionPortIndex = degree.getConnectionPorts().get(i).getIndex().toString(); - String circuitPackName = degree.getConnectionPorts().get(i).getCircuitPackName(); - String portName = degree.getConnectionPorts().get(i).getPortName().toString(); + @NonNull + Map connectionPortsMap = degree.nonnullConnectionPorts(); + for (Map.Entry portEntry : connectionPortsMap.entrySet()) { + String connectionPortIndex = portEntry.getValue().getIndex().toString(); + String circuitPackName = portEntry.getValue().getCircuitPackName(); + String portName = portEntry.getValue().getPortName().toString(); Object[] parameters = {nodeId, degreeNumber, @@ -1639,7 +1482,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices degrees connection ports", e); } } @@ -1652,18 +1495,29 @@ public class INode121 { Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (!deviceObject.isPresent()) { + LOG.error("No device found in operational datastore for node {}", nodeId); + return; + } if (deviceObject.get().getSharedRiskGroup() == null) { deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (!deviceObject.isPresent()) { + LOG.error("No device found in configuration datastore for node {}", nodeId); + return; + } } - if (deviceObject.get().getSharedRiskGroup() == null) { + + @NonNull + Map sharedRiskGroupMap = deviceObject.get().nonnullSharedRiskGroup(); + if (sharedRiskGroupMap.isEmpty()) { LOG.info("no srg found for node {} ", nodeId); } else { String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < deviceObject.get().getSharedRiskGroup().size(); i++) { - SharedRiskGroup sharedRiskGroup = deviceObject.get().getSharedRiskGroup().get(i); + for (Map.Entry groupEntry : sharedRiskGroupMap.entrySet()) { + SharedRiskGroup sharedRiskGroup = groupEntry.getValue(); //String currentProvisionedAddDropPorts = "-1"; //String mcCapSlotWidthGranularity = ""; //String mcCapCenterFreqGranularity = ""; @@ -1698,7 +1552,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices SRG", e); } } @@ -1710,10 +1564,16 @@ public class INode121 { Connection connection) { String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < sharedRiskGroup.getCircuitPacks().size(); i++) { + @NonNull + Map + circuitPacksMap = sharedRiskGroup.nonnullCircuitPacks(); + for (Map.Entry entry : + circuitPacksMap.entrySet()) { - String circuitPackindex = sharedRiskGroup.getCircuitPacks().get(i).getIndex().toString(); - String circuitPackName = sharedRiskGroup.getCircuitPacks().get(i).getCircuitPackName(); + String circuitPackindex = entry.getValue().getIndex().toString(); + String circuitPackName = entry.getValue().getCircuitPackName(); Object[] parameters = {nodeId, srgNumber, @@ -1732,7 +1592,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices SRG circuit packs", e); } } @@ -1746,17 +1606,26 @@ public class INode121 { Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - + if (!deviceObject.isPresent()) { + LOG.error("No device found in operational datastore for node {}", nodeId); + return; + } if (deviceObject.get().getRoadmConnections() == null) { deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.CONFIGURATION, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (!deviceObject.isPresent()) { + LOG.error("No device found in configuration datastore for node {}", nodeId); + return; + } } - if (deviceObject.get().getRoadmConnections() != null) { + @NonNull + Map connectionsMap = deviceObject.get().nonnullRoadmConnections(); + if (!connectionsMap.isEmpty()) { String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < deviceObject.get().getRoadmConnections().size(); i++) { - RoadmConnections roadmConnections = deviceObject.get().getRoadmConnections().get(i); + for (Map.Entry entry : connectionsMap.entrySet()) { + RoadmConnections roadmConnections = entry.getValue(); String connectionNumber = roadmConnections.getConnectionNumber(); //String connectionName = ""; String wavelengthNumber = roadmConnections.getWavelengthNumber().toString(); @@ -1787,7 +1656,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices ROADM connection ", e); } } @@ -1803,10 +1672,15 @@ public class INode121 { Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); - + if (!deviceObject.isPresent()) { + LOG.error("No device found in operational datastore for node {}", nodeId); + return; + } String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < deviceObject.get().getConnectionMap().size(); i++) { - ConnectionMap connectionMap = deviceObject.get().getConnectionMap().get(i); + @NonNull + Map connectionsMap = deviceObject.get().nonnullConnectionMap(); + for (Map.Entry entry : connectionsMap.entrySet()) { + ConnectionMap connectionMap = entry.getValue(); String connectionMapNumber = connectionMap.getConnectionMapNumber().toString(); String sourceCircuitPackName = connectionMap.getSource().getCircuitPackName(); String sourcePortName = connectionMap.getSource().getCircuitPackName(); @@ -1829,7 +1703,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices connection map", e); } } @@ -1841,10 +1715,16 @@ public class INode121 { Optional deviceObject = deviceTransactionManager.getDataFromDevice(nodeId, LogicalDatastoreType.OPERATIONAL, deviceIID, Timeouts.DEVICE_READ_TIMEOUT, Timeouts.DEVICE_READ_TIMEOUT_UNIT); + if (!deviceObject.isPresent()) { + LOG.error("No device found in operational datastore for node {}", nodeId); + return; + } String startTimestamp = getCurrentTimestamp(); - for (int i = 0; i < deviceObject.get().getWavelengthMap().getWavelengths().size(); i++) { - Wavelengths wavelengths = deviceObject.get().getWavelengthMap().getWavelengths().get(i); + @NonNull + Map wavelengthsMap = deviceObject.get().getWavelengthMap().nonnullWavelengths(); + for (Map.Entry entry : wavelengthsMap.entrySet()) { + Wavelengths wavelengths = entry.getValue(); String wavelengthNumber = wavelengths.getWavelengthNumber().toString(); String centerFrequency = wavelengths.getCenterFrequency().toString(); String wavelength = wavelengths.getWavelength().toString(); @@ -1867,7 +1747,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices wavelength map", e); } } @@ -1877,10 +1757,9 @@ public class INode121 { private void persistDevInterfaceTcm(String nodeId, String interfaceName, OduBuilder oduBuilder, Connection connection) { - for (int i = 0; i < oduBuilder.getTcm().size(); i++) { - Tcm tcm; - - tcm = oduBuilder.getTcm().get(i); + Map tcmMap = oduBuilder.getTcm(); + for (Map.Entry entry : tcmMap.entrySet()) { + Tcm tcm = entry.getValue(); Object[] parameters = prepareDevInterfaceTcmParameters(nodeId, interfaceName, tcm); @@ -1893,7 +1772,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices interface tcm", e); } } } @@ -1901,10 +1780,10 @@ public class INode121 { private void persistDevInterfaceOtnOduTxMsi(String nodeId, String interfaceName, OduBuilder oduBuilder, Connection connection) { - for (int i = 0; i < oduBuilder.getTcm().size(); i++) { - TxMsi txMsi; + Map txMsiMap = oduBuilder.getOpu().getMsi().nonnullTxMsi(); + for (Map.Entry entry : txMsiMap.entrySet()) { - txMsi = oduBuilder.getOpu().getMsi().getTxMsi().get(i); + TxMsi txMsi = entry.getValue(); Object[] parameters = prepareDevInterfaceOtnOduTxMsiParameters(nodeId, interfaceName, txMsi); @@ -1917,7 +1796,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices interface OTN ODU Tx MSI", e); } } } @@ -1925,11 +1804,9 @@ public class INode121 { private void persistDevInterfaceOtnOduRxMsi(String nodeId, String interfaceName, OduBuilder oduBuilder, Connection connection) { - - for (int i = 0; i < oduBuilder.getTcm().size(); i++) { - RxMsi rxMsi; - - rxMsi = oduBuilder.getOpu().getMsi().getRxMsi().get(i); + Map rxMsiMap = oduBuilder.getOpu().getMsi().nonnullRxMsi(); + for (Map.Entry entry : rxMsiMap.entrySet()) { + RxMsi rxMsi = entry.getValue(); Object[] parameters = prepareDevInterfaceOtnOduRxMsiParameters(nodeId, interfaceName, rxMsi); @@ -1942,7 +1819,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices interface OTN ODU Rx MSI", e); } } } @@ -1950,11 +1827,10 @@ public class INode121 { private void persistDevInterfaceOtnOduExpMsi(String nodeId, String interfaceName, OduBuilder oduBuilder, Connection connection) { - - for (int i = 0; i < oduBuilder.getTcm().size(); i++) { - ExpMsi expMsi; - - expMsi = oduBuilder.getOpu().getMsi().getExpMsi().get(i); + @NonNull + Map expMsiMap = oduBuilder.getOpu().getMsi().nonnullExpMsi(); + for (Map.Entry entry : expMsiMap.entrySet()) { + ExpMsi expMsi = entry.getValue(); Object[] parameters = prepareDevInterfaceOtnOduExpMsiParameters(nodeId, interfaceName, expMsi); @@ -1967,7 +1843,7 @@ public class INode121 { stmt.execute(); stmt.clearParameters(); } catch (SQLException e) { - LOG.error(e.getMessage(), e); + LOG.error("Something wrong when storing devices interface OTN ODU Exp MSI", e); } } }