X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=model%2Fietf%2Fietf-type-util%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fmdsal%2Fmodel%2Fietf%2Futil%2FIpv6Utils.java;h=6672600dc1f5448c02f79158606b482b737956c9;hb=991cf98a8ad1b1c73b5c164792e9e1d091f7fec4;hp=e8fecef4376006a2812909612a7b356b0301e307;hpb=30f8b36bd2b1ebd9697af125aacc8ddedb86d3b1;p=mdsal.git diff --git a/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv6Utils.java b/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv6Utils.java index e8fecef437..6672600dc1 100644 --- a/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv6Utils.java +++ b/model/ietf/ietf-type-util/src/main/java/org/opendaylight/mdsal/model/ietf/util/Ipv6Utils.java @@ -9,9 +9,6 @@ package org.opendaylight.mdsal.model.ietf.util; import com.google.common.base.Preconditions; import com.google.common.base.Verify; -import com.google.common.net.InetAddresses; -import java.net.Inet4Address; -import java.net.InetAddress; import javax.annotation.Nonnull; /** @@ -102,18 +99,12 @@ final class Ipv6Utils { /* frankenstein - v4 attached to v6, mixed notation */ if (ch == '.' && ((j + INADDR4SZ) <= INADDR6SZ)) { - /* this has passed the regexp so it is fairly safe to parse it - * straight away. As v4 addresses do not suffer from the same - * deficiencies as the java v6 implementation we can invoke it - * straight away and be done with it + /* + * This has passed the regexp so it is fairly safe to parse it + * straight away. Use the Ipv4Utils for that. */ - Preconditions.checkArgument(j != (INADDR6SZ - INADDR4SZ - 1), "Invalid v4 in v6 mapping in %s", addrStr); - InetAddress _inet_form = InetAddresses.forString(addrStr.substring(curtok, addrStrLen)); - - Preconditions.checkArgument(_inet_form instanceof Inet4Address); - System.arraycopy(_inet_form.getAddress(), 0, dst, j, INADDR4SZ); + Ipv4Utils.fillIpv4Bytes(dst, j, addrStr, curtok, addrStrLen); j += INADDR4SZ; - saw_xdigit = false; break; }