X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=natservice%2Fimpl%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fnetvirt%2Fnatservice%2Fcli%2FDisplayNaptSwithcesCli.java;h=894031fca561b253e3bfed5412bffa262a462a02;hb=2f0569ed75ef8a1fb60f992d19c8bbdf92ff45bf;hp=c7c4af00c07f075f8e78590dfcc47881d7eb9b9d;hpb=14cd5115173a053cf6d99b7dc9c9493f0f809b8b;p=netvirt.git diff --git a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/cli/DisplayNaptSwithcesCli.java b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/cli/DisplayNaptSwithcesCli.java index c7c4af00c0..894031fca5 100644 --- a/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/cli/DisplayNaptSwithcesCli.java +++ b/natservice/impl/src/main/java/org/opendaylight/netvirt/natservice/cli/DisplayNaptSwithcesCli.java @@ -8,17 +8,16 @@ package org.opendaylight.netvirt.natservice.cli; -import com.google.common.base.Optional; import java.io.PrintStream; import java.math.BigInteger; -import java.util.Collections; -import javax.annotation.Nonnull; -import javax.annotation.Nullable; +import java.util.Optional; import org.apache.karaf.shell.commands.Command; import org.apache.karaf.shell.console.OsgiCommandSupport; -import org.opendaylight.controller.md.sal.binding.api.DataBroker; -import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; +import org.eclipse.jdt.annotation.NonNull; +import org.eclipse.jdt.annotation.Nullable; import org.opendaylight.genius.datastoreutils.SingleTransactionDataBroker; +import org.opendaylight.mdsal.binding.api.DataBroker; +import org.opendaylight.mdsal.common.api.LogicalDatastoreType; import org.opendaylight.netvirt.natservice.internal.NatUtil; import org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.meta.rev160406.BridgeRefInfo; import org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.meta.rev160406.bridge.ref.info.BridgeRefEntry; @@ -49,10 +48,10 @@ public class DisplayNaptSwithcesCli extends OsgiCommandSupport { ps.printf(String.format(" %-36s %-20s %-20s %n", "Router Id ", "Datapath Node Id", "Managment Ip Address")); ps.printf("-------------------------------------------------------------------------------------------%n"); if (npatSwitches.isPresent()) { - for (RouterToNaptSwitch routerToNaptSwitch : NatUtil.requireNonNullElse( - npatSwitches.get().getRouterToNaptSwitch(), Collections.emptyList())) { + for (RouterToNaptSwitch routerToNaptSwitch : npatSwitches.get().nonnullRouterToNaptSwitch()) { ps.printf(String.format(" %-36s %-20s %-20s %n", routerToNaptSwitch.getRouterName(), - routerToNaptSwitch.getPrimarySwitchId(), getDpnLocalIp(routerToNaptSwitch.getPrimarySwitchId()))); + routerToNaptSwitch.getPrimarySwitchId(), + getDpnLocalIp(routerToNaptSwitch.getPrimarySwitchId().toJava()))); } } return null; @@ -67,7 +66,7 @@ public class DisplayNaptSwithcesCli extends OsgiCommandSupport { SingleTransactionDataBroker.syncReadOptionalAndTreatReadFailedExceptionAsAbsentOptional(dataBroker, LogicalDatastoreType.OPERATIONAL, bridgeRefInfoPath); if (!bridgeRefEntry.isPresent()) { - return Optional.absent(); + return Optional.empty(); } InstanceIdentifier nodeId = @@ -79,7 +78,7 @@ public class DisplayNaptSwithcesCli extends OsgiCommandSupport { @Nullable private String getDpnLocalIp(BigInteger dpId) { - return getPortsNode(dpId).toJavaUtil().map(node -> getOpenvswitchOtherConfig(node, LOCAL_IP)).orElse(null); + return getPortsNode(dpId).map(node -> getOpenvswitchOtherConfig(node, LOCAL_IP)).orElse(null); } @Nullable @@ -103,7 +102,7 @@ public class DisplayNaptSwithcesCli extends OsgiCommandSupport { return null; } - @Nonnull + @NonNull private Optional readOvsdbNode(Node bridgeNode) { OvsdbBridgeAugmentation bridgeAugmentation = extractBridgeAugmentation(bridgeNode); if (bridgeAugmentation != null) { @@ -112,7 +111,7 @@ public class DisplayNaptSwithcesCli extends OsgiCommandSupport { return SingleTransactionDataBroker.syncReadOptionalAndTreatReadFailedExceptionAsAbsentOptional(dataBroker, LogicalDatastoreType.OPERATIONAL, ovsdbNodeIid); } - return Optional.absent(); + return Optional.empty(); }