X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=netconf%2Fnetconf-api%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fnetconf%2Fapi%2Fxml%2FXmlElement.java;h=caba82a5157e41e98a20bd8bbf34acded64fe8ad;hb=3eeb70321434f6bf3ec6a87eec8a52dd995e305a;hp=c4346ee7e1d59f990e2a95fca3d23dee39cdeee3;hpb=29c57bb8a9d5f6cecd2c890c614709b83a7f516e;p=netconf.git diff --git a/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/xml/XmlElement.java b/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/xml/XmlElement.java index c4346ee7e1..caba82a515 100644 --- a/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/xml/XmlElement.java +++ b/netconf/netconf-api/src/main/java/org/opendaylight/netconf/api/xml/XmlElement.java @@ -154,7 +154,7 @@ public final class XmlElement { } public void appendChild(final Element toAppend) { - this.element.appendChild(toAppend); + element.appendChild(toAppend); } public Element getDomElement() { @@ -181,12 +181,8 @@ public final class XmlElement { NodeList childNodes = element.getChildNodes(); final List result = new ArrayList<>(); for (int i = 0; i < childNodes.getLength(); i++) { - Node item = childNodes.item(i); - if (!(item instanceof Element)) { - continue; - } - if (strat.accept((Element) item)) { - result.add(new XmlElement((Element) item)); + if (childNodes.item(i) instanceof Element elem && strat.accept(elem)) { + result.add(new XmlElement(elem)); } } @@ -321,10 +317,8 @@ public final class XmlElement { return DEFAULT_NAMESPACE_PREFIX; } for (int i = 0; i < childNodes.getLength(); i++) { - Node textChild = childNodes.item(i); - if (textChild instanceof Text) { - String content = textChild.getTextContent(); - return content.trim(); + if (childNodes.item(i) instanceof Text textChild) { + return textChild.getTextContent().trim(); } } throw new DocumentedException(getName() + " should contain text.", @@ -334,9 +328,8 @@ public final class XmlElement { public Optional getOnlyTextContentOptionally() { // only return text content if this node has exactly one Text child node if (element.getChildNodes().getLength() == 1) { - Node item = element.getChildNodes().item(0); - if (item instanceof Text) { - return Optional.of(((Text) item).getWholeText()); + if (element.getChildNodes().item(0) instanceof Text textChild) { + return Optional.of(textChild.getWholeText()); } } return Optional.empty();