X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=netconf%2Fsal-netconf-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fnetconf%2Fsal%2Fconnect%2Fnetconf%2Fsal%2Ftx%2FWriteRunningTx.java;h=940ea1a6b9fe6f9799caee811c79bbf9a165ebd3;hb=a0833fb27c69d919a4420c6ecbd11a3b2a1119cb;hp=4716437ca49e80e27225929c6263a2f12c601570;hpb=b63c5edc0f896e131846e975340cef7e9f1e0f36;p=netconf.git
diff --git a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteRunningTx.java b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteRunningTx.java
index 4716437ca4..940ea1a6b9 100644
--- a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteRunningTx.java
+++ b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteRunningTx.java
@@ -5,16 +5,13 @@
* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
-
package org.opendaylight.netconf.sal.connect.netconf.sal.tx;
-import com.google.common.base.Function;
-import com.google.common.base.Optional;
-import com.google.common.util.concurrent.CheckedFuture;
-import com.google.common.util.concurrent.Futures;
import com.google.common.util.concurrent.ListenableFuture;
-import org.opendaylight.controller.md.sal.common.api.TransactionStatus;
-import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Optional;
+import org.opendaylight.mdsal.dom.api.DOMRpcResult;
import org.opendaylight.netconf.sal.connect.netconf.util.NetconfBaseOps;
import org.opendaylight.netconf.sal.connect.netconf.util.NetconfRpcFutureCallback;
import org.opendaylight.netconf.sal.connect.util.RemoteDeviceId;
@@ -27,7 +24,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * Tx implementation for netconf devices that support only writable-running with no candidate
+ * Tx implementation for netconf devices that support only writable-running with no candidate.
* The sequence goes as:
*
* - Lock running datastore on tx construction
@@ -46,10 +43,16 @@ import org.slf4j.LoggerFactory;
public class WriteRunningTx extends AbstractWriteTx {
private static final Logger LOG = LoggerFactory.getLogger(WriteRunningTx.class);
+ private final List changes = new ArrayList<>();
public WriteRunningTx(final RemoteDeviceId id, final NetconfBaseOps netOps,
final boolean rollbackSupport) {
- super(netOps, id, rollbackSupport);
+ this(id, netOps, rollbackSupport, true);
+ }
+
+ public WriteRunningTx(RemoteDeviceId id, NetconfBaseOps netconfOps, boolean rollbackSupport,
+ boolean isLockAllowed) {
+ super(id, netconfOps, rollbackSupport, isLockAllowed);
}
@Override
@@ -58,7 +61,11 @@ public class WriteRunningTx extends AbstractWriteTx {
}
private void lock() {
- resultsFutures.add(netOps.lockRunning(new NetconfRpcFutureCallback("Lock running", id)));
+ if (isLockAllowed) {
+ resultsFutures.add(netOps.lockRunning(new NetconfRpcFutureCallback("Lock running", id)));
+ } else {
+ LOG.trace("Lock is not allowed: {}", id);
+ }
}
@Override
@@ -67,26 +74,11 @@ public class WriteRunningTx extends AbstractWriteTx {
}
@Override
- public synchronized CheckedFuture submit() {
- final ListenableFuture commmitFutureAsVoid = Futures.transform(commit(), new Function, Void>() {
- @Override
- public Void apply(final RpcResult input) {
- return null;
- }
- });
-
- return Futures.makeChecked(commmitFutureAsVoid, new Function() {
- @Override
- public TransactionCommitFailedException apply(final Exception input) {
- return new TransactionCommitFailedException("Submit of transaction " + getIdentifier() + " failed", input);
- }
- });
- }
-
- @Override
- public synchronized ListenableFuture> performCommit() {
+ public synchronized ListenableFuture> performCommit() {
+ for (final Change change : changes) {
+ resultsFutures.add(change.execute(id, netOps, rollbackSupport));
+ }
unlock();
-
return resultsToTxStatus();
}
@@ -96,18 +88,36 @@ public class WriteRunningTx extends AbstractWriteTx {
final DataContainerChild, ?> editStructure,
final Optional defaultOperation,
final String operation) {
+ changes.add(new Change(editStructure, defaultOperation));
+ }
- NetconfRpcFutureCallback editConfigCallback = new NetconfRpcFutureCallback("Edit running", id);
-
- if (defaultOperation.isPresent()) {
- resultsFutures.add(
- netOps.editConfigRunning(editConfigCallback, editStructure, defaultOperation.get(), rollbackSupport));
+ private void unlock() {
+ if (isLockAllowed) {
+ netOps.unlockRunning(new NetconfRpcFutureCallback("Unlock running", id));
} else {
- resultsFutures.add(netOps.editConfigRunning(editConfigCallback, editStructure, rollbackSupport));
+ LOG.trace("Unlock is not allowed: {}", id);
}
}
- private void unlock() {
- netOps.unlockRunning(new NetconfRpcFutureCallback("Unlock running", id));
+ private static final class Change {
+
+ private final DataContainerChild, ?> editStructure;
+ private final Optional defaultOperation;
+
+ Change(final DataContainerChild, ?> editStructure, final Optional defaultOperation) {
+ this.editStructure = editStructure;
+ this.defaultOperation = defaultOperation;
+ }
+
+ private ListenableFuture execute(final RemoteDeviceId id, final NetconfBaseOps netOps,
+ final boolean rollbackSupport) {
+ final NetconfRpcFutureCallback editConfigCallback = new NetconfRpcFutureCallback("Edit running", id);
+ if (defaultOperation.isPresent()) {
+ return netOps.editConfigRunning(editConfigCallback, editStructure, defaultOperation.get(),
+ rollbackSupport);
+ } else {
+ return netOps.editConfigRunning(editConfigCallback, editStructure, rollbackSupport);
+ }
+ }
}
}