X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=netconf%2Fsal-netconf-connector%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fnetconf%2Fsal%2Fconnect%2Futil%2FNetconfSalKeystoreService.java;h=55b72d3a68ba08fd38457d176cfc4f10676556a8;hb=1d91e1bbe29d0da6ea427a5d0837064c8a3d5134;hp=29d345287a28e542799d48c8ddb1064a4d4441d1;hpb=0a95f4298a7f467b6c2eebf7904c8253cf3d5198;p=netconf.git diff --git a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/util/NetconfSalKeystoreService.java b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/util/NetconfSalKeystoreService.java index 29d345287a..55b72d3a68 100644 --- a/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/util/NetconfSalKeystoreService.java +++ b/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/util/NetconfSalKeystoreService.java @@ -5,23 +5,20 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.netconf.sal.connect.util; -import com.google.common.util.concurrent.CheckedFuture; import com.google.common.util.concurrent.FutureCallback; -import com.google.common.util.concurrent.Futures; import com.google.common.util.concurrent.ListenableFuture; import com.google.common.util.concurrent.MoreExecutors; import com.google.common.util.concurrent.SettableFuture; import java.util.List; +import java.util.concurrent.ExecutionException; import java.util.stream.Collectors; -import javax.annotation.Nullable; import org.opendaylight.aaa.encrypt.AAAEncryptionService; -import org.opendaylight.controller.md.sal.binding.api.DataBroker; -import org.opendaylight.controller.md.sal.binding.api.WriteTransaction; -import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType; -import org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException; +import org.opendaylight.mdsal.binding.api.DataBroker; +import org.opendaylight.mdsal.binding.api.WriteTransaction; +import org.opendaylight.mdsal.common.api.CommitInfo; +import org.opendaylight.mdsal.common.api.LogicalDatastoreType; import org.opendaylight.yang.gen.v1.urn.opendaylight.netconf.keystore.rev171017.AddKeystoreEntryInput; import org.opendaylight.yang.gen.v1.urn.opendaylight.netconf.keystore.rev171017.AddKeystoreEntryOutput; import org.opendaylight.yang.gen.v1.urn.opendaylight.netconf.keystore.rev171017.AddKeystoreEntryOutputBuilder; @@ -81,12 +78,10 @@ public class NetconfSalKeystoreService implements NetconfKeystoreService { final WriteTransaction writeTransaction = dataBroker.newWriteOnlyTransaction(); writeTransaction.merge(LogicalDatastoreType.CONFIGURATION, keystoreIid, keystore); - final CheckedFuture submit = writeTransaction.submit(); - try { - submit.checkedGet(); + writeTransaction.commit().get(); LOG.debug("init keystore done"); - } catch (TransactionCommitFailedException exception) { + } catch (InterruptedException | ExecutionException exception) { LOG.error("Unable to initialize Netconf key-pair store.", exception); } } @@ -106,10 +101,9 @@ public class NetconfSalKeystoreService implements NetconfKeystoreService { final SettableFuture> rpcResult = SettableFuture.create(); - final ListenableFuture submit = writeTransaction.submit(); - Futures.addCallback(submit, new FutureCallback() { + writeTransaction.commit().addCallback(new FutureCallback() { @Override - public void onSuccess(@Nullable final Void result) { + public void onSuccess(final CommitInfo result) { LOG.debug("remove-key-pair success. Input: {}"); rpcResult.set(RpcResultBuilder.success(new RemoveKeystoreEntryOutputBuilder().build()).build()); } @@ -142,9 +136,9 @@ public class NetconfSalKeystoreService implements NetconfKeystoreService { final SettableFuture> rpcResult = SettableFuture.create(); - Futures.addCallback(writeTransaction.submit(), new FutureCallback() { + writeTransaction.commit().addCallback(new FutureCallback() { @Override - public void onSuccess(@Nullable final Void result) { + public void onSuccess(final CommitInfo result) { LOG.debug("add-key-pair success. Input: {}"); rpcResult.set(RpcResultBuilder.success(new AddKeystoreEntryOutputBuilder().build()).build()); } @@ -171,9 +165,9 @@ public class NetconfSalKeystoreService implements NetconfKeystoreService { final SettableFuture> rpcResult = SettableFuture.create(); - Futures.addCallback(writeTransaction.submit(), new FutureCallback() { + writeTransaction.commit().addCallback(new FutureCallback() { @Override - public void onSuccess(@Nullable final Void result) { + public void onSuccess(final CommitInfo result) { LOG.debug("add-trusted-certificate success. Input: {}", input); rpcResult.set(RpcResultBuilder.success(new AddTrustedCertificateOutputBuilder().build()).build()); } @@ -201,9 +195,9 @@ public class NetconfSalKeystoreService implements NetconfKeystoreService { final SettableFuture> rpcResult = SettableFuture.create(); - Futures.addCallback(writeTransaction.submit(), new FutureCallback() { + writeTransaction.commit().addCallback(new FutureCallback() { @Override - public void onSuccess(@Nullable final Void result) { + public void onSuccess(final CommitInfo result) { LOG.debug("remove-trusted-certificate success. Input: {}", input); rpcResult.set(RpcResultBuilder.success(new RemoveTrustedCertificateOutputBuilder().build()).build()); } @@ -229,9 +223,9 @@ public class NetconfSalKeystoreService implements NetconfKeystoreService { final SettableFuture> rpcResult = SettableFuture.create(); - Futures.addCallback(writeTransaction.submit(), new FutureCallback() { + writeTransaction.commit().addCallback(new FutureCallback() { @Override - public void onSuccess(@Nullable final Void result) { + public void onSuccess(final CommitInfo result) { LOG.debug("add-private-key success. Input: {}", input); rpcResult.set(RpcResultBuilder.success(new AddPrivateKeyOutputBuilder().build()).build()); } @@ -258,9 +252,9 @@ public class NetconfSalKeystoreService implements NetconfKeystoreService { final SettableFuture> rpcResult = SettableFuture.create(); - Futures.addCallback(writeTransaction.submit(), new FutureCallback() { + writeTransaction.commit().addCallback(new FutureCallback() { @Override - public void onSuccess(@Nullable final Void result) { + public void onSuccess(final CommitInfo result) { LOG.debug("remove-private-key success. Input: {}", input); rpcResult.set(RpcResultBuilder.success(new RemovePrivateKeyOutputBuilder().build()).build()); }