X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=netconf%2Fsal-netconf-connector%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fnetconf%2Fsal%2Fconnect%2Fnetconf%2FNetconfStateSchemasTest.java;h=3b8648ef49530ac9deec1ad0e834308638f7a43e;hb=b8f5ebd2f817de1d613d84cf41f3516728767eba;hp=c8564975b681bfbc519a1ed3fbabbca03dd7c204;hpb=1e1e99672bf3450a165b3ee0be5d38e856586da4;p=netconf.git diff --git a/netconf/sal-netconf-connector/src/test/java/org/opendaylight/netconf/sal/connect/netconf/NetconfStateSchemasTest.java b/netconf/sal-netconf-connector/src/test/java/org/opendaylight/netconf/sal/connect/netconf/NetconfStateSchemasTest.java index c8564975b6..3b8648ef49 100644 --- a/netconf/sal-netconf-connector/src/test/java/org/opendaylight/netconf/sal/connect/netconf/NetconfStateSchemasTest.java +++ b/netconf/sal-netconf-connector/src/test/java/org/opendaylight/netconf/sal/connect/netconf/NetconfStateSchemasTest.java @@ -5,21 +5,21 @@ * terms of the Eclipse Public License v1.0 which accompanies this distribution, * and is available at http://www.eclipse.org/legal/epl-v10.html */ - package org.opendaylight.netconf.sal.connect.netconf; import static org.hamcrest.CoreMatchers.hasItem; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertThat; -import static org.mockito.Matchers.any; -import static org.mockito.Matchers.eq; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.eq; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; import static org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTransformUtil.NETCONF_GET_QNAME; import static org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTransformUtil.toPath; +import static org.opendaylight.yangtools.util.concurrent.FluentFutures.immediateFailedFluentFuture; +import static org.opendaylight.yangtools.util.concurrent.FluentFutures.immediateFluentFuture; -import com.google.common.util.concurrent.CheckedFuture; -import com.google.common.util.concurrent.Futures; +import com.google.common.util.concurrent.FluentFuture; import com.google.common.util.concurrent.ListenableFuture; import java.net.InetSocketAddress; import java.util.Collections; @@ -30,55 +30,68 @@ import java.util.concurrent.Future; import java.util.concurrent.TimeUnit; import org.junit.Assert; import org.junit.Before; +import org.junit.Ignore; import org.junit.Test; import org.mockito.Mock; import org.mockito.MockitoAnnotations; -import org.opendaylight.controller.config.util.xml.XmlUtil; -import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException; -import org.opendaylight.controller.md.sal.dom.api.DOMRpcException; -import org.opendaylight.controller.md.sal.dom.api.DOMRpcImplementationNotAvailableException; -import org.opendaylight.controller.md.sal.dom.api.DOMRpcResult; -import org.opendaylight.controller.md.sal.dom.api.DOMRpcService; -import org.opendaylight.controller.md.sal.dom.spi.DefaultDOMRpcResult; +import org.opendaylight.mdsal.dom.api.DOMRpcImplementationNotAvailableException; +import org.opendaylight.mdsal.dom.api.DOMRpcResult; +import org.opendaylight.mdsal.dom.api.DOMRpcService; +import org.opendaylight.mdsal.dom.spi.DefaultDOMRpcResult; import org.opendaylight.netconf.sal.connect.netconf.listener.NetconfSessionPreferences; import org.opendaylight.netconf.sal.connect.netconf.schema.mapping.BaseSchema; import org.opendaylight.netconf.sal.connect.netconf.util.NetconfMessageTransformUtil; import org.opendaylight.netconf.sal.connect.util.RemoteDeviceId; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.monitoring.rev101004.NetconfState; import org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.netconf.monitoring.rev101004.netconf.state.Schemas; +import org.opendaylight.yangtools.util.xml.UntrustedXML; import org.opendaylight.yangtools.yang.common.QName; import org.opendaylight.yangtools.yang.common.RpcError; import org.opendaylight.yangtools.yang.common.RpcResultBuilder; import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier; import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode; -import org.opendaylight.yangtools.yang.data.impl.codec.xml.XmlUtils; +import org.opendaylight.yangtools.yang.data.api.schema.stream.NormalizedNodeStreamWriter; +import org.opendaylight.yangtools.yang.data.codec.xml.XmlParserStream; import org.opendaylight.yangtools.yang.data.impl.schema.Builders; -import org.opendaylight.yangtools.yang.data.impl.schema.transform.ToNormalizedNodeParser; -import org.opendaylight.yangtools.yang.data.impl.schema.transform.dom.parser.DomToNormalizedNodeParserFactory; +import org.opendaylight.yangtools.yang.data.impl.schema.ImmutableNormalizedNodeStreamWriter; +import org.opendaylight.yangtools.yang.data.impl.schema.NormalizedNodeResult; import org.opendaylight.yangtools.yang.model.api.ContainerSchemaNode; import org.opendaylight.yangtools.yang.model.api.DataSchemaNode; import org.opendaylight.yangtools.yang.model.api.SchemaContext; -import org.w3c.dom.Document; -import org.w3c.dom.Element; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class NetconfStateSchemasTest { - private static final NetconfSessionPreferences CAPS = NetconfSessionPreferences.fromStrings(Collections.singleton("urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring?module=ietf-netconf-monitoring&revision=2010-10-04")); + private static final Logger LOG = LoggerFactory.getLogger(NetconfStateSchemasTest.class); + + private static final NetconfSessionPreferences CAPS = NetconfSessionPreferences.fromStrings(Collections.singleton( + "urn:ietf:params:xml:ns:yang:ietf-netconf-monitoring?module=ietf-netconf-monitoring&revision=2010-10-04")); private final RemoteDeviceId deviceId = new RemoteDeviceId("device", new InetSocketAddress(99)); + private final int numberOfSchemas = 73; + private final int numberOfLegalSchemas = numberOfSchemas - 3; private ContainerNode compositeNodeSchemas; + @Mock private DOMRpcService rpc; + private SchemaContext schemaContext; + @Before public void setUp() throws Exception { MockitoAnnotations.initMocks(this); - final SchemaContext schemaContext = BaseSchema.BASE_NETCONF_CTX_WITH_NOTIFICATIONS.getSchemaContext(); + schemaContext = BaseSchema.BASE_NETCONF_CTX_WITH_NOTIFICATIONS.getSchemaContext(); final DataSchemaNode schemasNode = ((ContainerSchemaNode) schemaContext .getDataChildByName(NetconfState.QNAME)).getDataChildByName(Schemas.QNAME); - final Document schemasXml = XmlUtil.readXmlToDocument(getClass().getResourceAsStream("/netconf-state.schemas.payload.xml")); - final ToNormalizedNodeParser containerNodeParser = DomToNormalizedNodeParserFactory.getInstance(XmlUtils.DEFAULT_XML_CODEC_PROVIDER, schemaContext, false).getContainerNodeParser(); - compositeNodeSchemas = containerNodeParser.parse(Collections.singleton(schemasXml.getDocumentElement()), (ContainerSchemaNode) schemasNode); + + final NormalizedNodeResult resultHolder = new NormalizedNodeResult(); + final NormalizedNodeStreamWriter writer = ImmutableNormalizedNodeStreamWriter.from(resultHolder); + final XmlParserStream xmlParser = XmlParserStream.create(writer, schemaContext, schemasNode, false); + + xmlParser.parse(UntrustedXML.createXMLStreamReader(getClass().getResourceAsStream( + "/netconf-state.schemas.payload.xml"))); + compositeNodeSchemas = (ContainerNode) resultHolder.getResult(); } @@ -87,12 +100,13 @@ public class NetconfStateSchemasTest { final NetconfStateSchemas schemas = NetconfStateSchemas.create(deviceId, compositeNodeSchemas); final Set availableYangSchemasQNames = schemas.getAvailableYangSchemasQNames(); - assertEquals(73, availableYangSchemasQNames.size()); + assertEquals(numberOfLegalSchemas, availableYangSchemasQNames.size()); assertThat(availableYangSchemasQNames, hasItem(QName.create("urn:TBD:params:xml:ns:yang:network-topology", "2013-07-12", "network-topology"))); } + @Ignore @Test public void testCreate2() throws Exception { final ContainerNode netconfState = Builders.containerBuilder() @@ -100,17 +114,20 @@ public class NetconfStateSchemasTest { .withChild(compositeNodeSchemas) .build(); final ContainerNode data = Builders.containerBuilder() - .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(NetconfMessageTransformUtil.NETCONF_DATA_QNAME)) + .withNodeIdentifier(new YangInstanceIdentifier + .NodeIdentifier(NetconfMessageTransformUtil.NETCONF_DATA_QNAME)) .withChild(netconfState) .build(); final ContainerNode rpcReply = Builders.containerBuilder() - .withNodeIdentifier(new YangInstanceIdentifier.NodeIdentifier(NetconfMessageTransformUtil.NETCONF_RPC_REPLY_QNAME)) + .withNodeIdentifier(new YangInstanceIdentifier + .NodeIdentifier(NetconfMessageTransformUtil.NETCONF_RPC_REPLY_QNAME)) .withChild(data) .build(); - when(rpc.invokeRpc(eq(toPath(NETCONF_GET_QNAME)), any())).thenReturn(Futures.immediateCheckedFuture(new DefaultDOMRpcResult(rpcReply))); - final NetconfStateSchemas stateSchemas = NetconfStateSchemas.create(rpc, CAPS, deviceId); + when(rpc.invokeRpc(eq(toPath(NETCONF_GET_QNAME)), any())) + .thenReturn(immediateFluentFuture(new DefaultDOMRpcResult(rpcReply))); + final NetconfStateSchemas stateSchemas = NetconfStateSchemas.create(rpc, CAPS, deviceId, schemaContext); final Set availableYangSchemasQNames = stateSchemas.getAvailableYangSchemasQNames(); - assertEquals(73, availableYangSchemasQNames.size()); + assertEquals(numberOfLegalSchemas, availableYangSchemasQNames.size()); assertThat(availableYangSchemasQNames, hasItem(QName.create("urn:TBD:params:xml:ns:yang:network-topology", "2013-07-12", "network-topology"))); @@ -119,17 +136,16 @@ public class NetconfStateSchemasTest { @Test public void testCreateMonitoringNotSupported() throws Exception { final NetconfSessionPreferences caps = NetconfSessionPreferences.fromStrings(Collections.emptySet()); - final NetconfStateSchemas stateSchemas = NetconfStateSchemas.create(rpc, caps, deviceId); + final NetconfStateSchemas stateSchemas = NetconfStateSchemas.create(rpc, caps, deviceId, schemaContext); final Set availableYangSchemasQNames = stateSchemas.getAvailableYangSchemasQNames(); Assert.assertTrue(availableYangSchemasQNames.isEmpty()); } @Test public void testCreateFail() throws Exception { - final CheckedFuture resultFuture = - Futures.immediateFailedCheckedFuture(new DOMRpcImplementationNotAvailableException("not available")); - when(rpc.invokeRpc(eq(toPath(NETCONF_GET_QNAME)), any())).thenReturn(resultFuture); - final NetconfStateSchemas stateSchemas = NetconfStateSchemas.create(rpc, CAPS, deviceId); + when(rpc.invokeRpc(eq(toPath(NETCONF_GET_QNAME)), any())).thenReturn( + immediateFailedFluentFuture(new DOMRpcImplementationNotAvailableException("not available"))); + final NetconfStateSchemas stateSchemas = NetconfStateSchemas.create(rpc, CAPS, deviceId, schemaContext); final Set availableYangSchemasQNames = stateSchemas.getAvailableYangSchemasQNames(); Assert.assertTrue(availableYangSchemasQNames.isEmpty()); } @@ -137,24 +153,26 @@ public class NetconfStateSchemasTest { @Test public void testCreateRpcError() throws Exception { final RpcError rpcError = RpcResultBuilder.newError(RpcError.ErrorType.RPC, "fail", "fail"); - when(rpc.invokeRpc(eq(toPath(NETCONF_GET_QNAME)), any())).thenReturn(Futures.immediateCheckedFuture(new DefaultDOMRpcResult(rpcError))); - final NetconfStateSchemas stateSchemas = NetconfStateSchemas.create(rpc, CAPS, deviceId); + when(rpc.invokeRpc(eq(toPath(NETCONF_GET_QNAME)), any())) + .thenReturn(immediateFluentFuture(new DefaultDOMRpcResult(rpcError))); + final NetconfStateSchemas stateSchemas = NetconfStateSchemas.create(rpc, CAPS, deviceId, schemaContext); final Set availableYangSchemasQNames = stateSchemas.getAvailableYangSchemasQNames(); Assert.assertTrue(availableYangSchemasQNames.isEmpty()); } + @SuppressWarnings({ "checkstyle:IllegalThrows", "checkstyle:avoidHidingCauseException" }) @Test(expected = RuntimeException.class) public void testCreateInterrupted() throws Throwable { //NetconfStateSchemas.create calls Thread.currentThread().interrupt(), so it must run in its own thread final Future testFuture = Executors.newSingleThreadExecutor().submit(() -> { - final ListenableFuture interruptedFuture = mock(ListenableFuture.class); + final ListenableFuture interruptedFuture = mock(ListenableFuture.class); try { when(interruptedFuture.get()).thenThrow(new InterruptedException("interrupted")); - final CheckedFuture checkedFuture = Futures.makeChecked(interruptedFuture, ReadFailedException.MAPPER); - when(rpc.invokeRpc(eq(toPath(NETCONF_GET_QNAME)), any())).thenReturn(checkedFuture); - NetconfStateSchemas.create(rpc, CAPS, deviceId); + when(rpc.invokeRpc(eq(toPath(NETCONF_GET_QNAME)), any())).thenReturn( + FluentFuture.from(interruptedFuture)); + NetconfStateSchemas.create(rpc, CAPS, deviceId, schemaContext); } catch (final InterruptedException | ExecutionException e) { - e.printStackTrace(); + LOG.info("Operation failed.", e); } }); @@ -167,9 +185,12 @@ public class NetconfStateSchemasTest { @Test public void testRemoteYangSchemaEquals() throws Exception { - final NetconfStateSchemas.RemoteYangSchema schema1 = new NetconfStateSchemas.RemoteYangSchema(NetconfState.QNAME); - final NetconfStateSchemas.RemoteYangSchema schema2 = new NetconfStateSchemas.RemoteYangSchema(NetconfState.QNAME); - final NetconfStateSchemas.RemoteYangSchema schema3 = new NetconfStateSchemas.RemoteYangSchema(Schemas.QNAME); + final NetconfStateSchemas.RemoteYangSchema schema1 = + new NetconfStateSchemas.RemoteYangSchema(NetconfState.QNAME); + final NetconfStateSchemas.RemoteYangSchema schema2 = + new NetconfStateSchemas.RemoteYangSchema(NetconfState.QNAME); + final NetconfStateSchemas.RemoteYangSchema schema3 = + new NetconfStateSchemas.RemoteYangSchema(Schemas.QNAME); Assert.assertEquals(schema1, schema2); Assert.assertEquals(schema2, schema1); Assert.assertNotEquals(schema1, schema3);