X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=netconf%2Fsal-netconf-connector%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fnetconf%2Fsal%2Fconnect%2Fnetconf%2FNetconfToNotificationTest.java;h=d9525a07f36d8dda9e83639b3af835b4fecbb250;hb=af6992e683e759041acbc14b5217dd3171857ff7;hp=1b4c19098d3b6f15d6df8da3cf2167387a52bdec;hpb=79efb23e31ee1fbefc04907c9a2d0e5751b74f97;p=netconf.git diff --git a/netconf/sal-netconf-connector/src/test/java/org/opendaylight/netconf/sal/connect/netconf/NetconfToNotificationTest.java b/netconf/sal-netconf-connector/src/test/java/org/opendaylight/netconf/sal/connect/netconf/NetconfToNotificationTest.java index 1b4c19098d..d9525a07f3 100644 --- a/netconf/sal-netconf-connector/src/test/java/org/opendaylight/netconf/sal/connect/netconf/NetconfToNotificationTest.java +++ b/netconf/sal-netconf-connector/src/test/java/org/opendaylight/netconf/sal/connect/netconf/NetconfToNotificationTest.java @@ -14,24 +14,19 @@ import static org.junit.Assert.assertTrue; import com.google.common.collect.Iterables; import java.io.InputStream; -import java.text.SimpleDateFormat; -import java.util.ArrayList; -import java.util.List; import java.util.Set; -import javax.xml.parsers.DocumentBuilderFactory; import org.junit.Before; import org.junit.Test; -import org.opendaylight.controller.config.util.xml.XmlUtil; import org.opendaylight.controller.md.sal.dom.api.DOMEvent; import org.opendaylight.controller.md.sal.dom.api.DOMNotification; import org.opendaylight.netconf.api.NetconfMessage; +import org.opendaylight.netconf.api.xml.XmlUtil; import org.opendaylight.netconf.notifications.NetconfNotification; import org.opendaylight.netconf.sal.connect.netconf.schema.mapping.NetconfMessageTransformer; import org.opendaylight.yangtools.yang.data.api.schema.ContainerNode; import org.opendaylight.yangtools.yang.model.api.Module; import org.opendaylight.yangtools.yang.model.api.SchemaContext; -import org.opendaylight.yangtools.yang.model.parser.api.YangContextParser; -import org.opendaylight.yangtools.yang.parser.impl.YangParserImpl; +import org.opendaylight.yangtools.yang.test.util.YangParserTestUtils; import org.w3c.dom.Document; public class NetconfToNotificationTest { @@ -40,11 +35,8 @@ public class NetconfToNotificationTest { NetconfMessage userNotification; - @SuppressWarnings("deprecation") @Before public void setup() throws Exception { - final DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance(); - factory.setNamespaceAware(true); InputStream notifyPayloadStream = getClass().getResourceAsStream("/notification-payload.xml"); assertNotNull(notifyPayloadStream); @@ -53,26 +45,23 @@ public class NetconfToNotificationTest { userNotification = new NetconfMessage(doc); } - static SchemaContext getNotificationSchemaContext(Class loadClass, boolean getExceptionTest) { - final List modelsToParse = new ArrayList<>(); - + static SchemaContext getNotificationSchemaContext(final Class loadClass, final boolean getExceptionTest) { + final SchemaContext context; if (getExceptionTest) { - modelsToParse.add(loadClass.getResourceAsStream("/schemas/user-notification4.yang")); - modelsToParse.add(loadClass.getResourceAsStream("/schemas/user-notification3.yang")); + context = YangParserTestUtils.parseYangResources(loadClass, "/schemas/user-notification4.yang", + "/schemas/user-notification3.yang"); } else { - modelsToParse.add(loadClass.getResourceAsStream("/schemas/user-notification.yang")); - modelsToParse.add(loadClass.getResourceAsStream("/schemas/user-notification2.yang")); + context = YangParserTestUtils.parseYangResources(loadClass, "/schemas/user-notification.yang", + "/schemas/user-notification2.yang"); } - final YangContextParser parser = new YangParserImpl(); - final Set modules = parser.parseYangModelsFromStreams(modelsToParse); + final Set modules = context.getModules(); assertTrue(!modules.isEmpty()); - final SchemaContext schemaContext = parser.resolveSchemaContext(modules); - assertNotNull(schemaContext); - return schemaContext; + assertNotNull(context); + return context; } - @Test(expected = IllegalStateException.class) + @Test(expected = IllegalArgumentException.class) public void testMostRecentWrongYangModel() throws Exception { final SchemaContext schemaContext = getNotificationSchemaContext(getClass(), true); messageTransformer = new NetconfMessageTransformer(schemaContext, true); @@ -88,7 +77,7 @@ public class NetconfToNotificationTest { assertNotNull(root); assertEquals(6, Iterables.size(root.getValue())); assertEquals("user-visited-page", root.getNodeType().getLocalName()); - assertEquals(new SimpleDateFormat(NetconfNotification.RFC3339_DATE_FORMAT_WITH_MILLIS_BLUEPRINT).parse("2015-10-23T09:42:27.67175+00:00"), + assertEquals(NetconfNotification.RFC3339_DATE_PARSER.apply("2015-10-23T09:42:27.67175+00:00"), ((DOMEvent) domNotification).getEventTime()); } }