X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=olm%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Ftransportpce%2Folm%2Fpower%2FPowerMgmtImpl.java;h=e8fc629d9ca4c64d7ff5be36166da613d2bdb3a8;hb=refs%2Fchanges%2F75%2F87675%2F8;hp=ba3b5b2ca850191c2a9ecdff7b4419b0e5d8ce70;hpb=f5b5168d02112acea744f61b72ba3ab273f1a215;p=transportpce.git diff --git a/olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java b/olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java index ba3b5b2ca..e8fc629d9 100644 --- a/olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java +++ b/olm/src/main/java/org/opendaylight/transportpce/olm/power/PowerMgmtImpl.java @@ -8,6 +8,7 @@ package org.opendaylight.transportpce.olm.power; +//import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import java.math.BigDecimal; import java.util.HashMap; import java.util.Map; @@ -58,6 +59,7 @@ public class PowerMgmtImpl implements PowerMgmt { * @return true/false based on status of operation. */ //TODO Need to Case Optical Power mode/NodeType in case of 2.2 devices + //@SuppressFBwarnings("DM_CONVERT_CASE") public Boolean setPower(ServicePowerSetupInput input) { LOG.info("Olm-setPower initiated"); for (int i = 0; i < input.getNodes().size(); i++) { @@ -261,7 +263,7 @@ public class PowerMgmtImpl implements PowerMgmt { OpticalControlMode.Power, powerValue, connectionNumber); LOG.info("Success Value is {}", setXconnPowerSuccessVal); if (setXconnPowerSuccessVal) { - LOG.info("Roadm-connection: {} updated "); + LOG.info("Roadm-connection: {} updated ", connectionNumber); //The value recommended by the white paper is 20 seconds and not 60. //TODO - commented code because one vendor is not supporting //GainLoss with target-output-power @@ -274,7 +276,7 @@ public class PowerMgmtImpl implements PowerMgmt { return false; } } catch (InterruptedException e) { - LOG.error("Olm-setPower wait failed {}", e); + LOG.error("Olm-setPower wait failed :", e); return false; } } @@ -336,7 +338,7 @@ public class PowerMgmtImpl implements PowerMgmt { } } catch (InterruptedException e) { // TODO Auto-generated catch block - LOG.error("Olm-powerTurnDown wait failed {}",e); + LOG.error("Olm-powerTurnDown wait failed: ",e); return false; } }