X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fcommons%2Fcheckstyle%2Fsrc%2Fmain%2Fresources%2Fcontroller%2Fcheckstyle.xml;h=0c3699dca22e0451cb3f6be38101dbaf94acc529;hb=3fbfbc2881e4f18fd5972ec01c53c2a2d21aece1;hp=2b7462ac681665e5714fd5550ea1c6c7fe56e7da;hpb=a45976da8b191d3e44bbb9a07021a1dabda6333c;p=controller.git

diff --git a/opendaylight/commons/checkstyle/src/main/resources/controller/checkstyle.xml b/opendaylight/commons/checkstyle/src/main/resources/controller/checkstyle.xml
index 2b7462ac68..0c3699dca2 100644
--- a/opendaylight/commons/checkstyle/src/main/resources/controller/checkstyle.xml
+++ b/opendaylight/commons/checkstyle/src/main/resources/controller/checkstyle.xml
@@ -1,25 +1,45 @@
-<?xml version="1.0"?>
-<!DOCTYPE module PUBLIC
-    "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
-    "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
-
-<module name="Checker">
-    <module name="FileTabCharacter">
-        <property name="eachLine" value="true"/>
-    </module>
-
-    <module name="RegexpSingleline">
-        <!-- \s matches whitespace character, $ matches end of line. -->
-        <property name="format" value="\s+$"/>
-        <property name="message" value="Line has trailing spaces."/>
-    </module>
-    <module name="TreeWalker">
-       <module name="RedundantImport"/>
-       <module name="UnusedImports"/>
-       <module name="AvoidStarImport"/>
-       <module name="UpperEll"/>
-       <module name="EmptyStatement"/>
-       <module name="EqualsHashCode"/>
-    </module>
-
-</module>
+<?xml version="1.0"?>
+<!DOCTYPE module PUBLIC
+    "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
+    "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
+<module name="Checker">
+
+<!--
+     ======================================================================
+        Please do not add new Checkstyle check modules here anymore:
+
+        1. https://git.opendaylight.org/gerrit/#/c/39797/ has aligned
+        odl-parent's common Checkstyle rule set to include these.
+
+        2. As a next step, perhaps you would like to accept odl-parent's
+        Checkstyle definition as errors instead of warnings for Controller?
+        This is possible via violationSeverity=error as documented on
+        https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#Checkstyle
+
+        Please contact odlparent-dev@lists.opendaylight.org if you feel
+        a Checkstyle rule is too strict in general and should be reviewed.
+
+        3. Ultimately this entire project (org.opendaylight.controller:checkstyle)
+        should then be deleted, and dependencies to it removed.
+     ======================================================================
+ -->
+
+    <module name="FileTabCharacter">
+        <property name="eachLine" value="true"/>
+    </module>
+
+    <module name="RegexpSingleline">
+        <!-- \s matches whitespace character, $ matches end of line. -->
+        <property name="format" value="\s+$"/>
+        <property name="message" value="Line has trailing spaces."/>
+    </module>
+    <module name="TreeWalker">
+       <module name="RedundantImport"/>
+       <module name="UnusedImports"/>
+       <module name="AvoidStarImport"/>
+       <module name="UpperEll"/>
+       <module name="EmptyStatement"/>
+       <module name="EqualsHashCode"/>
+    </module>
+
+</module>