X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fconfig%2Fconfig-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfig%2Fmanager%2Fimpl%2Fjmx%2FModuleJMXRegistrator.java;h=206a623990ca94815357cabb9ebcce191efd9c60;hb=f43b01b81319959b1907e3e04537f5169e7f33d8;hp=c0e9b0d101b30bd912ff2674ccc254744356a68f;hpb=0eba94d9411ea40945ddc8c732640c0cc004599f;p=controller.git diff --git a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ModuleJMXRegistrator.java b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ModuleJMXRegistrator.java index c0e9b0d101..206a623990 100644 --- a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ModuleJMXRegistrator.java +++ b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/jmx/ModuleJMXRegistrator.java @@ -7,18 +7,16 @@ */ package org.opendaylight.controller.config.manager.impl.jmx; +import com.google.common.base.Preconditions; import java.io.Closeable; - import javax.annotation.concurrent.ThreadSafe; import javax.management.InstanceAlreadyExistsException; import javax.management.ObjectName; - import org.opendaylight.controller.config.api.jmx.ObjectNameUtil; -import org.opendaylight.controller.config.manager.impl.jmx.InternalJMXRegistrator.InternalJMXRegistration; /** * This subclass is used for registering readable module into JMX, it is also - * used as underlying provider in {@link RuntimeBeanRegistratorImpl}. Closing + * used as underlying provider in RuntimeBeanRegistratorImpl. Closing * the instance thus unregisters all JMX beans related to the module excluding * currently open transactions. */ @@ -26,14 +24,14 @@ import org.opendaylight.controller.config.manager.impl.jmx.InternalJMXRegistrato public class ModuleJMXRegistrator implements Closeable { private final InternalJMXRegistrator childJMXRegistrator; - public ModuleJMXRegistrator(InternalJMXRegistrator internalJMXRegistrator) { - this.childJMXRegistrator = internalJMXRegistrator.createChild(); + ModuleJMXRegistrator(final InternalJMXRegistrator internalJMXRegistrator) { + this.childJMXRegistrator = Preconditions.checkNotNull(internalJMXRegistrator); } static class ModuleJMXRegistration implements AutoCloseable { private final InternalJMXRegistration internalJMXRegistration; - ModuleJMXRegistration(InternalJMXRegistration registration) { + ModuleJMXRegistration(final InternalJMXRegistration registration) { this.internalJMXRegistration = registration; } @@ -43,7 +41,7 @@ public class ModuleJMXRegistrator implements Closeable { } } - public ModuleJMXRegistration registerMBean(Object object, ObjectName on) + public ModuleJMXRegistration registerMBean(final Object object, final ObjectName on) throws InstanceAlreadyExistsException { ObjectNameUtil.checkType(on, ObjectNameUtil.TYPE_MODULE); if (ObjectNameUtil.getTransactionName(on) != null) {