X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fconfig%2Fconfig-manager%2Fsrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfig%2Fmanager%2Fimpl%2Fosgi%2Fmapping%2FModuleInfoBundleTracker.java;h=7680f72612cd40468f3758d8030b55b6a6908afc;hb=a1c5cc3816cb52282a41818f02d638891b6fa28e;hp=a8fdfda7d7201f9cb00f50f590265e64825d2751;hpb=e4313092536d8fecf093ef790bd5cb7e53f27e74;p=controller.git diff --git a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/osgi/mapping/ModuleInfoBundleTracker.java b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/osgi/mapping/ModuleInfoBundleTracker.java index a8fdfda7d7..7680f72612 100644 --- a/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/osgi/mapping/ModuleInfoBundleTracker.java +++ b/opendaylight/config/config-manager/src/main/java/org/opendaylight/controller/config/manager/impl/osgi/mapping/ModuleInfoBundleTracker.java @@ -7,8 +7,16 @@ */ package org.opendaylight.controller.config.manager.impl.osgi.mapping; +import static java.lang.String.format; + +import java.io.InputStream; +import java.net.URL; +import java.util.Collection; +import java.util.LinkedList; +import java.util.List; + import org.apache.commons.io.IOUtils; -import org.opendaylight.yangtools.concepts.Registration; +import org.opendaylight.yangtools.concepts.ObjectRegistration; import org.opendaylight.yangtools.sal.binding.generator.impl.GeneratedClassLoadingStrategy; import org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext; import org.opendaylight.yangtools.yang.binding.YangModelBindingProvider; @@ -19,39 +27,31 @@ import org.osgi.util.tracker.BundleTrackerCustomizer; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.io.InputStream; -import java.net.URL; -import java.util.Collection; -import java.util.LinkedList; -import java.util.List; - -import static java.lang.String.format; - /** * Tracks bundles and attempts to retrieve YangModuleInfo. */ -public final class ModuleInfoBundleTracker implements BundleTrackerCustomizer>> { +public final class ModuleInfoBundleTracker implements BundleTrackerCustomizer>> { private static final Logger logger = LoggerFactory.getLogger(ModuleInfoBundleTracker.class); public static final String GET_MODULE_INFO_METHOD = "getModuleInfo"; public static final String MODULE_INFO_PROVIDER_PATH_PREFIX = "META-INF/services/"; - private ModuleInfoBackedContext moduleInfoLoadingStrategy = ModuleInfoBackedContext.create(); + private final ModuleInfoBackedContext moduleInfoLoadingStrategy = ModuleInfoBackedContext.create(); public GeneratedClassLoadingStrategy getModuleInfoLoadingStrategy() { return moduleInfoLoadingStrategy; } @Override - public Collection> addingBundle(Bundle bundle, BundleEvent event) { + public Collection> addingBundle(Bundle bundle, BundleEvent event) { URL resource = bundle.getEntry(MODULE_INFO_PROVIDER_PATH_PREFIX + YangModelBindingProvider.class.getName()); if(resource==null) { return null; } - List> registrations = new LinkedList<>(); + List> registrations = new LinkedList<>(); try (InputStream inputStream = resource.openStream()) { List lines = IOUtils.readLines(inputStream); @@ -70,17 +70,17 @@ public final class ModuleInfoBundleTracker implements BundleTrackerCustomizer> object) { + public void modifiedBundle(Bundle bundle, BundleEvent event, Collection> object) { // NOOP } @Override - public void removedBundle(Bundle bundle, BundleEvent event, Collection> regs) { + public void removedBundle(Bundle bundle, BundleEvent event, Collection> regs) { if(regs == null) { return; } - for (Registration reg : regs) { + for (ObjectRegistration reg : regs) { try { reg.close(); } catch (Exception e) {