X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fconfig%2Fconfig-manager%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfig%2Fmanager%2Fimpl%2FConfigRegistryImplLookupTest.java;h=8368a2723f9f422fcf95fd4edfc0a84d39e3aea7;hb=2b78ca93f44c372fd72927db6cbd65f5d8387b49;hp=7a4b46f9f373bbf237e2a325a99e8d8569bf8d96;hpb=20500c9eb46d1ceb99d742d1c110dcb7c558dc2b;p=controller.git diff --git a/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/ConfigRegistryImplLookupTest.java b/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/ConfigRegistryImplLookupTest.java index 7a4b46f9f3..8368a2723f 100644 --- a/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/ConfigRegistryImplLookupTest.java +++ b/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/ConfigRegistryImplLookupTest.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013 Cisco Systems, Inc. and others. All rights reserved. + * Copyright (c) 2013, 2017 Cisco Systems, Inc. and others. All rights reserved. * * This program and the accompanying materials are made available under the * terms of the Eclipse Public License v1.0 which accompanies this distribution, @@ -11,15 +11,14 @@ import static org.hamcrest.core.Is.is; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertThat; +import com.google.common.collect.Sets; import java.lang.management.ManagementFactory; import java.lang.reflect.Field; import java.util.Collections; import java.util.Map; import java.util.Set; - import javax.management.InstanceAlreadyExistsException; import javax.management.ObjectName; - import org.junit.After; import org.junit.Before; import org.junit.Test; @@ -30,78 +29,65 @@ import org.opendaylight.controller.config.manager.impl.jmx.BaseJMXRegistrator; import org.opendaylight.controller.config.manager.impl.jmx.RootRuntimeBeanRegistratorImpl; import org.opendaylight.controller.config.manager.impl.runtimembean.TestingRuntimeBean; -import com.google.common.collect.Sets; - -public class ConfigRegistryImplLookupTest extends - AbstractLockedPlatformMBeanServerTest { +public class ConfigRegistryImplLookupTest extends AbstractLockedPlatformMBeanServerTest { private ConfigRegistryImpl configRegistryImpl; private BaseJMXRegistrator baseJMXRegistrator; - private static final String moduleNameA = "moduleA"; - private static final String moduleNameB = "moduleB"; + private static final String MODULE_NAMEA = "moduleA"; + private static final String MODULE_NAMEB = "moduleB"; - private static final String instanceNameA = "instA"; - private static final String instanceNameB = "instB"; - private static final String instanceNameC = "instC"; + private static final String INSTANCE_NAMEA = "instA"; + private static final String INSTANCE_NAMEB = "instB"; + private static final String INSTANCE_NAMEC = "instC"; - private static final ObjectName name1 = ObjectNameUtil - .createReadOnlyModuleON(moduleNameA, instanceNameA); - private static final ObjectName name2 = ObjectNameUtil - .createReadOnlyModuleON(moduleNameA, instanceNameB); - private static final ObjectName name3 = ObjectNameUtil - .createReadOnlyModuleON(moduleNameA, instanceNameC); - private static final ObjectName name4 = ObjectNameUtil - .createReadOnlyModuleON(moduleNameB, instanceNameA); + private static final ObjectName NAME1 = ObjectNameUtil.createReadOnlyModuleON(MODULE_NAMEA, INSTANCE_NAMEA); + private static final ObjectName NAME2 = ObjectNameUtil.createReadOnlyModuleON(MODULE_NAMEA, INSTANCE_NAMEB); + private static final ObjectName NAME3 = ObjectNameUtil.createReadOnlyModuleON(MODULE_NAMEA, INSTANCE_NAMEC); + private static final ObjectName NAME4 = ObjectNameUtil.createReadOnlyModuleON(MODULE_NAMEB, INSTANCE_NAMEA); - private static final ObjectName name5 = ObjectNameUtil - .createRuntimeBeanName(moduleNameA, instanceNameA, Collections.emptyMap()); - private static final ObjectName name6 = ObjectNameUtil - .createRuntimeBeanName(moduleNameA, instanceNameB, Collections.emptyMap()); - private static final ObjectName name8 = ObjectNameUtil - .createRuntimeBeanName(moduleNameB, instanceNameA, Collections.emptyMap()); + private static final ObjectName NAME5 = ObjectNameUtil.createRuntimeBeanName(MODULE_NAMEA, INSTANCE_NAMEA, + Collections.emptyMap()); + private static final ObjectName NAME6 = ObjectNameUtil.createRuntimeBeanName(MODULE_NAMEA, INSTANCE_NAMEB, + Collections.emptyMap()); + private static final ObjectName NAME8 = ObjectNameUtil.createRuntimeBeanName(MODULE_NAMEB, INSTANCE_NAMEA, + Collections.emptyMap()); - private static final ObjectName name9 = ObjectNameUtil - .createTransactionModuleON("transaction", moduleNameA, instanceNameA); + private static final ObjectName NAME9 = ObjectNameUtil.createTransactionModuleON("transaction", MODULE_NAMEA, + INSTANCE_NAMEA); @Before public void setUp() throws Exception { - configRegistryImpl = new ConfigRegistryImpl(null, - ManagementFactory.getPlatformMBeanServer(), null); - Field field = configRegistryImpl.getClass().getDeclaredField( - "baseJMXRegistrator"); + configRegistryImpl = new ConfigRegistryImpl(null, ManagementFactory.getPlatformMBeanServer(), null); + Field field = configRegistryImpl.getClass().getDeclaredField("baseJMXRegistrator"); field.setAccessible(true); baseJMXRegistrator = (BaseJMXRegistrator) field.get(configRegistryImpl); - registerModuleBean(new TestingRuntimeBean(), baseJMXRegistrator, name1); - registerModuleBean(new TestingRuntimeBean(), baseJMXRegistrator, name2); - registerModuleBean(new TestingRuntimeBean(), baseJMXRegistrator, name3); - registerModuleBean(new TestingRuntimeBean(), baseJMXRegistrator, name4); + registerModuleBean(new TestingRuntimeBean(), baseJMXRegistrator, NAME1); + registerModuleBean(new TestingRuntimeBean(), baseJMXRegistrator, NAME2); + registerModuleBean(new TestingRuntimeBean(), baseJMXRegistrator, NAME3); + registerModuleBean(new TestingRuntimeBean(), baseJMXRegistrator, NAME4); - registerRuntimeBean(new TestingRuntimeBean(), baseJMXRegistrator, name5); - registerRuntimeBean(new TestingRuntimeBean(), baseJMXRegistrator, name6); - registerRuntimeBean(new TestingRuntimeBean(), baseJMXRegistrator, name8); + registerRuntimeBean(new TestingRuntimeBean(), baseJMXRegistrator, NAME5); + registerRuntimeBean(new TestingRuntimeBean(), baseJMXRegistrator, NAME6); + registerRuntimeBean(new TestingRuntimeBean(), baseJMXRegistrator, NAME8); - baseJMXRegistrator.createTransactionJMXRegistrator("transaction") - .createTransactionModuleJMXRegistrator() - .registerMBean(new TestingRuntimeBean(), name9); + baseJMXRegistrator.createTransactionJMXRegistrator("transaction").createTransactionModuleJMXRegistrator() + .registerMBean(new TestingRuntimeBean(), NAME9); } - private void registerModuleBean(TestingRuntimeBean testingRuntimeBean, - BaseJMXRegistrator baseJMXRegistrator, ObjectName objectName) + private static void registerModuleBean(final TestingRuntimeBean testingRuntimeBean, + final BaseJMXRegistrator baseJMXRegistrator, final ObjectName objectName) throws InstanceAlreadyExistsException { - baseJMXRegistrator.createModuleJMXRegistrator().registerMBean( - testingRuntimeBean, objectName); + baseJMXRegistrator.createModuleJMXRegistrator().registerMBean(testingRuntimeBean, objectName); } - private void registerRuntimeBean(RuntimeBean object, - BaseJMXRegistrator baseJMXRegistrator, ObjectName runtimeON) - throws InstanceAlreadyExistsException { + private static void registerRuntimeBean(final RuntimeBean object, final BaseJMXRegistrator baseJMXRegistrator, + final ObjectName runtimeON) throws InstanceAlreadyExistsException { String factoryName = ObjectNameUtil.getFactoryName(runtimeON); String instanceName = ObjectNameUtil.getInstanceName(runtimeON); - Map properties = ObjectNameUtil - .getAdditionalPropertiesOfRuntimeBeanName(runtimeON); + Map properties = ObjectNameUtil.getAdditionalPropertiesOfRuntimeBeanName(runtimeON); RootRuntimeBeanRegistratorImpl runtimeBeanRegistrator = baseJMXRegistrator .createRuntimeBeanRegistrator(new ModuleIdentifier(factoryName, instanceName)); @@ -119,39 +105,34 @@ public class ConfigRegistryImplLookupTest extends @Test public void testLookupConfigBeans() throws Exception { Set beans = configRegistryImpl.lookupConfigBeans(); - assertEquals(Sets.newHashSet(name1, name2, name3, name4), beans); + assertEquals(Sets.newHashSet(NAME1, NAME2, NAME3, NAME4), beans); beans = configRegistryImpl.lookupConfigBeans(); - assertEquals(Sets.newHashSet(name1, name2, name3, name4), beans); + assertEquals(Sets.newHashSet(NAME1, NAME2, NAME3, NAME4), beans); } @Test public void testLookupConfigBeanWithModuleName() throws Exception { - Set bean = configRegistryImpl - .lookupConfigBeans(moduleNameA); - assertEquals(Sets.newHashSet(name1, name2, name3), bean); + Set bean = configRegistryImpl.lookupConfigBeans(MODULE_NAMEA); + assertEquals(Sets.newHashSet(NAME1, NAME2, NAME3), bean); } @Test - public void testLookupConfigBeanWithModuleNameAndInstanceName() - throws Exception { - Set bean = configRegistryImpl.lookupConfigBeans( - moduleNameA, instanceNameA); - assertEquals(Sets.newHashSet(name1), bean); + public void testLookupConfigBeanWithModuleNameAndInstanceName() throws Exception { + Set bean = configRegistryImpl.lookupConfigBeans(MODULE_NAMEA, INSTANCE_NAMEA); + assertEquals(Sets.newHashSet(NAME1), bean); } @Test public void testLookupRuntimeBeans() throws Exception { Set beans = configRegistryImpl.lookupRuntimeBeans(); - assertEquals(Sets.newHashSet(name5, name6, name8), beans); + assertEquals(Sets.newHashSet(NAME5, NAME6, NAME8), beans); beans = configRegistryImpl.lookupRuntimeBeans(null, null); - assertEquals(Sets.newHashSet(name5, name6, name8), beans); + assertEquals(Sets.newHashSet(NAME5, NAME6, NAME8), beans); } @Test public void testLookupRuntimeBeansWithIFcNameAndImplName() throws Exception { - Set beans = configRegistryImpl.lookupRuntimeBeans( - moduleNameA, instanceNameA); - assertEquals(Sets.newHashSet(name5), beans); + Set beans = configRegistryImpl.lookupRuntimeBeans(MODULE_NAMEA, INSTANCE_NAMEA); + assertEquals(Sets.newHashSet(NAME5), beans); } - }