X-Git-Url: https://git.opendaylight.org/gerrit/gitweb?a=blobdiff_plain;f=opendaylight%2Fconfig%2Fconfig-manager%2Fsrc%2Ftest%2Fjava%2Forg%2Fopendaylight%2Fcontroller%2Fconfig%2Fmanager%2Fimpl%2Fdependencyresolver%2FDependencyResolverManagerTest.java;h=20a127ed23820c49e57ff4cb818b1f6b487c9748;hb=405c97ddf445b6057a2654545dd8072d28eedcce;hp=83ee87ce0e4fefad73e46b78e236a0a45bc9b803;hpb=dd32d3d246ebad8b7c76afb93239a4462f329a6b;p=controller.git diff --git a/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/dependencyresolver/DependencyResolverManagerTest.java b/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/dependencyresolver/DependencyResolverManagerTest.java index 83ee87ce0e..20a127ed23 100644 --- a/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/dependencyresolver/DependencyResolverManagerTest.java +++ b/opendaylight/config/config-manager/src/test/java/org/opendaylight/controller/config/manager/impl/dependencyresolver/DependencyResolverManagerTest.java @@ -69,7 +69,10 @@ public class DependencyResolverManagerTest extends AbstractLockedPlatformMBeanSe // switch to second phase committed reset(transactionStatus); + doNothing().when(transactionStatus).checkCommitStarted(); doNothing().when(transactionStatus).checkCommitted(); + doNothing().when(transactionStatus).checkNotCommitted(); + List sortedModuleIdentifiers = tested .getSortedModuleIdentifiers(); assertEquals( @@ -82,16 +85,16 @@ public class DependencyResolverManagerTest extends AbstractLockedPlatformMBeanSe * Simulate dependentResolver resolving its dependency identified by * dependentName. */ - private void declareDependency(DependencyResolverImpl dependerResolver, - ModuleIdentifier dependentName) { + private static void declareDependency(final DependencyResolverImpl dependerResolver, + final ModuleIdentifier dependentName) { JmxAttribute dummyAttribute = new JmxAttribute("dummy"); dependerResolver.resolveInstance(Object.class, ObjectNameUtil.createReadOnlyModuleON(dependentName), dummyAttribute); } - private static void mockGetInstance(DependencyResolverManager tested, - ModuleIdentifier moduleIdentifier) { + private static void mockGetInstance(final DependencyResolverManager tested, + final ModuleIdentifier moduleIdentifier) { ModuleFactory moduleFactory = mock(ModuleFactory.class); ModuleInternalInfo maybeOldInternalInfo = null; @@ -99,16 +102,17 @@ public class DependencyResolverManagerTest extends AbstractLockedPlatformMBeanSe boolean isDefaultBean = false; tested.put(moduleIdentifier, - mockedModule(), - moduleFactory, - maybeOldInternalInfo, - transactionModuleJMXRegistration, - isDefaultBean, mock(BundleContext.class)); + mockedModule(), + moduleFactory, + maybeOldInternalInfo, + transactionModuleJMXRegistration, + isDefaultBean, mock(BundleContext.class)); } private static Module mockedModule() { Module mockedModule = mock(Module.class); doReturn(mock(AutoCloseable.class)).when(mockedModule).getInstance(); + doReturn(new ModuleIdentifier("fact", "instance")).when(mockedModule).getIdentifier(); return mockedModule; }